One-Page Checkout [Support Thread]

[llemberg]

Hmmm... when I verified my files against one_page_checkout-2.3.7.zip, my OnePageCheckout.php was a match. Here is line 2323 from my OnePageCheckout.php:

trigger_error("Unknown/invalid billto address #{$_SESSION['billto']} for customer#{$_SESSION['customer_id']}.", E_USER_ERROR);

which looks like the error message I received.

[lat9]

Hmmm... when I verified my files against one_page_checkout-2.3.7.zip, my OnePageCheckout.php was a match. Here is line 2323 from my OnePageCheckout.php:

trigger_error("Unknown/invalid billto address #{$_SESSION['billto']} for customer#{$_SESSION['customer_id']}.", E_USER_ERROR);

which looks like the error message I received.

My bad, I was looking at the version in the forthcoming v2.3.8 release.

[lat9]

Thank you.

Now I have another problem.

I have set in
configuration > my store the basis of product tax, and basis of shipping tax to "store", when adding product the cart shows the full price (tax included), when clicking to checkout, and selecting guest (haven't tested new or existing customer) the price is displayed without tax, and when going back to edit cart (shopping_cart.html) the price has changed and displays without tax.
The tax column is not displayed in the table

<?php
// display tax info if exists
if ($display_tax_column)  {
?>
<td class="cartTotalDisplay"><?php echo zen_display_tax_value($order->products[$i]['tax']); ?>%</td>
<?php
}  // endif tax info display
?>

What do you think I messed up?

You didn't mess up anything ... I did. I've replicated this issue locally and have provided a correction via this OPC GitHub issue.

The underlying issue is that, for stores having configured My Store :: Store Country as a country containing zones (e.g. Italy) with My Store :: Basis of Product Tax set to Store, the order-class determines the tax-rate to apply via database lookup for a match on a database lookup of an address' country and zone-id. Unfortunately, the OnePageCheckout.php class was not initializing its temporary billing/shipping addresses to include the value present in My Store :: Store Zone.

With that zone_id set to 0, no matching country/zone pair was found in the database ... resulting in a 0-valued tax-rate.

That correction is now staged on the OPC GitHub repository for the v2.3.8 release. I'll wait for that release until you can provide third-party verification that the correction actually corrects the issue!

[keneso]

Thank you.
Will give feedback.

[keneso]

That correction is now staged on the OPC GitHub repository for the v2.3.8 release. I'll wait for that release until you can provide third-party verification that the correction actually corrects the issue!

It's a go.
Thank you.

[lat9]

I've just submitted v2.3.8 of One-Page Checkout for the Zen Cart moderators' review and will post back here when it's available for download.

This release contains changes associated with the following GitHub issues:

#291: zc158 compatibility, adding global $languageLoader;.
#292: Using global $db; instead of $GLOBALS['db'].
#293: Re-organize the checkout_one page's language file, grouping all jQuery-based constants as an aid in language translations.
#294: Correct "disappearing taxes" when a store's country has zones and the tax-basis is 'Store'.

[lat9]

I've just submitted v2.3.8 of One-Page Checkout for the Zen Cart moderators' review and will post back here when it's available for download.

This release contains changes associated with the following GitHub issues:

#291: zc158 compatibility, adding global $languageLoader;.
#292: Using global $db; instead of $GLOBALS['db'].
#293: Re-organize the checkout_one page's language file, grouping all jQuery-based constants as an aid in language translations.
#294: Correct "disappearing taxes" when a store's country has zones and the tax-basis is 'Store'.

Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2095

[jeking]

I searched but did not find any mention of this error. After entering the address and clicking update, I get this:

jquery.checkout_one.min.js?1598622382:5
Uncaught TypeError: Cannot read property 'length' of null

Zen Cart 1.5.7a
OPC 2.3.4
jQuery 1.7.1 (it's an old template)

Thanks.

[lat9]

I searched but did not find any mention of this error. After entering the address and clicking update, I get this:

jquery.checkout_one.min.js?1598622382:5
Uncaught TypeError: Cannot read property 'length' of null

Zen Cart 1.5.7a
OPC 2.3.4
jQuery 1.7.1 (it's an old template)

Thanks.

That's going to be a bit difficult to isolate, since it's the minimized jQuery file, but I'm guessing that it's got to do with that very, very woefully old version of jQuery. I'll need to review the jQuery base requirements for OPC's jQuery processing and will most likely provide an update that disallows the OPC processing if the current jQuery version is prior to that minimum-version requirement.

[jeking]

That's going to be a bit difficult to isolate, since it's the minimized jQuery file, but I'm guessing that it's got to do with that very, very woefully old version of jQuery. I'll need to review the jQuery base requirements for OPC's jQuery processing and will most likely provide an update that disallows the OPC processing if the current jQuery version is prior to that minimum-version requirement.

If it will be helpful, I can switch to the unminimized version and report back.