Fatal Error when purchasing Gift Certificate

[carlwhat]

this is a separate problem, and one where an error log would be generated... i do not really deal with GCs; so i am unfamiliar with how they get released.

have you gone to the gift certificate release queue page (gv_queue.php)? what do you see there? and are there any new log files?

[mvstudio]

this is a separate problem, and one where an error log would be generated... i do not really deal with GCs; so i am unfamiliar with how they get released.

have you gone to the gift certificate release queue page (gv_queue.php)? what do you see there? and are there any new log files?

Nothing appears on the gv_queue.php page and no log files for either the admin or the catalog.

[mc12345678]

Back on the original issue: isn't the issue here that with the product marked as do not collect the shipping address, that when the order is processed that a shipping address is not collected, which means that $shipping_address->EOF is true and then that $this->delivery['format_id'] is not set to 0 but instead is empty and that then when 'delivery_address_format_id' is attempted to be set from an empty value which in turn acts like an empty set of quotes instead of an integer? or is there some other process that has come to generate a 0 valued address_book_id such that $shipping_address actually has/should a record and the integer casting should address the situation? And wasn't there a test against the product/cart being virtual and if so to set some variables to prevent strict notices associated with the operation with that test incorporated into ZC 1.5.7?

Just seems like that all fits together with the database strictness to cause this issue to be seen.


BTW, please forgive me if something technical above is inaccurate, I've gotten distracted and can only seem to get to this on a mini screen at the moment which makes it terribly difficult to piece together a larger concept...

[mvstudio]

Nothing appears on the gv_queue.php page and no log files for either the admin or the catalog.

I was able to fix the issue of no gift certificate queue button. In the middle of changing settings I must have changed the settings for the gift certificate.
Queue Purchases and Show Queue in Admin header are now set to true and it finally works with the new patch.
Not that this solves the actual issue of why is misbehaving to start with, but at least it works for the time being until a more permanent fix is found.

[mvstudio]

Back on the original issue: isn't the issue here that with the product marked as do not collect the shipping address, that when the order is processed that a shipping address is not collected, which means that $shipping_address->EOF is true and then that $this->delivery['format_id'] is not set to 0 but instead is empty and that then when 'delivery_address_format_id' is attempted to be set from an empty value which in turn acts like an empty set of quotes instead of an integer? or is there some other process that has come to generate a 0 valued address_book_id such that $shipping_address actually has/should a record and the integer casting should address the situation? And wasn't there a test against the product/cart being virtual and if so to set some variables to prevent strict notices associated with the operation with that test incorporated into ZC 1.5.7?

Just seems like that all fits together with the database strictness to cause this issue to be seen.


BTW, please forgive me if something technical above is inaccurate, I've gotten distracted and can only seem to get to this on a mini screen at the moment which makes it terribly difficult to piece together a larger concept...

It seems that's the actual issue. The strictness of mysql which I have not even the most remote idea why is there, is the root of the problem.

The patch that Cindy provided didn't work, but the version of the patch that carlwhat provided did work in the end at least for now. I'm hoping my hosting provider won't complain about it! =D

[mc12345678]

It seems that's the actual issue. The strictness of mysql which I have not even the most remote idea why is there, is the root of the problem.

The patch that Cindy provided didn't work, but the version of the patch that carlwhat provided did work in the end at least for now. I'm hoping my hosting provider won't complain about it! =D

Suggest following the "rabbit trail" at the following github issue which led to a code change incorporated into ZC 1.5.7 that is compatible with ZC 1.5.6:
https://github.com/zencart/zencart/issues/2426

[mvstudio]

Suggest following the "rabbit trail" at the following github issue which led to a code change incorporated into ZC 1.5.7 that is compatible with ZC 1.5.6:
https://github.com/zencart/zencart/issues/2426

That's exactly the log files I've been getting. Thank you looking into it!!! This gives me reassurance it wasn't something I caused.
Before I manage to screw things up, would this be the change required? https://github.com/zencart/zencart/p...886837a3572ad9

[mc12345678]

That's exactly the log files I've been getting. Thank you looking into it!!! This gives me reassurance it wasn't something I caused.
Before I manage to screw things up, would this be the change required? https://github.com/zencart/zencart/p...886837a3572ad9

Yes it would. Then after applying that, you could remove the "patch" applied earlier in this thread (at least for that issue). There may be other things in the code that would "benefit" from not operating in strict mode, but being in strict mode offers tighter control in an effort of maintaining security.

[mvstudio]

Yes it would. Then after applying that, you could remove the "patch" applied earlier in this thread (at least for that issue). There may be other things in the code that would "benefit" from not operating in strict mode, but being in strict mode offers tighter control in an effort of maintaining security.

Brilliant!!
I tested it and it works perfectly!
Thank you so, so much!!! Have an awesome day!

[mc12345678]

Brilliant!!
I tested it and it works perfectly!
Thank you so, so much!!! Have an awesome day!

Welcome. As noted in the link and change, lat9 identified and suggested a correction for it.

I tested the operation yesterday (without the modification) with strict php but not strict database access and was able to "successfully" process the transaction, but had myDebug related files because of the strict php.