Forums / Bug Reports / [Done v155a] Cannot change shipping/billing address from address book

[Done v155a] Cannot change shipping/billing address from address book

Locked

Views: 4,864

Results 1 to 10 of 10
This thread is locked. New replies are disabled.
29 Mar 2016, 12:01 AM
#1
robbie269 avatar

robbie269

Zen Follower

Join Date:
Feb 2010
Location:
New South Wales, Australia
Posts:
228
Plugin Contributions:
0

[Done v155a] Cannot change shipping/billing address from address book

I have been working on my test v1.5.5 site hoping to go live soon.
One problem I have found is that I can not change the address for billing and shipping by picking one in my address book.
The form insists on me filling out the form.
I am using the responsive classic template and it does the same with the green classic one.
Nothing in my log files.
I have addons: COWOA, giftwrap & Ultimate URLs.
My test site is password protected but I can take it off if someone wants to check the site.

Any ideas?

29 Mar 2016, 12:06 AM
#2
kobra avatar

kobra

Black Belt

Join Date:
Aug 2005
Location:
Arizona
Posts:
31,500
Plugin Contributions:
4

Re: [Done v155a] Cannot change shipping/billing address from address book

I have found is that I can not change the address for billing and shipping by picking one in my address book.
Are you meaning that when logged in as a customer that you can not change shipping address??

Zen-Venom Get Bitten

29 Mar 2016, 12:14 AM
#3
robbie269 avatar

robbie269

Zen Follower

Join Date:
Feb 2010
Location:
New South Wales, Australia
Posts:
228
Plugin Contributions:
0

Re: [Done v155a] Cannot change shipping/billing address from address book

Yes logged in as a customer. I can change it if I type it all in. I can change the radio button to the address in the address book but when I hit continue it has the fields red that i have not filled in.
I am running the test site without SSL would that affect it?

29 Mar 2016, 12:46 AM
#4
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Done v155a] Cannot change shipping/billing address from address book

Hmmm ... Looks like a bug.
The HTML5 form attributes for "required" fields are clashing with the use of the radio-buttons to choose pre-defined addresses using the same <form>.
I'm guessing it's probably best to split the form into two separate forms.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

29 Mar 2016, 6:09 PM
#5
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Done v155a] Cannot change shipping/billing address from address book

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

31 Mar 2016, 4:03 AM
#6
robbie269 avatar

robbie269

Zen Follower

Join Date:
Feb 2010
Location:
New South Wales, Australia
Posts:
228
Plugin Contributions:
0

Re: [Done v155a] Cannot change shipping/billing address from address book

Yes it worked until I tried logging in as a new customer with no addresses in my address book.
Added a new shipping address OK but there are now 2 "continue" buttons at the bottom.
Only the top one works if there are not already some addresses.
The second "continue" button needs to only be visible if there are addresses in the address book. Or the default address is always in the address book.

31 Mar 2016, 5:13 AM
#7
robbie269 avatar

robbie269

Zen Follower

Join Date:
Feb 2010
Location:
New South Wales, Australia
Posts:
228
Plugin Contributions:
0

Re: [Done v155a] Cannot change shipping/billing address from address book

Fixed it (I think):

Changed:

<?php
    }
    if ($addresses_count > 1) {
?>

to:

<?php
    }
    if ($addresses_count > 0) {
?>

in tpl_checkout_shipping_address_default.php & tpl_checkout_payment_address_default.php

The default address now appears and all the "continue" buttons work how they should.

21 Apr 2016, 5:56 PM
#8
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Done v155a] Cannot change shipping/billing address from address book

Apologies for the delayed response.

The proper fix for the double-continue button is here: https://github.com/zencart/zencart/pull/904/files

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

7 May 2016, 5:10 PM
#9
mario75 avatar

mario75

New Zenner

Join Date:
May 2012
Posts:
22
Plugin Contributions:
0

Re: [Done v155a] Cannot change shipping/billing address from address book

Thank you very much for the fix. I have replaced the 4 files and all is right now. I see that in version 1.5.5a there are more changes and fixes of 1.5.5.
How do we upgrade from 1.5.5. to 1.5.5a? The classic way or is it enough to replace the core files? What files have changed? Sorry but I didn't find that info in docs folder as I usually do. Best regards!

7 May 2016, 5:39 PM
#10
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Done v155a] Cannot change shipping/billing address from address book

mario75:

Thank you very much for the fix. I have replaced the 4 files and all is right now. I see that in version 1.5.5a there are more changes and fixes of 1.5.5.
How do we upgrade from 1.5.5. to 1.5.5a? The classic way or is it enough to replace the core files? What files have changed? Sorry but I didn't find that info in docs folder as I usually do. Best regards!
See the list of v155a changed files at: https://www.zen-cart.com/docs/changed_files-v1-5-5.html

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.