Limit additional images listed?

can anyone explain if there is a way to limit the number of additional images shown?

My supplier provides up to 10 but I only want to display a maximum of 3? is there any way to only get it to display the first 3 found?

Thanks in advance.

Phil

You could copy /includes/modules/additional_images.php into /includes/modules/YOUR_TEMPLATE/additional_images.php and edit the following section (from the 1.5.0 version):

 // Check for additional matching images
  $file_extension = $products_image_extension;
  $products_image_match_array = array();
  $files_found = 0;  /* Add this */
  if ($dir = @dir($products_image_directory)) {
    while ($file = $dir->read() && $files_found < 3) {  /* Change this */
      $files_found++;  /* Add this */
      if (!is_dir($products_image_directory . $file)) {
        if (substr($file, strrpos($file, '.')) == $file_extension) {
          if(preg_match('/\Q' . $products_image_base . '\E/i', $file) == 1) {
            if ($file != $products_image) {
              if ($products_image_base . str_replace($products_image_base, '', $file) == $file) {
                //  echo 'I AM A MATCH ' . $file . '<br>';
                $images_array[] = $file;
              } else {
                //  echo 'I AM NOT A MATCH ' . $file . '<br>';
              }
            }
          }
        }
      }
    }
    if (sizeof($images_array)) {
      sort($images_array);
    }
    $dir->close();
  }

I'd make it "prettier" but I can't remember how to 'style' colors and the color buttons aren't there right now!

Hi, thanks for this but its not working for me. to be fair i'm not yet on 1.5.0 yet, however the code is identical. When I implement this suggestion no images are shown at all? did it work for you or have you done this from theory?

You could do it with CSS.

Set in the admin, max add images per row of 3, and then fix in the CSS the max height for the additional images container to the height of the first row, so all the other images aren't visible. Of course they are loaded etc, but not viewable by the user.

I prefer not to hide stuff. search engines dont like that sort of thing.

your initial idea looks like it should work but maybe its not quite coded right?

not sure if the array() part has the file names at that point?

if so could i implement something like this example:

$input = array("a", "b", "c", "d", "e");

$output = array_slice($input, 2); // returns "c", "d", and "e"
$output = array_slice($input, -2, 1); // returns "d"
$output = array_slice($input, 0, 3); // returns "a", "b", and "c"

philip937:

I prefer not to hide stuff. search engines dont like that sort of thing.

your initial idea looks like it should work but maybe its not quite coded right?

Your not hiding anything, its not a hidden div, its just a reduced sized div. The content is all there and accessible, and search engines only ignore (not penalise) hidden content if it is blantantly spamming, other wise the millions of sites with tabbed divs which use display:none would be ranked down.

That's what I get for "punting". Here's an updated/corrected version, the $files_found count was misplaced before:

// Check for additional matching images   
$file_extension = $products_image_extension;   
$products_image_match_array = array();   
$files_found = 0;  /* Add this */  
 if ($dir = @dir($products_image_directory)) {     
  while ($file = $dir->read() && $files_found < 3) {  /* Change this */       
    if (!is_dir($products_image_directory . $file)) {        
      if (substr($file, strrpos($file, '.')) == $file_extension) {          
        if(preg_match('/\Q' . $products_image_base . '\E/i', $file) == 1) {             
          if ($file != $products_image) {               
            if ($products_image_base . str_replace($products_image_base, '', $file) == $file) {                 
              //  echo 'I AM A MATCH ' . $file . '<br>';                
              $images_array[] = $file;
              $files_found++;  /* Add this */               
            } else {                 
              //  echo 'I AM NOT A MATCH ' . $file . '<br>';              
            }
          }
        }
      }
    }
  }
  if (sizeof($images_array)) {
       sort($images_array);
  }
  $dir->close();
}

lat9:

That's what I get for "punting". Here's an updated/corrected version, the $files_found count was misplaced before:

// Check for additional matching images
$file_extension = $products_image_extension;
$products_image_match_array = array();
$files_found = 0; /* Add this /
if ($dir = @dir($products_image_directory)) {
while ($file = $dir->read() && $files_found < 3) { / Change this /
if (!is_dir($products_image_directory . $file)) {
if (substr($file, strrpos($file, '.')) == $file_extension) {
if(preg_match('/\Q' . $products_image_base . '\E/i', $file) == 1) {
if ($file != $products_image) {
if ($products_image_base . str_replace($products_image_base, '', $file) == $file) {
// echo 'I AM A MATCH ' . $file . '<br>';
$images_array[] = $file;
$files_found++; / Add this */
} else {
// echo 'I AM NOT A MATCH ' . $file . '<br>';
}
}
}
}
}
}
if (sizeof($images_array)) {
sort($images_array);
}
$dir->close();
}

nope that still doesnt work :( outputs no images

includes/modules/additional_images.php

// Build output based on images found
$num_images = 3;

SWEET! haha after all that all that had to be changed was that! perfect thanks mate. Im surprised that this isn't controllable from the admin!

The only issue with the code change is if there are no additional images, it will put 3 'Image Not found' images.

philip937:

SWEET! haha after all that all that had to be changed was that! perfect thanks mate. Im surprised that this isn't controllable from the admin!

Well in theory, if you only want 3 additional images, just don't upload the other 7 :)

hmm yeah i do have some that have none. so thats a problem.

How can I test if there is no images in the array?

tied this but doesnt work..

if ($num_images < 1) {
$num_images = sizeof($images_array);
} else {
// Build output based on images found
$num_images = 3;
}

haha was having a brian fart.

this is the fix

if ($num_images < 3) {
$num_images = sizeof($images_array);
} else {
// Build output based on images found
$num_images = 3;
}

philip937:

haha was having a brian fart.

this is the fix

if ($num_images < 3) {
$num_images = sizeof($images_array);
} else {
// Build output based on images found
$num_images = 3;
}

Wont that also not show any additional images for products that only have 2?

no the logic is

if the number of images in the array is less than 3 then do what it normally does, i.e $num_images = sizeof($images_array); other wise if there are 4 or more excecute the mod that you said which instead of building based on the actual number of images, it only buoilds up to 3.

make sense? works a treat anyway :)

Thanks for you help dgent

Ah yes of course I didnt read it properly.

Philip937,

I am happy to hear you found the solutions for this! Can you please show me exactly where you added this code in includes/modules/additional_images.php? Or if you removed anything? Thank you!

WWRepair:

Philip937,

I am happy to hear you found the solutions for this! Can you please show me exactly where you added this code in includes/modules/additional_images.php? Or if you removed anything? Thank you!

cant remeber off the top of my head but I think I just added this code either after where $num_images is defined

so basically what its doing is saying if there is less than 3 images then the amount of images should be default i.e sizeof($image_array)

if ($num_images < 3) {
$num_images = sizeof($images_array);
}

otherwise lets fool it into thinking that there are only a max of 3..

 else {
// Build output based on images found
$num_images = 3;
}

so full code would be:

if ($num_images < 3) {
$num_images = sizeof($images_array);
}else {
// Build output based on images found
$num_images = 3;
}

hope this helps, if you get stuck let me know any I will pull more code from my file I modified. what version are you using also, just incase the code has been changed from the version I was playing with!