Twitch SaleMaker & Specials for Attributes

I nearly hit the three year anniversary of...

http://www.zen-cart.com/showthread.php?171756-Display-attributes-regular-price-and-sale-price&p=980486#post980486

After 19 days of relentless coding, I'm proud to present...

Twitch SaleMaker & Specials for Attributes
for ZenCart v1.51 Version 13a
December 21.2013

http://www.zen-cart.com/downloads.php?do=file&id=1801

** Description:**

• This module will display SaleMaker & Specials pricing for attributes on the product info page
• Displays product regular price, sale price, discount amount for each attribute
• Product price/ lowest attribute price on sale is displayed on product listing page
• Discounted attributes sale price is passed properly to shopping cart product price
• Includes improvements to admin SaleMaker & Specials calculations
• *Optional *- Make SaleMaker and Specials unavailable to wholesale clients

** Works with:**

• Twitch Wholesale + Attributes
• Twitch CORE Price
• SaleMaker 'Apply Discount Used' flag - Yes/No
• 'Include in Base Price When Priced by Attributes' flag - Yes/No
• SaleMaker condition 'Ignore Sale Condition - No Sale Applied When Special Exists'
• Product Price + Attribute Price
• Products Priced by Attribute

This is the attributes code that should come in every stock ZenCart 1.51!

Twitch,

I am floored by the depth of this contribution, and am praying to overcome my knowledge handicaps due to little coding experience. I have installed the entire contribution with great care, but some of the directions were not easy for the amateur as they do not always show current code and required change. Changing by pline number when other core files are modified have caused some problems for me. No complaints, as I may have replaced a line or two incorrectly. I have checked my logs as I wanted to provide the details. The problem is absolutely my following of the instructions, but here is the trace info.

First, I got this when my admin screen went blank,

[27-Dec-2013 14:33:31 America/Phoenix] PHP Parse error: syntax error, unexpected T_ELSE in /home/content/"removednumbers"/html/includes/functions/functions_prices.php on line 251

Here is the area of the functions.pricing file (I tried to upload but it destroyed formatting for viewing. Apologies to all if this texts out abusively, not desired or intended. Tried to quote, too long, )

<?php /** * functions_prices * * @package functions * @copyright Copyright 2003-2011 Zen Cart Development Team * @copyright Portions Copyright 2003 osCommerce * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0 * @version $Id: functions_prices.php 18697 2011-05-04 14:35:20Z wilt $ */ //// //get specials price or sale price function zen_get_products_special_price($product_id, $specials_price_only=false) { global $db; $product = $db->Execute("select products_price, products_model, products_priced_by_attribute from " . TABLE_PRODUCTS . " where products_id = '" . (int)$product_id . "'"); if ($product->RecordCount() > 0) { // $product_price = $product->fields['products_price']; $product_price = zen_get_products_base_price($product_id); } else { return false; } $specials = $db->Execute("select specials_new_products_price from " . TABLE_SPECIALS . " where products_id = '" . (int)$product_id . "' and status='1'"); if ($specials->RecordCount() > 0) { // if ($product->fields['products_priced_by_attribute'] == 1) { $special_price = $specials->fields['specials_new_products_price']; } else { $special_price = false; } if(substr($product->fields['products_model'], 0, 4) == 'GIFT') { //Never apply a salededuction to Ian Wilson's Giftvouchers if (zen_not_null($special_price)) { return $special_price; } else { return false; } } // return special price only if ($specials_price_only==true) { if (zen_not_null($special_price)) { return $special_price; } else { return false; } } else { // get sale price // changed to use master_categories_id // $product_to_categories = $db->Execute("select categories_id from " . TABLE_PRODUCTS_TO_CATEGORIES . " where products_id = '" . (int)$product_id . "'"); // $category = $product_to_categories->fields['categories_id']; $product_to_categories = $db->Execute("select master_categories_id from " . TABLE_PRODUCTS . " where products_id = '" . $product_id . "'"); $category = $product_to_categories->fields['master_categories_id']; $sale = $db->Execute("select sale_specials_condition, sale_deduction_value, sale_deduction_type from " . TABLE_SALEMAKER_SALES . " where sale_categories_all like '%," . $category . ",%' and sale_status = '1' and (sale_date_start <= now() or sale_date_start = '0001-01-01') and (sale_date_end >= now() or sale_date_end = '0001-01-01') and (sale_pricerange_from <= '" . $product_price . "' or sale_pricerange_from = '0') and (sale_pricerange_to >= '" . $product_price . "' or sale_pricerange_to = '0')"); if ($sale->RecordCount() < 1) { return $special_price; } if (!$special_price) { $tmp_special_price = $product_price; } else { $tmp_special_price = $special_price; } switch ($sale->fields['sale_deduction_type']) { case 0: $sale_product_price = $product_price - $sale->fields['sale_deduction_value']; $sale_special_price = $tmp_special_price - $sale->fields['sale_deduction_value']; break; case 1: $sale_product_price = $product_price - (($product_price * $sale->fields['sale_deduction_value']) / 100); $sale_special_price = $tmp_special_price - (($tmp_special_price * $sale->fields['sale_deduction_value']) / 100); break; case 2: $sale_product_price = $sale->fields['sale_deduction_value']; $sale_special_price = $sale->fields['sale_deduction_value']; break; default: return $special_price; } if ($sale_product_price < 0) { $sale_product_price = 0; } if ($sale_special_price < 0) { $sale_special_price = 0; } if (!$special_price) { return number_format($sale_product_price, 4, '.', ''); } else { switch($sale->fields['sale_specials_condition']){ case 0: return number_format($sale_product_price, 4, '.', ''); break; case 1: return number_format($special_price, 4, '.', ''); break; case 2: return number_format($sale_special_price, 4, '.', ''); break; default: return number_format($special_price, 4, '.', ''); } } } } //// // computes products_price + option groups lowest attributes price of each group when on function zen_get_products_base_price($products_id) { global $db; $product_check = $db->Execute("select products_price, products_priced_by_attribute from " . TABLE_PRODUCTS . " where products_id = '" . (int)$products_id . "'"); // is there a products_price to add to attributes $products_price = $product_check->fields['products_price']; // do not select display only attributes and attributes_price_base_included is true $product_att_query = $db->Execute("select options_id, price_prefix, options_values_price, attributes_display_only, attributes_price_base_included, round(concat(price_prefix, options_values_price), 5) as value from " . TABLE_PRODUCTS_ATTRIBUTES . " where products_id = '" . (int)$products_id . "' and attributes_display_only != '1' and attributes_price_base_included='1'". " order by options_id, value"); $the_options_id= 'x'; $the_base_price= 0; // add attributes price to price if ($product_check->fields['products_priced_by_attribute'] == '1' and $product_att_query->RecordCount() >= 1) { while (!$product_att_query->EOF) { if ( $the_options_id != $product_att_query->fields['options_id']) { $the_options_id = $product_att_query->fields['options_id']; $the_base_price += (($product_att_query->fields['price_prefix'] == '-') ? -1 : 1) * $product_att_query->fields['options_values_price']; } $product_att_query->MoveNext(); } $the_base_price = $products_price + $the_base_price; } else { $the_base_price = $products_price; } return $the_base_price; } //// // Display Price Retail // Specials and Tax Included function zen_get_products_display_price($products_id) { global $db, $currencies; $free_tag = ""; $call_tag = ""; // 0 = normal shopping // 1 = Login to shop // 2 = Can browse but no prices // verify display of prices switch (true) { case (CUSTOMERS_APPROVAL == '1' and $_SESSION['customer_id'] == ''): // customer must be logged in to browse return ''; break; case (CUSTOMERS_APPROVAL == '2' and $_SESSION['customer_id'] == ''): // customer may browse but no prices return TEXT_LOGIN_FOR_PRICE_PRICE; break; case (CUSTOMERS_APPROVAL == '3' and TEXT_LOGIN_FOR_PRICE_PRICE_SHOWROOM != ''): // customer may browse but no prices return TEXT_LOGIN_FOR_PRICE_PRICE_SHOWROOM; break; case ((CUSTOMERS_APPROVAL_AUTHORIZATION != '0' and CUSTOMERS_APPROVAL_AUTHORIZATION != '3') and $_SESSION['customer_id'] == ''): // customer must be logged in to browse return TEXT_AUTHORIZATION_PENDING_PRICE; break; case ((CUSTOMERS_APPROVAL_AUTHORIZATION != '0' and CUSTOMERS_APPROVAL_AUTHORIZATION != '3') and $_SESSION['customers_authorization'] > '0'): // customer must be logged in to browse return TEXT_AUTHORIZATION_PENDING_PRICE; break; default: // proceed normally break; } // show case only if (STORE_STATUS != '0') { if (STORE_STATUS == '1') { return ''; } } // $new_fields = ', product_is_free, product_is_call, product_is_showroom_only'; $product_check = $db->Execute("select products_tax_class_id, products_price, products_priced_by_attribute, product_is_free, product_is_call, products_type from " . TABLE_PRODUCTS . " where products_id = '" . (int)$products_id . "'" . " limit 1"); // no prices on Document General if ($product_check->fields['products_type'] == 3) { return ''; } $show_display_price = ''; $display_normal_price = zen_get_products_base_price($products_id); $display_special_price = zen_get_products_special_price($products_id, true); $display_sale_price = zen_get_products_special_price($products_id, false); $show_sale_discount = ''; if (SHOW_SALE_DISCOUNT_STATUS == '1' and ($display_special_price != 0 or $display_sale_price != 0)) { if ($display_sale_price) { if (SHOW_SALE_DISCOUNT == 1) { if ($display_normal_price != 0) { $show_discount_amount = number_format(100 - (($display_sale_price / $display_normal_price) * 100),SHOW_SALE_DISCOUNT_DECIMALS); } else { $show_discount_amount = ''; } $show_sale_discount = '<span class="productPriceDiscount">' . '<br />' . PRODUCT_PRICE_DISCOUNT_PREFIX . $show_discount_amount . PRODUCT_PRICE_DISCOUNT_PERCENTAGE . '</span>'; } else { $show_sale_discount = '<span class="productPriceDiscount">' . '<br />' . PRODUCT_PRICE_DISCOUNT_PREFIX . $currencies->display_price(($display_normal_price - $display_sale_price), zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . PRODUCT_PRICE_DISCOUNT_AMOUNT . '</span>'; } } else { if (SHOW_SALE_DISCOUNT == 1) { $show_sale_discount = '<span class="productPriceDiscount">' . '<br />' . PRODUCT_PRICE_DISCOUNT_PREFIX . number_format(100 - (($display_special_price / $display_normal_price) * 100),SHOW_SALE_DISCOUNT_DECIMALS) . PRODUCT_PRICE_DISCOUNT_PERCENTAGE . '</span>'; } else { $show_sale_discount = '<span class="productPriceDiscount">' . '<br />' . PRODUCT_PRICE_DISCOUNT_PREFIX . $currencies->display_price(($display_normal_price - $display_special_price), zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . PRODUCT_PRICE_DISCOUNT_AMOUNT . '</span>'; } } } if ($display_special_price) { // discount display for specials $show_sale_discount = '<span class="productPriceDiscount">' . '<br />' . PRODUCT_PRICE_DISCOUNT_PREFIX . $currencies->display_price(($display_normal_price - $display_special_price), zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . PRODUCT_PRICE_DISCOUNT_AMOUNT . '</span>'; } else { // discount display for salemaker $show_sale_discount = '<span class="productPriceDiscount">' . '<br />' . PRODUCT_PRICE_DISCOUNT_PREFIX . $currencies->display_price(($display_normal_price - $display_sale_price), zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . PRODUCT_PRICE_DISCOUNT_AMOUNT . '</span>'; } if ($display_sale_price && $display_special_price != $display_special_price) { $show_special_price = ' ' . '<span class="productSpecialPriceSale">' . $currencies->display_price($display_special_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</span>'; if ($product_check->fields['product_is_free'] == '1') { $show_sale_price = '<br />' . '<span class="productSalePrice">' . PRODUCT_PRICE_SALE . '<s>' . $currencies->display_price($display_sale_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</s>' . '</span>'; } else { $show_sale_price = '<br />' . '<span class="productSalePrice">' . PRODUCT_PRICE_SALE . $currencies->display_price($display_sale_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</span>'; } } else { if ($product_check->fields['product_is_free'] == '1') { $show_special_price = ' ' . '<span class="productSpecialPrice">' . '<s>' . $currencies->display_price($display_special_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</s>' . '</span>'; } else { $show_special_price = '' . '<span class="productSpecialPrice">' . '<br />' . PRODUCT_PRICE_SALE . $currencies->display_price($display_special_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</span>'; } $show_sale_price = ''; } } else { if ($display_sale_price) { $show_normal_price = '<span class="normalprice">' . $currencies->display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . ' </span>'; $show_special_price = ''; $show_sale_price = '<br />' . '<span class="productSalePrice">' . PRODUCT_PRICE_SALE . $currencies->display_price($display_sale_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</span>'; } else { if ($product_check->fields['product_is_free'] == '1') { $show_normal_price = '<s>' . $currencies->display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</s>'; } else { $show_normal_price = $currencies->display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])); } $show_special_price = ''; $show_sale_price = ''; } } if ($display_normal_price == 0) { // don't show the $0.00 $final_display_price = $show_special_price . $show_sale_discount . $show_sale_price; // Swapped sale_discount and sale_price } else { $final_display_price = $show_normal_price . $show_special_price . $show_sale_discount . $show_sale_price; // Swapped sale_discount and sale_price } have truncated as cannot post that file in text. Too long and way ugly, but you have the line I think. Thx I may need to revert my site to yesterdays status as the entire page layout got fried. I am using 1.5.1 and replaced all text in the text instructions. I did not download all of the core files the changes were from as I tried to merge them properly. Please emessage me, if needed. My problems may not help the group. I desire this mod greatly, and don't think I have f'd up too badly. Only takes a ;, you know? Again, my sincere thanks for this important accomplishment. Please help me to find the error as I need this, and your other mods in the package. Private E if you want to talk. Marc

I am floored by the depth of this contribution, and am praying to overcome my knowledge handicaps due to little coding experience. I have installed the entire contribution with great care, but some of the directions were not easy for the amateur as they do not always show current code and required change. Changing by pline number when other core files are modified have caused some problems for me. No complaints, as I may have replaced a line or two incorrectly. I have checked my logs as I wanted to provide the details. The problem is absolutely my following of the instructions, but here is the trace info.

First, I got this when my admin screen went blank,

[27-Dec-2013 14:33:31 America/Phoenix] PHP Parse error: syntax error, unexpected T_ELSE in /home/content/"removednumbers"/html/includes/functions/functions_prices.php on line 251

Trademagic, quote the error. If you're going to put the entire file up, zip it and attach the file or wrap it with code tags.

The answer to the quote above is exactly what you have mentioned:
'Changing by line number when other core files are modified have caused some problems for me.'

The parse error exposes code that doesn't exist in the original ZenCart files or any of my Twitch modules.

There's no way to troubleshoot the problem if you have inserted code into a modified functions_prices.php file... in the wrong locations.

I may need to revert my site to yesterdays status as the entire page layout got fried. I am using 1.5.1 and replaced all text in the text instructions. I did not download all of the core files the changes were from as I tried to merge them properly. Please emessage me, if needed. My problems may not help the group. I desire this mod greatly, and don't think I have f'd up too badly. Only takes a ;, you know? Again, my sincere thanks for this important accomplishment. Please help me to find the error as I need this, and your other mods in the package. Private E if you want to talk.

Please do replace anything you have changed back to the last working site.

Once you get it working again, a list of the modules you have installed properly/working would help. WinMerge is your friend for comparing code, especially when it comes to the kind of core changes I made to get this all working.

Our work publicly in the forum provides all others a learning experience regardless of their ego/competence/wealth or lack of knowledge regardless of whether they are willing to admit it or not, myself included.

I'm happy to support the community, however if you'd like to hire me to install modules into your cart, my contact info is in my signature.

Dear Twitch,

I redid the install tonight, and learned a great deal about the merging, and was extraordinarily cautions. I am a 1.5.1 store with many other affecting modifications, so I merged with the originals from the 1.5.1 download for your line number support, and poured my mind into it. With the basic coding changes you specified, I found my site cracked completely, would not work from the index page. The page refused to load, then I changed back one of your files, i think function_prices.php, and got the main text on the front page back, and the left column went from the middle of the page back down the left with function. However, each level of depth in the site brought new failures even when I got the index back, you've got me. The way your line numbers read with original 1.5.1, you are off by a line or two, which sometimes tells you to take out a break; that does not get replaced. Example: Line 564 of includes/functions/functions_prices.php your instructions are to replace 564, which is break; and the replace code never gets back to there. Also includes/modules/attributes.php replace 255-246 seemed way off when searching for 158-159 original file which I think should be 157-158 for the replace, which seemed in the 300s on my amended file.

I did not amend the css files as looks were not what I wanted to play with, just wanted to see it work. I did all code changes, added notes to all of the files. Since I merged, and you weren't specific, I did not download the files in your folders over the changes I made to merged files. I do not think I did it wrong, but I may have not intuited these instructions correctly. I beg for more detail, if possible.

I gave up again, and believe there may be code issues. If anyone else can verify it's working on their site, I would dearly like to get this working on mine.

I would like to have confirmation that this works perfectly, as I truly want what you are offering. I am not sure this is bug free. Here were a couple of the error files, although I have already gone back to standard to await further developments or depth in the install script clarifications, whatever you decide makes this reasonable for dummies.

[29-Dec-2013 00:50:31 America/Phoenix] PHP Parse error: syntax error, unexpected T_ELSE in /home/content/69/11416569/html/includes/functions/functions_prices.php on line 251

funny enough, it is showing the savings in dollars not percent, one of your features? or a selection you recommended checked? I want to get this implemented, and would wish some help, but my current status is unable to donate until I reach some cash flow. My problem, I know. ;-(

Trademagic, as I've mentioned before the line numbers are relative to the other installed modules recommended in the package and merely guidelines. It may not be necessary to have the other modules installed but at that point you'll need to be exceptionally good at understanding the placement of the code within the existing files.

https://www.twitchparts.com is a simple base ZenCart v1.51 install with all published Twitch modules installed and functioning. No tricks or gimmics. I develop the files on a separate ZenCart then follow my own instructions to install them on two unique shopping carts, one in production - twitchparts, the other bone stock non public.

As mentioned in the install instructions percent/dollars is located here:
Admin-> Configuration-> Product Info
Product Info - Show Sales Discount Savings Dollars or Percentage

I will again offer my assistance to get your cart up and running for you, worry about donations when there's an income to support them.

**Trademagic, thanks for accepting my help. **

Although your site is heavily modified, the following modules are now working and installed correctly:

Twitch Base_Cost
Twitch List_Price

Twitch Wholesale with Twitch Wholesale Attributes
Twitch SaleMaker & Specials for Attributes

Twitch TURN OFF SaleMaker & Specials & Discount Coupons for Wholesale Customers
- Discount Coupons for wholesale was left ON as I noticed you are offering wholesale DC's

Let there be sales! :)

Twitchtoo,

For the dunces in the audience, where do I administer them. I apologize that I cannot find a single clue, although some warnings show on the backend. I do not see anything in the menus where my other mods are. Also, I saw a 5% discount that I do not recognize called first test dollars. Do I delete that?

Thank you again,

Marc

Trademagic, I left the test category visible with two products with attributes and w/o att, two SaleMaker sales - percent and amount, one Special for reg. twitch test product and one Special for twitch test product with attributes.

If you navigate to Admin-> Catalog-> Categories-> Twitch Test Cat, you'll be able to see how the products are now displayed, then click the 'edit attributes' link on the product with attributes to see how the wholesale prices have been added to each attribute option.

You can now also modify your wholesale landing page languages/english/html_includes/YOUR_TEMPLATE/define_wholesale_store.php and perhaps the guest/retail landing pages that are running within languages/english/html_includes/YOUR_TEMPLATE/define_main_page.php.

Note: SaleMaker and Specials are 'hidden' from wholesale as I installed the Twitch TURN OFF module. That means there were no core changes to 'split' the SaleMaker/Specials code between retail/wholesale.

I've instaled your module as I find the concept verry good. The problem is that it shows the same price for all atributes. I used winmearge and I dont know why is not working right. I want to mention that I sale digital products and my product price is 0, only the attributes give the price.
I will send a link by PM as I dont want my website posted on the forum.

I looked over the source of the page you sent me, it looks like the module is installed but the admin settings may not be lining up. Can you PM an admin login, I need to see the pricing setup along with the sale setup. It's possible the product type you are using is not seeing the new code.

I use product tipe bookx. How can I find the lining up you mention? Everything worked fine until I've instaled your module.

I'll need access to your site ftp and admin to set this up for book product type as I currently do not have a suitable test cart.

It's not only that it displayes the same price for all discounted atributes, but if you ad that atribute to cart it keeps the shown price, so is not a display isue is sometrhing about the way it calculates the discounted price.
Whit the normal zencart function.price it shows the same discounted price but when you add to cart it uses the right price.

What puzzels me is that it calculates different discounts (those should be the same) and keeps the same price, it's like it's working in reverse.
For an 30% Discount, this is what I get:

Option name 1
aaaa 19,00 lei
Discounted price 13,30 lei , save 30%
bbbbb 29,00 lei
Discounted price 13,30 lei , save 54%

Option name 2
ccccc 10,00 lei
Discounted price 13,30 lei , save -33%

This above is the behavior of the "SPECIALS". I tryed now the behavior of the ""SaleMaker". And my conclusions are:
In "Specials" it treats the discount as new price for all the atributes and in "SaleMaker" it treats all discounts like Deduct amount lowering the atribute's prince with the respective amount.
This happens indiferent of what I chose (New Price, Percent, Deduct amount), the behavior is the same.
If I look at the atribute's prices in the admin, the ones from "SaleMaker" are correct and those from "Specials" ar wrong like in the front end. On the front end, in both the situations the prices are wrong.

I've decided to take it off as after using the "Salemaker" all af the products apear discounted with 0% off for those that are neither on special nor included int the "SaleMaker".
I still think that your idea is great, but for my store it seams to be too strange and confusing.

Given the complexity of your site and the issue of the product type you are using not currently supported in this package I'd need to tackle this hands on with your cart. From our PM's I understand if you choose to uninstall it at this point.

All of the products appear discounted with 0% off for those that are neither on special nor included in the "SaleMaker". This happens indifferent of what I chose (New Price, Percent, Deduct amount), the behavior is the same. I uploaded the mod to a clean install, tried with merging file s on a clean install, no luck for either way. I also have prices set to show with tax but they do not with this mod installed. http://candlemoney.karmelscents.com. I'm using v1.51

here's a link to example. http://candlemoney.karmelscents.com/index.php?main_page=product_info&cPath=17_21&products_id=194