1.5.7c - category_products_listing

version 1.5.7.c
Thanks for the changes. Might i suggest that line 875 of admin/category_products_listing.php

$zco_notifier->notify('NOTIFY_ADMIN_PROD_LISTING_DATA_B4_QTY', '', $extra_data);

be modified to

$zco_notifier->notify('NOTIFY_ADMIN_PROD_LISTING_DATA_B4_QTY', $product, $extra_data);

This would remove the need to rely on a global or $GLOBALS to set the data value for your additional columns assuming you have modified the select.

Appropriate comment also to line 906.

So, BrittainMark, what Pull Request (PR) number should we be looking for in github (https://github.com/zencart/zencart) where your above suggestion/revision is incorporated?

If I have done it correctly pull request it should be https://github.com/zencart/zencart/commit/7e029ee991db508162d530978d28ee9dad1cd99a
I am always nervous of changing code before asking.
Should I look at v1.5.8 and make the same change (tried there first) would need to look at it as it is a little different.

don't think i got it right last time. newish to git hub. I think the pull request is Update category_product_listing.php #4238
Do i need to make same change to v1.5.8

For next time:
It's better to do 1.5.8 first and then let the moderators worry about backporting it. Only super important fixes are being backported to 1.5.7 at this point.

Thanks for your contribution to the Zen Cart project!

Ok closed previous pull request and opened new one on 1.5.8. Update category_product_listing.php #4239
Still learning how to do these things. Happy to help.

swguy:

For next time:
It's better to do 1.5.8 first and then let the moderators worry about backporting it. Only super important fixes are being backported to 1.5.7 at this point.

Thanks for your contribution to the Zen Cart project!

Forgive me for asking .... but does that mean when a fix is put up as a "you need to upgrade now because of this error" that a fixed older version may be out that that we could put the code up instead of doing a complete update?

Thank you!

shrimp-gumbo-mmmhhh:

Forgive me for asking .... but does that mean when a fix is put up as a "you need to upgrade now because of this error" that a fixed older version may be out that that we could put the code up instead of doing a complete update?Still looking for that shortcut. :D

dbltoe:

Still looking for that shortcut. :D

:) Not necessarily the shortcut.... but like this last update.... Things are too busy in November-December to update the cart to with a full upgrade.... if I can just move some files over to get serious issues fixed would be easier to do.

As always, the majority of major fixes are posted in the "Known bugs and fixes" thread.

Moderator comment: I'm locking this thread because it's now straying from its purpose and duplicating discussions already posted elsewhere.