AJAX errors document.write

[pasi]

I noticed that AJAX errors are being printed on to the document directly....

jscript_framework.php

         document.open();
         document.write(responseHtml);
         document.close();

Should probaby change that behaviour to

         console.log(responseHtml);

Haven't got the time to go through the system, but it seems to have something to do with showing "raw" html error messages?

But if there are other (non intended) errors, just printing the output brakes layout.

[DrByte]

I noticed that AJAX errors are being printed on to the document directly....

jscript_framework.php

         document.open();
         document.write(responseHtml);
         document.close();

Those lines are not for error output. They are specifically for the intended payload. Changing them to console.log would completely break the whole purpose for adding the ajax support in the first place.

Can you explain the specific errors you're encountering which led you to posting about this? Show us how to recreate your exact symptoms, so we can propose a proper fix.

[pasi]

I noticed it as I got a PHP warning just under the body tag.... the ajax call returned:

{"data": true} PHP Warning: Some warning not relevant to this.

And this did read just under the body tag (not visible in standard "view source", but webdeveloper addons "view generated source" which includes javascript output. Commenting out the document.write part sorted it.

Obviously this is a developement version as I have errors on, so this would probably not be a problem in production enviroment.

I got the idea of it being an error as the part of the code is wrapped in:
.fail(function(jqXHR, textStatus, errorThrown) {

But like I said, I haven't had the chance to check the code out much so am not 10000% sure.


Unfortunately I can't remember which page this was on... I re-enabled the document.write and will give more info when/if I run to it again.