PHP Warning admin/attributes_controller.php

**ianhg** · 7 Jun 2022, 10:09 AM

V1.5.7d
PHP 7.4
Just found a php warning in admin/attributes_controller.php. Its just a warning but I have no idea how to fix it.
count(): Parameter must be an array or an object that implements Countable in admin/attributes_controller.php on line 212
Line 212 for ($i = 0; $i < count($_POST['values_id']); $i++) {

PHP Code:


    case 'add_product_attributes':      $current_image_name = '';      for ($i = 0; $i < count($_POST['values_id']); $i++) {        if (isset($_POST['values_id'][$i])) {          $value_id = (int)$_POST['values_id'][$i];        }        if (isset($_POST['options_id'])) {          $options_id = (int)$_POST['options_id'];        }        if (isset($_POST['products_id'])) {          $products_id = (int)$_POST['products_id'];        }

Thanks

**ianhg** · 28 Jun 2022, 06:07 PM

Originally Posted by ianhg

V1.5.7d
PHP 7.4
Just found a php warning in admin/attributes_controller.php. Its just a warning but I have no idea how to fix it.
count(): Parameter must be an array or an object that implements Countable in admin/attributes_controller.php on line 212
Line 212 for ($i = 0; $i < count($_POST['values_id']); $i++) {

PHP Code:


    case 'add_product_attributes':      $current_image_name = '';      for ($i = 0; $i < count($_POST['values_id']); $i++) {        if (isset($_POST['values_id'][$i])) {          $value_id = (int)$_POST['values_id'][$i];        }        if (isset($_POST['options_id'])) {          $options_id = (int)$_POST['options_id'];        }        if (isset($_POST['products_id'])) {          $products_id = (int)$_POST['products_id'];        }

Thanks

Sorry to bounce this to the top, but still getting this warning. Can anyone please suggest a fix, many thanks

**lat9** · 28 Jun 2022, 07:08 PM

Originally Posted by ianhg

Sorry to bounce this to the top, but still getting this warning. Can anyone please suggest a fix, many thanks

From the current zc158 GitHub, add the highlighted section

Code:

    case 'add_product_attributes':
      $current_image_name = '';
      if (!isset($_POST['options_id'], $_POST['products_id']) || empty($_POST['values_id'])) {
           break;
      }

**ianhg** · 29 Jun 2022, 09:11 AM

Originally Posted by lat9

From the current zc158 GitHub, add the highlighted section

Code:

    case 'add_product_attributes':
      $current_image_name = '';
      if (!isset($_POST['options_id'], $_POST['products_id']) || empty($_POST['values_id'])) {
           break;
      }

@lat9
Thank you,