I don't have the hang of knowing exactly what you guys need for information but hopefully I'll get better at it!! ;)Quote:
Originally Posted by lat9
Printable View
I don't have the hang of knowing exactly what you guys need for information but hopefully I'll get better at it!! ;)Quote:
Originally Posted by lat9
v4.1.6 is now available for download from the Zen Cart plugins.
This release provides updates for the following issues (the issue numbers are those from the plugin's GitHub repository
#27: Missing echo in admin orders.php
#28: Don't display "missing shipping address" if the order's all virtual products
#29: Tax not added if the order didn't start with tax; tax not applied to products added to an order
#30: Re-factor debug-output to be on an order-basis
#31: Convert all tab characters to 4 spaces.
How to merge the admin\includes\class\plugin.php with that is from another plugin? I am installing "ultimate urls" which has the same file with different codes. Since it isn't original zen cart file, I have no idea how to merge them. Is anybody can help? Thanks.
Unfortunately, the version of that module (and its associated language file, admin\includes\languages\modules\plugin\plugin.php) is newer for the USU plugin and, as you identified, the plugin file-structure is also different.Quote:
Originally Posted by su35
That said, there's no merging of the two versions that will make both plugins "happy".
My suggestion is to install the plugins one-at-a-time (the plugin class is only used on installation), using the files associated with EO for that plugin's install and replacing those two files when you're installing USU.
Thanks, lat9. I will try it.
Hi, lat9. I find three files named plugin.php in new file folder:
1_new_files\admin\includes\languages\english\modules\plugin\plugin.php
1_new_files\admin\includes\extra_configures\plugin.php
1_new_files\admin\includes\classes\plugin.php
Are all of them for installation and can be deleted after install? Do I need them in uninstall process?
The folder structure you identified is that for the Ultimate SEO plugin's installation. There's no harm in leaving that file in /extra_configures, but the other two files should be replaced by the like-named ones from the EO installation file-set.
The files are used only during the plugin's installation and don't do any harm by leaving them after install.
Thanks! I'm just worried that other plugin may add the same files.
Has this issue been fixed in the latest version? This is still a big issue for us that we've been unable to resolve. The first time we edit an order, it reverses the attribute lines, even if we don't edit anything. We just click the edit button and then click update. If we go in and do the same thing again, it doesn't switch back, it stays in the reverse order. It's very odd, I'm not sure why it only happens the first time. In the database, the fields are displayed in reverse order, so somehow the edit_orders.php file is pulling the attribute data from the database and then putting it back in reverse order.
Quote:
Originally Posted by Danielle
I did test using the 4.1.6 version of admin/includes/classes/attributes.php as I see that it sorts the attributes differently, but am still having this issue. If I fully update the module to 4.1.6 will it fix the issue?
Quote:
Originally Posted by Danielle
I'm not able to reproduce this on an installation using EO 4.1.6 and Zen Cart 1.5.5a.
Do you have sort-orders assigned to those attributes that are sorted "differently"?
This is happening with EO 4.1.4 on a 1.5.4 installation. There are no sort orders assigned to the attributes. There are sort orders attached to the options. I'll attach some screenshots to show you the back end display of the attributes and options, as well as the order before and after we edit it.
Quote:
Originally Posted by lat9
I could only put 4 images in the last post so here are the other two.
I'll need to look further for the way that EO differs from the "standard" Zen Cart handling of those attributes that are without sort-orders. I'll post back here when I have additional information.
OK, thank you. I don't know why the sort order of the attributes would really matter though, since there is only one attribute per option. The options (Line 1, Line 2, etc.) do have sort orders. They are text options, so just one attribute per option.
Quote:
Originally Posted by lat9
Sorry I have not had time to go through a bunch of posts but will this work with 1.55a?
It doesn't take a lot of reading. Not sure of your setup for reviewing posts on this forum, but now 6 posts back it was stated that problems asked about could not be reproduced in ZC 1.5.5.a and would think that in the plugins download section that it would show that it is supported on ZC 1.5.5.Quote:
Originally Posted by roberttimmons
As mc12345678 indicated, the plugin does work on Zen Cart 1.5.5a. Just follow the installation instructions, merging required core-file changes where noted, and you should be good-to-go.Quote:
Originally Posted by roberttimmons
thank you guys. I was just in a frenzy that day had to do a forced upgrade on a site and had many other add ins I needed to get working before I even started to worry about edit orders. Things are back to normal now so I will do my due diligence.
EO 4.1.6 orders.php patches for ZC 1.5.5a
I am upgrading to ZC 1.5.5a from 1.3.9h with all fresh configuration and only migrating the database.
The read me file for EO 4.1.6 under Modified Core files, item 3, states:
There are five (5) change sections that apply to "Edit Orders" and other sections that introduce the Super Orders navigation to the orders' handling. If you are installing/upgrading on Zen Cart 1.5.5 or later, these navigation-related changes are already incorporated, but you'll need to merge the five change-sections into your version of this file."
In the 1_modified_core_files folder the orders.php file provided has only 4 change sections clearly marked. These are edit order patches 2 of 5 through to 5 of 5.
Are there really only 4 patches or are there 5?
Bailey
There really are 5 patches; the first (a one-line insert) is at line 331 of the plugin's orders.php to add the edit_orders.css file's load.Quote:
Originally Posted by OldNGrey
I've been using Edit Orders (slightly modified by me) on 1.5.1 forever. Now upgrading to 1.5.5 (as a new install) there are a couple of issues I haven't been able to resolve.
First one is the big one - the tax treatment (we're in Canada) of the order_total items. Most of these are discounts, which should affect the tax charged etc (reducing it).
I also tried a COD charge, which of course is taxable, and determined the totals correct after placing the order.
After Admin / Edit Orders / (no changes) / Update: First update, the total and tax was changed to completely wrong - it didn't add in the COD fee, and the total included only some of the tax. On the second Update, the tax was corrected on the shipping, however the COD fee and the tax on it is completely ignored for the tax amount AND the base COD fee.
I've attached the edit orders debug log.
HOW editing works, and what code is used to recalc these things, or at least the flow - and what dependancies would be great to know so I can edit myself. Can you point me to documentation of who does what to who for these?
Thanks,
Dan Tomlinson
I had a similar problem due to the default sort order!Quote:
Originally Posted by DTomlinson
The tax has to be the "lowest" on the list just before the final total!
Dan, how "slightly modified" is your copy of Edit Orders? Are you using the 4.1.6 EO version as your change-basis?Quote:
Originally Posted by DTomlinson
The 4.1.6 EO is installed, and as far as I remember is unchanged.
It's the previous that I'd modified on the live site.
What I modified was to not allow the user to "lose" information. I always kept the original order quantities etc, and had added fields to do that.
All added items were tagged as [CSAdd] in the product name, as well the original quantity was kept. 0 became a valid order quantity that never could ship of course - but a customer, or me, could see the original and as-shipped order.
We have 50,000+ products in 1,000+ categories - and 3 people who deal with orders, so there has to be that level of auditability.
That's not in THIS install - yet! I have to wrap my head around how to change 4.1.6 to have the capability I had in 4.0.3 on ZC151.
That one I have :) It's some items that are being ignored, no tax changes, or even just dropped :(Quote:
Originally Posted by marton_1
Did you have any luck with this? We are still having this issue, I've tried a variety of things to fix it but no luck so far.
Quote:
Originally Posted by lat9
Nope, haven't had a chance ... yet.Quote:
Originally Posted by Danielle
@Danielle, did you try upgrading your EO installation to 4.1.6? That version has a slew of bugfixes pre-included.
I've modeled your configuration on EO 4.1.6 and Zen Cart 1.5.5a and cannot reproduce your issue. I created an order for a product with two text-type attributes followed by a radio-button choice (ordered in that manner). When I edit the order (via press of the "Update" button after updating the item's price), the attributes come back listed in the same (text/text/radio) order.
What are your Configuration->Edit Orders settings?
I've just installed Edit Orders in my 1.55a test site. The installation proceeded just fine, no error messages, but when I try to go to the orders screen, I get an error message. It's one of those really unhelpful ones that means something happened way back there in the program like a missing semi-colon, but there's no way to know exactly where. Don't you love those, sigh.
Parse error: syntax error, unexpected end of file in /home/darwinhi/public_html/newnaturalsonline/test/My_Admin/orders.php on line 1068
I have gone through and very carefully examined every one of the five merge code sections, and don't see anything wrong. If anyone has run into this particular issue and knows what the fix is, I'd appreciate it. My biggest supplier just let me know that he's sending two different versions of the product we've all been waiting for, so now I have to be able to change people's orders if they want the alternate version. We'll do it the old fashioned way with scribbled notes on the packing slips if we have to, but this seemed like a perfect opportunity to install the Edit Orders plugin.
Rather than a semicolon, you've probably removed or added extra braces: } or {
I've checked for that, and didn't find any missing or extras. But I just realized that this wasn't a vanilla orders.php. I have the affiliate plug-in installed. So I need to go back and look at what got changed in that. I may have to go back to the orders.php from the installation package and start over from there.Quote:
Originally Posted by DrByte
I'm sure it's been mentioned before, but Beyond Compare, and Araxis Merge, are great tools for visually comparing files. (I know Merge even has a 3-way compare which can be really handy.)
Yes, I use Beyond Compare.Quote:
Originally Posted by DrByte
I'm receiving the following error PHP Warning: Invalid argument supplied for foreach() in edit_orders.php on line 1700
It's happening when I try to add a product with attributes, the product is added to the order but the attributes are not, any idea what the issue could be?
Edit Orders v4.1.4
Zen Cart v1.5.4
Below is the code staring with line 1700
PHP Code:foreach($_POST['id'] as $id => $value) {
if(is_array($value)) {
foreach($value as $id2 => $value2) {
if(is_array($value2)) {
foreach($value2 as $id3 => $value3) {
echo '<input type="hidden" name="id[' . $id . '][' . $id2 .'][' . $id3 . ']" value="' . zen_html_quotes($value3) . '">';
}
}
else {
echo '<input type="hidden" name="id[' . $id . '][' . $id2 .']" value="' . zen_html_quotes($value2) . '">';
}
}
}
else {
echo '<input type="hidden" name="id[' . $id . ']" value="' . zen_html_quotes($value) . '">';
}
}
}
@marcopolo, the current version for EO is 4.1.6 (with 4.1.7 in the "works"); it's got a bunch of bug-fixes and other changes incorporated.
Please upgrade to the most recent version and see if the issue has been previously resolved.
Ok just upgraded but now when I click on an order to edit I'm getting this in admin:
You must install the Zen Cart 1.5.5 AdminRequestSanitizer class before you can use Edit Orders on this site
You'll need to also install the latest Trustwave Security patch: https://www.zen-cart.com/showthread....80#post1311680
Ok that fixed that issue and by upgrading to Edit Orders v4.1.6 fixed the attribute issue, thanks. Question I did not upgrade whatever changes were made to the core files though only new files and install, is that a big deal? It worked so I assuming not but just thought I would ask in case I should do it right away or wait until v4.1.7 is released.
I've got this working, but when you go to details, the shipping and billing icons are displaying part of the alt text also.Attachment 16738Attachment 16739
Oops, I take it back. The order screen and editing functions appear to be working just fine, but the invoice and packing slip routines just give me a nice white screen. Good thing I checked before copying it over to the live site.
Those two (2) storefront class-files (/includes/classes/shipping.php and /includes/classes/order_total.php) are very necessary, but the admin-side changes to the Customers->Orders handling aren't.Quote:
Originally Posted by marcopolo
Note, however, that without the button-additions to the Orders handling, there's not a one-click path to get to Edit Orders (you'll need to modify the browser address-bar).
Glad to hear you got Edit Orders working! Note that EO has nothing to do with the invoice/packing-slip display.Quote:
Originally Posted by HeleneWallis
Yes, I know. And the only change I've made to the packing slips is to add the shipping method. So I'll have to do some digging to see what's going on. I do have DrByte's nice addon for the invoices to change order statuses on multiple orders at one time, but that's not in the packing slip program at all. Oh well.
This site has Taxcloud installed and that might be the problem. Does anyone have tax cloud and edit orders working together?
I fixed the problem with taxcloud and now see there's a problem with a shipping module which is specific to this cart and UPS customer. Is there anyway to bypass bringing all the dang shipping methods in? I can't see how to fix this.
The error message in cpanel says the class upsxmlmpr is not found in shipping.php. With taxcloud it was a matter of specifying the DIR_FS_CATALOG in the file because it couldn't find the file from admin. This actually might be a case of a non-working mod but it works for the customers sake and what she needs. If I could just exclude that one shipping mod, that might fix the problem.
@delia, most issues with shipping and order-totals modules with EO have to do with their use of (presumed) storefront functionality that fails when they're included in the admin environment.
You don't identify the version of Zen Cart or EO that you're using ...
Zen cart is version 1.5.4. The upsxmlmpr and tax cloud are the only two odd things on the site. Since the ups module was mostly written by some ups folks many years ago, it's not surprising that this one would be a problem. But the mpr is based on the upsxml code - adds dimensions based on box sizes so a number of new functions. The class definition does look to be identical with just changes so that it's not the upsxl class.
@delia, what version of EO?
The latest - from August.
@delia, was there a Zen-Cart log produced by EO? I'm not sure what you mean by:
If you've got a ZC log, please post it (sanitizing the site's admin folder-name).Code:The error message in cpanel says the class upsxmlmpr is not found in shipping.php
No, it's a cpanel error log which I can't even see all of.
This happens too early to generate a zen cart - seen it before.
You can see the entire error message, in your cPanel error-log screen, as long as it's one of the last 300(i think that's the default) errors.Quote:
Originally Posted by delia
And if it's too wide to see on-screen (should be able to scroll though), you can double/triple click on it and copy it to your clipboard to paste here.
I don't see how that can happen, as the Zen Cart logging is set up way early in a page's rendering and the call to the shipping.php class wouldn't happen until the full autoload_functions processing is complete.Quote:
Originally Posted by delia
Learn something new everyday!
[Thu Oct 20 10:24:54.153807 2016] [:error] [pid 28102] [client 76.123.2.38:65216] PHP Fatal error: Class 'upsxmlmpr' not found in /home/xxxxxxx/public_html/includes/classes/shipping.php on line 59, referer: http://xxxxx.com/pellets/orders.php[Thu Oct 20 10:24:54.153728 2016] [:error] [pid 28102] [client 76.123.2.38:65216] PHP Warning: include_once(): Failed opening 'includes/modules/shipping/upsxmlmpr.php' for inclusion (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home/xxxxxx/public_html/includes/classes/shipping.php on line 58, referer: http://xxxxx.com/pellets/orders.php
[Thu Oct 20 10:24:54.153529 2016] [:error] [pid 28102] [client 76.123.2.38:65216] PHP Warning: include_once(includes/modules/shipping/upsxmlmpr.php): failed to open stream: No such file or directory in /home/xxxxxx/public_html/includes/classes/shipping.php on line 58, referer: http://xxxxx.com/pellets/orders.php
If those errors aren't getting logged to the /logs folder, then there's something messed up in your server's configuration ... like the PHP function ini_set being disabled.Quote:
Originally Posted by delia
I'll also note that the errors are associated with the built-in Zen Cart's Customers->Orders processing (orders.php), not edit_orders. Please continue this discussion in a new thread, outside of the EO support one.
My server, no problems there. I'm pretty sure there have been log files in the log folder but can't be positive sure. Quite a few sites with no problems and the server. No use of php.ini file on this site or any other site. This site was upgraded (new files completely, not just upload new over old.) but old configure files. Do you supposed there could be an issue there?
Oh, I did find error logs that had been written to the logs folder. I had downloaded them and left them up. So logs are being written correctly. Like I said, I have seen this before and I have a sneaking suspicion it was the edit orders doing it before.
@delia, the log you posted showed the issue with the built-in orders.php, not edit_orders.php. Since your issue also occurs during built-in Zen Cart processing, I suggest that you solve that issue outside of the EO support thread.
That is the orders file in admin that came with the edit orders mod.
And this only happens when I try to edit the order. No problems otherwise.
... and it's slightly modified from the Zen Cart 1.5.4 base. Have you looked to see that the file includes/modules/shipping/upsxmlmpr.php actually exists?Quote:
Originally Posted by delia
Uh, yeah. That's the point. It does exist in the modules/shipping folder.
... and you copied the plugin's update for /includes/classes/shipping.php? From the line number posted in the log, I'm thinking not.
hmm, well I know I did by the file dates but I went ahead and uploaded the files anyway. Problem solved! Weird as there was also a taxcloud error that I fixed by making a change to the taxcloud includes statement. Thank you!!!!
No problem; I'm glad we finally sorted the issue out!
I've just submitted v4.1.7 to the Plugins for review, correcting the following issues (identified by their GitHub issue number):
#37: Modify the storefront version "order.php" to include the "value" field for each order-total in the order.
#34: Correct interaction with "ot_cod_fee".
#35: Correctly handle taxable order-totals.
#38: Correct currency-related rounding issues.
v4.1.7 is now available for download from the plugins ...
Hi,
I recently upgraded to zenCart 155b and now the edit order add on does not work I mean if I go to an order and click on "edit" then I see the order details OK but I cannot edit anything. The order looks just like as if Edit Orders is not installed.
The edit order installation V4.1.7 seemed to be OK, I received the completion message - see image. I had installed the install files again and ran the installation a second time.
The Configuration entry looks OK, see second image.
There are no error messages in the Zen Cart error log and although I set the edit order debug to "on" there is no new edit order log.
@marton_1, that implies to me that you haven't merged the changes required for Edit Orders into the base Zen Cart's /YOUR_ADMIN/orders.php.
Great thanks, that fixed it.
I had done the merge with WinMerge but I must have screwed it up somewhere; I did the merge again and now everything works. :smile:
Just updated from v4.1.6 to v4.1.7 but in admin still says v4.1.6
@marcopolo, did you run the "Install" step? That's the last step in the installation procedure and it's what's going to update that configuration version number.
Quote:
Originally Posted by lat9
Nevermind it worked!
I'll need to investigate further. FWIW, there were no configuration changes going from 4.1.6 to 4.1.7 (other than the version number itself).
Nevermind it worked
Excellent! Thanks for the update.
Hi
Installed edit_orders-4.1.7 and it is working (sort of)
I also have another plugin called 'Attribute Grid 1.3.1' . All my products are added using the normally in Zencart and all the options/variations are added using 'Attribute Grid 1.3.1' plugin.
In admin when I want to add an order to existing order:
Step 1: I can select the category fine
Step 2: I can select the product fine
Step 3: Here it aoutomatically display the first item ([2160] Racing Rosso+$56.00 ) at the top from the attributes page my using 'Attribute Grid 1.3.1' . It should give me an option to select which attribute I should select. Instead it selects aoutomatically the first uption ([2160] Racing Rosso+$56.00) and the field is not selectable or editable nor has a drop down.
For example I have following attributes from the Category but only the top one is choosen.
[2160] Racing Rosso+$56.00
[2161] Speed Yellow+$56.00
[2162] RS Blue+$56.00
[2164] Midnight Black+$56.00
[2165] Prestige Gold Met+$56.00
[2166] Power Green+$56.00
[2167] Flame Orange+$56.00
[2168] Pure White+$56.00
Can anyone please help?
Product attribute grid was not made compatible until version 1.3.3. You will need to upgrade that plugin in order for it to work with Edit Orders. There is nothing wrong with Edit Orders, it is/was working as designed. PAG was the software that was "behind" the times.Quote:
Originally Posted by oavs
You beauty mate!
Works like xmas bells. Thank you :-)
This version contains the changes associated with the following issues (identified by their GitHub issue number):
#39: Additional option type supported (for SBA interoperation).
#42: Remove integration with Ty Package Tracker (separate install required)
#43: Restructure plugin installation
#44: Remove support for Zen Cart versions prior to v1.5.5.
If you are using a version of Zen Cart prior to v1.5.5, please continue to use EO v4.1.7.
Once approved, you can download the update here: https://www.zen-cart.com/downloads.php?do=file&id=1513
Updated an older version to EO 4.2.0 and when I now try to edit an order, I get this error:
I thought maybe I had to change the "true" to "1" but I still get the error. Any thoughts on what I might have done wrong?Quote:
PHP Fatal error: Call to a member function eoLog() on a non-object in admin/includes/functions/extra_functions/edit_orders_functions.php on line 1534
Thanks
I should also ask... when clicking the ADMIN HOME link, should something have happened since I already had 4.1.5 installed because nothing happened
You're missing the file /YOUR_ADMIN/includes/classes/editOrders.php (and if you're missing that, you're probably also missing EditOrdersQueryCache.php from the same directory).Quote:
Originally Posted by marieAA
When you click the "Admin Home" button, EO does its installation (now without message). You'll need to review the distribution zip-file to make sure that you've copied all the required files from the plugin.Quote:
Originally Posted by marieAA
Note that the readme's inclusion of "what changed in this release" only began with v4.2.0.
OK, I misspoke in my previous post. To receive the log information that you indicated, the $eo object was not previously created, which implies that the version of /YOUR_ADMIN/edit_orders.php wasn't updated correctly.
What version of EO were you upgrading from?
yep you are right, it was the admin/edit_orders.php update that didn't update correctly on the website. Everything seems to be alright now.Quote:
Originally Posted by lat9
Thank you
@marieAA, thanks for the update!
thank YOU for the help! Really appreciatedQuote:
Originally Posted by lat9
Hi!
Is this correct? ( $order->id ?? )
(line #758 in modified YOUR_ADMIN\orders.php)HTML Code:<td colspan="2" align="right" class="noprint"><?php echo '<a href="' . zen_href_link(FILENAME_ORDERS_INVOICE, 'oID=' . $order->id) . '" target="_blank">' . zen_image_button('button_invoice.gif', IMAGE_ORDERS_INVOICE) . '</a> <a href="' . zen_href_link(FILENAME_ORDERS_PACKINGSLIP, 'oID=' . $order->id) . '" target="_blank">' . zen_image_button('button_packingslip.gif', IMAGE_ORDERS_PACKINGSLIP) . '</a> <a href="' . zen_href_link(FILENAME_ORDERS, zen_get_all_get_params(array('action'))) . '">' . zen_image_button('button_orders.gif', IMAGE_ORDERS) . '</a>' . $extra_buttons; ?></td>
No, it is not! In each case, that $order->id should be $_GET['oID']. I'll get this updated in the plugin's GitHub repository and ready for a 4.2.1 release. Thanks for the report!:smile:Quote:
Originally Posted by yesaul
Arggh, I've submitted v4.2.1 for review, but it's got a PHP parse error. Hold up for v4.2.2, coming soon.
EO v4.2.2 was just submitted to the Plugins for review; I'll post back when it's available.Quote:
Originally Posted by lat9
Wow, that was quick! EO v4.2.2 is now available for download.Quote:
Originally Posted by lat9
Hi
Recently I've upgraded my ZC version from 1.3.9h to 1.5.5e. Also upgraded Super orders and edit orders module to current latest version though. Now my issue is
After I've edited attribute option value in order details page, option name sort order was totally messed up. Its completely changed and its not look like as before. Please see this small video. I've entered Sort order properly on each option name.
http://recordit.co/5P61O5OOKS
Please help..
What are your current settings for Products Info - Products Option Name Sort Order and Products Info - Product Option Value of Attributes Sort Order in Configuration->Product Info?
HiQuote:
Originally Posted by lat9
Thanks for reply. here is my settings Configuration->Product Info
Attachment 17034
Catalog -> Option name sorter
Attachment 17035
@Prabu, thanks for the information. I'll post back once I've got this replicated!
HiQuote:
Originally Posted by lat9
Many thanks. Please provide some instructions to fix this issue.
Prabu, please let me know your direct email address via PM (Private Message) so that I can send you an update to verify.