One-Page Checkout [Support Thread]

Quote:

---

Originally Posted by lat9

No, but I've opened an issue (https://github.com/lat9/one_page_checkout/issues/155) on OPC's GitHub repository to track any investigation.

---

Thanks! I've made a few modifications that have the plugin operational and operating together, although not the prettiest yet.
A couple of .css lines modified changing from visibility: none in checkout_one.css solved the blank-ish display, although the loading cursor is still there;
forcing jquery.js to load earlier
and some heavy conditional expiry date manipulation solved the checkout problem in the elavon_converge payment method.

Prettification to come at https://www.beadfx.com/catalogue/

Thanks!
Dan

Hi!

Another checkout issue has arisen, One-Page checkout 2.04. Possibly related to issue #126, and #150

A customer tried to checkout (paypal) for a Gift certificate. Initially tried as a guest but that failed (good thing :) ) then setup an account and still could not check-out.
Disabling OPC allowed the checkout.

I captured a debug log for her, and can also re-produce it. Attempted on my test account (conditional) and it also fails. Everything appears
correct, but pressing the "Confirm" button (with any payment method including moneyorder) the button dims and returns with no action.

I will send you the test login as well as the debug logs etc (live site)

Dan

@DTomlinson, was it that the customer tried to create an order that contained a Gift Certificate or that the customer tried to use a GC to make that purchase?

I successfully ordered a GC (albeit using the Check/Money Order payment method) and then used that GC (after release) to make an OPC purchase.

Quote:

---

Originally Posted by lat9

@DTomlinson, was it that the customer tried to create an order that contained a Gift Certificate or that the customer tried to use a GC to make that purchase?

I successfully ordered a GC (albeit using the Check/Money Order payment method) and then used that GC (after release) to make an OPC purchase.

---

Customer is trying to create an order that only contains a gift certificate. If it has real product in it it works fine!
Paying using a GC worked fine when there was real product included.
(my check/moneyorder is called "Call Back")

I just tried using my test account on both Firefox and Chrome with both not continuing past "Confirm"


Dan

155f fresh install
php: 7.1.24
OPC 2.0.5 munged from Git Hub

Created a product test order with OPC & Square was successful.
Dowloable pdf/zip file with OPC after clicking confirm the order, the curser just spins. :(
So no error logs were generated.
Turned off OPC to 3 page checkout and was successful.

Sent you a pm when you have time

Thanks,
Mark

Quote:

---

Originally Posted by haredo

155f fresh install
php: 7.1.24
OPC 2.0.5 munged from Git Hub

Created a product test order with OPC & Square was successful.
Dowloable pdf/zip file with OPC after clicking confirm the order, the curser just spins. :(
So no error logs were generated.
Turned off OPC to 3 page checkout and was successful.

Sent you a pm when you have time

Thanks,
Mark

---

Mark, is that product a "Product - General" type product or "Document - General"?

Cindy,
It is set up as Document - General

Cindy,
Upon further investigation it is set up as Document - General but I have created a Product - General to get a free download of the Brochure

Quote:

---

Originally Posted by haredo

Cindy,
It is set up as Document - General

---

My bad, @haredo ... is that 'Document - Product'? Does the issue occur during Guest checkout, 'normal' OPC or both?

Cindy,
OPC turned on
Category set up as Document - General called Printable Brochure
Product enabled under it called Document - Product which I have the pdf & zip of the brochure to download
When clicking confirm to order when logged in to download pdf/zip the cursor just spins and does not complete the order
Also using guest check out the cursor just spin and does not complete the order

Quote:

---

Originally Posted by haredo

Cindy,
OPC turned on
Category set up as Document - General called Printable Brochure
Product enabled under it called Document - Product which I have the pdf & zip of the brochure to download
When clicking confirm to order when logged in to download pdf/zip the cursor just spins and does not complete the order
Also using guest check out the cursor just spin and does not complete the order

---

Thanks, @haredo, that nailed it. The issue is that the Square payment module is creating a jQuery/javascript error and preventing OPC from continuing.

See this image for the console-log. What version of Square are you using?

Cindy,
Square Payments Module 0.95

Quote:

---

Originally Posted by haredo

Cindy,
Square Payments Module 0.95

---

There was a similar issue with that module previously, but you should report it to the Square Payments' payment-method's support thread.

It affects OPC due to OPC's heavy use of jQuery; I'm guessing that the console log will still be there on the 3-page checkout's confirmation page but doesn't wreck as much havoc.

Cindy,
Thank you for your time and I will start a thread in the Square Section.

Here's hoping someone can help with some OPC problems that I've unsuccessfully tried to resolve for some time.

I was using this great plugin successfully for some time on my development website (constantly changing) but started having payment-order_total interaction issues. The fix supplied at #148 in Github resolved that part (thanks lat9 :D!). But there are now other problems. Since it's a bit complicated, I provide a summary here... & then a detailed step-by-step guide later (so apologies for long post).

Summary
A. Shipping-payment module interaction issue (see Issue 1 below) that's resolved when browser is refreshed:

In Dr Byte's Square installation instructions, he cites where this can happen:

Quote:

---

If you find the input fields for credit card numbers are flat with no text box to type into, this typically means you're missing the jscript_square.php file as described earlier in the Installation Instructions.

• Or you've got a firewall or browser plugin blocking access to Square's javascript code.
• Or you've got a plugin having jQuery conflicts.

---

My efforts to find possible jQuery conflicts iaw ZC forum research (e.g. uninstalling some plugins [e.g. CSS/JS Loader v1.5.2]; upgrading some jquery files - done both before and after the step-by-step sequence below) all failed to resolve this problem. However, my experience here is limited…so I may have missed something.

B. Payment-order_total interaction issues (see Issues 2-5 below) that's resolved when OPC sends the customer back with the "…order has changed…resubmit" message.

BTW, I only remembered to get a CTRL-U dump after those steps were completed & after some last-ditch effects to address possible jQuery conflicts:Attachment 18178

Thanks for any help in advance.

Cheers…Gerri

My system:
ZC 1.5.5e
jQuery: In ...template/mytemplate/common/html_header.php: v11.1 (during step-by-step seq.) Upgraded to ZCv1.5.5f's 1.12.4.min.js after.
Template: clone of Responsive Sheffield Blue (modified to work with ZCv1.5.5)
OPC: v2.0.5-beta1 (i.e. v2.04 + fix for issue #148 provided in Github)
Shipping: Australia Post Shipping Module v2.3; In Store Pick-up (modified for specific postcodes iaw this thread);
Payment: Direct Bank Deposit V1.5.3-revised, Square v0.96
Order-Total: Optional Shipping Insurance v3.2.3 (was using jquery/jquery-1.6.min.js. I modified this so think it now accesses v 1.12.4 :unsure:); Payment Module Fee v1.1.0; Override Shipping No Price Module v1.1 ot_AUD_total (a clone of ot_total I modified iaw this thread - only shows up when foreign currency used)
Other plugins: Lots. E.g. of those using JQuery installed b4 from problems started: Image Handler 5.0.0Beta4, EC Analytics v1.2.2
Website: https://recoveredheritage.com.au/ (under development so Maintenance currently enabled - pls let me know & I can turn it off temporarily if needed).

STEP-BY-STEP SEQUENCE:
a. Starting point:

1. OPC guest checkout disabled; OPC logging = true,
   
2. At entry into Checkout page:
   
   1. cheapest of 2 x postage options is auto-selected (Parcel Post incl P&H fee [$16.75 incl GST]); In-store Pickup is also available but not selected
   2. none of the 2 x payment options selected (Square CC or Direct Bank Deposit;
   3. In order-total box, all is correct:
      
      1. product T001 is selected ($77 incl GST of 10%);
      2. Insurance of $2.00 (incl GST)
      3. total = $95.75; GST = $8.70;

b. Change postage to Express Post ($19.75 incl GST); no payment selected yet

• ISSUE 1: the Square CC text boxes disappear.
• In order-total box, all is correct: $8.98 GST; total = $98.75
• Screen dump:

Attachment 18171

NOTE: Issue 1 also occurs even when In Store pickup is selected…so it's unlikely that the AU Post shipping module is the cause.

c. Payment selected - Direct Bank Deposit:

• Nothing changes (nothing should)
• I progress the payment without any issue.

d. OPC log file of preceding steps: Attachment 18175

e.Cleared the cache & repeated steps a-b above. Issue 1 is duplicated.
f. Payment selected - Square (CC):

• in addition to the CC text boxes not appearing... there's another problem:

- ISSUE 2: a transaction fee (for CC payments) should have shown up in order-total box

• Since I can't complete the sale, I have to refresh the browser.

g. After browser refresh, SQUARE CC text boxes appear again, no payment option is selected & order-total is correct (as it was before)
h. When CC selected:

• Order-total box correctly shows Card Transaction Fee ($2.13 = 2.2%'of the total; I don't charge GST)
• 3 issues in order total box (numbered 1, 2 & 3 in screen dump):

- ISSUE 3: Express Post cost in order-total is incorrect: it quotes the ex-GST price ($17.95) instead of incl-GST price ($19.75)

- ISSUE 4: GST calculation is incorrect: it doesn't include the postage GST; shows $7.18 instead of $8.98 i.e. it's lost the GST for the P&H charge added within the AUPost module

- ISSUE 5: the total shows a rounding error: total of figure above should be $99.08, not $99.09 (I have tries various suggestions from ZC forums to correct this - but no luck yet.)

• Screen dump:

Attachment 18176

i. If I then change payment method to Bank Deposit, Transaction Fee correctly disappears but ISSUES 3-5 remain
j Progress the CC payment:

• Change payment method back to CC, the transaction fee reappears (correct); ISSUES 3-5 remain
• Click REVIEW ORDER button
• OPC sends customer back to Checkout page with "Your order's details have changed. Please review the current values and re-submit" message
• On return, all is correct - no ISSUE 3-5. (The customer could proceed to CONFIRM - but I don't in this test environment)

k. OPC log file for preceding steps: Attachment 18177

@GerriM, PM sent with my IP address so that I can see your site in Maintenance Mode.

A couple of initial observations:

1. The Square payment module (https://www.zen-cart.com/downloads.php?do=file&id=156) has been updated to correct some jQuery interaction issues. I'm not sure if that's part of the problem you're having, but I suggest that you upgrade your version of that payment method.
2. I'm guessing that the Shipping Insurance order-total is using a checkbox-type field to allow the customer to make their selection. I've seen other OPC issues arise, requiring a continual 'Please re-submit', when a checkbox is used to gather that page-to-page information. See that referenced OPC posting for additional information.

Thanks very much for looking at this, Cindy.

P/O my reply, for other Zenners' info:

Quote:

---

The Square payment module (https://www.zen-cart.com/downloads.php?do=file&id=156) has been updated to correct some jQuery interaction issues. I'm not sure if that's part of the problem you're having, but I suggest that you upgrade your version of that payment method.

---

Square v0.96 (released by Dr Byte on 6 Dec) already uploaded. Had my fingers crossed...but no help: nothing changed.:(

Quote:

---

I'm guessing that the Shipping Insurance order-total is using a checkbox-type field to allow the customer to make their selection....See that referenced OPC posting for additional information.

---

No. Insurance is compulsory & the rest come up automatically as req'd (I've made code modifications). But I'll look at that bit of the docs again in case it's relevant. Thnx.

First, thanks to @GerriM for granting me access to her test site so that I could investigate the issues she identified.:smile:

There are actually two underlying issues that I've identified and currently opened as issues on the OPC's GitHub repository:

Square payment inputs disappear after shipping-method change
The Square (and possibly other?) payment-method has an external jQuery script that's loaded on a full-page load, so when OPC re-loaded only the payment-selection block, that processing didn't kick in ... resulting in no input fields for the Square credit card information.

My current approach, validated by @GerriM, has its limitations. For the Square module to operate properly when the shipping method changes, it's necessary to not re-load the payment-choices block. Unfortunately, there are payment methods that are dependent on the shipping method selected (like enabling a Cash payment only when the shipping-method is store-pickup), so these payment methods absolutely require that the payment-choices' block be updated on a shipping method change.

The approach I plan to take (unless a better solution is proposed) is to add another configuration value to the One-Page Checkout Configuration, allowing a store-owner to identify payment methods that require no reload of the payment-choices' block; that setting will be initialized to identify the square method by default. What this means to store-owners utilizing OPC is that you can't have a combination of payment methods that require the block to be updated and those that require the block not to be updated.

If anyone has a better solution to the issue, I'm open to suggestions!

Taxed order-totals 'lose' their tax on payment method update.
This one was caused by the payment-method update's AJAX not initializing the order's shipping- and payment-classes prior to requesting the order-total modules to perform their calculations.

I'll be updating the OPC's GitHub in the morning with my current changes.

Quote:

---

Originally Posted by lat9

First, thanks to @GerriM for granting me access to her test site so that I could investigate the issues she identified.:smile:

There are actually two underlying issues that I've identified and currently opened as issues on the OPC's GitHub repository:

Square payment inputs disappear after shipping-method change
The Square (and possibly other?) payment-method has an external jQuery script that's loaded on a full-page load, so when OPC re-loaded only the payment-selection block, that processing didn't kick in ... resulting in no input fields for the Square credit card information.

My current approach, validated by @GerriM, has its limitations. For the Square module to operate properly when the shipping method changes, it's necessary to not re-load the payment-choices block. Unfortunately, there are payment methods that are dependent on the shipping method selected (like enabling a Cash payment only when the shipping-method is store-pickup), so these payment methods absolutely require that the payment-choices' block be updated on a shipping method change.

The approach I plan to take (unless a better solution is proposed) is to add another configuration value to the One-Page Checkout Configuration, allowing a store-owner to identify payment methods that require no reload of the payment-choices' block; that setting will be initialized to identify the square method by default. What this means to store-owners utilizing OPC is that you can't have a combination of payment methods that require the block to be updated and those that require the block not to be updated.

If anyone has a better solution to the issue, I'm open to suggestions!

Taxed order-totals 'lose' their tax on payment method update.
This one was caused by the payment-method update's AJAX not initializing the order's shipping- and payment-classes prior to requesting the order-total modules to perform their calculations.

I'll be updating the OPC's GitHub in the morning with my current changes.

---

Your solution solved all issues for me:clap:. Thank you sooo much. You’re my hero:D!! OPC is a great plugin. And thanks to Dr Byte for his Square plugin assistance also.

I've just submitted v2.0.5 of One-Page Checkout to the Zen Cart plugins for review. This version contains changes associated with the following GitHub issues:


#133: Guest/Registered-Accounts, pre-fill Zip Code
#148: Payment change requires order-totals block update
#151: zc156 updates not fully incorporated
#152: Salutation Ms. not saved on guest-account creation
#156: Square payments input blocks disappear after shipping change
#157: Taxed order-totals 'lose' their tax on payment-method update.
#158: Correct various 'PHP Notice' issues.
#159: Partial zc156 integration; downward-compatible files only.


Please note: This version is not fully integrated with Zen Cart 1.5.6; you'll need to review the core- and template-file changes and merge the well-marked change sections into the Zen Cart 1.5.6 base. I expect to have the zc156 integration completed early next year.

This is the final release that will continue to support Zen Cart versions less than 1.5.5f, too, due to the number of changes introduced by the zc156 core.

Quote:

---

Originally Posted by lat9

I've just submitted v2.0.5 of One-Page Checkout to the Zen Cart plugins for review. This version contains changes associated with the following GitHub issues:


#133: Guest/Registered-Accounts, pre-fill Zip Code
#148: Payment change requires order-totals block update
#151: zc156 updates not fully incorporated
#152: Salutation Ms. not saved on guest-account creation
#156: Square payments input blocks disappear after shipping change
#157: Taxed order-totals 'lose' their tax on payment-method update.
#158: Correct various 'PHP Notice' issues.
#159: Partial zc156 integration; downward-compatible files only.


Please note: This version is not fully integrated with Zen Cart 1.5.6; you'll need to review the core- and template-file changes and merge the well-marked change sections into the Zen Cart 1.5.6 base. I expect to have the zc156 integration completed early next year.

This is the final release that will continue to support Zen Cart versions less than 1.5.5f, too, due to the number of changes introduced by the zc156 core.

---

Now available for download from the Zen Cart plugins section.

Hello Cindy - I would like to add some text to the PayPal image in payment selection - had a few customers 'expecting' that when they selected the paypal radio button on the payment page that it would take them immediately to PayPal (like the paypal icon on the checkout page) not realizing they need to click confirm order first which requires scrolling with a lot of white space between them (a couple have contacted me meaning a bunch of others haven't) - so in an effort to try to obviate these instances could you guide me please to where/how I can add some text to the bottom of that block, if this is possible that is - if not then no problem.

cheers, Mike
Attachment 18317

includes/modules/payment/paypalwpp.php around line 270. It's all an image from PayPal itself.

MODULE_PAYMENT_PAYPALEC_MARK_BUTTON_IMG

Quote:

---

Originally Posted by dbltoe

includes/modules/payment/paypalwpp.php around line 270. It's all an image from PayPal itself.

MODULE_PAYMENT_PAYPALEC_MARK_BUTTON_IMG

---

Many Thanks dbltoe

Since I couldn't find this referenced on the ZC forum, here's some info in case it can help another not-so-experienced Zenner out there like me. Cindy, please see text in blue below re whether this affects OPC code.

An OPC javascript-like error started to appear i.e. on checkout entry, instead of the usual OPC screen, only this is displayed:

HTML Code:

---

Sorry, but our expedited checkout process cannot be used. Click here to use our alternate checkout process

---

.
FYI, javascript errors (Firefox: F12; Console menu) displayed while SQUARE was enabled (the middle ones disappeared when SQUARE was disabled): Attachment 18321
However, I couldn’t track the problem down & resolve this issue for ages because, just through bad luck, a server PHP version issue happened at the same time and 'muddied the waters'. But more about the PHP issue later…

My system: ZC1.5.5e; OPC v2.0.5; Template: RSB v2 modified; various payment & shipping modules including SQUARE v, Direct Bank Deposit & Australia Post Shipping Modules; lots more plugins & mods. My website: (currently under development so closed for maintenance): https://recoveredheritage.com.au/ .

First, the OPC issue + solution:
That OPC error message was caused by 2 x database entries in my zones table including an apostrophe: Côte-d'Or & Côtes-d'Armor. Internet research mentioned that one could use "a SqlParameter object to pass in values...so you don't have to worry about the apostrophes users enter in". However I did a manual work-around (replaced those apostrophes with spaces) since I'm not sure whether OPC has that functionality or if one of my other mods is interfering.

Where did the apostrophe errors come from? Back in January, after getting OPC to play well with SQUARE (with Cindy's help - thanks), I added extra countries into my zones table in the database using ZC plugins including this one. After working through ZC1.5.5 compatibility issues with the old ZC version SQL files, I did lots of testing...and thought I had nailed it :no:. When I tested OPC the next day or so, I started getting error logs at the same time. With hind-sight being 20-20, I now know those error logs had abolutely nothing to do with the OPC issue but were, instead, to do with the PHP issue (below). But I didn't know that then so... since a site can only have one active PHP version, I headed in the wrong direction and started in on upgrading to PHP 7.2. :oops:

Now that this OPC issue is solved:clap:I've reverted to backups and am free instead to progress towards launching the website (using PHP 7.1) while upgrading to ZC1.5.6(maybe b) locally with WAMP where I can run PHP 7.3 while testing.

And now the PHP issue:

Don't take it for granted that your hosting company will tell you when they upgrade the server PHP default version to 7.2. Mine didn't (inMotion hosting). So...if you start getting error logs out of the blue like these ones, investigate whether you can just change your site PHP version manually back to PHP 7.1 FIRST - before you assume you have to do a full PHP 7.2 upgrade like I did.

While I still had to address a few error logs even after I had reverted to Site PHP 7.1, there aren't too many so far. I think these occur when the cPanel currency cron job runs &, of course accessed the default server running PHP 7.2. (I haven't yet been able to get the SQUARE cron job to work...so fingers crossed.)

Hope this helps.

Thanks for the great job of analysis and data-gathering, @GerriM! I'll see if I can reproduce the issue to correct the underlying issue.

Greetings =)

I am having an issues where guest checkout is not updating totals for order total modules such as low order fee and minimum order fee. Neither works and checkout proceeds without adding them at all.

Zen Cart 1.5.5F
PayPal Express & WPP
PHP 7.1.26
OPC 2.0.5 (2018-12-23)
ZCA Bootstrap 1.0.6

Code:

---

[06-Feb-2019 15:56:26 UTC] PHP Notice:  Undefined property: ot_loworderfee::$credit_class in /home/----/public_html/includes/classes/order_total.php on line 125

---

Code:

---

2019-02-06 15:56:26 checkout_one: CHECKOUT_ONE_AFTER_ORDER_TOTAL_PROCESSING
order_total::__set_state(array(
  'modules' =>
  array (
    0 => 'ot_subtotal.php',
    1 => 'ot_shipping.php',
    2 => 'ot_coupon.php',
    3 => 'ot_tax.php',
    4 => 'ot_loworderfee.php',
    5 => 'ot_mfg_min_order.php',
    6 => 'ot_gv.php',
    7 => 'ot_total.php',
  ),

---

Code:

---

    <tr id="otsubtotal">
<td colspan="2" class="text-right bg-white">
Sub-Total:</td>
<td class="text-left bg-white">
$53.85</td>
    </tr>

    <tr id="otshipping">
<td colspan="2" class="text-right bg-white">
USPS (Priority Mail&trade;):</td>
<td class="text-left bg-white">
$11.16</td>
    </tr>

    <tr id="ottotal">
<td colspan="2" class="text-right bg-white">
Total:</td>
<td class="text-left bg-white">
$65.01</td>
    </tr>

---

I can provide the whole log if necessary, it's a dev environment.

Code:

---

2019-02-06 15:56:36 checkout_one_confirmation: Initial order information:order::__set_state(array(
  'info' =>
  array (
    'order_status' => '1',
    'currency' => 'USD',
    'currency_value' => '1.00000000',
    'payment_method' => NULL,
    'payment_module_code' => NULL,
    'coupon_code' => NULL,
    'shipping_method' => 'USPS (Priority Mail™)',
    'shipping_module_code' => 'usps_Priority MailTM',
    'shipping_cost' => 11.160000000000000142108547152020037174224853515625,
    'subtotal' => 53.85000000000000142108547152020037174224853515625,
    'shipping_tax' => 0,
    'tax' => 0.0,
    'total' => 65.0100000000000051159076974727213382720947265625,
    'tax_groups' =>
    array (
      'Sales Tax' => 0.0,
    ),
    'comments' => '',

---

Any ideas?

Thanks,
~Melanie

Melanie, I just tried a < $50.00 order on my demo site (the configured low-order fee cut-off). Running zc155f/OPC 2.0.5/responsive_classic and had no issues regarding the low-order fee's addition to the order (verified that it's included in the order-confirmation email, too).

I've never used a "Minimum Order Fee", so I can't comment on its operation. I suppose the next step is to see what differences are seen between the bootstrap templates versions of the OPC template files (as-shipped in the /template_default subdirectory).

Question. I have been using this for sites instead of FEC. Problem is that I create a start template and thus it's already installed and customized. When I port over the live site's info the added SQL installation pieces are lost. It doesn't recheck even if I remove the admin installation.

Can you provide a means to install the SQL changes after installation?

Quote:

---

Originally Posted by mprough

Question. I have been using this for sites instead of FEC. Problem is that I create a start template and thus it's already installed and customized. When I port over the live site's info the added SQL installation pieces are lost. It doesn't recheck even if I remove the admin installation.

Can you provide a means to install the SQL changes after installation?

---

I don't understand. If the live site doesn't currently have OPC installed, then the admin-side processing will auto-create those configuration settings.

If you're porting from a test- to live-site, I suggest taking a snapshot of the test-site's OPC settings and updating those on the live site.

It is installed. But when I bring over the updated tables from the live site they do not contain all the database changes from OPC and it does not reinstall them.

@mprough, I still don't understand. Which tables is it that you are "bringing over" from the live site and which OPC database changes are missing?

OPC doesn't perform its database update process if it doesn't see a change in its version.

So you create a dev site for an upgrade. Build it, make sure everything works... then when it's done, you have to upgrade the live site's database to catch up the orders, customers etc.

But the tables created by OPC are then lost and the installer doesn't re-create them, then people cannot check out for example.

... and how do you go about that upgrading of the live site's database? I ask because what you said still doesn't make sense to me.

Was OPC previously installed on the live site? If so, what version? What version of OPC is installed on the upgrade site?

There are no tables, per se, created by OPC's installation script ... just additions to the database's configuration, customers and address_book tables.

Another one, sorry to double you up... It's a great mod. I am migrating a great deal of site from FEC, many of them have guest checkout only. I am trying to include the post for guest from the shopping cart page checkout button, so they go directly to checkout as a guest. I cannot redirect them because the checkout type is un-chosen, so I have to post the guest checkout selection.

So even if I bring in

Code:

---

zen_draw_hidden_field('guest_checkout', 1)

---

I am still directed to the login page. I have tried a bunch of things and I am certainly missing something, but no idea what. Any ideas?

Quote:

---

Originally Posted by lat9

... and how do you go about that upgrading of the live site's database? I ask because what you said still doesn't make sense to me.

Was OPC previously installed on the live site? If so, what version? What version of OPC is installed on the upgrade site?

There are no tables, per se, created by OPC's installation script ... just additions to the database's configuration, customers and address_book tables.

---

The live site's database is upgraded to zc_install and then I bring over all of the customer, order and related tables to "refresh" the dev site's data. Then it's just a matter of moving the live (in maintenance mode) site's files out and the new files in. Right, I need to then add the changes for customers and address_book tables.

@mprough, you can have OPC re-generate those customers and address-book records by cutting and pasting the following into the store's Tools->Install SQL Patches:

Code:

---

DELETE FROM configuration WHERE configuration_key IN ('CHECKOUT_ONE_GUEST_CUSTOMER_ID', 'CHECKOUT_ONE_GUEST_BILLTO_ADDRESS_BOOK_ID', 'CHECKOUT_ONE_GUEST_SENDTO_ADDRESS_BOOK_ID');

---

That will cause the OPC auto-installer to create those customer/address-book records on the next admin login or screen refresh.

Quote:

---

Originally Posted by lat9

@mprough, you can have OPC re-generate those customers and address-book records by cutting and pasting the following into the store's Tools->Install SQL Patches:

Code:

---

DELETE FROM configuration WHERE configuration_key IN ('CHECKOUT_ONE_GUEST_CUSTOMER_ID', 'CHECKOUT_ONE_GUEST_BILLTO_ADDRESS_BOOK_ID', 'CHECKOUT_ONE_GUEST_SENDTO_ADDRESS_BOOK_ID');

---

That will cause the OPC auto-installer to create those customer/address-book records on the next admin login or screen refresh.

---

Thank you very much

Quote:

---

Originally Posted by mprough

Another one, sorry to double you up... It's a great mod. I am migrating a great deal of site from FEC, many of them have guest checkout only. I am trying to include the post for guest from the shopping cart page checkout button, so they go directly to checkout as a guest. I cannot redirect them because the checkout type is un-chosen, so I have to post the guest checkout selection.

So even if I bring in

Code:

---

zen_draw_hidden_field('guest_checkout', 1)

---

I am still directed to the login page. I have tried a bunch of things and I am certainly missing something, but no idea what. Any ideas?

---

So I figured this out.
V1.5.5F

In tpl_shopping_cart_default.php
find

Code:

---

      <!-- Finished loop through all products /-->
      </table>

<div id="cartSubTotal"><?php echo SUB_TITLE_SUB_TOTAL; ?> <?php echo $cartShowTotal; ?></div>

---

And make it

Code:

---

      <!-- Finished loop through all products /-->
      </table>
</form>
<div id="cartSubTotal"><?php echo SUB_TITLE_SUB_TOTAL; ?> <?php echo $cartShowTotal; ?></div>

---

then find:

Code:

---

<!--bof shopping cart buttons-->
<div class="buttonRow forward"><?php echo '<a href="' . zen_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL') . '">' . zen_image_button(BUTTON_IMAGE_CHECKOUT, BUTTON_CHECKOUT_ALT) . '</a>'; ?></div>
<div class="buttonRow back"><?php echo zen_back_link() . zen_image_button(BUTTON_IMAGE_CONTINUE_SHOPPING, BUTTON_CONTINUE_SHOPPING_ALT) . '</a>'; ?></div>

---

and make it:

Code:

---

<!--bof shopping cart buttons-->
<?php echo zen_back_link() . zen_image_button(BUTTON_IMAGE_CONTINUE_SHOPPING, BUTTON_CONTINUE_SHOPPING_ALT) . '</a>'; ?><?php echo zen_draw_form('guest', zen_href_link(FILENAME_CHECKOUT_ONE, '', 'SSL'), 'post') . zen_draw_hidden_field('guest_checkout', 1); ?>
<div class="buttonRow back"><?php echo zen_back_link() . zen_image_button(BUTTON_IMAGE_CONTINUE_SHOPPING, BUTTON_CONTINUE_SHOPPING_ALT) . '</a>'; ?></div>
</form>

---

Then a few lines down (146ish)
find

Code:

---

</form>

---

and remove it.

This change makes people always be a guest and continue right in to checkout from the shopping cart page.

My testing so far is minimal, but if I find any issues I'll report here.

~Melanie

Hi Cindy - after checking out with OPC on the checkout success page SITE/index.php?main_page=checkout_success I am seeing the following;
Checkout Success Sample Text ...

HTML Code:

---

Checkout Success Sample Text ...

A few words about the approximate shipping time or your processing policy for guest-checkout would be put here.

This section of text is from the Define Pages Editor located under Tools in the Admin.
You can view the status of this order by going to the Order Status page and supplying this order number and your email address.
Please direct any questions you have to customer service.

---

in admin/tools/define pages editor/checkout success ... I inserted customized text when the site was built but that text is not showing - have I missed a file merge or something?

cheers, Mike

PHP 7.2
ZC verion 156a "classic template"
Up and running with no issues.

How do you disable the display of the header on the "Check Out" Page?
NOTE:
I was able to successfully do this for the "Login" page.

I tried putting a "checkout_one" directory with tpl_header.php un-commenting this code in it per the below instructions.

Code:

---

$flag_disable_header = true;

---

The page displays but when I "submit" the order or try to change an address nothing happens.
All other links on the page respond.

NOTE:
I was able to successfully do this for the "Login" page.

* Common Template - tpl_header.php
*
* this file can be copied to /templates/your_template_dir/pagename<br />
* example: to override the privacy page<br />
* make a directory /templates/my_template/privacy<br />
* copy /templates/templates_defaults/common/tpl_footer.php to /templates/my_template/privacy/tpl_header.php<br />
* to override the global settings and turn off the footer un-comment the following line:<br />
? * <br /> */
$flag_disable_header = true;
/*
* @package templateSystem
* @copyright Copyright 2003-2016 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version $Id: Author: DrByte Sat Oct 17 22:01:06 2015 -0400 Modified in v1.5.5 $
Yada Yada...

Quote:

---

Originally Posted by shags38

Hi Cindy - after checking out with OPC on the checkout success page SITE/index.php?main_page=checkout_success I am seeing the following;
Checkout Success Sample Text ...

HTML Code:

---

Checkout Success Sample Text ...

A few words about the approximate shipping time or your processing policy for guest-checkout would be put here.

This section of text is from the Define Pages Editor located under Tools in the Admin.
You can view the status of this order by going to the Order Status page and supplying this order number and your email address.
Please direct any questions you have to customer service.

---

in admin/tools/define pages editor/checkout success ... I inserted customized text when the site was built but that text is not showing - have I missed a file merge or something?

cheers, Mike

---

Mike, you'll need to provide content for /includes/languages/english/html_includes/define_checkout_success_guest.php.

Quote:

---

Originally Posted by linuxguy2

PHP 7.2
ZC verion 156a "classic template"
Up and running with no issues.

How do you disable the display of the header on the "Check Out" Page?
NOTE:
I was able to successfully do this for the "Login" page.

I tried putting a "checkout_one" directory with tpl_header.php un-commenting this code in it per the below instructions.

Code:

---

$flag_disable_header = true;

---

The page displays but when I "submit" the order or try to change an address nothing happens.
All other links on the page respond.

NOTE:
I was able to successfully do this for the "Login" page.

* Common Template - tpl_header.php
*
* this file can be copied to /templates/your_template_dir/pagename<br />
* example: to override the privacy page<br />
* make a directory /templates/my_template/privacy<br />
* copy /templates/templates_defaults/common/tpl_footer.php to /templates/my_template/privacy/tpl_header.php<br />
* to override the global settings and turn off the footer un-comment the following line:<br />
? * <br /> */
$flag_disable_header = true;
/*
* @package templateSystem
* @copyright Copyright 2003-2016 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version $Id: Author: DrByte Sat Oct 17 22:01:06 2015 -0400 Modified in v1.5.5 $
Yada Yada...

---

I was able to disable the header on the checkout_one page by adding the file /includes/modules/pages/checkout_one/header_php_no_header.php containing

Code:

---

<?php
$flag_disable_header = true;

---

To also disable the header on the checkout_one_confirmation page, just copy that file to the /includes/modules/pages/checkout_one_confirmation directory.

Quote:

---

Originally Posted by lat9

I was able to disable the header on the checkout_one page by adding the file /includes/modules/pages/checkout_one/header_php_no_header.php containing

Code:

---

<?php
$flag_disable_header = true;

---

To also disable the header on the checkout_one_confirmation page, just copy that file to the /includes/modules/pages/checkout_one_confirmation directory.

---

VERY GOOD!!! :clap:
If that is documented someplace I could not find it...

While we're at it is there a way to get Zen cart to add the hyphens when entering phone numbers with an iPhone or iPad telephone keypad. (Not the regular keyboard)
( Like when you are registering a new account)

Thank You Very Much!!

I've been trying to add a customer field to tpl_modules_opc_customer_info.php. I chased down all of the instances and added my field, but haven't had any luck storing it in checkout, nor the database.

I am calling the stored value on checkout success with an observer class for another application. I can't even get it stored in the session.

Do you have any idea or documentation for customer fields in guest checkout?

Thanks in advance

Quote:

---

Originally Posted by mprough

I've been trying to add a customer field to tpl_modules_opc_customer_info.php. I chased down all of the instances and added my field, but haven't had any luck storing it in checkout, nor the database.

I am calling the stored value on checkout success with an observer class for another application. I can't even get it stored in the session.

Do you have any idea or documentation for customer fields in guest checkout?

Thanks in advance

---

I suggest reviewing the notifications issued by /includes/classes/OnePageCheckout.php. I believe that there are sufficient call-outs to allow you to add fields without requiring a change to OPC's base files.

If you have some handling that's required that is not covered by the current notifications, I'll be happy to create additional notifications.

I got it working, I'm just passing it in the session because it really doesn't need stored =)
Thank you

@lat9 Wonderful plugin. Thank you for all your time on this.

Question: with guest checkout the customer details require the 'Save Changes' button to be clicked. Might there be a way to avoid that? Maybe it's me, but it took me some time trouble shooting to figure out that was the cause for not being able to complete an order. It's just not a logical part of checkout, to have to save field entries like that, so I'd suspect shoppers will do the same thing.

Quote:

---

Originally Posted by jeking

@lat9 Wonderful plugin. Thank you for all your time on this.

Question: with guest checkout the customer details require the 'Save Changes' button to be clicked. Might there be a way to avoid that? Maybe it's me, but it took me some time trouble shooting to figure out that was the cause for not being able to complete an order. It's just not a logical part of checkout, to have to save field entries like that, so I'd suspect shoppers will do the same thing.

---

@jeking, I'll give your request some consideration. Just noting that the change will be fairly 'intrusive', changing the templates' structure and the AJAX processing as well as OPC's 'core' class.

Issue created on the plugin's GitHub repository for tracking: https://github.com/lat9/one_page_checkout/issues/163

At the moment I am having to use v1.5.5f

In the instructions it says 'css_js_loader' has to be loaded first. However in those instruction it says 'Composer' has to be download and installed before 'css_js_loader' is. What does 'Composer' do?

Quote:

---

Originally Posted by adb34

At the moment I am having to use v1.5.5f

In the instructions it says 'css_js_loader' has to be loaded first. However in those instruction it says 'Composer' has to be download and installed before 'css_js_loader' is. What does 'Composer' do?

---

Are you, perhaps, confusing One-Page Checkout with Fast and Easy Checkout? OPC has never had a requirement for the css_js_loader.

Quote:

---

Originally Posted by mprough

I got it working, I'm just passing it in the session because it really doesn't need stored =)
Thank you

---

What was your solution?
Can you share the code your used?

the reason I ask is I'm having trouble adding the "Company" And extra fields to the Admin email sent when a new customer signs up. (functions_email.php) Couldn't find detailed instructions anyplace.
Otherwise the Additional Customer Fields at Sign Up plugin is working fine.

(Using ZC 1.5.6a "Green Classic template" & running on PHP 7.2)

I did not have this problem with 1.5.1.
Here is the code I used in 1.5.1 but it does not work in 1.5.6a.
Only testing with "Company" right now will add 2 of the Extra fields after I get this resolved.


functions_email.php

Code:

---

Around Line 600
//  function email_collect_extra_info($from, $email_from, $login, $login_email, $login_phone='', $login_fax='', $moreinfo = array()) {
(Changed to)
  function email_collect_extra_info($from, $email_from, $login, $login_email, $login_phone='', $login_fax='', $company='', $extrafield='', $extrafield2='', $street_address='', $suburb='', $city='', $state='', $postcode='', $extrafield4='', $moreinfo = array()) {

Around line 630
 ($login_phone !='' ? '<tr><td class="extra-info-bold">' . OFFICE_LOGIN_PHONE . '</td><td>' . $login_phone . '</td></tr>' : '') .
          /////////////// Added Company Field  //////////////////
          ($company !='' ? '<tr><td class="extra-info-bold">' . OFFICE_COMPANY . '</td><td>' . $company . '</td></tr>' : '') .
 ($login_fax !='' ? '<tr><td class="extra-info-bold">' . OFFICE_LOGIN_FAX . '</td><td>' . $login_fax . '</td></tr>' : '') .

---

Quote:

---

Originally Posted by linuxguy2

What was your solution?
Can you share the code your used?

the reason I ask is I'm having trouble adding the "Company" And extra fields to the Admin email sent when a new customer signs up. (functions_email.php) Couldn't find detailed instructions anyplace.
Otherwise the Additional Customer Fields at Sign Up plugin is working fine.

(Using ZC 1.5.6a "Green Classic template" & running on PHP 7.2)

I did not have this problem with 1.5.1.
Here is the code I used in 1.5.1 but it does not work in 1.5.6a.
Only testing with "Company" right now will add 2 of the Extra fields after I get this resolved.


functions_email.php

Code:

---

Around Line 600
//  function email_collect_extra_info($from, $email_from, $login, $login_email, $login_phone='', $login_fax='', $moreinfo = array()) {
(Changed to)
  function email_collect_extra_info($from, $email_from, $login, $login_email, $login_phone='', $login_fax='', $company='', $extrafield='', $extrafield2='', $street_address='', $suburb='', $city='', $state='', $postcode='', $extrafield4='', $moreinfo = array()) {

Around line 590
 ($login_phone !='' ? '<tr><td class="extra-info-bold">' . OFFICE_LOGIN_PHONE . '</td><td>' . $login_phone . '</td></tr>' : '') .
          /////////////// Added Company Field  //////////////////
          ($company !='' ? '<tr><td class="extra-info-bold">' . OFFICE_COMPANY . '</td><td>' . $company . '</td></tr>' : '') .
 ($login_fax !='' ? '<tr><td class="extra-info-bold">' . OFFICE_LOGIN_FAX . '</td><td>' . $login_fax . '</td></tr>' : '') .

---

---

Problem SOLVED
After many hours of toiling over a smoking keyboard the only logical conclusion was the "extra_info" array wasn't being created.
Hope this helps some other non-coder like myself in the future.

In includes/modules/your_template/create_account.php I hadn't added the necessary code to generate the "extra_info" array

Around line 440
ORIGINAL :

Code:

---

$extra_info=email_collect_extra_info($name,$email_address, $account->fields['customers_firstname'] . ' ' . $account->fields['customers_lastname'], $account->fields['customers_email_address'], $account->fields['customers_telephone'], $account->fields['customers_fax']);

---

MODIFIED:

Code:

---

$extra_info=email_collect_extra_info($name,$email_address, $account->fields['customers_firstname'] . ' ' . $account->fields['customers_lastname'], $account->fields['customers_email_address'], $account->fields['customers_telephone'], $account->fields['customers_fax'], $company, $extrafield, $extrafield2, $street_address, $suburb, $city, $state, $postcode, $extrafield4);

---

Then of course this mod in /includes/functions/email_functions.php around line 590
ORIGINAL

Code:

---

function email_collect_extra_info($from, $email_from, $login, $login_email, $login_phone='', $login_fax='', $moreinfo = array()) {

---

MODIFIED

Code:

---

function email_collect_extra_info($from, $email_from, $login, $login_email, $login_phone='', $login_fax='', $company='', $extrafield='', $extrafield2='', $street_address='', $suburb='', $city='', $state='', $postcode='', $extrafield4='', $moreinfo = array()) {

---

AND modify/add: around line 610

Code:

---

$extra_info['HTML'] = '<table width="100%" class="extra-info">' .
      '<tr><td class="extra-info-bold" colspan="2">' . OFFICE_USE . '</td></tr>' .
      '<tr><td  width="20%" class="extra-info-bold">' . OFFICE_FROM . '</td><td>' . $from . '</td></tr>' .
          //'<tr><td class="extra-info-bold">' . OFFICE_EMAIL. '</td><td>' . $email_from . '</td></tr>' .         
      ($login_email !='' ? '<tr><td class="extra-info-bold">' . OFFICE_LOGIN_EMAIL . '</td><td>' . $login_email . '</td></tr>' : '') .         
      ($login !='' ? '<tr><td class="extra-info-bold">' . OFFICE_LOGIN_NAME . '</td><td>' . $login . '</td></tr>' : '') .
          ($company != '' ? '<tr><td class="extra-info-bold">' . OFFICE_COMPANY . '</td><td>' . $company . '</td></tr>' : '') .
          ($extrafield != '' ? '<tr><td class="extra-info-bold">' . OFFICE_EXTRAFIELD . '</td><td>' . $extrafield . '</td></tr>' : '') .
          ($street_address != '' ? '<tr><td class="extra-info-bold">' . OFFICE_STREET_ADDRESS . '</td><td>' . $street_address . '</td></tr>' : '') .
          ($suburb != '' ? '<tr><td class="extra-info-bold">' . OFFICE_STREET_ADDRESS_LINE2 . '</td><td>' . $suburb . '</td></tr>' : '') .
          ($city != '' ?'<tr><td class="extra-info-bold">' . OFFICE_CITY . '</td><td>' . $city . '</td></tr>' : '') .
          ($state != '' ? '<tr><td class="extra-info-bold">' . OFFICE_STATE . '</td><td>' . $state . '</td></tr>' : '') .
          ($postcode != '' ? '<tr><td class="extra-info-bold">' . OFFICE_POSTCODE . '</td><td>' . $postcode . '</td></tr>' : '') .         
          ($login_phone !='' ? '<tr><td class="extra-info-bold">' . OFFICE_LOGIN_PHONE . '</td><td>' . $login_phone . '</td></tr>' : '') .
      ($login_fax !='' ? '<tr><td class="extra-info-bold">' . OFFICE_LOGIN_FAX . '</td><td>' . $login_fax . '</td></tr>' : '') .
          ($extrafield2 != '' ? '<tr><td  width="20%" class="extra-info-bold">' . OFFICE_EXTRAFIELD2 . '</td><td>' . $extrafield2 . '</td></tr>' : '') .       
          ($extrafield4 != '' ? '<tr><td class="extra-info-bold">' . OFFICE_EXTRAFIELD4 . '</td><td>' . $extrafield4 . '</td></tr>' : '') .
          '<tr><td class="extra-info-bold">' . "&nbsp;" . '</td><td>' . "&nbsp;" . '</td></tr>' .               
          '<tr><td class="extra-info-bold">' . OFFICE_IP_ADDRESS . '</td><td>' . $_SESSION['customers_ip_address'] . ' - ' . $_SERVER['REMOTE_ADDR'] . '</td></tr>' .         
      '<tr><td class="extra-info-bold">' . OFFICE_HOST_ADDRESS . '</td><td>' . $email_host_address . '</td></tr>' .
      '<tr><td class="extra-info-bold">' . OFFICE_DATE_TIME . '</td><td>' . date('D M j Y G:i:s T') . '</td></tr>';

---

Quote:

---

Originally Posted by lat9

Are you, perhaps, confusing One-Page Checkout with Fast and Easy Checkout? OPC has never had a requirement for the css_js_loader.

---

Oh??????? I will have to get back on that one. Sorry if I have got it wrong. My bad

The order.php has issues, when you click "Checkout" from the Shopping Cart page or refresh the checkout page it throws errors.
I have tested under several different conditions but my latest testing was a out-of-the-box install of 1.5.6a on PHP 7.2 with the default green classic template.
Added a couple products.
Payment module was Money Order
location was the default Florida state.
OPC debug set to FULL

Note: OPC order.php needs updating for 1.5.6a or more explanation as there are major differences from OPC order.php.
As far as I can tell all the files except order.php are very much the same as 1.5.6a

I tested with the following:
OPC order.php
Original order.php
MERGED order.php
All three tests post very similar PHP warnings.
Also note even though I've selected the green classic template in a couple cases it's looking in the responsive_classic template

myDEBUG-20190226-180718-210765-log

Code:

---

[26-Feb-2019 18:07:18 UTC] Request URI: /156a/index.php?main_page=checkout_one, IP address: 76.182.229.147
#1  require(/home/pc/public_html/156a/includes/modules/pages/checkout_one/header_php.php) called at [/home/pc/public_html/156a/index.php:36]
--> PHP Warning: count(): Parameter must be an array or an object that implements Countable in /home/pc/public_html/156a/includes/modules/pages/checkout_one/header_php.php on line 321.

[26-Feb-2019 18:07:18 UTC] Request URI: /156a/index.php?main_page=checkout_one, IP address: 76.182.229.147
#1  require(/home/pc/public_html/156a/includes/templates/template_default/templates/tpl_modules_opc_credit_selections.php) called at [/home/pc/public_html/156a/includes/templates/template_default/templates/tpl_checkout_one_default.php:67]
#2  require(/home/pc/public_html/156a/includes/templates/template_default/templates/tpl_checkout_one_default.php) called at [/home/pc/public_html/156a/includes/templates/responsive_classic/common/tpl_main_page.php:171]
#3  require(/home/pc/public_html/156a/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/home/pc/public_html/156a/index.php:97]
--> PHP Warning: Invalid argument supplied for foreach() in /home/pc/public_html/156a/includes/templates/template_default/templates/tpl_modules_opc_credit_selections.php on line 44.

---

pc_com.php.error-log

Code:

---

[26-Feb-2019 18:07:18 UTC] PHP Notice:  Undefined index:  in /home/pc/public_html/156a/includes/classes/order.php on line 354
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Trying to get property 'title' of non-object in /home/pc/public_html/156a/includes/classes/order.php on line 354
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Undefined index:  in /home/pc/public_html/156a/includes/classes/order.php on line 355
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Trying to get property 'code' of non-object in /home/pc/public_html/156a/includes/classes/order.php on line 355
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Undefined variable: coupon_code in /home/pc/public_html/156a/includes/classes/order.php on line 356
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Trying to get property 'fields' of non-object in /home/pc/public_html/156a/includes/classes/order.php on line 356
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Undefined index: shipping in /home/pc/public_html/156a/includes/classes/order.php on line 363
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Constant FREE_SHIPPING_TITLE already defined in /home/pc/public_html/156a/includes/languages/english/modules/order_total/ot_shipping.php on line 26
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Constant FREE_SHIPPING_DESCRIPTION already defined in /home/pc/public_html/156a/includes/languages/english/modules/order_total/ot_shipping.php on line 27
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Constant MODULE_ORDER_TOTAL_COUPON_HEADER already defined in /home/pc/public_html/156a/includes/languages/english/modules/order_total/ot_coupon.php on line 14
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Constant SHIPPING_NOT_INCLUDED already defined in /home/pc/public_html/156a/includes/languages/english/modules/order_total/ot_gv.php on line 13
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Constant TAX_NOT_INCLUDED already defined in /home/pc/public_html/156a/includes/languages/english/modules/order_total/ot_gv.php on line 14
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Undefined index: coupon_is_valid_for_sales in /home/pc/public_html/156a/includes/functions/functions_gvcoupons.php on line 113
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Undefined index: id in /home/pc/public_html/156a/includes/templates/template_default/templates/tpl_modules_opc_credit_selections.php on line 20
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Undefined index: id in /home/pc/public_html/156a/includes/templates/template_default/templates/tpl_modules_opc_credit_selections.php on line 43
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Undefined index: fields in /home/pc/public_html/156a/includes/templates/template_default/templates/tpl_modules_opc_credit_selections.php on line 44
[26-Feb-2019 18:07:18 UTC] PHP Notice:  Undefined index: coupon_is_valid_for_sales in /home/pc/public_html/156a/includes/functions/functions_gvcoupons.php on line 113

---

Thank You for you time

The single change in the as-distributed /includes/classes/order.php is already included in zc156+. Just restore that file to its Zen Cart "base" version.

Is "Money Order" one of the payment methods allowed for guest-checkout?

Quote:

---

Originally Posted by lat9

The single change in the as-distributed /includes/classes/order.php is already included in zc156+. Just restore that file to its Zen Cart "base" version.


Is "Money Order" one of the payment methods allowed for guest-checkout?

---

Guest checkout is disabled.
On the "Confirm Order" page "Check/Money Order" and Free Order are listed under the Payment section. Those are the default in the admin modules payment selection page.
I am not using any CC processing selections.

On the Order Total Modules page everything is enabled except the ot_cod_fee

Let me add that on my production build I will be using the PO_Number plugin.
I will never be using the guest-checkout function.
NOTE: I get these same errors on my production build where I am using the PO_Number mod and it's my only selection.

Quote:

---

Originally Posted by linuxguy2

Guest checkout is disabled.
On the "Confirm Order" page "Check/Money Order" and Free Order are listed under the Payment section. Those are the default in the admin modules payment selection page.
I am not using any CC processing selections.

On the Order Total Modules page everything is enabled except the ot_cod_fee

Let me add that on my production build I will be using the PO_Number plugin.
I will never be using the guest-checkout function.
NOTE: I get these same errors on my production build where I am using the PO_Number mod and it's my only selection.

---

If I add a cc I get the same error

Did you revert to the as-shipped zc156 /includes/classes/order.php?

Just did a test install of OPC 2.0.5 on zc156a.

I'll note that the majority of the core-file overwrites required for zc155 are no longer required as the notifications are now "baked into" the base Zen Cart code. The two exceptions (on cursory inspection) are the changes required to /includes/modules/pages/login/header_php.php and to /includes/modules/order_total/ot_coupon.php; the remaining core files from the OPC distribution should not be copied for a zc156 install.

I've corrected (for v2.0.6) the issues identified by @linuxguy2 in post #1055 on OPC's GitHub repository and will be reworking the distribution layout and/or installation instructions for Zen Cart 1.5.6.

Quote:

---

Originally Posted by lat9

Just did a test install of OPC 2.0.5 on zc156a.

I'll note that the majority of the core-file overwrites required for zc155 are no longer required as the notifications are now "baked into" the base Zen Cart code. The two exceptions (on cursory inspection) are the changes required to /includes/modules/pages/login/header_php.php and to /includes/modules/order_total/ot_coupon.php; the remaining core files from the OPC distribution should not be copied for a zc156 install.

I've corrected (for v2.0.6) the issues identified by @linuxguy2 in post #1055 on OPC's GitHub repository and will be reworking the distribution layout and/or installation instructions for Zen Cart 1.5.6.

---

I'll get the changes from github and test.
Thank You very much for your time and expertise!
You Guy's ROCK!

Quote:

---

Originally Posted by linuxguy2

I'll get the changes from github and test.
Thank You very much for your time and expertise!
You Guy's ROCK!

---

Tested with "Guest Checkout" FALSE and tried several different settings.
Used the base order.php file
The one in the plugin caused problems.

Set Payment to "Money Order" and Shipping to "Flat".
Then I had to have "Free Charger" and "Store Pickup" enabled before I did not get the below notices.

Is there another way to disable the "free" stuff in Admin because when I disabled them in the (Admin Modules) Payment and Shipping I got these errors.

Disabled Free Charger error

Code:

---

[27-Feb-2019 21:22:25 UTC] PHP Notice:  Undefined index: configuration_value in /home/pc/public_html/156a/includes/functions/functions_lookups.php on line 558

---

Disabled Store Pickup error

Code:

---

[27-Feb-2019 21:22:25 UTC] PHP Notice:  Undefined index: tax in /home/pc/public_html/156a/includes/templates/template_default/templates/tpl_modules_checkout_one_shipping.php on line 34

---

Also under certain settings these defines in "checkout_one_extra_definitions.php" show a warning as already defined in another place/file

Code:

---

define('FREE_SHIPPING_TITLE', 'Free Shipping');
define('FREE_SHIPPING_DESCRIPTION', 'Free shipping for orders over %s');

---

If I use the order.php from the plugin I get these errors

Code:

---

[27-Feb-2019 22:36:38 UTC] PHP Notice:  Undefined index:  in /home/pc/public_html/156a/includes/classes/order.php on line 354
[27-Feb-2019 22:36:38 UTC] PHP Notice:  Trying to get property 'title' of non-object in /home/pc/public_html/156a/includes/classes/order.php on line 354
[27-Feb-2019 22:36:38 UTC] PHP Notice:  Undefined index:  in /home/pc/public_html/156a/includes/classes/order.php on line 355
[27-Feb-2019 22:36:38 UTC] PHP Notice:  Trying to get property 'code' of non-object in /home/pc/public_html/156a/includes/classes/order.php on line 355
[27-Feb-2019 22:36:38 UTC] PHP Notice:  Undefined variable: coupon_code in /home/pc/public_html/156a/includes/classes/order.php on line 356
[27-Feb-2019 22:36:38 UTC] PHP Notice:  Trying to get property 'fields' of non-object in /home/pc/public_html/156a/includes/classes/order.php on line 356
[27-Feb-2019 22:36:38 UTC] PHP Notice:  Undefined index: shipping in /home/pc/public_html/156a/includes/classes/order.php on line 363

---

Thanks,

@linuxguy2, I'm now lost as to what you're trying to do. Other than those notices and warnings (which I'll investigate further), is the zc156+OPC not processing the checkout for you?

As mentioned in post #1060, the version of the order.php class currently distributed by OPC should not be used for zc156+ installations -- use the version contained in the Zen Cart distribution instead.

Quote:

---

Originally Posted by lat9

@linuxguy2, I'm now lost as to what you're trying to do. Other than those notices and warnings (which I'll investigate further), is the zc156+OPC not processing the checkout for you?

As mentioned in post #1060, the version of the order.php class currently distributed by OPC should not be used for zc156+ installations -- use the version contained in the Zen Cart distribution instead.

---

Yes, I can process orders thru checkout!
Appologies if my message was confusing.
I was trying to provide additional information that one would get that last block of errors if they used the OPC plugin order.php.

On the test site I can complete the entire customer experience with Payment set to "moneyorder" and Shipping set to "flat".
BUT I have to have "freecharger" and "storepickup" enabled or I get the below notices.

Code:

---

[27-Feb-2019 21:22:25 UTC] PHP Notice:  Undefined index: configuration_value in /home/pc/public_html/156a/includes/functions/functions_lookups.php on line 558
[27-Feb-2019 21:22:25 UTC] PHP Notice:  Undefined index: tax in /home/pc/public_html/156a/includes/templates/template_default/templates/tpl_modules_checkout_one_shipping.php on line 34

---

ADDITIONALLY
I have applied your OPC updates to my production site on which I am using Payment Module "purchaseorder" (the PO_Number plugin) and all's well as long as I also enable "freecharger"
Without also enabling freecharger I am getting this notice.

Code:

---

[27-Feb-2019 21:22:25 UTC] PHP Notice:  Undefined index: configuration_value in /home/pc/public_html/156a/includes/functions/functions_lookups.php on line 558

---

Thank You for your time!

Thanks for the clarification, @linuxguy2, I'll attempt to get those warnings and notices reproduced and corrected.

Quote:

---

Originally Posted by linuxguy2

Tested with "Guest Checkout" FALSE and tried several different settings.
Used the base order.php file
The one in the plugin caused problems.

Set Payment to "Money Order" and Shipping to "Flat".
Then I had to have "Free Charger" and "Store Pickup" enabled before I did not get the below notices.

Is there another way to disable the "free" stuff in Admin because when I disabled them in the (Admin Modules) Payment and Shipping I got these errors.

Disabled Free Charger error

Code:

---

[27-Feb-2019 21:22:25 UTC] PHP Notice:  Undefined index: configuration_value in /home/pc/public_html/156a/includes/functions/functions_lookups.php on line 558

---

Disabled Store Pickup error

Code:

---

[27-Feb-2019 21:22:25 UTC] PHP Notice:  Undefined index: tax in /home/pc/public_html/156a/includes/templates/template_default/templates/tpl_modules_checkout_one_shipping.php on line 34

---

Also under certain settings these defines in "checkout_one_extra_definitions.php" show a warning as already defined in another place/file

Code:

---

define('FREE_SHIPPING_TITLE', 'Free Shipping');
define('FREE_SHIPPING_DESCRIPTION', 'Free shipping for orders over %s');

---

...

Thanks,

---

The log

Code:

---

[27-Feb-2019 21:22:25 UTC] PHP Notice:  Undefined index:  configuration_value in  /home/pc/public_html/156a/includes/functions/functions_lookups.php on  line 558

---

is coming from /includes/modules/payment.php in the Zen Cart base when "Free Charger" is disabled. I'll be opening a zencart GitHub issue, since I'm unclear as to the expected return values from the zen_get_configuration_key_value function, as there are 20 uses of that function within the Zen Cart base code.

The issue is that the payment-class is checking to see that MODULE_PAYMENT_FREECHARGER_STATUS is present in the database and, when the payment-method is not installed, it's not.

Noting that I've opened a Zen Cart GitHub issue (https://github.com/zencart/zencart/issues/2184) to track the change(s) required to correct the above scenario.

Quote:

---

Originally Posted by linuxguy2

... On the test site I can complete the entire customer experience with Payment set to "moneyorder" and Shipping set to "flat".
BUT I have to have "freecharger" and "storepickup" enabled or I get the below notices.

Code:

---

[27-Feb-2019 21:22:25 UTC] PHP Notice:  Undefined index: configuration_value in /home/pc/public_html/156a/includes/functions/functions_lookups.php on line 558
[27-Feb-2019 21:22:25 UTC] PHP Notice:  Undefined index: tax in /home/pc/public_html/156a/includes/templates/template_default/templates/tpl_modules_checkout_one_shipping.php on line 34

---

...

---

@linuxguy2, could you provide a bit more information regarding how you disabled storepickup? I've tried removing it as well as disabling it, but am unable to reproduce that second PHP Notice logged.

Quote:

---

Originally Posted by lat9

@linuxguy2, could you provide a bit more information regarding how you disabled storepickup? I've tried removing it as well as disabling it, but am unable to reproduce that second PHP Notice logged.

---

I just install/uninstalled storepickup in the "Modules Menu"
Same with freecharger

That was an out-of-the-box install test site with the latest OPC installed, no option changes except for the mentioned (Module settings)in the admin.
I'll have to go back and reproduce that.
It may be tomorrow before I get back to it.

My configuration settings:

Code:

---

One-Page Checkout Settings
Title        Value        Action
Version/Release Date        2.0.5 (2018-12-23)       
Enable One-Page Checkout?        true       
Enable: Customer List               
Update Shipping AJAX Time-out        5000       
Payment-Block Action on Shipping Change        no-update       
Enable Shipping=Billing?        true       
Payment Methods Requiring Confirmation        eway_rapid,stripepay,gps       
Load Minified Script Files?        false       
Order Status: Slamming Control        3       
Login-Page Layout        L;P,G,C;B       
Enable Guest Checkout?        false       
Guest Checkout: Require Email Confirmation?        false       
Guest Checkout: Pages Allowed Post-Checkout        download       
Guest Checkout: Disallowed Pages        account, account_edit, account_history, account_history_info, account_newsletters, account_notifications, account_password, address_book, address_book_process, create_account_success, gv_redeem, gv_send, password_forgotten, product_reviews_write, unsubscribe
Guest Checkout: Disallowed Credit Class Order-Totals        ot_gv       
Guest Checkout: Disallowed Payment Methods        moneyorder, cod       
Enable Account Registration?        false

---

NOTE (Different build)
No storepickup issues on my soon to be production build on which I have multiple plugins installed.
However If I disable freecharger I get a notice.

Upps...More issues:

When on the checkout page clicking the "Save Changes" button under any circumstances generates one of these errors for every entry in the address form.

Code:

---

[03-Mar-2019 03:53:05 UTC] PHP Notice:  Undefined index: countries_iso_code_2 in /home/pcsnnets/public_html/156a/includes/classes/order.php on line 451
[03-Mar-2019 03:53:05 UTC] PHP Notice:  Undefined index: countries_iso_code_3 in /home/pcsnnets/public_html/156a/includes/classes/order.php on line 451
[03-Mar-2019 03:53:05 UTC] PHP Notice:  Undefined index: entry_country_id in /home/pcsnnets/public_html/156a/includes/classes/order.php on line 452
[03-Mar-2019 03:53:05 UTC] PHP Notice:  Undefined index: address_format_id in /home/pcsnnets/public_html/156a/includes/classes/order.php on line 453

---

Quote:

---

Originally Posted by linuxguy2

Upps...More issues:

When on the checkout page clicking the "Save Changes" button under any circumstances generates one of these errors for every entry in the address form.

Code:

---

[03-Mar-2019 03:53:05 UTC] PHP Notice:  Undefined index: countries_iso_code_2 in /home/pcsnnets/public_html/156a/includes/classes/order.php on line 451
[03-Mar-2019 03:53:05 UTC] PHP Notice:  Undefined index: countries_iso_code_3 in /home/pcsnnets/public_html/156a/includes/classes/order.php on line 451
[03-Mar-2019 03:53:05 UTC] PHP Notice:  Undefined index: entry_country_id in /home/pcsnnets/public_html/156a/includes/classes/order.php on line 452
[03-Mar-2019 03:53:05 UTC] PHP Notice:  Undefined index: address_format_id in /home/pcsnnets/public_html/156a/includes/classes/order.php on line 453

---

---

Phew, that one took a bit of investigation! Corrected via this (https://github.com/lat9/one_page_checkout/issues/169) GitHub issue.

The problem was that when neither Guest Checkout nor Registered Accounts were enabled, the plugin's observer no longer monitored the address-related notifications. When a customer changed their address to a temporary one, the temporary address was not being filled into the order's billing and/or shipping blocks.

Quote:

---

Originally Posted by lat9

Noting that I've opened a Zen Cart GitHub issue (https://github.com/zencart/zencart/issues/2184) to track the change(s) required to correct the above scenario.

---

I've created a GitHub PR (Pull Request), providing a correction for those issues.

Quote:

---

Originally Posted by lat9

I've created a GitHub PR (Pull Request), providing a correction for those issues.

---

Thanks for the update.

Have done lots of testing today while building out my production site and nothing new has popped op.
I have not tested with any other types of payment or shipping.

Thank You for your time and expertise!!!!

Hi, I have what seems to be a minor bug to report. I'm running OPC 2.0.5 and ZC 1.5.6a, with the latter's shipping module set to Zone Rates. In guest checkout, when I enter a billing address in one country, then uncheck the shipping=billing box and enter a shipping address in another country, the shipping charge quite rightly changes to the amount for the second country. BUT, if I then change my mind and re-click the shipping=billing box, the shipping charge remains stuck at the amount for the second country. (Note that this glitch does NOT happen if I log into an account instead of doing guest checkout.) Anyway, I realize the situation is one that will almost never arise in real life, but it came up while I was putting the plugin through its paces, so I thought you would want to be aware of it. In any event, thank you for designing a very useful product!

Quote:

---

Originally Posted by archelaus

Hi, I have what seems to be a minor bug to report. I'm running OPC 2.0.5 and ZC 1.5.6a, with the latter's shipping module set to Zone Rates. In guest checkout, when I enter a billing address in one country, then uncheck the shipping=billing box and enter a shipping address in another country, the shipping charge quite rightly changes to the amount for the second country. BUT, if I then change my mind and re-click the shipping=billing box, the shipping charge remains stuck at the amount for the second country. (Note that this glitch does NOT happen if I log into an account instead of doing guest checkout.) Anyway, I realize the situation is one that will almost never arise in real life, but it came up while I was putting the plugin through its paces, so I thought you would want to be aware of it. In any event, thank you for designing a very useful product!

---

archelaus
On the OPC admin page if you have "Enable One-Page Checkout Debug? Full" you should be getting PHP notices/errors in the Logs. (Two places System root / and your cart root.)
You may already be aware of this but OPC is being update. You might review some of the latest unreleased fixes for 1.5.6a noted here.
https://github.com/lat9/one_page_checkout

Quote:

---

Originally Posted by archelaus

Hi, I have what seems to be a minor bug to report. I'm running OPC 2.0.5 and ZC 1.5.6a, with the latter's shipping module set to Zone Rates. In guest checkout, when I enter a billing address in one country, then uncheck the shipping=billing box and enter a shipping address in another country, the shipping charge quite rightly changes to the amount for the second country. BUT, if I then change my mind and re-click the shipping=billing box, the shipping charge remains stuck at the amount for the second country. (Note that this glitch does NOT happen if I log into an account instead of doing guest checkout.) Anyway, I realize the situation is one that will almost never arise in real life, but it came up while I was putting the plugin through its paces, so I thought you would want to be aware of it. In any event, thank you for designing a very useful product!

---

Thanks for the report! I've noted the issue on OPC's GitHub repository and will investigate later this week.

Quote:

---

Originally Posted by linuxguy2

archelaus
On the OPC admin page if you have "Enable One-Page Checkout Debug? Full" you should be getting PHP notices/errors in the Logs. (Two places System root / and your cart root.)
You may already be aware of this but OPC is being update. You might review some of the latest unreleased fixes for 1.5.6a noted here.
https://github.com/lat9/one_page_checkout

---

The code changes are the easy part!:blush:

The hard part with v2.1.0 for OPC is documenting the process that you'll need to use when updating, as the majority of OPC's core/template file changes are now included in the zc156/zc156a (and to-be-released zc156b) distributions. I'm trying to create an overall set of procedures to be used when updating or performing an initial install for Zen Cart versions prior to zc156b ... it's kind of like "putting Humpty Dumpty back together again"!

Quote:

---

Originally Posted by linuxguy2

archelaus
On the OPC admin page if you have "Enable One-Page Checkout Debug? Full" you should be getting PHP notices/errors in the Logs. (Two places System root / and your cart root.)
You may already be aware of this but OPC is being update. You might review some of the latest unreleased fixes for 1.5.6a noted here.
https://github.com/lat9/one_page_checkout

---

Thanks, linuxguy2!

Quote:

---

Originally Posted by lat9

Thanks for the report! I've noted the issue on OPC's GitHub repository and will investigate later this week.

---

Glad to help. Thanks again!

OPC 2.0.5 and ZC 1.5.6a. I hate to waste people's time with something I should be able to figure out by myself, but I'm stumped. In guest checkout, the customer's billing address is pre-filling with the state/province listed for the store in Configuration>My Store and the zip code listed for the store in Configuration>Shipping/Packaging. I'm okay with it defaulting to USA, but I'd like state and zip code to be blank. I'm not seeing anything in Configuration>One-Page Checkout Settings, and the code in tpl_modules_opc_address_block.php is over my head. Thanks in advance!

Quote:

---

Originally Posted by archelaus

OPC 2.0.5 and ZC 1.5.6a. I hate to waste people's time with something I should be able to figure out by myself, but I'm stumped. In guest checkout, the customer's billing address is pre-filling with the state/province listed for the store in Configuration>My Store and the zip code listed for the store in Configuration>Shipping/Packaging. I'm okay with it defaulting to USA, but I'd like state and zip code to be blank. I'm not seeing anything in Configuration>One-Page Checkout Settings, and the code in tpl_modules_opc_address_block.php is over my head. Thanks in advance!

---

That pre-filling of country/state/postcode was introduced in OPC 2.0.1 to address the issue where some shipping modules (like USPS) don't send back quotes and, to my remembrance, also throw debug-logs if those fields aren't present in the 'order-object' when the shipping-modules are loaded. See this (https://github.com/lat9/one_page_checkout/issues/133) issue for additional information.

If it's important for you to not pre-fill those fields, you could make store-specific changes to the OnePageCheckout.php class-file, backing out the changes provided in the issue referenced above. Just remember, if you choose to, that you'll need to merge those changes into that class-file whenever you update your version of OPC.

Quote:

---

Originally Posted by lat9

That pre-filling of country/state/postcode was introduced in OPC 2.0.1 to address the issue where some shipping modules (like USPS) don't send back quotes and, to my remembrance, also throw debug-logs if those fields aren't present in the 'order-object' when the shipping-modules are loaded. See this (https://github.com/lat9/one_page_checkout/issues/133) issue for additional information.

If it's important for you to not pre-fill those fields, you could make store-specific changes to the OnePageCheckout.php class-file, backing out the changes provided in the issue referenced above. Just remember, if you choose to, that you'll need to merge those changes into that class-file whenever you update your version of OPC.

---

That did the trick! Many thanks. I'm not using any of those shipping modules, and I have relatively few customers in DC (population 700,000), and almost none in my actual zip code, so I really did want to get rid of the pre-fills.

I need help, i am getting "Your order's details have changed. Please review the current values and re-submit." error message.
I am using zencart 1.5.5e . Can some one help me?

Quote:

---

Originally Posted by MrSteeiii

I need help, i am getting "Your order's details have changed. Please review the current values and re-submit." error message.
I am using zencart 1.5.5e . Can some one help me?

---

Sure, but I'll need a little more information:

What version of One-Page Checkout?
What template are you using?
What payment-module was chosen?
What shipping-module was chosen?
What order-total modules are applied to the order (before you click the Submit button)?
Was the order being placed for a customer with an account or was this using the Guest Checkout?

Quote:

---

Originally Posted by lat9

Sure, but I'll need a little more information:

1.What version of One-Page Checkout?
2.What template are you using?
3.What payment-module was chosen?
4.What shipping-module was chosen?
5.What order-total modules are applied to the order (before you click the Submit button)?
6.Was the order being placed for a customer with an account or was this using the Guest Checkout?

---

0.I Changed zencart version to 1.5.6
1.one_page_checkout-2.0.5
2.Template: yourstore
3.Check/Money Order I removed from Guest Disallowed Payment Methods tab for testing purpose.
4.Default (Flat Rate Best Way, Flat Rate Best Way, Store Pickup Walk In.
5.Default
6. I tryed both ways as a guest and as a customer.

I have to figure it out. Thanks for your reply lat9.

Zen Cart 1.5.6a
OPC 2.0.5

When placing an order, I get this error:

[07-Mar-2019 07:41:05 America/Chicago] Request URI: /index.php?main_page=checkout_one, IP address:
#1 require(/home/XXXX/public_html/includes/templates/template_default/templates/tpl_modules_opc_credit_selections.php) called at [/home/XXXX/public_html/includes/templates/template_default/templates/tpl_checkout_one_default.php:67]
#2 require(/home/XXXX/public_html/includes/templates/template_default/templates/tpl_checkout_one_default.php) called at [/home/XXXX/public_html/includes/templates/XXXX/common/tpl_main_page.php:146]
#3 require(/home/XXXX/public_html/includes/templates/XXXX/common/tpl_main_page.php) called at [/home/XXXX/public_html/index.php:97]
--> PHP Warning: Invalid argument supplied for foreach() in /home/XXXX/public_html/includes/templates/template_default/templates/tpl_modules_opc_credit_selections.php on line 44.

If it matters....site was upgraded from 1.5.4. OPC was not installed previously. Using a custom template.

As I keep playing with this excellent plugin, I've come up with a suggestion for a very minor improvement:

If you change line 25 of tpl_modules_opc_address _block.php from

if (count($address_selections) != 0) {

to

if (count($address_selections) > 2) {

customers will see the dropdown list of previously defined addresses only when there's actually more than one address for them to choose from. (It's > 2 rather than > 1 because the "Select from saved addresses" line counts as an address.)

Quote:

---

Originally Posted by MrSteeiii

0.I Changed zencart version to 1.5.6
1.one_page_checkout-2.0.5
2.Template: yourstore
3.Check/Money Order I removed from Guest Disallowed Payment Methods tab for testing purpose.
4.Default (Flat Rate Best Way, Flat Rate Best Way, Store Pickup Walk In.
5.Default
6. I tryed both ways as a guest and as a customer.

I have to figure it out. Thanks for your reply lat9.

---

Per the plugin's readme, the YourStore template is known to be incompatible with One-Page Checkout.

Quote:

---

Originally Posted by archelaus

As I keep playing with this excellent plugin, I've come up with a suggestion for a very minor improvement:

If you change line 25 of tpl_modules_opc_address _block.php from

if (count($address_selections) != 0) {

to

if (count($address_selections) > 2) {

customers will see the dropdown list of previously defined addresses only when there's actually more than one address for them to choose from. (It's > 2 rather than > 1 because the "Select from saved addresses" line counts as an address.)

---

Good catch! I've opened an issue on OPC's GitHub repository to track the change (https://github.com/lat9/one_page_checkout/issues/171).

I'll note, though, that dropdown list should be shown if the customer has more than 1 (not 2) addresses previously recorded.

Quote:

---

Originally Posted by jeking

Zen Cart 1.5.6a
OPC 2.0.5

When placing an order, I get this error:

[07-Mar-2019 07:41:05 America/Chicago] Request URI: /index.php?main_page=checkout_one, IP address:
#1 require(/home/XXXX/public_html/includes/templates/template_default/templates/tpl_modules_opc_credit_selections.php) called at [/home/XXXX/public_html/includes/templates/template_default/templates/tpl_checkout_one_default.php:67]
#2 require(/home/XXXX/public_html/includes/templates/template_default/templates/tpl_checkout_one_default.php) called at [/home/XXXX/public_html/includes/templates/XXXX/common/tpl_main_page.php:146]
#3 require(/home/XXXX/public_html/includes/templates/XXXX/common/tpl_main_page.php) called at [/home/XXXX/public_html/index.php:97]
--> PHP Warning: Invalid argument supplied for foreach() in /home/XXXX/public_html/includes/templates/template_default/templates/tpl_modules_opc_credit_selections.php on line 44.

If it matters....site was upgraded from 1.5.4. OPC was not installed previously. Using a custom template.

---

See this (https://github.com/lat9/one_page_checkout/issues/165) GitHub issue; let me know if that corrects the issue when a store doesn't have ot_gv enabled.

There was a change made for zc156 such that an empty array (instead of false) is being returned in that case, that's what the change for that issue addresses.

Quote:

---

Originally Posted by lat9

See this (https://github.com/lat9/one_page_checkout/issues/165) GitHub issue; let me know if that corrects the issue when a store doesn't have ot_gv enabled.

There was a change made for zc156 such that an empty array (instead of false) is being returned in that case, that's what the change for that issue addresses.

---

Thanks. I've applied the change and will check back to see if the error goes away.

Quote:

---

Originally Posted by lat9

Good catch! I've opened an issue on OPC's GitHub repository to track the change (https://github.com/lat9/one_page_checkout/issues/171).

I'll note, though, that dropdown list should be shown if the customer has more than 1 (not 2) addresses previously recorded.

---

Hmm. When I did it, I had to set it to 2 for it to work. I concluded that it was counting "Select from saved addresses" as an address.

Quote:

---

Originally Posted by archelaus

Hmm. When I did it, I had to set it to 2 for it to work. I concluded that it was counting "Select from saved addresses" as an address.

---

Arggh, you're quite right; let me get that corrected on GitHub.

Quote:

---

Originally Posted by lat9

Per the plugin's readme, the YourStore template is known to be incompatible with One-Page Checkout.

---

Yes I know that, but still I think I can make it work. Yourstore support offered me to install this plugin for alot of money. This template use unique method to show header and I think this is the main think why plugin isn't working properly. With your knowledge I think it's possible to merge those two files. But maybe you know better where is the problem. Thanks

Quote:

---

Originally Posted by MrSteeiii

Yes I know that, but still I think I can make it work. Yourstore support offered me to install this plugin for alot of money. This template use unique method to show header and I think this is the main think why plugin isn't working properly. With your knowledge I think it's possible to merge those two files. But maybe you know better where is the problem. Thanks

---

The YourStore template (and its ThemeForest siblings) gave me quite the headache when I investigated the interoperability a couple of years ago. It's not something that I'm willing to offer as a free service.

Quote:

---

Originally Posted by lat9

The YourStore template (and its ThemeForest siblings) gave me quite the headache when I investigated the interoperability a couple of years ago. It's not something that I'm willing to offer as a free service.

---

I am willing to pay some money for your help. Can you tell me how much this can cost for me?

Quote:

---

Originally Posted by MrSteeiii

I am willing to pay some money for your help. Can you tell me how much this can cost for me?

---

PM (Private Message) sent.

:beta:I've completed the changes for One-Page Checkout, v2.1.0, and have packaged up v2.1.0-beta5 for download from the plugin's GitHub repository. Do not deploy this on a live site!


I'd appreciate any/all beta-testing that the community can provide, especially with respect to the installation/upgrade documentation ... which has changed significantly. Please report any issues found (or suggestions for improvement) as GitHub issues on that repository.

PHP 7.2
ZC 156a
OPC v2.1.0-beta5

I've been testing with this build but I'm only using "PO Number Payment and Flat Rate Shipping" so I'm not covering the corner cases.
The documentation seems to be OK if you read it carefully.

The only issue I have is:
The "Shipping Address" drop list on the checkout page is listing the addresses in the order I entered them NOT in any alphabetical order.

Googled and checked the forums but can't come up with a solution.

Any clues on how to make that sort on Company name would be appreciated.

Thanks

FWIW, I'm up to OPC v2.1.0-beta8.

You'll need to edit (and make a copy of) /includes/classes/OnePageCheckout.php to edit its formatAddressBookDropdown method:

Code:

---

   
    public function formatAddressBookDropdown()
    {
        $select_array = array();
        if (isset($_SESSION['customer_id']) && !$this->isGuestCheckout() && !$this->customerAccountNeedsPrimaryAddress()) {
            // -----
            // Build up address list input to create a customer-specific selection list of
            // pre-existing addresses from which to choose.
            //
            $addresses = $GLOBALS['db']->Execute(
                "SELECT address_book_id
                  FROM " . TABLE_ADDRESS_BOOK . "
                  WHERE customers_id = " . (int)$_SESSION['customer_id'] . "
              ORDER BY address_book_id"
            );
            if (!$addresses->EOF) {
                $select_array[] = array(
                    'id' => 0,
                    'text' => TEXT_SELECT_FROM_SAVED_ADDRESSES
                );
            }
            while (!$addresses->EOF) {
                $select_array[] = array(
                    'id' => $addresses->fields['address_book_id'],
                    'text' => str_replace("\n", ', ', zen_address_label($_SESSION['customer_id'], $addresses->fields['address_book_id']))
                );
                $addresses->MoveNext();
            }
        }
        return $select_array;
    }

---

Note, though, that this class is very 'volatile' as it's the heart of OPC's processing.