Re: Edit Orders v4.1 Released
Quote:
Originally Posted by
magz
What if any Zen Cart error logs exist (/cache/ in 1.5.0 and /logs/ in 1.5.1 - use FTP to look)?
None related to EO
and you know this for sure because????????? After clicking the edit button you SHOULD see SOMETHING in the error logs.. To alleviate any possibility that it's NOT an Edit Orders error, please clear your error logs. Then try again to do what you were doing when you got the issue.. and check the logs again.. I'm pretty sure something will be there.. Please post that error log..
Re: Edit Orders v4.1 Released
Hi DivaVocals - I looked at all logs generated on 4/30 after I re-installed EO, and none mentioned EO. But I did what you said, and here's the error log that got generated after I clicked the edit icon again (in addition to the server error 500 mentioned earlier):
PHP Fatal error: require_once() [<a href='function.require'>function.require</a>]: Failed opening required 'includes/modules/TaxCloud/func.taxcloud.php' (include_path='.:/usr/lib/php5') in /SITE/includes/classes/order.php on line 21
Line 21 in that particular order.php is indeed: require_once DIR_WS_MODULES . 'TaxCloud/func.taxcloud.php';
func.taxcloud.php is present in the location specified above.
I hope it's an easy fix. I'd really like to use your plugin, it sounds very promising...
Thank you!
Magz
Re: Edit Orders v4.1 Released
Quote:
Originally Posted by
magz
Hi DivaVocals - I looked at all logs generated on 4/30 after I re-installed EO, and none mentioned EO. But I did what you said, and here's the error log that got generated after I clicked the edit icon again (in addition to the server error 500 mentioned earlier):
PHP Fatal error: require_once() [<a href='function.require'>function.require</a>]: Failed opening required 'includes/modules/TaxCloud/func.taxcloud.php' (include_path='.:/usr/lib/php5') in /SITE/includes/classes/order.php on line 21
Line 21 in that particular order.php is indeed: require_once DIR_WS_MODULES . 'TaxCloud/func.taxcloud.php';
func.taxcloud.php is present in the location specified above.
I hope it's an easy fix. I'd really like to use your plugin, it sounds very promising...
Thank you!
Magz
The error message wouldn't say "Hey this is an EDIT ORDERS error" persay:laugh:.. it would give you an indication as to where the issue might be coming from. Which is why I questioned you dismissing the error logs as not relevant..
That said.. as you can see this is not an issue cause by Edit Order, but by your Tax Cloud add-on. So you are going to have to troubleshoot what's going on with your Tax Cloud add-on.. You will need to post your issue on the Tax Cloud support thread.. suggest you check your install before posting your question.. are you SURE that there is a file called func.taxcloud.php in your includes/modules/TaxCloud/ folder?? (the SHOP side not the ADMIN side..
Wish I could help, but the issue is NOT with Edit Orders..
Re: Edit Orders v4.1 Released
You have an error with tax cloud in the orders class file. That's what the error message is telling you, it's not finding the required file from the orders class file. And since edit orders also has to do with orders you need to fix one to fix the other since taxes are involved with orders. It could be a case-sensitive error. In php TaxCloud is not the same as taxcloud or Taxcloud. I would check that first and make sure the directory that func.taxcloud.php is located is spelled that way.
Re: Edit Orders v4.1 Released
Quote:
Originally Posted by
magz
Hi DivaVocals - I looked at all logs generated on 4/30 after I re-installed EO, and none mentioned EO. But I did what you said, and here's the error log that got generated after I clicked the edit icon again (in addition to the server error 500 mentioned earlier):
PHP Fatal error: require_once() [<a href='function.require'>function.require</a>]: Failed opening required 'includes/modules/TaxCloud/func.taxcloud.php' (include_path='.:/usr/lib/php5') in /SITE/includes/classes/order.php on line 21
Line 21 in that particular order.php is indeed: require_once DIR_WS_MODULES . 'TaxCloud/func.taxcloud.php';
func.taxcloud.php is present in the location specified above.
I hope it's an easy fix. I'd really like to use your plugin, it sounds very promising...
Thank you!
Magz
Quote:
Originally Posted by
DivaVocals
The error message wouldn't say "Hey this is an EDIT ORDERS error" persay:laugh:.. it would give you an indication as to where the issue might be coming from. Which is why I questioned you dismissing the error logs as not relevant..
That said.. as you can see this is not an issue cause by Edit Order, but by your Tax Cloud add-on. So you are going to have to troubleshoot what's going on with your Tax Cloud add-on.. You will need to post your issue on the Tax Cloud support thread.. suggest you check your install before posting your question.. are you SURE that there is a file called func.taxcloud.php in your includes/modules/TaxCloud/ folder?? (the SHOP side not the ADMIN side..
Wish I could help, but the issue is NOT with Edit Orders..
And I just did a quick check.. Tax Cloud actually has NO FILES in common with Edit Orders.. so something is amiss in one or both of your installations of these modules..
I suggest installing ONE at a time and test test test to ensure one is working before installing the other.. Would suggest rolling back to the state your store was before installing EITHER modules.. (not just do an uninstall I mean restore your store and DB to a state it was BEFORE you installed these modules) Then start by installing Edit Orders.. Make SURE it works before you move on to install Tax Cloud.. Either way the issue is NOT Edit Orders, but something amiss with regards to your Tax Cloud add-on.. You will need to post questions relating to Tax Cloud issues in the support thread for Tax Cloud..
Re: Edit Orders v4.1 Released
Thanks for your pointers, DivaVocals and lankeeyankee. Will research/test/retest/post/etc., and report back IF I find anything relevant to EO in the process...
Thanks for your many contributions as well!
Magz
Re: Edit Orders v4.1 Released
Mystery solved thanks to RCwebdev. It was indeed an issue with TaxCloud code, so for anyone trying to use both TC 1.5.2 and EO 4.1 (with ZC 1.5.1), to fix the error change the following code in YOUR-SITE/includes/classes/order.php (on whatever line # your error log gives you).
Find:
require_once DIR_WS_MODULES . 'TaxCloud/func.taxcloud.php';
and try replacing it with:
require_once(DIR_FS_CATALOG . DIR_WS_MODULES . 'TaxCloud/func.taxcloud.php');
For me this solved the problem - no more server error 500 or error logs mentioned in my previous post, and now I can finally use Edit Orders 4.1!
Re: Edit Orders v4.1 Released
Quote:
Originally Posted by
magz
Mystery solved thanks to
RCwebdev. It was indeed an issue with TaxCloud code, so for anyone trying to use both TC 1.5.2 and EO 4.1 (with ZC 1.5.1), to fix the error change the following code in YOUR-SITE/includes/classes/order.php (on whatever line # your error log gives you).
Find:
require_once DIR_WS_MODULES . 'TaxCloud/func.taxcloud.php';
and try replacing it with:
require_once(DIR_FS_CATALOG . DIR_WS_MODULES . 'TaxCloud/func.taxcloud.php');
For me this solved the problem - no more server error 500 or error logs mentioned in my previous post, and now I can finally use Edit Orders 4.1!
Want to make sure it's clear.. this error has NOTHING to do with Edit Orders.. Edit Orders only helps to uncover an error created by Tax Cloud.. this would be an issue regardless as to whether or not you have Edit Orders installed.. It's purely a Tax Cloud issue..
Re: Edit Orders v4.1 Released
Quote:
Originally Posted by
lhungil
Thank You nannid and Phil Lomas for your feedback. I believe I have now narrowed down the cause.
Can you please try the following fix and let me know if it works in your environments?
- Remove all products from the affected order (or cancel the order). Make sure the Order Total is Zero (the bug should cause this to be true).
- Make the code change listed below.
- Add the products back to your order (or to a new order).
Edit "/admin/includes/functions/extra_functions/edit_orders_functions.php" as follows:
Starting at line 1134 replace:
Code:
// Remove order totals already present in the order
$module_list = explode(';', (str_replace('.php', '', MODULE_ORDER_TOTAL_INSTALLED)));
$order_totals = eo_get_order_total_by_order($oID);
if($order_totals !== null) {
foreach($order_totals as $class => $total) {
$keys = array_keys($module_list, $class);
foreach($keys as $key) {
if($key != 'ot_local_sales_taxes') unset($module_list[$key]);
}
}
}
With the following code:
Code:
// Remove order totals already present in the order
$module_list = explode(';', (str_replace('.php', '', MODULE_ORDER_TOTAL_INSTALLED)));
$order_totals = eo_get_order_total_by_order($oID);
if($order_totals !== null) {
foreach($order_totals as $class => $total) {
if($class == 'ot_local_sales_taxes') continue;
$keys = array_keys($module_list, $class);
foreach($keys as $key) {
unset($module_list[$key]);
}
}
}
Hi lhungil - thank you, this code change did fix the subtotal issue in EO 4.1 for me, as well. However, it seems to be causing another issue with Ty Package Tracker 3.1.3. I posted on TPT thread about this, but have been directed here.
With version 1 of the above code, TPT works great. With version 2, however, after the tracking # is added to an order, the email sent to the customer includes a list of all shippers, even those that are turned off. I only have USPS turned on, and only the USPS tracking # field appears on my Edit Orders page, but here's the list customers get in their emails (the bolded part is the only one that should appear):
====
Your FedEx Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
http://www.fedex.com/Tracking?action...&tracknumbers=
It may take up to 24 hours for the tracking information to appear on the
website.
Your UPS Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
http://wwwapps.ups.com/WebTracking/p...nquiryNumber1=
It may take up to 24 hours for the tracking information to appear on the
website.
Your USPS Tracking ID is 9000000000000000000000
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
https://tools.usps.com/go/TrackConfirmAction!input.action?tLabels=#9000000000000000000000
It may take up to 24 hours for the tracking information to appear on the
website.
Your Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
It may take up to 24 hours for the tracking information to appear on the
website.
Your Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
It may take up to 24 hours for the tracking information to appear on the
website.
====
I noticed your snippet mentions ot_local_sales_taxes - I don't have that module installed, I use TaxCloud instead. No idea if that could be related to the issue, what are your thoughts? Can the snippet be adjusted to work with TaxCloud, or another one added someplace to fix the TPT issue? (I'm not a programmer, wouldn't know where to start.)
Thank you!
Magz
Re: Edit Orders v4.1 Released
Quote:
Originally Posted by
magz
Hi lhungil - thank you, this code change did fix the subtotal issue in EO 4.1 for me, as well. However, it seems to be causing another issue with Ty Package Tracker 3.1.3. I posted on TPT thread about this, but have been directed here.
With version 1 of the above code, TPT works great. With version 2, however, after the tracking # is added to an order, the email sent to the customer includes a list of all shippers, even those that are turned off. I only have USPS turned on, and only the USPS tracking # field appears on my Edit Orders page, but here's the list customers get in their emails (the
bolded part is the only one that
should appear):
====
Your FedEx Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
http://www.fedex.com/Tracking?action...&tracknumbers=
It may take up to 24 hours for the tracking information to appear on the
website.
Your UPS Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
http://wwwapps.ups.com/WebTracking/p...nquiryNumber1=
It may take up to 24 hours for the tracking information to appear on the
website.
Your USPS Tracking ID is 9000000000000000000000
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
https://tools.usps.com/go/TrackConfirmAction!input.action?tLabels=#9000000000000000000000
It may take up to 24 hours for the tracking information to appear on the
website.
Your Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
It may take up to 24 hours for the tracking information to appear on the
website.
Your Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
It may take up to 24 hours for the tracking information to appear on the
website.
====
I noticed your snippet mentions ot_local_sales_taxes - I don't have that module installed, I use TaxCloud instead. No idea if that could be related to the issue, what are your thoughts? Can the snippet be adjusted to work with TaxCloud, or another one added someplace to fix the TPT issue? (I'm not a programmer, wouldn't know where to start.)
Thank you!
Magz
It's not that I don't want to help.. it's that I CAN'T help you with a problem that is not caused by a defect with the Ty Package Tracker code.. I directed you here because the issue you are having is not with the Ty Package Tracker code, but rather with the code you used to modify the Edit Order files which has caused the issue you are reporting.. The Edit Orders code is the cause.. not the Ty Package Tracker code.. This support thread is where you got the code from. lhungil wrote the code and is probably the BEST person to direct you as to how to fix it.. so this is where you must come for the solution..