Edit Orders v4.0 Support Thread

[lhungil]

Thank You nannid and Phil Lomas for your feedback. I believe I have now narrowed down the cause.

Can you please try the following fix and let me know if it works in your environments?

1. Remove all products from the affected order (or cancel the order). Make sure the Order Total is Zero (the bug should cause this to be true).
2. Make the code change listed below.
3. Add the products back to your order (or to a new order).

Edit "/admin/includes/functions/extra_functions/edit_orders_functions.php" as follows:

Starting at line 1134 replace:

	// Remove order totals already present in the order
	$module_list = explode(';', (str_replace('.php', '', MODULE_ORDER_TOTAL_INSTALLED)));
	$order_totals = eo_get_order_total_by_order($oID);
	if($order_totals !== null) {
		foreach($order_totals as $class => $total) {
			$keys = array_keys($module_list, $class);
			foreach($keys as $key) {
				if($key != 'ot_local_sales_taxes') unset($module_list[$key]);
			}
		}
	}

With the following code:

	// Remove order totals already present in the order
	$module_list = explode(';', (str_replace('.php', '', MODULE_ORDER_TOTAL_INSTALLED)));
	$order_totals = eo_get_order_total_by_order($oID);
	if($order_totals !== null) {
		foreach($order_totals as $class => $total) {
			if($class == 'ot_local_sales_taxes') continue;
			$keys = array_keys($module_list, $class);
			foreach($keys as $key) {
				unset($module_list[$key]);
			}
		}
	}

[nannid]

Solved !!!

I applied your suggested modifications and your sw runs correctly.

I tried both with an admin order and with an order produced by the front end.

Many thanks for your fundamental help.

[Phil Lomas]

Hi Lungil

Yes works for me too.

Thanks

Phil

[magz]

Thank You nannid and Phil Lomas for your feedback. I believe I have now narrowed down the cause.

Can you please try the following fix and let me know if it works in your environments?

1. Remove all products from the affected order (or cancel the order). Make sure the Order Total is Zero (the bug should cause this to be true).
2. Make the code change listed below.
3. Add the products back to your order (or to a new order).

Edit "/admin/includes/functions/extra_functions/edit_orders_functions.php" as follows:

Starting at line 1134 replace:

    // Remove order totals already present in the order
    $module_list = explode(';', (str_replace('.php', '', MODULE_ORDER_TOTAL_INSTALLED)));
    $order_totals = eo_get_order_total_by_order($oID);
    if($order_totals !== null) {
        foreach($order_totals as $class => $total) {
            $keys = array_keys($module_list, $class);
            foreach($keys as $key) {
                if($key != 'ot_local_sales_taxes') unset($module_list[$key]);
            }
        }
    }

With the following code:

    // Remove order totals already present in the order
    $module_list = explode(';', (str_replace('.php', '', MODULE_ORDER_TOTAL_INSTALLED)));
    $order_totals = eo_get_order_total_by_order($oID);
    if($order_totals !== null) {
        foreach($order_totals as $class => $total) {
            if($class == 'ot_local_sales_taxes') continue;
            $keys = array_keys($module_list, $class);
            foreach($keys as $key) {
                unset($module_list[$key]);
            }
        }
    }

Hi lhungil - thank you, this code change did fix the subtotal issue in EO 4.1 for me, as well. However, it seems to be causing another issue with Ty Package Tracker 3.1.3. I posted on TPT thread about this, but have been directed here.

With version 1 of the above code, TPT works great. With version 2, however, after the tracking # is added to an order, the email sent to the customer includes a list of all shippers, even those that are turned off. I only have USPS turned on, and only the USPS tracking # field appears on my Edit Orders page, but here's the list customers get in their emails (the bolded part is the only one that should appear):

====
Your FedEx Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
http://www.fedex.com/Tracking?action...&tracknumbers=

It may take up to 24 hours for the tracking information to appear on the
website.

Your UPS Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
http://wwwapps.ups.com/WebTracking/p...nquiryNumber1=

It may take up to 24 hours for the tracking information to appear on the
website.

Your USPS Tracking ID is 9000000000000000000000
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
https://tools.usps.com/go/TrackConfirmAction!input.action?tLabels=#9000000000000000000000

It may take up to 24 hours for the tracking information to appear on the
website.

Your Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.

It may take up to 24 hours for the tracking information to appear on the
website.

Your Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.

It may take up to 24 hours for the tracking information to appear on the
website.
====

I noticed your snippet mentions ot_local_sales_taxes - I don't have that module installed, I use TaxCloud instead. No idea if that could be related to the issue, what are your thoughts? Can the snippet be adjusted to work with TaxCloud, or another one added someplace to fix the TPT issue? (I'm not a programmer, wouldn't know where to start.)

Thank you!
Magz

[DivaVocals]

Hi lhungil - thank you, this code change did fix the subtotal issue in EO 4.1 for me, as well. However, it seems to be causing another issue with Ty Package Tracker 3.1.3. I posted on TPT thread about this, but have been directed here.

With version 1 of the above code, TPT works great. With version 2, however, after the tracking # is added to an order, the email sent to the customer includes a list of all shippers, even those that are turned off. I only have USPS turned on, and only the USPS tracking # field appears on my Edit Orders page, but here's the list customers get in their emails (the bolded part is the only one that should appear):

====
Your FedEx Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
http://www.fedex.com/Tracking?action...&tracknumbers=

It may take up to 24 hours for the tracking information to appear on the
website.

Your UPS Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
http://wwwapps.ups.com/WebTracking/p...nquiryNumber1=

It may take up to 24 hours for the tracking information to appear on the
website.

Your USPS Tracking ID is 9000000000000000000000
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.
https://tools.usps.com/go/TrackConfirmAction!input.action?tLabels=#9000000000000000000000

It may take up to 24 hours for the tracking information to appear on the
website.

Your Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.

It may take up to 24 hours for the tracking information to appear on the
website.

Your Tracking ID is
Click here to track your package.
If the above link does not work, copy the following URL address and paste it
into your Web browser.

It may take up to 24 hours for the tracking information to appear on the
website.
====

I noticed your snippet mentions ot_local_sales_taxes - I don't have that module installed, I use TaxCloud instead. No idea if that could be related to the issue, what are your thoughts? Can the snippet be adjusted to work with TaxCloud, or another one added someplace to fix the TPT issue? (I'm not a programmer, wouldn't know where to start.)

Thank you!
Magz

It's not that I don't want to help.. it's that I CAN'T help you with a problem that is not caused by a defect with the Ty Package Tracker code.. I directed you here because the issue you are having is not with the Ty Package Tracker code, but rather with the code you used to modify the Edit Order files which has caused the issue you are reporting.. The Edit Orders code is the cause.. not the Ty Package Tracker code.. This support thread is where you got the code from. lhungil wrote the code and is probably the BEST person to direct you as to how to fix it.. so this is where you must come for the solution..

[magz]

Update to my earlier post - I just discovered that all shippers are listed in the email to customer even when NO tracking number is uploaded, just a comment is made OR order status is changed. On the other hand, when the Append Comments checkbox is UNchecked, no shippers are listed even when a tracking number was added. (The last one might be the expected behavior for all I know, I'm just describing my observations; perhaps shipper info is regarded as part of the comment.)
Hope this can help find a solution...
Thanks,
Magz

[lhungil]

... Mystery solved ... It was indeed an issue with TaxCloud code. ...

Not necessarily a problem, but as outlined in the readme.html some modules may need to be modified to correctly load from the admin side of Zen Cart (many make assumptions about paths and GLOBAL variables).

If you are using a 3rd party tax software to calculate and store tax records... You may want to check with TaxCloud about how to update the stored order and tax information in their database... Otherwise you could end up with records on your end which do not match the records stored by TaxCloud. I'd expect there to be a special call needed to update order and tax records sent to (and stored by) any 3rd party tax software.

... With version 1 of the above code, TPT works great. With version 2, however, after the tracking # is added to an order, the email sent to the customer includes a list of all shippers, even those that are turned off. ...

This is unrelated to the code changes mentioned earlier.

... I just discovered that all shippers are listed in the email to customer even when NO tracking number is uploaded, just a comment is made OR order status is changed. On the other hand, when the Append Comments checkbox is UNchecked, no shippers are listed even when a tracking number was added. ...

The code for TPT was for the most part left alone between version 4.0 and 4.1 (I do not use TPT so have been relying on others for feedback). Thank You for finding something and reporting. The changes will most likely need to be made to "/admin/edit_orders.php" as this is where the integration code is. When I get back from vacation (no place with stable internet here) and get some time, I'll take a deeper look at the TPT integration code.

[magz]

Thanks for your pointers, DivaVocals and lankeeyankee. Will research/test/retest/post/etc., and report back IF I find anything relevant to EO in the process...
Thanks for your many contributions as well!
Magz

[rod44]

I have 'kind of' the same problem with totals.....

ZenCart 1.5.1
Edit Orders 4.1
Admin New Orders 1.3
2Checkout module

My issue is I installed the 3 modules 1st week in June, and seems to be working OK, however I just noticed that whenever I update and order to 'Shipped' the total goes to $0.00. Will this fix possibly correct this issue?

Thanks

[lhungil]

... My issue is I installed the 3 modules 1st week in June, and seems to be working OK, however I just noticed that whenever I update and order to 'Shipped' the total goes to $0.00. Will this fix possibly correct this issue? ...

It should.