Administrator
- Join Date:
- Sep 2009
- Location:
- Stuart, FL
- Posts:
- 14,140
- Plugin Contributions:
- 56
Edit Orders v4.0 Support Thread
Thanks for the report, I've created a GitHub issue to track the change: https://github.com/lat9/edit_orders/issues/350
Administrator
Thanks for the report, I've created a GitHub issue to track the change: https://github.com/lat9/edit_orders/issues/350
Administrator
After reviewing the code for the ot_coupon.php, it's just not compatible with EO's admin environment. It makes many redirects if/when anomalies are found with the coupon-code to the storefront checkout_payment page.
I'll be updating EO to make that more clear, but any order-related discounts can be handled using EO's Onetime Discount order total.
Administrator
lat9:
After reviewing the code for the ot_coupon.php, it's just not compatible with EO's admin environment. It makes many redirects if/when anomalies are found with the coupon-code to the storefront checkout_payment page.
I'll be updating EO to make that more clear, but any order-related discounts can be handled using EO's Onetime Discount order total.
OK, I might have "jumped the gun" a bit on the ot_coupon inclusion. I'm hoping to have something finished by the end of the day.
Administrator
Edit Orders v5.0.4 is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2400
This release contains changes associated with these GitHub issues:
#349: Remove unused parameter from observer; was resulting in zc210 error, since it wasn't added until zc220.
#350: Enable a coupon to be added to the order.
#351: Ensure that any GV payment isn't reduced by ordered-product changes.
#352: Correct zenConfig method return for EO's order-total modules.
Administrator
In the older (4.7.1) version of edit orders for Zen Cart 1.5, it seems like editing an order with sales tax winds up wiping out the sales tax record (even if EO_TOTAL_RESET_DEFAULT is on). Is this fixed in the newer version of EO for Zen Cart 2.1.0+? Any way to fix it for the older version?
That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.
Administrator
swguy:
In the older (4.7.1) version of edit orders for Zen Cart 1.5, it seems like editing an order with sales tax winds up wiping out the sales tax record (even if EO_TOTAL_RESET_DEFAULT is on). Is this fixed in the newer version of EO for Zen Cart 2.1.0+? Any way to fix it for the older version?
EO-5 is a whole different "animal". You get to see what's going to be committed to the order before it's written to the database.
I have no plans to update the EO-4 series.
Administrator
Understood.
That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.
Zen Follower
When using Edit Order 5.0.4 with ZC version < 3, without zen_config function included I get some logs with PHP Warning: Undefined variable $default_value in ..\zc_plugins\EditOrders\v5.0.4\admin\includes\functions\extra_functions\edit_orders_functions.php on line 80.
There is a bug in the provided zen_config function using different variable names in the function parameter and the function code itself: $default as parameter but $default_value in code.
function zen_config(string $key, mixed $default = null): mixed
{
if (defined($key)) {
return constant($key);
}
return ($default_value !== null) ? $default_value : null;
}
ZC v2.2.2 PHP 8.4+ MySQL 8.4+
Administrator
pilou2:
When using Edit Order 5.0.4 with ZC version < 3, without zen_config function included I get some logs with
PHP Warning: Undefined variable $default_value in ..\zc_plugins\EditOrders\v5.0.4\admin\includes\functions\extra_functions\edit_orders_functions.php on line 80.There is a bug in the provided
zen_configfunction using different variable names in the function parameter and the function code itself:$defaultas parameter but$default_valuein code.function zen_config(string $key, mixed $default = null): mixed{if (defined($key)) {return constant($key);}return ($default_value !== null) ? $default_value : null;}
Previously reported and staged for v5.0.5: https://github.com/lat9/edit_orders/issues/353
Administrator
v5.0.5 of Edit Orders is now available for download: https://www.zen-cart.com/plugins/edit-orders-5x-vb2400
This release contains changes for these GitHub issues:
#353: Correct parameter name in zen_config function polyfill.
#354: Allow tax-rate descriptions without a percentage (%) to be matched.
#355: Add missing 'TAX_EXEMPT_DESCRIPTION' language constant.
Zen Follower
Thank you for updating the mod! I really appreciate all your time and effort 👍
*Zen Cart eCommerce Solution - Putting the Dream of Owning an Online Business within reach of anyone!
Tell staff why this post should be reviewed.