See the post above yours:smile: ... it's on my list, but paying clients come first.Quote:
Originally Posted by rlexyd
Printable View
See the post above yours:smile: ... it's on my list, but paying clients come first.Quote:
Originally Posted by rlexyd
Thanks Cindy, I appreciate where you are coming from :)
Until you get a chance to update it, for the time being I've commented out the login code in (/includes/modules/pages/product_reviews_write/header.php) as suggest in the link below incase anyone else is wondering.
https://www.zen-cart.com/showthread....26#post1284826
Ok, I was getting an error log every time someone loaded the product write review page, even if they didn't write a review.
So I decided to undo the change I did and install this plugin.
I'm running fresh install of Zen Cart 1.5.7c on PHP 7.4.22 with OPC and IH5 Installed.
It works, guest can leave reviews and their name appears, thank you.
I am however getting Error Logs with this :(
I know you said this hasn't been updated yet, but is there a way you can help resolve some of these errors in the log if it's not too much trouble, or if anyone else with the skills to help!? (I've added the corresponding php line under each php notice!)
Thank you in advance.
Code:Request URI: /01/index.php?main_page=product_reviews_write&products_id=47&cPath=1
#1 require_once(/01/includes/languages/english/responsive_classic/product_reviews_write.php) called at [/01/includes/modules/require_languages.php:22]
#2 require(/01/includes/modules/require_languages.php) called at [/01/includes/modules/pages/product_reviews_write/header_php.php:18]
#3 require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined index: customer_id in /01/includes/languages/english/responsive_classic/product_reviews_write.php on line 13.
if( $_SESSION['customer_id'] ) {
Request URI: /01/index.php?main_page=product_reviews_write&products_id=47&cPath=1
#1 require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined index: customer_id in /01/includes/modules/pages/product_reviews_write/header_php.php on line 42.
if (!$_SESSION['customer_id']) {
Request URI: /01/index.php?main_page=product_reviews_write&products_id=47&cPath=1
#1 require(/01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php) called at [/01/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2 require(/01/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/01/index.php:94]
--> PHP Notice: Undefined index: customer_id in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 16.
<?php echo zen_draw_form('product_reviews_write', zen_href_link(FILENAME_PRODUCT_REVIEWS_WRITE, 'action=process&products_id=' . $_GET['products_id'], ($_SESSION['customer_id']) ? 'SSL' : 'NONSSL'), 'post', 'onsubmit="return checkForm(product_reviews_write);"'); ?>
Request URI: /01/index.php?main_page=product_reviews_write&products_id=47&cPath=1
#1 require(/01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php) called at [/01/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2 require(/01/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/01/index.php:94]
--> PHP Notice: Undefined index: customer_id in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 38.
if ($_SESSION['customer_id']) {
Request URI: /01/index.php?main_page=product_reviews_write&products_id=47&cPath=1
#1 require(/01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php) called at [/01/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2 require(/01/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/01/index.php:94]
--> PHP Notice: Trying to get property 'fields' of non-object in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.
--> PHP Notice: Trying to get property 'fields' of non-object in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.
<div id="textAreaReviews"><?php echo sprintf(SUB_TITLE_REVIEW, $customer->fields['customers_firstname'], $customer->fields['customers_lastname']); ?></div>
Request URI: /01/index.php?main_page=product_reviews_write&products_id=47&cPath=1
#1 require(/01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php) called at [/01/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2 require(/01/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/01/index.php:94]
--> PHP Notice: Undefined index: customer_id in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 58.
if (!$_SESSION['customer_id']) {
These are only notices, not errors so aren't a problem for the time being.Quote:
Originally Posted by rlexyd
I think I'm right in saying: because this plugin was written for ZC v1.5.5 it used the
to determine whether or not a user was logged in. More recent versions now useCode:if($_SESSION['customer_id']) {
I'm not sure how straightforward the fix is but This thread has a suggestion for the customer_id, at least.Code:if(zen_is_logged_in()) {
Thank you Simon,
I replaced these:
if( $_SESSION['customer_id'] ) {
if (!$_SESSION['customer_id']) {
with
if(zen_is_logged_in()) {
That stopped the Undefined index: customer_id from appearing in the logs.
Now these are the remaining error logs generated:
Error Log generates as a (Guest/Not Logged In) when you click on Write Review (Before Submitting Review):
Error Log generates as a (Guest/Not Logged In) when you click submit the information on the Write Review Page (After Submitting Review):Code:Request URI: /01/index.php?main_page=product_reviews_write&products_id=16&cPath=1,
#1 require(/01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php) called at [/01/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2 require(/01/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/01/index.php:94]
--> PHP Notice: Trying to get property 'fields' of non-object in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 42.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 42.
--> PHP Notice: Trying to get property 'fields' of non-object in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 42.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 42.
Line 42: <?php echo SUB_TITLE_FROM . zen_output_string_protected($customer->fields['customers_firstname'] . ' ' . $customer->fields['customers_lastname']) . '</h3>';}?>
Request URI: /01/index.php?main_page=product_reviews_write&products_id=16&cPath=1,
#1 require(/01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php) called at [/01/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2 require(/01/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/01/index.php:94]
--> PHP Notice: Trying to get property 'fields' of non-object in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.
--> PHP Notice: Trying to get property 'fields' of non-object in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.
Line 45: <div id="textAreaReviews"><?php echo sprintf(SUB_TITLE_REVIEW, $customer->fields['customers_firstname'], $customer->fields['customers_lastname']); ?></div>
Error Log generates as a (Logged In Customer) when you click submit the information on the Write Review Page (After Submitting Review):Code:Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=48,
#1 require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined variable: extra_info in /01/includes/modules/pages/product_reviews_write/header_php.php on line 137.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/modules/pages/product_reviews_write/header_php.php on line 137.
Line 137: zen_mail('', SEND_EXTRA_REVIEW_NOTIFICATION_EMAILS_TO, $email_subject, $email_text . $extra_info['TEXT'], STORE_NAME, EMAIL_FROM, $html_msg, 'reviews_extra');
Code:Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=16,
#1 require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined index: review_name in /01/includes/modules/pages/product_reviews_write/header_php.php on line 57.
Line 57: $review_name = zen_db_prepare_input($_POST['review_name']);
Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=16,
#1 require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined variable: name in /01/includes/modules/pages/product_reviews_write/header_php.php on line 133.
--> PHP Notice: Undefined variable: email_address in /01/includes/modules/pages/product_reviews_write/header_php.php on line 133.
Line 133: $extra_info=email_collect_extra_info($name,$email_address, $customer->fields['customers_firstname'] . ' ' . $customer->fields['customers_lastname'] , $customer->fields['customers_email_address'] );
Not sure if you did butQuote:
Originally Posted by rlexyd
needs to be replaced with (exclamation mark before 'zen')Code:if (!$_SESSION['customer_id']) {
Code:if(!zen_is_logged_in()) {
I've just submitted v1.3.0 of Reviews Updated for the Zen Cart moderators' review; I'll post back here when it's available for download.
This version supports Zen Cart versions 1.5.7 and later, using the responsive_classic template's layout for the templating change-basis. Anyone wanting an early peek can grab the changes from the plugin's GitHub repository: https://github.com/lat9/reviews_updated.
Thank you Cindy. I've sent you a long overdue coffee and sugar-free doughnuts.Quote:
Originally Posted by lat9
Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=1442Quote:
Originally Posted by lat9
THANK YOU very much :bow:Cindy!!!
I've just installed it on my 1.5.7c, PHP 7.4 on Responsive Classic.
I am no longer getting error logs generate BEFORE submitting, which is great!
I am however getting a couple of issues, please see below.
1) When Logged in as a Customer, the part that displays the First name and initial Surname is showing as this %s %1.1s.
(Note it displays the name correctly after the Written By: First S section, but not the lower privacy warning.)
https://i.imgur.com/dNCkY0x.jpg
2) I am getting an Error log generate after submitting a review as a Guest:
3) I am also getting an Error log generate after submitting a review as a Customer:Code:[25-Aug-2021 08:31:56 Australia/Sydney] Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=16,
#1 require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined variable: extra_info in /01/includes/modules/pages/product_reviews_write/header_php.php on line 150.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/modules/pages/product_reviews_write/header_php.php on line 150.
Line 150: zen_mail('', SEND_EXTRA_REVIEW_NOTIFICATION_EMAILS_TO, $email_subject, $email_text . $extra_info['TEXT'], STORE_NAME, EMAIL_FROM, $html_msg, 'reviews_extra');
Code:[25-Aug-2021 08:36:55 Australia/Sydney] Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=11,
#1 require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined index: review_name in /01/includes/modules/pages/product_reviews_write/header_php.php on line 66.
Line 66: $review_name = zen_db_prepare_input(zen_clean_html($_POST['review_name']));
[25-Aug-2021 08:36:55 Australia/Sydney] Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=11,
#1 require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined variable: name in /01/includes/modules/pages/product_reviews_write/header_php.php on line 144.
--> PHP Notice: Undefined variable: email_address in /01/includes/modules/pages/product_reviews_write/header_php.php on line 144.
Line 144: $extra_info=email_collect_extra_info($name,$email_address, $customer->fields['customers_firstname'] . ' ' . $customer->fields['customers_lastname'] , $customer->fields['customers_email_address'] );
Sigh. It's always something.
I'll note those issues on the plugin's GitHub repository and get to them real-soon-now.
FWIW, the changes associated with the correction of those unwanted PHP notices is currently staged on GitHub: https://github.com/lat9/reviews_updated.Quote:
Originally Posted by lat9
OMG, Thank YOU Cindy so much!!!
All works well with the updated github files, finally No more error logs re: the guest or customer reviews and it works and looks awesome!
Thank you from the Zen community once again :clap:. Will be sending you a cup of coffee shortly.
On another note, is there a way to display just the month & year in the date added field that shows on the review?
I read an Old post from Linda advising to comment out the date where you find (TEXT_REVIEW_DATE_ADDED) which will remove the date added completely, but I would like to keep displaying the Month and Year but Remove the actual Date digit if at all possible?!
Thanks for the report that the bugfix-version on GitHub is a go!Quote:
Originally Posted by rlexyd
For the display of those reviews, please open a separate thread since it's not to do with the writing of reviews, but in their after-approval display.
I've just submitted v1.3.1 of Reviews Updated for the Zen Cart moderators' review and will post back here when it's available for download.
This release corrects (see GitHub issue #4) bugs introduced in v1.3.0.
Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=1442Quote:
Originally Posted by lat9
Can anyone please verify this will work with 1.5.8 (1.5.8a) before I install it since it changes core files
I've not looked at this plugin for a couple of years and my gut feeling is that it's going to need some "care and feeding" to work properly with zc158+. I'll review and get back real-soon-now.Quote:
Originally Posted by jtlswan
Thank you Cindy! Always appreciate your promptness and work!Quote:
Originally Posted by lat9
Not suitable for pushing to core?
Possibly, once I work through the way the plugin should work with zc158.Quote:
Originally Posted by torvista
v2.0.0 of "Reviews Updated" is now available for download: http://www.zen-cart.com/downloads.php?do=file&id=1442
This version
- Requires Zen Cart 1.5.8 or later
- Supports either the responsive_classic or bootstrap templates (or clones thereof)
- No more core file overwrites
- Auto-install via admin initialization script.
Excellent, thank you @lat9Quote:
Originally Posted by lat9
Amazing Cindy! Thank you Ma'am!!!
I meant is it not universally useful enough to push it INTO Zen Cart core....
I understood, just wanted to see what it was going to take to be minimally-invasive as a plugin first.Quote:
Originally Posted by torvista
Note that, since it's got a database-modification component, I can propose the functionality but it won't hit the core until the next non-alpha-suffixed release.