Reviews - Updated [Support Thread]

[rlexyd]

Thank you Simon,

I replaced these:
if( $_SESSION['customer_id'] ) {
if (!$_SESSION['customer_id']) {
with
if(zen_is_logged_in()) {

That stopped the Undefined index: customer_id from appearing in the logs.

Now these are the remaining error logs generated:

Error Log generates as a (Guest/Not Logged In) when you click on Write Review (Before Submitting Review):

 Request URI: /01/index.php?main_page=product_reviews_write&products_id=16&cPath=1, 
#1  require(/01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php) called at [/01/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2  require(/01/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/01/index.php:94]

--> PHP Notice: Trying to get property 'fields' of non-object in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 42.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 42.
--> PHP Notice: Trying to get property 'fields' of non-object in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 42.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 42.

Line 42: <?php echo SUB_TITLE_FROM . zen_output_string_protected($customer->fields['customers_firstname'] . ' ' . $customer->fields['customers_lastname']) . '</h3>';}?>

 Request URI: /01/index.php?main_page=product_reviews_write&products_id=16&cPath=1, 
#1  require(/01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php) called at [/01/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2  require(/01/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/01/index.php:94]

--> PHP Notice: Trying to get property 'fields' of non-object in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.
--> PHP Notice: Trying to get property 'fields' of non-object in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/templates/responsive_classic/templates/tpl_product_reviews_write_default.php on line 45.

Line 45: <div id="textAreaReviews"><?php echo sprintf(SUB_TITLE_REVIEW, $customer->fields['customers_firstname'], $customer->fields['customers_lastname']); ?></div>

Error Log generates as a (Guest/Not Logged In) when you click submit the information on the Write Review Page (After Submitting Review):

 Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=48,
#1  require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined variable: extra_info in /01/includes/modules/pages/product_reviews_write/header_php.php on line 137.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/modules/pages/product_reviews_write/header_php.php on line 137.

Line 137: zen_mail('', SEND_EXTRA_REVIEW_NOTIFICATION_EMAILS_TO, $email_subject, $email_text . $extra_info['TEXT'], STORE_NAME, EMAIL_FROM, $html_msg, 'reviews_extra');

Error Log generates as a (Logged In Customer) when you click submit the information on the Write Review Page (After Submitting Review):

 Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=16, 
#1  require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined index: review_name in /01/includes/modules/pages/product_reviews_write/header_php.php on line 57.

Line 57: $review_name = zen_db_prepare_input($_POST['review_name']);

 Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=16, 
#1  require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined variable: name in /01/includes/modules/pages/product_reviews_write/header_php.php on line 133.
--> PHP Notice: Undefined variable: email_address in /01/includes/modules/pages/product_reviews_write/header_php.php on line 133.

Line 133: $extra_info=email_collect_extra_info($name,$email_address, $customer->fields['customers_firstname'] . ' ' . $customer->fields['customers_lastname'] , $customer->fields['customers_email_address'] );

[simon1066]

Thank you Simon,

I replaced these:
if( $_SESSION['customer_id'] ) {
if (!$_SESSION['customer_id']) {
with
if(zen_is_logged_in()) {

That stopped the Undefined index: customer_id from appearing in the logs.

Not sure if you did but

if (!$_SESSION['customer_id']) {

needs to be replaced with (exclamation mark before 'zen')

if(!zen_is_logged_in()) {

[lat9]

I've just submitted v1.3.0 of Reviews Updated for the Zen Cart moderators' review; I'll post back here when it's available for download.

This version supports Zen Cart versions 1.5.7 and later, using the responsive_classic template's layout for the templating change-basis. Anyone wanting an early peek can grab the changes from the plugin's GitHub repository: https://github.com/lat9/reviews_updated.

[simon1066]

I've just submitted v1.3.0 of Reviews Updated for the Zen Cart moderators' review; I'll post back here when it's available for download.

This version supports Zen Cart versions 1.5.7 and later, using the responsive_classic template's layout for the templating change-basis. Anyone wanting an early peek can grab the changes from the plugin's GitHub repository: https://github.com/lat9/reviews_updated.

Thank you Cindy. I've sent you a long overdue coffee and sugar-free doughnuts.

[lat9]

I've just submitted v1.3.0 of Reviews Updated for the Zen Cart moderators' review; I'll post back here when it's available for download.

This version supports Zen Cart versions 1.5.7 and later, using the responsive_classic template's layout for the templating change-basis. Anyone wanting an early peek can grab the changes from the plugin's GitHub repository: https://github.com/lat9/reviews_updated.

Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=1442

[rlexyd]

THANK YOU very much Cindy!!!
I've just installed it on my 1.5.7c, PHP 7.4 on Responsive Classic.
I am no longer getting error logs generate BEFORE submitting, which is great!
I am however getting a couple of issues, please see below.

1) When Logged in as a Customer, the part that displays the First name and initial Surname is showing as this %s %1.1s.
(Note it displays the name correctly after the Written By: First S section, but not the lower privacy warning.)
https://i.imgur.com/dNCkY0x.jpg

2) I am getting an Error log generate after submitting a review as a Guest:

[25-Aug-2021 08:31:56 Australia/Sydney] Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=16,
#1  require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined variable: extra_info in /01/includes/modules/pages/product_reviews_write/header_php.php on line 150.
--> PHP Notice: Trying to access array offset on value of type null in /01/includes/modules/pages/product_reviews_write/header_php.php on line 150.

Line 150: zen_mail('', SEND_EXTRA_REVIEW_NOTIFICATION_EMAILS_TO, $email_subject, $email_text . $extra_info['TEXT'], STORE_NAME, EMAIL_FROM, $html_msg, 'reviews_extra');

3) I am also getting an Error log generate after submitting a review as a Customer:

[25-Aug-2021 08:36:55 Australia/Sydney] Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=11,
#1  require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined index: review_name in /01/includes/modules/pages/product_reviews_write/header_php.php on line 66.

Line 66: $review_name = zen_db_prepare_input(zen_clean_html($_POST['review_name']));

[25-Aug-2021 08:36:55 Australia/Sydney] Request URI: /01/index.php?main_page=product_reviews_write&action=process&products_id=11,
#1  require(/01/includes/modules/pages/product_reviews_write/header_php.php) called at [/01/index.php:35]
--> PHP Notice: Undefined variable: name in /01/includes/modules/pages/product_reviews_write/header_php.php on line 144.
--> PHP Notice: Undefined variable: email_address in /01/includes/modules/pages/product_reviews_write/header_php.php on line 144.

Line 144: $extra_info=email_collect_extra_info($name,$email_address, $customer->fields['customers_firstname'] . ' ' . $customer->fields['customers_lastname'] , $customer->fields['customers_email_address'] );

[lat9]

Sigh. It's always something.

I'll note those issues on the plugin's GitHub repository and get to them real-soon-now.

[lat9]

Sigh. It's always something.

I'll note those issues on the plugin's GitHub repository and get to them real-soon-now.

FWIW, the changes associated with the correction of those unwanted PHP notices is currently staged on GitHub: https://github.com/lat9/reviews_updated.