[Closed] FEEDBACK ON BETA of v1.5.5

includes/classes/order.php
generation of a database table id is not collected for potential use before initiating a notify action. lines 888-890.

Code:

---

          zen_db_perform(TABLE_ORDERS_PRODUCTS_ATTRIBUTES, $sql_data_array);

          $this->notify('NOTIFY_ORDER_DURING_CREATE_ADDED_ATTRIBUTE_LINE_ITEM', $sql_data_array);

---

The $sql_data_array is added to the table Orders Products Attributes, but the position of that addition is not immediately captured and could be lost in the initiation of the notify.

Earlier in the code a similar addition is performed at lines 802-804:

Code:

---

      zen_db_perform(TABLE_ORDERS_PRODUCTS, $sql_data_array);

      $order_products_id = $db->Insert_ID();

      $this->notify('NOTIFY_ORDER_DURING_CREATE_ADDED_PRODUCT_LINE_ITEM', array_merge(array('orders_products_id' => $order_products_id), $sql_data_array));

---

suggest the same type of designation and assignment:

Code:

---

          zen_db_perform(TABLE_ORDERS_PRODUCTS_ATTRIBUTES, $sql_data_array);

          $order_products_attributes_id = $db->Insert_ID();

          $this->notify('NOTIFY_ORDER_DURING_CREATE_ADDED_ATTRIBUTE_LINE_ITEM', array_merge(array('orders_products_attributes_id' => $order_products_attributes_id), $sql_data_array));

---

It would seem that though the additional assignment would not be necessary for discovery of the same information in the table (ie. the database table can be searched for successful addition of the $sql_data_array), it is inconsistent with the guidelines and suggestions of the forum for design by NOT collecting the insertion id before performing an action against the $db variable/the database table before collecting that new number and is inconsistent with code a few lines back...

FWIW, this was also posted previously as a code suggestion.

Quote:

---

Originally Posted by mc12345678

Changes made to sql statements in includes/functions/functions_lookups did not use $db->bindVars(

Code:

---

function zen_has_product_attributes_downloads_status($products_id) {
  if (!defined('DOWNLOAD_ENABLED') || DOWNLOAD_ENABLED != 'true') {
    return false;
  }

  $query = "select pad.products_attributes_id
              from " . TABLE_PRODUCTS_ATTRIBUTES . " pa
              inner join " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " pad
              on pad.products_attributes_id = pa.products_attributes_id
              where pa.products_id = " . (int) $products_id;

  global $db;
  return ($db->Execute($query)->RecordCount() > 0);
}

---

Could/should be:

Code:

---

function zen_has_product_attributes_downloads_status($products_id) {
  if (!defined('DOWNLOAD_ENABLED') || DOWNLOAD_ENABLED != 'true') {
    return false;
  }

  $query = "select pad.products_attributes_id
              from " . TABLE_PRODUCTS_ATTRIBUTES . " pa
              inner join " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " pad
              on pad.products_attributes_id = pa.products_attributes_id
              where pa.products_id = :products_id:";

  global $db;
  $query = $db->bindvars($query, ':products_id:', $products_id, 'integer');
  return ($db->Execute($query)->RecordCount() > 0);
}

---

---

Also just noticed that this function has been left justified as compared to being indented by two spaces.

Quote:

---

Originally Posted by ibuttons

is there any additional documentation on how to install and/or setup the responsive design stuff?

---

The new template is responsive out of the box.

Thanks,

Anne

includes/modules/shopping_cart/header_php.php

includes a closing ?> at the end of the file, even though it has been modified in ZC 1.5.5 (cleanup of files modified to consistently be "touched up")

Also, the header of the header file reflects the last change as in ZC 1.5.4; however, is changed here in ZC 1.5.5.

Similirar issue with checkout_shipping that the header is not modified. (Perhaps the case in several of the includes/modules/pages header_php.php files?)

Quote:

---

Originally Posted by mc12345678

Changes made to sql statements in includes/functions/functions_lookups did not use $db->bindVars(

Code:

---

function zen_has_product_attributes_downloads_status($products_id) {
  if (!defined('DOWNLOAD_ENABLED') || DOWNLOAD_ENABLED != 'true') {
    return false;
  }

  $query = "select pad.products_attributes_id
              from " . TABLE_PRODUCTS_ATTRIBUTES . " pa
              inner join " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " pad
              on pad.products_attributes_id = pa.products_attributes_id
              where pa.products_id = " . (int) $products_id;

  global $db;
  return ($db->Execute($query)->RecordCount() > 0);
}

---

Could/should be:

Code:

---

function zen_has_product_attributes_downloads_status($products_id) {
  if (!defined('DOWNLOAD_ENABLED') || DOWNLOAD_ENABLED != 'true') {
    return false;
  }

  $query = "select pad.products_attributes_id
              from " . TABLE_PRODUCTS_ATTRIBUTES . " pa
              inner join " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " pad
              on pad.products_attributes_id = pa.products_attributes_id
              where pa.products_id = :products_id:";

  global $db;
  $query = $db->bindvars($query, ':products_id:', $products_id, 'integer');
  return ($db->Execute($query)->RecordCount() > 0);
}

---

---

Personally, I think that using bindVars in this case is overkill; the simple recast to (int) as the original code does is sufficient.

Quote:

---

Originally Posted by lat9

Personally, I think that using bindVars in this case is overkill; the simple recast to (int) as the original code does is sufficient.

---

I agree in functionality it is sufficient and in fact the addition of the use of the bindVars invokes additional code execution (in the end bindVars also casts the value to an integer anyways). When is it "right" to use bindVars, when there is more than one field involved? Only when the datatype/source can change on the fly? When the field is non-numeric only thereby using the most secure "conversions" available by the host system?

It's just one of those when making changes go all out and continue to introduce consistency (makes future upgrades/changes much easier). As for style, there are other places where a value is cast as an integer for a sql query and the sql statement has the value captured in single quotes (not the case here), but that is equally "acceptable" but inconsistent with this particular change.

This particular change is interesting in that it approaches things to see first if the database/files even support the code that follows, instead of the previous check of if it was enabled/disabled... A little of a different turn on code compatibility/verification of acceptability for use.

admin/attributes_controller.php
header not updated to reflect Changed in ZC 1.5.5.

(FYI, Let me know if I need to stop identifying these because some other "search" or "final edit" is going to be done for such "changes".)

Within the classic_responsive/jscript directory, there are a bunch of minimized javascript files

1. jscript_matchHeight.min.js
2. jquery.mmenu.min.all.js
3. jquery.mmenu.fixedelements.min.js

Having the unminimized versions, too, will be a big help ... just in case anything "goes funky".

admin/includes/classes/order.php indicates changed in ZC 1.6.0... Chicken/egg? :)

includes\templates\template_default\templates\tpl_account_history_info_default.p hp

header not updated to reflect change in ZC 1.5.5.

within a for loop, which could cause a validation issue:
Line 42 changed from:

Code:

---

      echo '<ul id="orderAttribsList">';

---

To the more acceptable:

Code:

---

      echo '<ul class="orderAttribsList">';

---

Haven't looked to see if the CSS changed accordingly or needed to (from #orderAttribsList to .orderAttribsList)...

includes\templates\template_default\templates\tpl_checkout_confirmation_default. php

No functional change, but file did change, "not tagged in header". (previously commented out content was simply removed.)

includes\templates\template_default\templates\tpl_shopping_cart_default.php

Modified, but not identified as such...

,

Performing install. Site does not have SSL enabled/available,
Did not click on the "advanced tip" on the first page, but once continued, catalog (storefront) settings included pre-selected Enable SSL for Storefront. Would think that there be some form of internal check first to validate that SSL would be supported before offering the suggestion as default selected.

Also, it seems that the admin server domain being asked up front, if it is different for https: as compared to http: seems like might be better left for a follow on screen?

Somewhat surprised that there are so many "disjointed" fields to fill in their entirety: Domain and URL where URL contains the domain but is not auto updated when the domain is edited.

There is no "back" button, for example when at the database setup, can't return to the system setup section if something were "entered" wrong or needed to be modified. It would appear would have to restart the entire process.

So far during install have also noticed that there is nothing indicating what version this install is to provide... Wouldn't that be something worth having without revealing "too much"?

Database User tip: Is: "... For PCI reasons you should NEVER user 'root' here." could be either: "... For PCI reasons you should NEVER use 'root' here." or "... For PCI reasons you should NEVER use user 'root' here."

Database Host and Database User fields provide auto help if the field is blank and the cursor is placed in the block, but on initial loading the host is populated with localhost and therefore the autohelp is not provided until the field is emptied.

Database Password does not have an autotip (in red below the block) like the previous two, but it does appear when clicking on the field title as described at the top. (Perhaps intermittently applied, recommend review of why and what is to be presented the way(s) it is. Kinda' cool/nice to have the autotip without fear of leaving the page if a link is clicked and without the "popup" information being in the way of starting to type in information.

Database Character Set: Maybe lat9 already made this comment; however, the dropdown selection shows UTF-8, while the help information indicates to possibly use UTF8. Seems like "can't complete the installation" because can't choose what is suggested...

SQL Cache Method tip: Says: "...If your server is really slow, use 'none'. If your site is moderately busy, use 'database'. If your site is extremely high traffic, use 'file'." Also may be something from lat9, but it is not clear if slow is to mean infrequently visited or does not respond quickly.

Auto generated password, would think perhaps it might be possible to have it autogenerate again if "don't like the one provided".

Admin Directory provided, there is a bit of a conflict in description: Says: " We did not change your admin directory automatically as it already seems to have been changed from the default." Thing is, somebody (we?) changed it from the default and it wasn't me... When the files were uploaded an admin directory named admin existed... At this stage of the install, admin does not exist, but the newly created/renamed admin directory does...

Admin Directory tip: Haven't progressed to the next step, but should it indicate that renaming should at least wait until the install is complete?

Finally into the store:

Little surprised that so much of the initial setup (setup wizard) was removed from initial install, but it also somewhat makes sense for those that do the software side. They then let the store owner login and complete the initial information. Also, great that can navigate away from the home page to do other things, though if "needed" to verify home page information and the information was not available for the initial setup, then there does not appear to be a way to "set aside" the initial setup wizard to see how the home page is "coming along". Maybe set the information as a clickable link in the top of the screen (message) after initial display perhaps after initial display per login? (SESSION)

All as one here: related to Developer's Tool kit and hopefully different than what has previously been discussed. Tried to take some obscure actions to just see how things resolved. Overall like the additional options and how the data is highlighted for display.



developer's tool kit: Like the "context" option; however, seems like there could be a little more "clarity" on what it is/what it means, also would be nice if whatever value was entered previously was available again somewhere on screen, either in the results section or back in the box itself (preferred)



Developer's tool kit: search of information in an observer using the look-up classes or things in classes files does not provide results... Example, vanilla install, search in look-up classes or things in classes on: products_viewed_counter extends

No results, place the same search criteria in the Look-up in all files entry and the default observer is searched.



DTK: Not sure what's going on, but I expected different results: using the template search (wanted to see if template override files in the modules directory would be searched since not in the dropdown list for that selection). Entered the following search:

params' => 'class="productListing-hea


Two results returned: both line 69 of: includes/modules/product_listing.php
I expected that the sub-folder responsive_classic would be included...
Search using the "Look-up in all files" option produced the correct result of the same filename in two different folders...
Didn't try searching for information below any change/difference that would change the line number(s).

This having to do with store_manager.php

admin/store_manager.php:

Store Manager: Update Hit Counter
to to a new value

(Anyone notice the double to?)define at: admin/includes/languages/english/store_manager.php line 23

admin/store_manager.php
Set next order number
NOTE: You cannot set the order number to a value lower than any existing order already in the database.

Shouldn't the existing order number show up as part of this statement, even if it could be constantly changing while on the screen?

Store Manager: Cleanup Debug Log Files: Indicates that will address debug logs associated with PHP errors and payment modules, in the /logs/ folder, but what about install logs? The code appears to support the delete, but the statement does not. Line 66 of the same language file as above.

Came back to revisit this after installing the software, but in tpl_modules_attributes, there is a check/variable called $options_html_id on line 30 that does not appear to be defined in includes/modules/attributes.php nor anywhere else in the code...

Anyone have any ideas why it is there? Won't there be a problem identified that referencing an array that is never created, nor assigned? Maybe not so much an issue with recalling data that hasn't been assigned, but still seems like it could end up being random.

Okay, going to take a look at the instructions/documentation this time. :) Enough playing and commenting for now. :)

Okay.. Sorta tough to read through the documentation when there doesn't appear to be any?

the install.txt file in the root says (areas related to the documentation highlighted in red):

Quote:

---

Zen Cart(R) - The Art of E-Commerce

Welcome to Zen Cart(R) E-Commerce

THE FOLLOWING IS A VERY SIMPLIFIED INSTALLATION DOCUMENT.
WE SUGGEST YOU USE THE HTML VERSIONS IN THE /docs FOLDER FOR MORE DETAILED INSTRUCTIONS.

THE README DOCUMENTS ARE IN THE /docs FOLDER OF THIS DISTRIBUTION.


You can find online documentation at: https://tutorials.zen-cart.com


Zen Cart has a built-in automatic installation system. However to use this you must first unpack and upload the code to a compatible web server:

1. Extract the Zen Cart ZIP file (and tell the unzip utility to *retain* folder structures)
2. Upload the Zen Cart files and folders to your server using your FTP program
3. You must make some folders writable. The details are in the HTML-formatted documentation in the /docs/ folder
4. In your browser enter the URL to your website where you uploaded the files, specifically to the /zc_install/index.php file.
5. Follow the instructions. You must create your MySQL database credentials before installation, and provide those details when prompted.

For more detailed installation instructions, please see the /docs/1.readme_installation.html document in this distribution.






(Document Revision: $Id: install.txt 19798 2011-10-12 05:52:54Z drbyte $)
((c)Copyright 2003-2011, Zen Cart(R). All rights reserved.)

---

Quote:

---

Originally Posted by picaflor-azul

The new template is responsive out of the box.

Thanks,

Anne

---

Anne, sorry, but I strongly disagree with this. A truly responsive template works on ALL screen sizes no matter what device is used. This template is "broken" when screen is reduced to less than than 768px - there's no menu and no navigation at all, thus making it seem broken. I mentioned this before...

I understand using mobile detect class, but IMHO, this should not be used on the mobile menu. You're using the same menu as I always do for mobile (mmenu). I usually put the mobile navigation div in the footer (it's using absolute position anyways) and just hide it with css on larger screens. If anyone thinks this would have some major impact on site speed or performance because of the few extra queries or the few extra bytes loaded, well, I won't go into that discussion... But, that one MINOR change would make the template truly responsive. This way, it just looks unprofessional.

Quote:

---

Originally Posted by lat9

Within the classic_responsive/jscript directory, there are a bunch of minimized javascript files

1. jscript_matchHeight.min.js
2. jquery.mmenu.min.all.js
3. jquery.mmenu.fixedelements.min.js

Having the unminimized versions, too, will be a big help ... just in case anything "goes funky".

---

If you do a search for the jscripts you will find the links to their sites which have un minimized versions of the scripts.

Thanks,

Anne

Quote:

---

Originally Posted by picaflor-azul

If you do a search for the jscripts you will find the links to their sites which have un minimized versions of the scripts.

Thanks,

Anne

---

That's all well-and-good, but other than the jquery.mmenu.min.all.js, there's no version number in the minimized script. It's certainly going to make life easier to debug in the future if the unminimized versions were simply part of the distribution.

Quote:

---

Originally Posted by balihr

Anne, sorry, but I strongly disagree with this. A truly responsive template works on ALL screen sizes no matter what device is used.

---

The template meets this definition of responsive design from the Wikipedia:

https://en.wikipedia.org/wiki/Responsive_web_design

Quote:

---

Responsive web design (RWD) is an approach to web design aimed at crafting sites to provide an optimal viewing and interaction experience—easy reading and navigation with a minimum of resizing, panning, and scrolling—across a wide range of devices (from desktop computer monitors to mobile phones)

---

If you feel that a significant number of your web site's clients will be viewing the website with their desktop window minimized below 768 pixels wide then you can do one or more of these:

* un hide the categories sidebox
* un hide the top categories navigation tabs
* add the menu code to desktops as you have stated in your post

Thanks,

Anne

Quote:

---

Originally Posted by picaflor-azul

The template meets this definition of responsive design from the Wikipedia:

https://en.wikipedia.org/wiki/Responsive_web_design



If you feel that a significant number of your web site's clients will be viewing the website with their desktop window minimized below 768 pixels wide then you can do one or more of these:

* un hide the categories sidebox
* un hide the top categories navigation tabs
* add the menu code to desktops as you have stated in your post

Thanks,

Anne

---

Well, Anne, if you're gonna go quoting wikipedia and highlighting it for me, then you might also consider highlighting the other, maybe most important part (the one I'm talking about):

Quote:

---

Responsive web design (RWD) is an approach to web design aimed at crafting sites to provide an optimal viewing and interaction experience—easy reading and navigation with a minimum of resizing, panning, and scrolling—across a wide range of devices (from desktop computer monitors to mobile phones)

---

Furthermore, the same article on wikipedia clearly states how that's done and does NOT mention MobileDetect class as a part of RWD, but instead speaks of using CSS3 media queries to decide what content is to be shown. Therefore, this is NOT a responsive template and should not be advertised as such. This is a mobile-ready template, that's all. There IS a difference.

I'm not trying to be rude here, nor am I trying to tell you how to do your business, but I'm trying to think like an average user here. What's the best way to test if a site is responsive or not? Well, just try resizing your browser window and see what happens. Right? What do you think, how many average users out there will know how to override user agent in their browsers to see how their site looks on mobile devices?

I'm kindly asking you to make this minor change in the code and use CSS3 media queries to show/hide the mobile menu, instead of triggering it based on user agent. I'm sure it will help a lot of average users (or at least make them look professional enough)... Don't think about me and what I can do to change it - personally, I won't be using that template at all - I have my own template as starting point based on Bootstrap, I have never been a fan of Foundation... Think about all the other users who have no idea how to do it... :wink:

Quote:

---

Originally Posted by lat9

That's all well-and-good, but other than the jquery.mmenu.min.all.js, there's no version number in the minimized script. It's certainly going to make life easier to debug in the future if the unminimized versions were simply part of the distribution.

---

I have just submitted the un minimized versions of the scripts to be included in the distribution ;)

Thanks,

Anne

I got the beta installed ok and am poking around. So far, so good, but I would also like to:

1. add a home page slide show
2. change the look of the menu items
3. create tabs on the product info page to display product "description", "details", and "reviews
4. etc

Is this beta just the responsive design features? That's great, but I need more. For some reason, I had thought it would include the above stuff and more.

Is all this stuff in the RESPONSIVESHEFFIELD BLUE template? And if so, can I use that template on this beta right now or should I wait til the dust settles on the beta then add?

I feel like this is such a basic (aka stupid) question. If so, my apologies. I have looked, but not been able to find these answers.

If there is documentation with an overview of this beta and what it does specifically, please send me a link.

Quote:

---

Originally Posted by ibuttons

I got the beta installed ok and am poking around. So far, so good, but I would also like to:

1. add a home page slide show
2. change the look of the menu items
3. create tabs on the product info page to display product "description", "details", and "reviews
4. etc

Is this beta just the responsive design features? That's great, but I need more. For some reason, I had thought it would include the above stuff and more.

Is all this stuff in the RESPONSIVESHEFFIELD BLUE template? And if so, can I use that template on this beta right now or should I wait til the dust settles on the beta then add?

I feel like this is such a basic (aka stupid) question. If so, my apologies. I have looked, but not been able to find these answers.

If there is documentation with an overview of this beta and what it does specifically, please send me a link.

---

This default template does not come with all of the bells and whistles like a slide show or tabs, etc. ;) They (and any other features you need) can be added. You can make css changes using the stylesheets. If you get stuck on a specific change you can post and I or someone can help you out ;)

You can certainly use the Responsive Sheffield Blue or any other template with this version of zen cart. If you are building a live store, you might want to wait until the final version of 1.5.5 is released to use the code.


Thanks,

Anne

Quote:

---

Originally Posted by picaflor-azul

I have just submitted the un minimized versions of the scripts to be included in the distribution ;)

Thanks,

Anne

---

Much appreciated, Anne!

Thanks, Anne.
I am working on a test version and want to see what it will do, so I'll install the RESPONSIVE SHEFFIELD BLUE and play around with it for a bit to get some experience.

Quote:

---

Originally Posted by picaflor-azul

If you feel that a significant number of your web site's clients will be viewing the website with their desktop window minimized below 768 pixels wide then you can do one or more of these:

* un hide the categories sidebox
* un hide the top categories navigation tabs
* add the menu code to desktops as you have stated in your post

Thanks,

Anne

---

I don't know if the pixel width is as much of a "thing" as I think think the percentage of screen. Allow me to explain what I just came across and how *I* browse... (Remember, obviously I'm not your "typical" internet user otherwise I wouldn't be where I am with ZC. :))

Anyways, I went to my page on the beta version, didn't really matter what, though let's say I went to a product, I then had the screen width reduced to about 50% of my screen display so that I could compare what I had on screen with notes on a different file or an email to make sure that I got the right product and had the settings needed. I'm a guy, I get things wrong so I try to not do that where I can avoid it... But, my options were to go back to the home page from where I could navigate to the "new", "specials", etc.. product, navigate up one or more categories (bread crumbs or the previous-return to product list-next buttons), etc...

I haven't gone to look at how that turn off occurs, but do wonder if the set value is perhaps a little too small for turnoff of the menu which may include other options besides just categories...


So, I don't know a magic number or setting, but did find it surprising to not have any navigation menu when not yet thinned down to almost nothing.

Vanilla install, responsive classic template, index.php?main_page=index&cPath=53

screen width of #mainWrapper at: 757px - 799px.

At this point, the Add Selected To Cart button has shifted downward and now is off the right side of the background grey box, part of the white text: Displaying 1 to 10 (of 12 products) has wrapped around to the white background (non-visible text).
The Add Selected To Cart button first shifted down at 1060px.

Also, I don't recall changing a setting, but I would have thought that perhaps the product list would be columnar rather than by row or at least available with this template without additional plugin. I guess though if trying to keep the # of modified files to a minimum in each basic template, I could see how that could affect all templates not just the desired.

So is there now to be a sort of responsive "default" template? (Similar to the template_default folder but for all responsive templates?) I'm thinking from the perspective of overrides and file loading if that has or is changing in this version...

Had one problem with install - Running zc_install it says...
"We did not change your admin directory automatically as it already seems to have been changed from the default." but it DID automatically change the directory and does not allow it to be edited on that page.

So, perhaps it should say...."We changed your admin directory for security. You can change the name through FTP or FileManager when install is complete."

When clicking on the link in this box - Admin Directory, the popup says:

We try to rename your admin folder for you automatically, to offer a degree of security-by-obscurity. While we understand that this doesn't make it foolproof, it does discourage unauthorized visitors from attacking your site. You may still consider changing the foldername yourself (just rename the folder to whatever you wish it to be, by using your FTP program or your hosting company's File Manager tool in your hosting control panel).

This directly conflicts with what is in that box that I referenced above.

Also... this is just a goofy OCD thing, but I thought I would throw it out there just in case... In all these years I have been building zen cart websites and templates for people, the one thing that annoys the heck out of me is that the layout boxes under the tools menu is not in alphabetical order! lol It would be SO MUCH easier to blow through the list of what you want to turn on or leave off if they were listed alphabetically. Oh MY .... OCD to the max!! giggle

Quote:

---

Originally Posted by mc12345678

Vanilla install, responsive classic template, index.php?main_page=index&cPath=53

screen width of #mainWrapper at: 757px - 799px.

At this point, the Add Selected To Cart button has shifted downward and now is off the right side of the background grey box, part of the white text: Displaying 1 to 10 (of 12 products) has wrapped around to the white background (non-visible text).
The Add Selected To Cart button first shifted down at 1060px.

Also, I don't recall changing a setting, but I would have thought that perhaps the product list would be columnar rather than by row or at least available with this template without additional plugin. I guess though if trying to keep the # of modified files to a minimum in each basic template, I could see how that could affect all templates not just the desired.

So is there now to be a sort of responsive "default" template? (Similar to the template_default folder but for all responsive templates?) I'm thinking from the perspective of overrides and file loading if that has or is changing in this version...

---

The widths you are working at (757 - 799 pixels wide) are not typically laptop or desktop widths. If you want to view the tablet layout while working on a desktop, switch the user agent using the links on the home page or:

for a tablet:

yourdomain.com/index.php?main_page=index&layoutType=tablet

for a mobile:

yourdomain.com/index.php?main_page=index&layoutType=mobile


Thanks,

Anne

Quote:

---

the one thing that annoys the heck out of me is that the layout boxes under the tools menu is not in alphabetical order! lol It would be SO MUCH easier to blow through the list of what you want to turn on or leave off if they were listed alphabetically. Oh MY .... OCD to the max!! giggle

---

...and it would annoy me no end if they layout boxes were not listed in the order I have set for their sort order, which mirror how they display on the site. layout boxes I am not using I set to right column and a really high sort order number to move them to the bottom of the listing, so the only ones I have turned on are listed first in the order I want them in.

Quote:

---

Originally Posted by barco57

...and it would annoy me no end if they layout boxes were not listed in the order I have set for their sort order, which mirror how they display on the site. layout boxes I am not using I set to right column and a really high sort order number to move them to the bottom of the listing, so the only ones I have turned on are listed first in the order I want them in.

---

I would agree that "losing" the current sort order would be a problem, but perhaps adding the ability to sort by clicking on a header field would be a good mix?

Quote:

---

Originally Posted by balihr

I'm not trying to be rude here, nor am I trying to tell you how to do your business, but I'm trying to think like an average user here. What's the best way to test if a site is responsive or not? Well, just try resizing your browser window and see what happens. Right? What do you think, how many average users out there will know how to override user agent in their browsers to see how their site looks on mobile devices?

---

The average user wont even consider resizing their browser, 1024 x 768 since at least March 2009 is the average desktop screen size only increasing in width and I can't recall flipping my desktop monitor from portrait to landscape. The desktop version of this template is indeed responsive out of box.

For development purposes and "the average user" their are pretty obvious and strategically placed links on the home page to switch views and most modern browsers now provide UA switching.

Quote:

---

Originally Posted by balihr

I'm kindly asking you to make this minor change in the code and use CSS3 media queries to show/hide the mobile menu, instead of triggering it based on user agent. I'm sure it will help a lot of average users (or at least make them look professional enough)... Don't think about me and what I can do to change it - personally, I won't be using that template at all -

---

I personally think instead of changing the code from UA to CSS media queries a admin switch might be more sufficient to allow one to choose whether or not they want the mobile menu to display in desktop view.

Quote:

---

Originally Posted by balihr

I have my own template as starting point based on Bootstrap, I have never been a fan of Foundation... Think about all the other users who have no idea how to do it... :wink:

---

Just an FYI, this template isn't based on Foundation at all.

As always, just my #2cents

I am not referring to how they look after you put a sort order in... I am referring to the generic, out of the box (pun intended) listing order with everything set at 0. I like Chad's idea about maybe putting a link to sort alphabetically for those with OCD like me! :shocking:

Quote:

---

Originally Posted by barco57

...and it would annoy me no end if they layout boxes were not listed in the order I have set for their sort order, which mirror how they display on the site. layout boxes I am not using I set to right column and a really high sort order number to move them to the bottom of the listing, so the only ones I have turned on are listed first in the order I want them in.

---

Quote:

---

Originally Posted by rbarbour

The desktop version of this template is indeed responsive out of box.

---

No, it's not. It's mobile-friendly, just as if it were using a separate mobile template. If it were responsive, it would have at least a basic navigation menu when browser window is reduced. If it hides the top menu, and doesn't show a replacement unless a mobile device is detected, it doesn't quite fit the term "responsive". After all, why hide the main one then? :wink:

Quote:

---

Originally Posted by rbarbour

For development purposes and "the average user" their are pretty obvious and strategically placed links on the home page to switch views and most modern browsers now provide UA switching.

---

I've seen quite a few users doing a "split view" while managing orders or handling customers on the phone. Left half of the screen is showing the admin, and the right side is showing the front end. Some people don't maximize their windows (for whatever reasons) and this is where problems MIGHT occur.

Quote:

---

Originally Posted by rbarbour

I personally think instead of changing the code from UA to CSS media queries a admin switch might be more sufficient to allow one to choose whether or not they want the mobile menu to display in desktop view.

---

Uhm... But why? How does the store owner know if the customer will resize browser window?

Can anyone please tell me why it would be so wrong to hide the mobile menu instead of using the UA trigger? I'm not asking for a core file change, just a simple something that might be of real use... And, except for a 0.01 seconds extra load time, what are the downsides of my idea?

Quote:

---

Originally Posted by rbarbour

Just an FYI, this template isn't based on Foundation at all.

---

Yeah, I noticed that AFTER posting, but who cares... :smile: I took a real quick look, saw it wasn't bootstrap and said foundation because I remember reading somewhere it was gonna use foundation... Irrelevant...

IMHO, the only downside is the insignificant extra server load, whilst the potential usability really does exist. The only thing that really surprises me here is that no one is giving any cons for the idea, but are still treating it as a bad one and refusing to accept it. :( But, OK, so be it - I won't push this any more since I'm not even gonna be using it, I was just trying to help the community with a constructive idea...

Your point of view is valid but circumstantial.

Not having a "mobile button" in the viewport of the desktop version doesn't discredit it from being responsive. Again my #2cents as well as all the Google docs on responsive web design.

Maybe the idea isn't being rejected at all but the way it was presented is why its not being even addressed. Instead of criticizing what "should" be in your opinion a mere suggestion would have been taken and responded to with a more constructive answer.

Quote:

---

Originally Posted by lat9

Another question: Looking through /zc_install/sql/updates/mysql_update_zencart_155.sql (which is a utf8 w/o BOM encoded file), there are a couple of updates of the form:

Code:

---

UPDATE countries set countries_name = 'Åland Islands' where countries_iso_code_3 = 'ALA';
UPDATE countries set countries_name = 'Réunion' where countries_iso_code_3 = 'REU';
UPDATE countries set countries_name = "Côte d'Ivoire" where countries_iso_code_3 = 'CIV';

---

Won't those non-ASCII (and utf8-encoded) country names get mangled if the store-being-upgraded uses a latin1 collation?

---

Yes. All the more incentive for them to convert their db to utf8 ;)

Quote:

---

Originally Posted by mc12345678

admin/attributes_controller.php
header not updated to reflect Changed in ZC 1.5.5.

(FYI, Let me know if I need to stop identifying these because some other "search" or "final edit" is going to be done for such "changes".)

---

Yes, we plan to do a mass "file stamping" before release, for changed files.

Quote:

---

Originally Posted by lat9

Within the classic_responsive/jscript directory, there are a bunch of minimized javascript files

1. jscript_matchHeight.min.js
2. jquery.mmenu.min.all.js
3. jquery.mmenu.fixedelements.min.js

Having the unminimized versions, too, will be a big help ... just in case anything "goes funky".

---

Quote:

---

Originally Posted by picaflor-azul

If you do a search for the jscripts you will find the links to their sites which have un minimized versions of the scripts.

Thanks,

Anne

---

Quote:

---

Originally Posted by lat9

That's all well-and-good, but other than the jquery.mmenu.min.all.js, there's no version number in the minimized script. It's certainly going to make life easier to debug in the future if the unminimized versions were simply part of the distribution.

---

Quote:

---

Originally Posted by picaflor-azul

I have just submitted the un minimized versions of the scripts to be included in the distribution ;)

Thanks,

Anne

---

Now included.

Quote:

---

Originally Posted by mc12345678

includes\templates\template_default\templates\tpl_account_history_info_default.p hp

...
within a for loop, which could cause a validation issue:
Line 42 changed from:

Code:

---

      echo '<ul id="orderAttribsList">';

---

To the more acceptable:

Code:

---

      echo '<ul class="orderAttribsList">';

---

Haven't looked to see if the CSS changed accordingly or needed to (from #orderAttribsList to .orderAttribsList)...

---

In v155 it's using a class ... so, I'm not sure what you're trying to say here.

Quote:

---

Originally Posted by DrByte

Yes, we plan to do a mass "file stamping" before release, for changed files.

---

Quote:

---

Originally Posted by DrByte

In v155 it's using a class ... so, I'm not sure what you're trying to say here.

---

In some regards related to the above, because the header of the file was not updated for the beta, I was 1) flagging a "change" that was not yet identified as a change. And 2) indicating that there is a possible change to css commands necessary for this version. Figured if I didn't get to doing the review, maybe someone else would. While a minor impact, it does also mean that other templates to be used with this version of ZC may need some minor tweaking to account for that change.

I would say, if anything that perhaps documentation of the template "flag" change would help other perspective template developers. I know, get too detailed and will miss something, too broad and the masses are unhappy. :)

Duplicate Post Deleted. Intermittent slow internet connection. Sorry.

Quote:

---

Originally Posted by mc12345678

Also, great that can navigate away from the home page to do other things, though if "needed" to verify home page information and the information was not available for the initial setup, then there does not appear to be a way to "set aside" the initial setup wizard to see how the home page is "coming along". Maybe set the information as a clickable link in the top of the screen (message) after initial display perhaps after initial display per login? (SESSION)

---

If you're complaining that one must fill in the settings in order to see the normal home page, then yes, that is intentional ... so that you do fill in that info.
If you're asking for a way to "let someone else, like the storeowner, fill that in later", then you can simply go into the Configuration->My Store area and blank out the store name or the store owner ... and the wizard will then automatically display again on the home page, prompting for setup.

Quote:

---

Originally Posted by DrByte

If you're complaining that one must fill in the settings in order to see the normal home page, then yes, that is intentional ... so that you do fill in that info.
If you're asking for a way to "let someone else, like the storeowner, fill that in later", then you can simply go into the Configuration->My Store area and blank out the store name or the store owner ... and the wizard will then automatically display again on the home page, prompting for setup.

---

Would say complain is a strong word in this regards... Had an initial observation and considered the various impacts. It really is great to see such functionality added to the store side versus the install side. And now a developers workaround has been identified: temporarily fill in information if it is needed to see past the "registration" screen and clear some of that info when ready to get the store owner on board. Nice...

Quote:

---

Originally Posted by DrByte

Yes. All the more incentive for them to convert their db to utf8 ;)

---

Wouldn't it be nicer to simply use the HTML entities for those characters in the upgrade script (e.g. Réunion instead of Réunion) rather than making the future update to UTF8 more difficult?

Quote:

---

Originally Posted by mc12345678

While a minor impact, it does also mean that other templates to be used with this version of ZC may need some minor tweaking to account for that change.

I would say, if anything that perhaps documentation of the template "flag" change would help other perspective template developers. I know, get too detailed and will miss something, too broad and the masses are unhappy. :)

---

Fair. Those id/classes were never mentioned in the default/supplied css files.

Quote:

---

Originally Posted by mc12345678

Okay.. Sorta tough to read through the documentation when there doesn't appear to be any?

the install.txt file in the root says (areas related to the documentation highlighted in red):

---

When using the github "download the zip" button, a number of dev-only things are excluded, including the /docs/ folder.
You can access the docs folder directly in github (to get latest updates in real time), or at www.zen-cart.com/docs (which will be updated when v155 is fully released)

Quote:

---

Originally Posted by mc12345678

includes/classes/order.php
generation of a database table id is not collected for potential use before initiating a notify action. lines 888-890.

Code:

---

          zen_db_perform(TABLE_ORDERS_PRODUCTS_ATTRIBUTES, $sql_data_array);

          $this->notify('NOTIFY_ORDER_DURING_CREATE_ADDED_ATTRIBUTE_LINE_ITEM', $sql_data_array);

---

The $sql_data_array is added to the table Orders Products Attributes, but the position of that addition is not immediately captured and could be lost in the initiation of the notify.

Earlier in the code a similar addition is performed at lines 802-804:

Code:

---

      zen_db_perform(TABLE_ORDERS_PRODUCTS, $sql_data_array);

      $order_products_id = $db->Insert_ID();

      $this->notify('NOTIFY_ORDER_DURING_CREATE_ADDED_PRODUCT_LINE_ITEM', array_merge(array('orders_products_id' => $order_products_id), $sql_data_array));

---

suggest the same type of designation and assignment:

Code:

---

          zen_db_perform(TABLE_ORDERS_PRODUCTS_ATTRIBUTES, $sql_data_array);

          $order_products_attributes_id = $db->Insert_ID();

          $this->notify('NOTIFY_ORDER_DURING_CREATE_ADDED_ATTRIBUTE_LINE_ITEM', array_merge(array('orders_products_attributes_id' => $order_products_attributes_id), $sql_data_array));

---

It would seem that though the additional assignment would not be necessary for discovery of the same information in the table (ie. the database table can be searched for successful addition of the $sql_data_array), it is inconsistent with the guidelines and suggestions of the forum for design by NOT collecting the insertion id before performing an action against the $db variable/the database table before collecting that new number and is inconsistent with code a few lines back...

FWIW, this was also posted previously as a code suggestion.

---

https://github.com/zencart/zencart/pull/692/files

Quote:

---

Originally Posted by DrByte

When using the github "download the zip" button, a number of dev-only things are excluded, including the /docs/ folder.
You can access the docs folder directly in github (to get latest updates in real time), or at www.zen-cart.com/docs (which will be updated when v155 is fully released)

---

Super! (On the availability of the docs in github as I didn't go back to see if they were there o not after that minor discovery.) Certainly would like to at least leaf through them to see if there are any obvious issues. And really look forward to the updated docs online at least those similar to: http://www.zen-cart.com/docs/phpdoc-1-5-0/

Otherwise I can continue to search through the github version of ZC when I'm away from a computer.

Quote:

---

Originally Posted by mc12345678

So far during install have also noticed that there is nothing indicating what version this install is to provide...

---

Done .

Quote:

---

Originally Posted by lat9

Wouldn't it be nicer to simply use the HTML entities for those characters in the upgrade script (e.g. Réunion instead of Réunion) rather than making the future update to UTF8 more difficult?

---

That would be a bad plan ... try adding it to the end of United States on countries and make an order ...

Notice the terrible mess on TEXT emails and the Account History page that it makes ... :lookaroun

Quote:

---

Originally Posted by mc12345678

Came back to revisit this after installing the software, but in tpl_modules_attributes, there is a check/variable called $options_html_id on line 30 that does not appear to be defined in includes/modules/attributes.php nor anywhere else in the code...

Anyone have any ideas why it is there? Won't there be a problem identified that referencing an array that is never created, nor assigned? Maybe not so much an issue with recalling data that hasn't been assigned, but still seems like it could end up being random.

---

Fixed the missing $options_html_id stuff.
https://github.com/zencart/zencart/c...9f8835a1aa32da

Its purpose is to allow for javascript targeting of specific CSS IDs on the page, to allow dynamic update stuff.

Quote:

---

Originally Posted by mc12345678

Developer's tool kit: search of information in an observer using the look-up classes or things in classes files does not provide results... Example, vanilla install, search in look-up classes or things in classes on: products_viewed_counter extends

No results, place the same search criteria in the Look-up in all files entry and the default observer is searched.



DTK: Not sure what's going on, but I expected different results: using the template search (wanted to see if template override files in the modules directory would be searched since not in the dropdown list for that selection). Entered the following search:

params' => 'class="productListing-hea

---

Fixed:
- observers folder is now searched
- the overrides for modules and sidebox templates are now searched
- previous search terms are repopulated (into the same search that was last used)

Quote:

---

Originally Posted by DrByte

Fixed:
- observers folder is now searched
- the overrides for modules and sidebox templates are now searched
- previous search terms are repopulated (into the same search that was last used)

---

Is the admin/includes/classes/observers folder also searched?

psst ... sure he did what are you reading? :lookaroun

oops I didn't ... there isn't one in the /admin/classes

Quote:

---

Originally Posted by Ajeh

That would be a bad plan ... try adding it to the end of United States on countries and make an order ...

Notice the terrible mess on TEXT emails and the Account History page that it makes ... :lookaroun

---

Good point. It's sounding like a store with an existing latin1 database that's looking to upgrade is going to be :censored:.

Not that I'm against going to all-utf8-all-the-time (especially given that most of the payment providers are sending utf8 datastreams that don't record nicely in a latin1 database) ... I'm about to formalize this for any upgrades that I'm asked to do.

Quote:

---

Originally Posted by lat9

Good point. It's sounding like a store with an existing latin1 database that's looking to upgrade is going to be :censored:.

Not that I'm against going to all-utf8-all-the-time (especially given that most of the payment providers are sending utf8 datastreams that don't record nicely in a latin1 database) ... I'm about to formalize this for any upgrades that I'm asked to do.

---

Sounds good to me ... wish everyone would! :cool:

Done

https://github.com/zencart/zencart/c...11d3dc5f50df12

Quote:

---

Originally Posted by balihr

Don't want to be a pain in the a**, but was there any reason why this was ignored? IMHO, an important fix

---

I am probably jumping the gun here (so what else is new? lol) but is it ok to start doing some testing on mods in the plugins section to see if they are going to work with 1.5.5? Or should I wait until 1.5.5 is officially released?

Quote:

---

Originally Posted by stellarweb

I am probably jumping the gun here (so what else is new? lol) but is it ok to start doing some testing on mods in the plugins section to see if they are going to work with 1.5.5? Or should I wait until 1.5.5 is officially released?

---

Nothing wrong with testing them!

The most notable potential compatibility issues are with plugins which change core function files like html_output.php and functions_general.php or functions_lookups.php ... and of course any other files that need merging of changes.

Quote:

---

Originally Posted by bn17311

in mobile template if you click contact us link it takes to you part way down page missing out the store name etc

you wouldnt naturally think to scroll up for store name phone no etc

Attachment 15883

---

Hmmm ... The focus is automatically set to the first field in the form ... which results in partially scrolling the page downward so that the field is visible. It's a bit of a chicken-vs-egg thing ... as it's impossible to know whether the visitor went to the contact-us page to merely see address/phone info vs with the intention of using the contact-us form. Those are kinda difficult stats to collect ... or, at least, I've not seen any to suggest which "default" is the best for most sites.

This functionality has existed in ZC since v1.3 ... and is driven by the brief javascript in /includes/modules/pages/contact_us/on_load_main.js
I suppose one could alter that javascript to behave differently on mobile devices.
Removing the javascript and using the HTML "autofocus" attribute also causes the same "scroll" effect.

Cool - Thanks Chris. I am on it as soon as I get done with this site I am working on. I will also see what I can do about submitting any of them that need to be updated as well.

Quote:

---

Originally Posted by DrByte

Nothing wrong with testing them!

The most notable potential compatibility issues are with plugins which change core function files like html_output.php and functions_general.php or functions_lookups.php ... and of course any other files that need merging of changes.

---

Anne - I am having a problem identifying why the buttons on the login page are being distorted.... see attached

Attachment 15896

Can you help me figure it out? I have looked in stylesheets as well as the tpl_login_default.php to see if there is coding in there that is magnifying them and I just can't find anything.

THANKS!

Quote:

---

Originally Posted by bn17311

on desktop template with right column switched off

sample data - category big linked and mixed product types the add button is hidden slightly

Attachment 15884

bn

---

Fixed .

Quote:

---

Originally Posted by DrByte

Fixed the missing $options_html_id stuff.
https://github.com/zencart/zencart/c...9f8835a1aa32da

Its purpose is to allow for javascript targeting of specific CSS IDs on the page, to allow dynamic update stuff.

---

Looking at the includes/modules/attributes.php changes identified in the above commit, didn't see the "special" case of a dropdown with a single value that results in a radio button instead of a dropdown... Not having tried to use those features, I don't have a suggestion for addressing it, but would certainly want to be sure that one or the other side recognized/addressed that.

Quote:

---

Originally Posted by mc12345678

Looking at the includes/modules/attributes.php changes identified in the above commit, didn't see the "special" case of a dropdown with a single value that results in a radio button instead of a dropdown... Not having tried to use those features, I don't have a suggestion for addressing it, but would certainly want to be sure that one or the other side recognized/addressed that.

---

That is covered too ...

small thing, enabling and disabling products

while browsing categories products you click on red / green button this is what its called

Attachment 15897

Attachment 15898

but when in product i think you could be confused into thinking you are switching product to out of stock or instock rather than enable / disable

Attachment 15899

unless there is a reason for this. if they do the same job call them the same

bn

Quote:

---

Originally Posted by Ajeh

That is covered too ...

---

Well, I guess I meant there is no "unique" consideration for that condition...

Code:

---

$options_html_id[] = 'drp-attrib-' . $products_options_names->fields['products_options_id'];
                    $options_menu[] = zen_draw_radio_field('id[' . $products_options_names->fields['products_options_id'] . ']', $products_options_value_id, 'selected', 'id="' . 'attrib-' . $products_options_names->fields['products_options_id'] . '-' . $products_options_value_id . '"') . '<label class="attribsRadioButton" for="' . 'attrib-' . $products_options_names->fields['products_options_id'] . '-' . $products_options_value_id . '">' . $products_options_details . '</label>' . "\n";

---

Maybe a drprad setting? Therefore the "handler" can determine which way to go with it? Treat it as a radio button or treat it as a dropdown?

Oh and sorry for any # symbols in the above code. Happens typically when I copy on cell phone from github to post. I doubt I can get them all out once posted and then tryng to edit.

minor thing in configuration maximum values most items have a better description for title except these

Products on Special
New Products Module
Upcoming Products

bn

Quote:

---

Originally Posted by bn17311

small thing, enabling and disabling products

while browsing categories products you click on red / green button this is what its called

Attachment 15897

Attachment 15898

but when in product i think you could be confused into thinking you are switching product to out of stock or instock rather than enable / disable

Attachment 15899

unless there is a reason for this. if they do the same job call them the same

bn

---

If the product listings screen for the in-stock/out-of-stock message is changed, I believe it would also have to be changed on each of the product type data entry screens... In otherwords currently these sets of words match the other respective use/location areas.

Quote:

---

Originally Posted by stellarweb

Anne - I am having a problem identifying why the buttons on the login page are being distorted.... see attached

Attachment 15896

Can you help me figure it out? I have looked in stylesheets as well as the tpl_login_default.php to see if there is coding in there that is magnifying them and I just can't find anything.

THANKS!

---

What is the link to the page?

Thanks,

Anne

Quote:

---

Originally Posted by mc12345678

If the product listings screen for the in-stock/out-of-stock message is changed, I believe it would also have to be changed on each of the product type data entry screens... In otherwords currently these sets of words match the other respective use/location areas.

---

you lost me there ...

but when editing a product it says in stock or out of stock, but if you click either it enables or disables

if thats the way its meant to be thats ok, but for me i have plenty of products on my site out of stock but don't want them switched off

bn

Quote:

---

Originally Posted by picaflor-azul

What is the link to the page?

Thanks,

Anne

---

Anne, I think that the issue appears whenever someone chooses to use image-buttons instead of CSS buttons on the responsive template.

Quote Originally Posted by bn17311 View Post
on desktop template with right column switched off

sample data - category big linked and mixed product types the add button is hidden slightly

Attachment 15884

bn

Quote:

---

Originally Posted by DrByte

Fixed .

---

confirmed now working here

bn

Quote:

---

Originally Posted by lat9

Anne, I think that the issue appears whenever someone chooses to use image-buttons instead of CSS buttons on the responsive template.

---

You can add this to line 77 of the stylesheet.css:

Code:

---

height:auto;width:auto;

---

I'll get the change submitted.

Thanks,

Anne

Quote:

---

Originally Posted by bn17311

minor thing in configuration maximum values most items have a better description for title except these

Products on Special
New Products Module
Upcoming Products

bn

---

I hate to be lame here ... but you are in the Maximum Values of the configuration settings ... you have:
Products on Special

If you click it you see:

Quote:

---

Products on Special
Number of products on special to display

---

What additional words would you suggest? :lookaroun

Quote:

---

Originally Posted by picaflor-azul

You can add this to line 77 of the stylesheet.css:

Code:

---

height:auto;width:auto;

---

I'll get the change submitted.

Thanks,

Anne

---

Committed.

I also noticed that the buttons on the product listing page and product page get enlarged as well. This is using the classic responsive template and uploading buttons that are different than the "out of the box" buttons that come with Zen Cart. The index.php?main_page=shopping_cart page shows them absolutely perfectly.

Here is a link to the site http://learnaboutfengshui dot com /155

WHOO HOO!! That worked!

:hug:

Quote:

---

Originally Posted by picaflor-azul

You can add this to line 77 of the stylesheet.css:

Code:

---

height:auto;width:auto;

---

I'll get the change submitted.

Thanks,

Anne

---

Quote:

---

Originally Posted by Ajeh

I hate to be lame here ... but you are in the Maximum Values of the configuration settings ... you have:
Products on Special

If you click it you see:


What additional words would you suggest? :lookaroun

---

i was just thinking similar to the other formats

so the new products listing is

New Products Listing- Number Per Page

the featured product listing is

Maximum Display of Featured Products Page

and the all products is

Maximum Display of Products All Page

so just having products on special was not as clear as

Maximum Display of Specials Product Page or Special Products Listing- Number Per Page

and New Products Module not as clear as

New Products Centre Box - Number Per Page

or

Maximum Display of New Products - Centre Box

bn

the 2 boxes are slightly different sizes and change depending on screen size

Attachment 15900

Attachment 15901

bn

Quote:

---

Originally Posted by bn17311

the 2 boxes are slightly different sizes and change depending on screen size

Attachment 15900

Attachment 15901

bn

---

What pages are you seeing these on?

Thanks,

Anne

Quote:

---

Originally Posted by picaflor-azul

What pages are you seeing these on?

Thanks,

Anne

---

hi,

its on the product info page

bn

Responsive template, no additional plugins, possibly a day or two old installation, but didn't find comment on the issue in this thread.

meta name for author in the header is not ended properly:

Code:

---

<meta name="author" content="">

---

I removed the content between the quotes, but that is properly populated, the issue is that it doesn't resolve to:

Code:

---

<meta name="author" content="" />

---

Sorry for stopping there on the research with only reporting the issue and not a fix. No other template(s) installed, no modifications loaded (other than was testing the init_canonical modifications suggested on another thread and started looking at the source code to find this issue).

Also, two "errors" reported in validation, though have also seen "on the internet" that it may not really be an issue...

required attribute "type" not specified for both areas.

Code:

---

<script> if (typeof zcJS == "undefined" || !zcJS) {  window.zcJS = { name: 'zcJS', version: '0.1.0.0' }; };  zcJS.ajax = function (options) {  options.url = options.url.replace("&amp;", "&");  var deferred = $.Deferred(function (d) {      var securityToken = 'obscured to not publicly post an SID';      var defaults = {          cache: false,          type: 'POST',          traditional: true,          dataType: 'json',          timeout: 5000,          data: $.extend(true,{            securityToken: securityToken        }, options.data)      },      settings = $.extend(true, {}, defaults, options);

---

Where the initial <script> does not have a type assigned to it.

Same issue at bannerSix for the following "advertisement?" which would be a database population issue I believe not so much a "code" issue.

Code:

---

<!--bof- banner #6 display --> <div id="bannerSix" class="banners"><script><!--//<![CDATA[    var loc = '//pan.zen-cart.com/display/group/1/';    var rd = Math.floor(Math.random()*99999999999);    document.write ("<scr"+"ipt src='"+loc);    document.write ('?rd=' + rd);    document.write ("'></scr"+"ipt>"); //]]>--></script></div> <!--eof- banner #6 display -->

---

Quote:

---

Originally Posted by mc12345678

Responsive template, no additional plugins, possibly a day or two old installation, but didn't find comment on the issue in this thread.

meta name for author in the header is not ended properly:

Code:

---

<meta name="author" content="">

---

I removed the content between the quotes, but that is properly populated, the issue is that it doesn't resolve to:

Code:

---

<meta name="author" content="" />

---

Sorry for stopping there on the research with only reporting the issue and not a fix. No other template(s) installed, no modifications loaded (other than was testing the init_canonical modifications suggested on another thread and started looking at the source code to find this issue).

Also, two "errors" reported in validation, though have also seen "on the internet" that it may not really be an issue...

required attribute "type" not specified for both areas.

Code:

---

<script> if (typeof zcJS == "undefined" || !zcJS) {  window.zcJS = { name: 'zcJS', version: '0.1.0.0' }; };  zcJS.ajax = function (options) {  options.url = options.url.replace("&amp;", "&");  var deferred = $.Deferred(function (d) {      var securityToken = 'obscured to not publicly post an SID';      var defaults = {          cache: false,          type: 'POST',          traditional: true,          dataType: 'json',          timeout: 5000,          data: $.extend(true,{            securityToken: securityToken        }, options.data)      },      settings = $.extend(true, {}, defaults, options);

---

Where the initial <script> does not have a type assigned to it.

Same issue at bannerSix for the following "advertisement?" which would be a database population issue I believe not so much a "code" issue.

Code:

---

<!--bof- banner #6 display --> <div id="bannerSix" class="banners"><script><!--//<=!=[=C=D=A=T=A=[    var loc = '//pan.zen-cart.com/display/group/1/';    var rd = Math.floor(Math.random()*99999999999);    document.write ("<scr"+"ipt src='"+loc);    document.write ('?rd=' + rd);    document.write ("'></scr"+"ipt>"); //]=]=>--></script></div> <!--eof- banner #6 display -->

---

---

Those are all just discrepancies between HTML5 vs XHTML4.
Debating whether to aggressively force the whole template to HTML5 or not ...

Quote:

---

Originally Posted by DrByte

Those are all just discrepancies between HTML5 vs XHTML4.
Debating whether to aggressively force the whole template to HTML5 or not ...

---

FWIW..

+1 vote for HTML5..

IJS.. :laugh:

Quote:

---

Originally Posted by DivaVocals

+1 vote for HTML5..

---

That makes it +2 :D

Quote:

---

Originally Posted by bn17311

the 2 boxes are slightly different sizes and change depending on screen size

Attachment 15900

Attachment 15901

bn

---

Quote:

---

Originally Posted by picaflor-azul

What pages are you seeing these on?

Thanks,

Anne

---

Quote:

---

Originally Posted by bn17311

hi,

its on the product info page

bn

---

What screen resolutions are you seeing this on?

Thanks,

Anne

Quote:

---

Originally Posted by picaflor-azul

What screen resolutions are you seeing this on?

Thanks,

Anne

---

hi

the boxes seem to change depending on screen size also out slightly on iPad

i have resized browser and done screenshot if it helps

bn

Quote:

---

Originally Posted by picaflor-azul

What screen resolutions are you seeing this on?

Thanks,

Anne

---

iPad

bn

Quote:

---

Originally Posted by bn17311

hi

the boxes seem to change depending on screen size also out slightly on iPad

i have resized browser and done screenshot if it helps

bn

---

It looks like you've turned off Admin->Configuration->Layout Settings->CSS Buttons. Is that intentional?

Quote:

---

Originally Posted by DrByte

It looks like you've turned off Admin->Configuration->Layout Settings->CSS Buttons. Is that intentional?

---

hi i was just trying this code change

Quote:

---

Originally Posted by picaflor-azul

You can add this to line 77 of the stylesheet.css:

Code:

---

height:auto;width:auto;

---

I'll get the change submitted.

Thanks,

Anne

---

but doesn't matter if on or off the boxes seem to resize

bn

Quote:

---

Originally Posted by DrByte

It looks like you've turned off Admin->Configuration->Layout Settings->CSS Buttons. Is that intentional?

---

screenshot with css buttons back on

bn