[Closed] FEEDBACK ON BETA of v1.5.5

[lat9]

Fixed:
- observers folder is now searched
- the overrides for modules and sidebox templates are now searched
- previous search terms are repopulated (into the same search that was last used)

Is the admin/includes/classes/observers folder also searched?

[Ajeh]

psst ... sure he did what are you reading?

oops I didn't ... there isn't one in the /admin/classes

[lat9]

That would be a bad plan ... try adding it to the end of United States on countries and make an order ...

Notice the terrible mess on TEXT emails and the Account History page that it makes ...

Good point. It's sounding like a store with an existing latin1 database that's looking to upgrade is going to be .

Not that I'm against going to all-utf8-all-the-time (especially given that most of the payment providers are sending utf8 datastreams that don't record nicely in a latin1 database) ... I'm about to formalize this for any upgrades that I'm asked to do.

[Ajeh]

Good point. It's sounding like a store with an existing latin1 database that's looking to upgrade is going to be .

Not that I'm against going to all-utf8-all-the-time (especially given that most of the payment providers are sending utf8 datastreams that don't record nicely in a latin1 database) ... I'm about to formalize this for any upgrades that I'm asked to do.

Sounds good to me ... wish everyone would!

[wilt]

Done

https://github.com/zencart/zencart/c...11d3dc5f50df12

Don't want to be a pain in the a**, but was there any reason why this was ignored? IMHO, an important fix

[stellarweb]

I am probably jumping the gun here (so what else is new? lol) but is it ok to start doing some testing on mods in the plugins section to see if they are going to work with 1.5.5? Or should I wait until 1.5.5 is officially released?

[DrByte]

I am probably jumping the gun here (so what else is new? lol) but is it ok to start doing some testing on mods in the plugins section to see if they are going to work with 1.5.5? Or should I wait until 1.5.5 is officially released?

Nothing wrong with testing them!

The most notable potential compatibility issues are with plugins which change core function files like html_output.php and functions_general.php or functions_lookups.php ... and of course any other files that need merging of changes.

[DrByte]

in mobile template if you click contact us link it takes to you part way down page missing out the store name etc

you wouldnt naturally think to scroll up for store name phone no etc

Attachment 15883

Hmmm ... The focus is automatically set to the first field in the form ... which results in partially scrolling the page downward so that the field is visible. It's a bit of a chicken-vs-egg thing ... as it's impossible to know whether the visitor went to the contact-us page to merely see address/phone info vs with the intention of using the contact-us form. Those are kinda difficult stats to collect ... or, at least, I've not seen any to suggest which "default" is the best for most sites.

This functionality has existed in ZC since v1.3 ... and is driven by the brief javascript in /includes/modules/pages/contact_us/on_load_main.js
I suppose one could alter that javascript to behave differently on mobile devices.
Removing the javascript and using the HTML "autofocus" attribute also causes the same "scroll" effect.

[stellarweb]

Cool - Thanks Chris. I am on it as soon as I get done with this site I am working on. I will also see what I can do about submitting any of them that need to be updated as well.

Nothing wrong with testing them!

The most notable potential compatibility issues are with plugins which change core function files like html_output.php and functions_general.php or functions_lookups.php ... and of course any other files that need merging of changes.

[stellarweb]

Anne - I am having a problem identifying why the buttons on the login page are being distorted.... see attached



Can you help me figure it out? I have looked in stylesheets as well as the tpl_login_default.php to see if there is coding in there that is magnifying them and I just can't find anything.

THANKS!