looks like a model number.
Printable View
looks like a model number.
s_mack,
Yes, it is a model number.
But I dont think it's supposed be shown....
[1940RY-RB]">
There is a missing tag somewhere...
Is it just my site? Anybody else get this? Is it a zencart bug?
When I click on it I get a zoom. Does that help any?
Thanks for the respond.Quote:
Originally Posted by opentrees
The Zen Light works... even on the review page. that's great.
However, this
[1940RY-RB]">
should not be there. It's an error. Is it just my site?
I should have mention that it is a REVIEW Page.
Thank you,
Quote:
Originally Posted by Alex Clarke
Hi Alex-Quote:
Originally Posted by Alex Clarke
It appears you have made many people happy with your Lightbox mod. I was about to install your version 1.3 mod on Zen Cart 1.36 shop (which already has ImageHandler 2 installed). But I decided to read this entire thread first and then observed the above quotes.
Before I install I am wondering about the specific "tweaking" which needs implemented to "fully" support 1.3.6?
Or should I wait for v.1.4 of your mod which I suspect is just around the corner?
Thank you for any info.
Woody
After looking at the distribution/readme I see it is an easy/quick install so decided to just do it.Quote:
Originally Posted by Woodymon
One thing. The readme instructs to install the 6 gif images and 4 js files into /template_default.
Is there any reason why these files cannot be dropped into my custom template directory instead and therefore override template_default (just like the template file)?
Woody
1. After I found placing the image and js files in my custom directory did not work I put them into template_default and everything works as advertised.Quote:
Originally Posted by Woodymon
(Note: I'm using the tabbed_products lite mod and placing the js files for that mod into the custom directory structure (but not template_default) works.
So hoping for a more informational answer than "don't do it that way because it doesn't work". The more I begin to think I understand overrides, along comes another exception to the rule ;-)
2. A more important issue/question:
When I view the shop with Lightbox installed I observe different results in Firefox 2 on two different PC's (but with IE6 there are no differences). With FF2 on one PC, after I click on the main image (or any one of the additional images) the Lightbox window appears with a white square on top of a black background. However no product images or navigation controls display, In FF2 on the other PC Lightbox displays correctly.
I've cleared my browser cache but same result. FF2 configuration and firewall settings are exactly the same on both PC's
DOM Inspector in FF2 shows no errors. I disabled AdBlock and NoScript but observe same issue. JS is enabled, otherwise the product tabs would not render on the product_info page.
I noted the FF2 Error Console shows:
stylesheet_lightbox.css contains:Quote:
Warning: Error in parsing value for property '-moz-opacity'. Declaration dropped.
Source File: /includes/templates/fz/css/stylesheet_lightbox.css
Line: 112
Warning: Unknown property 'filter'. Declaration dropped.
Source File: /includes/templates/fz/css/stylesheet_lightbox.css
Line: 114
Warning: Error in parsing value for property 'opacity'. Declaration dropped.
Source File: /includes/templates/fz/css/stylesheet_lightbox.css
Line: 117
Warning: Error in parsing value for property 'display'. Declaration dropped.
Source File: /includes/templates/fz/css/stylesheet_lightbox.css
Line: 133
I then checked some other shops posted in this thread which have Lightbox installed and I noted the same issue with Lightbox not displaying correctly in FF2 on this one PC.Quote:
#overlay {
-moz-opacity:0.6px; <--- LN 112
background-color:#000;
filter:alpha(opacity=60); <--- LN 114
height:500px;
left:0;
opacity:0.6px; <-- LN 117
position:absolute;
top:0;
width:100%;
z-index:90;
}
* html>body .clearfix {
display:inline-block; <-- LN 133
width:100%;
}
On the other hand the Error Console shows the exact same errors for these other sites in FF2 on both PC's. (so I conclude we have two different issues going on here).
Any idea why Lightbox would work in FF2 browser on one PC but not the other?
3. BTW when I made an animated gif as one of the additional images, Lightbox displays some strange results and repeatedly rebuilds the image frame ;-)
Woody
I just wrote my first test product review and the resulting product review page:Quote:
Originally Posted by gems14k
(/index.php?main_page=product_reviews&products_id=2)
displays an out of place model number (within brackets with an apostrophe and greater sign symbol appended at the very end). This is the product reviews URL which displays until admin approves the Review. The same as gems14k just reported.
For example:
The model number displays to the left of the product image and under the image the text "larger image" is displayed. Both together form a single URL which links to the product image.Code:[ProductName Model Number]">larger image
Also I see the ALT tag for this link is very strange:
I had not observed this issue before installing the Lightbox mod. But since this was the first review authored, and was authored after the install of Lightbox, I do not know which code might be producing this issue (Lightbox or some other mod or Zen Cart bug or ...)?Code:ProductName<br /><span class=
On the other hand, once the Review is approved by admin, the page:
/index.php?main_page=product_reviews_info&products_id=2&reviews_id=1
displays the "larger image" link correctly along with a correct ALT tag.
But Lightbox did not work on the Reviews page for me. So rereading this thread, I noted s_macks' recommendation on post #204. And indeed after employing his suggestions Lightbox worked on reviews pages.
However the model number still incorrectly displays as part of the "larger image" link (on the Reviews page, that is... until the Review is approved by admin).
Hope this makes sense.
Woody
Thanks for the info, Woody.Quote:
Originally Posted by Woodymon
However, the review on my site is approved, but the error tag is there...
Gems14k:Quote:
Originally Posted by gems14k
I'm think we are in agreement. I will use your site as an example of the issue...
The review page which customers will have access to and see (after the review has been approved) does not display the malformed text in the link.
See here:
http://www.nokoria.com/genuine/index...8&reviews_id=2
But the page the review author will observe immediately after submitting the review and the page the customer will see if review has not been approved does indeed show the malformed text for the link.
See here:
http://www.nokoria.com/genuine/index...roducts_id=358
So what I was trying to say is the error impacts product_reviews but does not impact product_reviews_info.
I observe everything behaves/degrades correctly when JavaScript is disabled.
Looking at tpl_modules_main_product_image.php updated for Lightbox/ImageHandler 2:
Which generates the following HTML on product_reviews page:Code:<!-- begin zen lightbox v1.3 aclarke 2006-10-20 -->
<script language="javascript" type="text/javascript"><!--
document.write('<?php echo '<a href="' . zen_image_lightbox_IH2_url($products_image_large, addslashes($products_name), LARGE_IMAGE_WIDTH, LARGE_IMAGE_HEIGHT) . '" rel="lightbox[gallery]" title="' . addslashes($products_name) . '">' . zen_image($products_image_medium, addslashes($products_name), MEDIUM_IMAGE_WIDTH, MEDIUM_IMAGE_HEIGHT) . '<br /><span class="imgLink">' . TEXT_CLICK_TO_ENLARGE . '</span></a>'; ?>');
//--></script>
<!-- end zen lightbox v1.3 aclarke 2006-10-20 -->
Note:Code:<!-- begin zen lightbox v1.3 aclarke 2006-10-20 -->
<script language="javascript" type="text/javascript"><!--
document.write('<a href="images/rings/1940RY-RB.jpg" rel="lightbox[gallery]" title="Genuine Ruby Band Ring 14K Yellow Gold<br /><span class=\"smallText\">[1940RY-RB]</span>"><img src="images/rings/1940RY-RB.jpg" alt="Genuine Ruby Band Ring 14K Yellow Gold [1940RY-RB]" title=" Genuine Ruby Band Ring 14K Yellow Gold [1940RY-RB] " width="267" height="225" /><br /><span class="imgLink">zoom</span></a>');
//--></script>
<!-- end zen lightbox v1.3 aclarke 2006-10-20 -->
Hopefully this leads you in the right direction.Code:<br /><span class=\"smallText\">[1940RY-RB]</span>">
Woody