Zen Lightbox generates odd HTML on the product reviews page
Not sure why, but the Lightbox add-on is generating some weird/invalid HTML on the product reviews pages. You will see the model number appear in what appears to be some weird link to the left of the product image. You can see what I am speaking of on this page:
http://clientlaserdiscvault(dot)overthehillweb(dot)com/index.php?main_page=product_reviews&products_id=8909
This weird link goes away when I turn off Lightbox.
Without Lightbox turned on this is the HTML created:
Code:
<div id="productReviewsDefaultProductImage" class="centeredContent back">
<div id="productMainImage" class="centeredContent back">
<script language="javascript" type="text/javascript">
<!-- document.write('<a href="javascript:popupWindow(\'http://myclient.com/index.php?main_page=popup_image&pID=8909\')"><img src="images/dasPic_24141.jpg" alt="National Geographic - Secrets of the Titanic [G52000]" title=" National Geographic - Secrets of the Titanic [G52000] " width="349" height="350" />
<br /><span class="imgLink">larger image</span></a>'); //-->
</script>
<noscript>
<a href="http://myclient.com/index.php?main_page=popup_image&pID=8909" target="_blank"><img src="images/dasPic_24141.jpg" alt="National Geographic - Secrets of the Titanic [G52000]" title=" National Geographic - Secrets of the Titanic [G52000] " width="349" height="350" /><br /><span class="imgLink">larger image</span></a>
</noscript>
</div></div>
With Lightbox turned off this is the HTML created (note the mis-behaving HTML created is in red):
Code:
<div id="productReviewsDefaultProductImage" class="centeredContent back">
<div id="productMainImage" class="centeredContent back">
<script language="javascript" type="text/javascript">
<!-- document.write('<a href="images/dasPic_24141.jpg" rel="lightbox-g" title="National Geographic - Secrets of the Titanic<br /><span class=\"smallText\">[G52000]</span>"><img src="images/dasPic_24141.jpg" alt="National Geographic - Secrets of the Titanic [G52000]" title=" National Geographic - Secrets of the Titanic [G52000] " width="349" height="350" /><br /><span class="imgLink">larger image</span></a>'); //-->
</script>
<a href="images/dasPic_24141.jpg" rel="lightbox-g" title="National Geographic - Secrets of the Titanic<br /><span class=" smalltext"="">[G52000]"><img src="images/dasPic_24141.jpg" alt="National Geographic - Secrets of the Titanic [G52000]" title=" National Geographic - Secrets of the Titanic [G52000] " height="350" width="349"><br><span class="imgLink">larger image</span></a>
<noscript>
<a href="http://myclient.com/index.php?main_page=popup_image&pID=8909" target="_blank"><img src="images/dasPic_24141.jpg" alt="National Geographic - Secrets of the Titanic [G52000]" title=" National Geographic - Secrets of the Titanic [G52000] " width="349" height="350" /><br /><span class="imgLink">larger image</span></a>
</noscript>
</div></div>
I found the EXACT same issue with the beta version of the Colorbox add-on as well. (will also post this on the thread for the beta version of Colorbox) You can see the same issue using the Colorbox add-on on this page:
http://clienthairisle(dot)overthehillweb(dot)com/Hair-Extensions/Economy-Collection/Economy-Unprocessed/Indian-Remy-Micro-Thin-Machine-Weft-Virgin-Curly-Texture-3-Oz/reviews?number_of_uploads=0&
Re: Zen Lightbox generates odd HTML on the product reviews page
what is invalid about it? thats the link that makes the lightbox work. note the rel="lightbox-g"
Re: Zen Lightbox generates odd HTML on the product reviews page
Quote:
Originally Posted by
niestudio
what is invalid about it? thats the link that makes the lightbox work. note the rel="lightbox-g"
Please look at the page I referenced.. See the odd text link next to the image??? That's NOT supposed to be there..
This is the incorrect HTML that makes up this link. Please note the text in blue and green.. The text in blue is invalid HTML, and the text in green (looks like the model number) just doesn't belong there at all.
Code:
<a href="images/dasPic_24141.jpg" rel="lightbox-g" title="National Geographic - Secrets of the Titanic<br /><span class=" smalltext"="">[G52000]"><img src="images/dasPic_24141.jpg" alt="National Geographic - Secrets of the Titanic [G52000]" title=" National Geographic - Secrets of the Titanic [G52000] " height="350" width="349"><br><span class="imgLink">larger image</span></a>
Re: Zen Lightbox generates odd HTML on the product reviews page
strange indeed, I'll have a look soon.
Re: Zen Lightbox generates odd HTML on the product reviews page
Quote:
Originally Posted by
niestudio
strange indeed, I'll have a look soon.
and this occurs in BOTH the Zen Lightbox and the beta Colorbox add-ons..
Re: Zen Lightbox generates odd HTML on the product reviews page
More information.. Did a little hunting with the Admin Toolbox and I think I know where the part of the store is being hosed is coming from..
/home2/myhost/public_html/myclient/includes/modules/pages/product_reviews/header_php.php |
Line #42 : $products_name = $review->fields['products_name'] . '<br /><span class="smallText">[' . $review->fields['products_model'] . ']</span>'; |
|
/home2/myhost/public_html/myclient/includes/modules/pages/product_reviews_info/header_php.php |
Line #100 : $products_model = '<br /><span class="smallText">[' . $review_info->fields['products_model'] . ']</span>'; |
|
/home2/myhost/public_html/myclient/includes/modules/pages/product_reviews_write/header_php.php |
Line #119 : $products_model = '<br /><span class="smallText">[' . $product_info->fields['products_model'] . ']</span>'; |
These were the only files I could related to reviews which has code similar to the code that is getting mangled by the lightbox (specifically the reference to the model number). The write reviews page is probably fine since the I do not see the problem manifest itself there, but you never know.. Dunno if this helps narrow things down, but hoping it helps point things in the right direction..
Re: Zen Lightbox generates odd HTML on the product reviews page
Hello all I just installed lightbox on zen 1.5 and I cant see the configuration page in the admin. I'm a noob please help! not sure if i posted in the right spot..
Re: Zen Lightbox generates odd HTML on the product reviews page
Found a temporary solution.
In this file: /includes/modules/pages/product_reviews/header_php.php
I made the following change:
Find line #43-44 and replace with the following.
Code:
// $products_name = $review->fields['products_name'] . '<br /><span class="smallText">[' . $review->fields['products_model'] . ']</span>';
// } else {
Basically I am commenting out the code that Zen Lightbox is mangling which makes the odd/malformed HTML go away. I'm sure the same solution will fix the issue with the Colorbox beta so I'm gonna post this there too..
Quote:
Originally Posted by
DivaVocals
More information.. Did a little hunting with the Admin Toolbox and I think I know where the part of the store is being hosed is coming from..
/home2/myhost/public_html/myclient/includes/modules/pages/product_reviews/header_php.php |
Line #42 : $products_name = $review->fields['products_name'] . '<br /><span class="smallText">[' . $review->fields['products_model'] . ']</span>'; |
|
/home2/myhost/public_html/myclient/includes/modules/pages/product_reviews_info/header_php.php |
Line #100 : $products_model = '<br /><span class="smallText">[' . $review_info->fields['products_model'] . ']</span>'; |
|
/home2/myhost/public_html/myclient/includes/modules/pages/product_reviews_write/header_php.php |
Line #119 : $products_model = '<br /><span class="smallText">[' . $product_info->fields['products_model'] . ']</span>'; |
These were the only files I could related to reviews which has code similar to the code that is getting mangled by the lightbox (specifically the reference to the model number). The write reviews page is probably fine since the I do not see the problem manifest itself there, but you never know.. Dunno if this helps narrow things down, but hoping it helps point things in the right direction..
Re: Make Zen Cart Lightbox Movable
Can someone make the lightbox movable/draggable?
That will be awesome.
New installation--Zen cart 1.5
Hello,
I just installed Zen lightbox v1.6 on a fresh install of ZenCart 1.5
Here is a page that will show you the issue
http://ie-proofs.com/domo-online.com...llon-p-18.html
It will not pull up the images and there is no button to close the popup. I know you can click on it but I thought there would be a close button..
the main problem though is the images are not pulling up, any ideas? Here is my settings
Thanks
Zen Lightbox true
Overlay Opacity 0.8
Overlay Fade Duration 400
Resize Duration 400
Resize Transition false
Initial Width 250
Initial Height 250
Image Fade Duration 400
Caption Animation Duration 400
Display Image Counter true
Close on Image Click true
Close on Overlay Click true
Always show Prev / Next true
Keyboard Navigation true
Close Lightbox 27,88,67
Previous Image 37,80
Next Image 39,78
Gallery Mode true
Include Main Image in Gallery true
EZ-Pages Support true
File Types jpg,png,gif
Close on Overlay Click
If true, the lightbox will close when the overlay is clicked.
Default: false
Date Added: 10/28/2012
Last Modified: 11/01/2012
Designed by Image Excellence
Re: New installation--Zen cart 1.5
It looks like it's probably related to your file names.
Spaces are bad news and special characters are even worse.
you have both: "image (16).png"
http://dailyseotip.com/how-to-name-y...tes-files/648/
Re: New installation--Zen cart 1.5
two questions for you...is Version: 1.6.4_1.5 able to be used still in version 1.3.9h?
secondly...no matter what I do for my clients store, the lightbox has stopped working on the main product image, it still works on the additional images but not the main one.
link:
http://www.pennylanebridal.com.au/sh...roducts_id=249
version: 1.3.9h
template: Oxford Dark by Picaflor Azul
both of you use a jscript so is there a workaround or a way to meld the two together. I can send you both the jscripts if you need.
Re: New installation--Zen cart 1.5
did you try version zlb 1.6.2 to see if it worked with your 1.3.9h site?
Re: New installation--Zen cart 1.5
yes I did and not sure what is going on here. another use of this template says that all their templates work with your lightbox out of box. I even went in and replaced the files in case some got corrupted, uninstalled, then reinstalled and still it refuses to work on main image of product, just the additional ones.
the attached is the settings it has and also the main image opens in regular window but waaaaay small
Re: New installation--Zen cart 1.5
disregard the issue please, maybe her host is a poke a long cause as mysteriously as it started, it is functioning proper right now...not five minutes ago but now it is...lol
thanks