Printable View
Yes Seeing that is what prompted my query. I had visited and quickly scanned the GH page, and also downloaded the zip. However, for the likes of me such wonders are cursed with "many a slip between cup and lip".Quote:
Originally Posted by mc12345678
Are the files on GH the updated and newest files?
If so, their seems to be allot of unnecessary code copied from the slimbox.php file from google groups that is not needed and may cause issues.
That file is generic and the custom options may/may not override options.php (ADMIN Configurations).
I thought the discussion of GH and Zen LightBox got moved to elsewhere. My understanding is that one person setup GH, another had posted the update here on ZC, so not sure (without comparing the two filesets) if they are/were the same. That said, the GH files are there for mod/continued improvement if an issue has/will be identified. Please feel free to evaluate for the issues of concern and contribute back the changes/suggestions.Quote:
Originally Posted by rbarbour
I have used this lightbox for a very long time and the only real problems that have been written about are when the user accidently installs both lightbox and slimbox together, they do not play nice so only one is needed for the store.Quote:
Originally Posted by rbarbour
Aside from that and the occasional corrupt file or missing file I have not had any problems with this mod at all...in my own store or the ones I have installed it on.
Darkangel, if I understand correctly, you are indicating that the Zen LightBox as provided here in ZC has been good; however, in the last couple of days, a "solution" for it working better on mobile devices was proposed. The result of incorporating that appears to have been the incorporation (in full?) of a file into the package. What rbarbour was indicating was that perhaps the included file contains more code than necessary, and may (or may not) be fully compatible with options.php. That is something still to be determined, unless those that proposed the change(s) have already addressed that issue.Quote:
Originally Posted by DarkAngel
Btw, where's that other thread to discuss things like this further?
I did not see a link to another thread or I would have posted their.Quote:
Originally Posted by mc12345678
However, the same code exists in the latest version uploaded to the plugins.
Just making a mere suggestion that this should be re-evaluated. That's all.
You are absolutely right about the extra unnecessary code.Quote:
Originally Posted by rbarbour
I took the zip file posted here, and the comments from others that said "It works!" and blindly committed it to the project.
While it does "work", I do not want to use the eval() method that was used in the responsive "fix".
Today I have been manually un-minifying that code so that I can use basic minified JS instead.
GH has been updated just now, with some code & structure updates. Proceed with caution though, it still needs some testing
Is there a discussion forum or such on GH where we can continue the discussion of GH and Zen LightBox???Quote:
Originally Posted by niestudio
"Issues" I think can be brought up with comments (discussion) associated.Quote:
Originally Posted by DivaVocals
Quote:
Originally Posted by DivaVocals
Check out: https://github.com/niestudio/zen_lightbox/issues/3Quote:
Originally Posted by mc12345678
Thanks!Quote:
Originally Posted by mc12345678
I need help fixing an issue we are currently experiencing on our site with this mod. We are currently using zen_lightbox-v1.6.4a_1.5. If you go here: http://www.clevershoppers.com/index....ducts_id=13478 you will notice the extra garbage ([EI2915]">) on top of the image. If I disable Zen Lightbox, this garbage goes away and everything works as expected. We are also using image handler on our site and I made sure it was installed before Zen Lightbox since Zen Lightbox also share some files with Image Handler (and supposedly included what's needed by Image Handler). Thanks for help me troubleshoot this problem.
I know I had this same problem and it has to do with the model number---that is the garbage you seeQuote:
Originally Posted by BlessIsaacola
I am looking thru my files to find the fix which was somewhere in this forum..several months ago.
forgot to mention that I think it has nothing to do with lightbox or IH either
Thanks for your prompt response. If you find your solution please let me know. I will continue to dig through this thread to see if I find it. The fact that the problem goes away when I disable Zen Lightbox makes me to think it they are somewhat related but perhaps not.Quote:
Originally Posted by DarkAngel
still looking, I usually write down what I find as a "fix" to problems for later looking at but had a slight computer outage not long ago and can find it quickly right nw...
but if I recall it was brought up here or in the IH3 thread and it was found that it was not them but a main file....but as I said that was a couple of months ago and I can't remember/
will be back
I think this is it:
mainly because if you notice it is ONLY in the reviews to read area:
To fix this in the *includes/modules/pages/product_reviews/header_php.php* file
FIND:
---------
if (zen_not_null($review->fields['products_model'])) {
$products_name = $review->fields['products_name'] . '<br /><span class="smallText">[' . $review->fields['products_model'] . ']</span>';
} else {
$products_name = $review->fields['products_name'];
}
---------
REPLACE WITH THIS:
---------
if (zen_not_null($review->fields['products_model'])) {
$products_name = $review->fields['products_name'] . '<br /><span class="smallText">[' . $review->fields']</span>';
} else {
$products_name = $review->fields['products_name'];
}
}
---------
hope it works
Thanks for the post. That did not work. I got a blank page with the following error in the log:Quote:
Originally Posted by DarkAngel
Quote:
[16-Nov-2013 22:05:16 America/New_York] PHP Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in /includes/modules/pages/product_reviews/header_php.php on line 43
try leaving out the very last }
I may have added in an extra one...and make sure you do not remove anything other than what it needs removed
<span class="smallText">[' . $review->fields['products_model'] . ']</span>'; < --- this is the culprit
<span class="smallText">[' . $review->fields']</span>'; <---should look like this so remove the text in red
Quote:
Originally Posted by BlessIsaacola
It's not really an issue with this mod.. It's a minor Zen Cart core code issue that is ILLUMINATED when this mod is activated.. It has been marked as being fixed in v1.6. Solution is in the post below:Quote:
the includes/modules/pages/product_reviews/header_php.php file uses different code to display the product name and model number than the includes/modules/pages/product_reviews_write/header_php.php file. It would appear that the activation of the Zen Lightbox or Zen Colorbox add-ons simply made it easier to spot this difference.
http://www.zen-cart.com/showthread.p...number-display
Thanks! Since basically, we are removing the product_model I tried this which works:Quote:
Originally Posted by DarkAngel
The section of the code above is simply saying, if product_model exist use it and if not, use product name. Since the product_model on the review page is causing issue right now, I basically changed it to just show product name without the product model. It solves the problem I am currently experiencing but hope it didn't create something else but I am not seeing any error in the log at the moment.PHP Code:// if (zen_not_null($review->fields['products_model'])) {
// $products_name = $review->fields['products_name'] . '<br /><span class="smallText">[' . $review->fields['products_model'] . ']</span>';
// } else {
$products_name = $review->fields['products_name'];
// }
Thank you so much for your assistance. You're a GOODAngel :D
Thank you so much! Applied the solution from your link and that worked so the problem is resolved. Also good to know I don't even have to remember when we upgrade to 1.6.0 since the problem is resolved in that version.Quote:
Originally Posted by DivaVocals
Is there a way to display more than one product image?
For example, I have 5 images for one product, how do I show all of these on the products page and/or have them show up in the lightbox?
Thanks,
Leslie
Have a look at this page.Quote:
Originally Posted by lunabug
Once the additional images are added, they appear in Lightbox.
:cool:
or install Image Handler 3 or 4 depending on store version
And none of this is directly related to Zen Lightbox support..
Hi There,
I've already installed this plugin on other zencart websites without any problem and really like this addon! So I installed it on a website I'm currently working on and it's not working properly on this one. The difference here is that I installed it on a template called Responsive Sheffield Blue. This template is not suppose to get in conflict with the plugin. I reinstalled it 3 times but the issue is always there. The pictures are not showing at all on the product page.
Here's a link to the shop: http://www.offroadrescuenetwork.com/salesorn
There's currently 2 products. A red sticker and a cap. The sticker has only one picture and the cap has 3. The pictures are working on the other templates. I unfortunately don't know if they were working before the Zen Lightbox installation because they were upload after the plugin installation. I would need help to find where the problem is.
Hi - I am a new Zen (v 1.51)user and am building my first store for a client. Everything has been going well. I installed Zen Lightbox last night and it works as described, but I have an odd issue. I have lost the footer on my Product Description pages.
http://lemarcinternational.com/mysto...&products_id=1
can anyone offer assistance?
Blank pages or partial blank pages (like yours) indicate an error log has probably been generate.. post the results of your error logs..Quote:
Originally Posted by laquilino68
Thank you for the reply! I am not sure where to find the logs -Quote:
Originally Posted by DivaVocals
The FAQs are your friend.. You should get to know how to use the forum and FAQs to search for info..Quote:
Originally Posted by laquilino68
I took the liberty of highlighting in red the articles related to your reported issue..
Quote:
Search:
Type: FAQs/Articles/Tutorials; Keyword(s): error, log
Search: Search took 0.23 seconds.
- WARNING: An Error occurred, please refresh the page and try again.
- Comments: 0
CMS:
Troubleshooting
- How can I protect my site from malicious attack? Security Recommendations
- Comments: 0
CMS:
Security Matters
- I am getting a blank page (or blank part of a page)
- Comments: 0
CMS:
Quick Start Guide
Thank you! very much - I appreciate you taking the time. I have used the FAQ's for other things, but did not think my solution for this could be found there. I will look it over. Thank you again.Quote:
Originally Posted by DivaVocals
Quote:
Originally Posted by AlexThibo
Have you tried re-uploading the files again just to make sure they are all uploaded or not corrupted...which has been known to happen upon uploading.
If that does not help then remove all files for the lightbox, use the uninstall script to totally uninstall from database and check out to see if the images do indead show in that template.
Also --- cause I don't see it --- what version of shopping cart are you using.
is this the image for the one item:
http://www.offroadrescuenetwork.com/...nt4RNF_MED.jpg
Yes, that's one of the images. Version is 1.5.1.
I reinstalled it 3 times and reupload each times. But I did redownload the files and didn't completely uninstalled the files. I just run the uninstalled SQL. I'll try to completely uninstal and redownload the files and will see. Thanks for your time.
I was wondering, you do see the plugin under the configuration tab in admin right?Quote:
Originally Posted by AlexThibo
If you have installed several times and run the install script each time you may have multiple entries in admin. Run your uninstall sql for each entry you find in admin to really ensure you got it all out of there.
Hope it works and come back to let us know so if it still does not show you can get even better assistance.
If I was to guess, you should double check that the javascript files are in the correct directory, if so, just try uploading those files.Quote:
Originally Posted by DarkAngel
my first guess would be that your template had a custom [includes/templates/[template_name]/templates/tpl_modules_main_product_image.php] and that ZLB overwrote this file.Quote:
Originally Posted by AlexThibo
If that is the case then you'll need to manually merges the changes from that file in ZLB with the file that came with your template.
I'm sorry for the delay. I missed time to check and reply on this problem but really appreciate your help!
I look at this first but the Responsive Sheffield Blue template doesn't include this file. I redownload the complete package of this pluging and reinstalled it without succes.Quote:
Originally Posted by niestudio
So I tried something... I installed it on the classic template, which wasn't modified at all, and it's working as it should. So it eliminates the pluging/files problem. It's definitely on the template side. The problem is that I'm not sure Picaflor Azul, which create the template will be able to help me on this... I think it will be hard to find where the problem is.
Hi
I'm new to Zen Cart but not to programming in general, and would like to share a thought on this problem that may bear some fruit (or not, depending on the root cause). I have read the whole of this topic through and hope I have understood the issue correctly. Egg on face is not my preferred dress code :blush:
One thing I have learnt the hard way, whilst coding with CSS/Javascript and PHP, is that in situations where there is not a strictly moderated structure for css z-index use and where there are many code contributors each with individual coding style, addons like lightboxes tend not to display on a rendered web page because of conflicting CSS manipulations involving z-index [css layers]. There will be no error logs for these in the PHP or Javascript consoles and you will tear out your hair before discovering that the lightbox is exclipsed by another module because of 1 of 2 situations:
1. The conflicting module operates on a higher CSS z-index than the lightbox and therefore hides it unintentionally;
2. The two modules have the same z-index which causes the interesting effect that, depending on which module renders its screen output first, leads to one or the other being eclipsed;
As far as errors go, these are presentational and not programmatic so will not lend themselves to tracing by logs if CSS layer conflicts are the root cause.
The result is the same in either case - so try to dig about in the javascript and CSS to see where the z-index manipulations are taking place and check that the lightbox has a higher z-index than the rest of the site. My own thought is that the CSS Mega Menu merged into Picaflor Azul's templates may be the contributory module as its z-index may be too high and cause the menu layer [which CSS regards as the whole display port] to be in front of the lightbox. Another potential culprit is the Social Networking Sidebar which makes use of CSS layers [z-index, interchangeable]. There are so many possible modules that could cause the problem.
A good technique to trace this type of error is to locate the z-index code for every module using CSS layers and make a list of the module name, pages affected by the module and the z-index of the layers in the module. Once you have done this you will be able to sort the list [use excel] by page and then by z-index and see if the lightbox is eclipsed by any other module with a higher z-index. You will then see what modules to adjust so that the lightbox comes out on top.
I hope these musings can help to locate the cause of the error, if not in your case, it will probably apply to other, similar, scenarios.
BTW: I apologise if there are any typos in this post, but my wireless keyboard batteries are dying and making it hard to type.
Thanks for sharing your experience silver-net-surfer. :smile: I understand what you mean but I'm not sure I understand how and where to locate the z-index for each module. I have the Firebug plugin installed on my firefox browser. Could it help?
But in the case the Zen Lightbox module is under an other one, will it only prevent it to work properly, and not show the popup image? Because currently, no image at all is showed in the product description. See: http://www.offroadrescuenetwork.com/...roducts_id=181 This product has 3 working images
Also, even if I uninstall the Zen Lightbox plugin with running the uninstall SQL lines, the image are still not showing. That another reason why I think the issue is on the template. Probably juste a line that I modified that I don't remember... :(
**delete**
silver-net-surfer makes some valid points and my thought would be the mega menu is the first culprit I would look at as I have had issues with the mega menu and the lightbox (a different issue and adjusting the z-index was indeed the solution)
However you state yourself that the images were not working BEFORE you installed the lightbox, so there is another issue at play, and you need to resolve it before asking for help with this module.. It is UNLIKELY the issue of missing images will be resolved by troubleshooting THIS MODULE since the images were missing BEFORE you installed Zen Lightbox.. It would be a tremendous waste of energy to try and troubleshoot issues fundamentally not related to this module as if this module is the cause (by your own admission.. they were not)
Quote:
Originally Posted by AlexThibo
Alexthibo.
Is the problem on a LIVE site?
If it is, rather than spending time chasing for a solution I would personally take a different approach.
NOTE: You may already have set up a test site and a live site separately, but if not read on.
When I had a problem that I could not figure (not with ZenCart - but same principal), this is what I did.
- Install a second 'testing' copy of the package.
- Configure exactly the same as the live copy - but without any plugins.
- Add a couple of products and test it all works.
- Add first plugin - test
- Add second plugin - test again
- etc until the problem plugin is found or all plugins added successfully.
This should not take long because adding plugin files is simply an upload, and there is no need to edit all the individual files needed for each plugin - just copy them from your live site.
When a problem appears on the site or it breaks you know that the last installed plugin is the culprit and you can check that to ensure it was installed properly.
I did this on a site that had a package with 12 plugins, and the problem showed up on the third one, but even installing them all would have not taken more than an hour.
Of course this all assumes you have access to add a second copy on the server.
NOTE: Use the same database with a different table prefix.
Now I always do 2 installations of a package from day one - it may take a little longer to set up, but it can save a lot of time and trouble if things go wrong.
OR..Quote:
Originally Posted by pewe
simply configure the test site with the Zen Cart test data at the time of the install
Regardless I think it's pretty clear that Alex's issue is NOT this module... He has another fundamental issue going on with his images, and that needs to be resolved before coming to the Zen Lightbox support thread seeking help for an issue that is NOT related to Zen Lightbox.. The issue is not this module at all..
@AlexThibo
I think I found your problem.
Looking at your source code, the img tag is never getting created by the document.write function.
Upon inspection, it's the translation of "larger image" that is breaking the page.
Look in [includes/languages] if there is a french.php file there, or you may have to go into /french and find another file there.
You are looking for:
then change it to:Code:define('TEXT_CLICK_TO_ENLARGE', "Agrandir l'image");
this backslash will escape the apostrophe in l'image and should let the function complete without error.Code:define('TEXT_CLICK_TO_ENLARGE', "Agrandir l\'image");
daniel
Woohoo! Right on Sir!! That was the problem, it's now working!!Thanks a lot!Quote:
Originally Posted by niestudio
It amaze me how you guys can give people so much time and help! I would never find it alone! Thank you a billion times!! And thanks everyone for your time to help, you are all wonderful!! :hug:
Glad to hear it worked!Quote:
Originally Posted by AlexThibo
I have a question for you nie,
I swear I was using your lightbox version 1.6.4 for both 1.3.9 and 1.5.
It quit working properly and my zip disappeared from my computer (had a slight hard drive issue and it ate things. Anyway the zip no longer exists in the plugins and there I find that 1.3+ users still are to use 1.6.2
So had to downgrade what I had.
I know it worked and the name and version were right because I have also installed it into many stores but what happened to that zip in the offerings on your downloads page in plugins -- I know it was there becasue when I looked at the 1.6.4 zip it had the sql exactly as I remembered it.
Just like every add-on ALL historical versions are available for download.. Are you saying you can't find it?? (not clear what you are asking..)Quote:
Originally Posted by DarkAngel
Quote:
Originally Posted by DivaVocals
That's right Diva. The one I used to have before comp ate it was for 1.6.4 v1.39-1.5 and had the sql install script for both of the store versions. The one that is listed now for 1.64 is totally for 1.5---it is a split sql file with 1.5 commented out at the bottom, but it will not work in 1.39h anymore :(
When I removed all files and sql, then reinstalled them my problem was still there
the product images in he description page would not open to the gallery part of LB, the aditional pages when clicked on would not go to LB at all. I had to revert down to 1.62 for the lightbox to fully function.
I tried all variations of the 1.6.4 offering
Unfortunately I don't really remember all the different versions.Quote:
Originally Posted by DarkAngel
Could it have been a zip that was uploaded here in the thread?
I bet that was it...or you pm'd it to me cause i think I was beta testing it at one time.Quote:
Originally Posted by niestudio
I just installed a new paid template . It includes zen lightbox with it. I think it is preventing my attribute image option name is "attribImg" in the code from displaying. I have narrowed it down to lightbox because when I switch back to my original template the attribute image displays.
My store version is 1.5.1
M o z e n Template:
Plugins:
Twitter Updates Sidebox
Zen Lighbox
CSS Dropdown Menu
Flex Slider
I have a screenshot showing the same product (with the New Template vs the Previous Template). At the bottom of the screen shot is a snippet of the code for both I got from using the firefox's Inspect Element Q Feature.
I don't know much about lightbox. I have read through the forums and the documentation but I don't see anything covering this.
The product in the example doesn't have any additional images however I do display a color chart so that the customer can see the available colors; consist of
- Main image Name and sits in: /images/il_570xN.203690455[1].jpg[/I])
- Attribute Image Name and sits in: images/attributes/online_vinylwall_colorchart.jpg
I have spent 1 1/2 days trying to figure out why the attribute image doesn't display. The code shows that the attribImg field does have an image name in it.
I'm assuming I either need to name the files a certain way or have someething turned off that should be on.
Screenshots
I really need help.
Seems there are a lot of not happy comments with that template. The really big problem is that most paid for templates are so altered by the seller that when trying to use an addon from here breaks things.
http://themeforest.net/item/########...50041/comments
You might need to contact them about your problem...if I am wrong then someone will let us both know.
Quote:
Originally Posted by printchic
The original screenshot and sample code was hard to view so I have uploaded again hereQuote:
Originally Posted by printchic
I still cannot read those screenshots.Quote:
Originally Posted by printchic
Try using imgur and then just post a link to them.
Sorry about the images. Here are the links to the updated images;
Screenshot of both templates: http://imgur.com/SbFzmPz
Screenshot of source code viewed through Inspect Element Q in browser: http://imgur.com/gc3zF1z
My lightbox settings: http://imgur.com/BLzjg9L
Much better, thanks.Quote:
Originally Posted by printchic
Is this site online somewhere, or is it locally only?
You said when you switch back to your original template, the chart comes back.
When you disable ZLB with your new template does your color chart come back?
Hi,
It's an online working store. When I turn it off ZLB it still doesn't display. Are attribute images supposed to be in the lightbox with the product image? It seems like that is what is happening.
The main attribute image is called xxx.jpg and then it looks for another xxx_LRG.jpg
I have sent you a private msg.
Right now my webhost has decided to do maintenance. Don't know when they will be back up :(
The fact that it still does not work even when you turn off ZLB indicates that it is not a ZLB issue.Quote:
Originally Posted by printchic
ZLB may work with attribute images, I'm not really sure. But even if it does, it does not remove any images from the page, it just adds some code to them so that they popup into the lightbox.
Hi,
Thanks for all the help. It at least lets me know ZLB is not the culprit. I will go ahead and let the template maker fix it. I didn't want to give them my login info. This morning I just rebuild a copy of the store on a different site so they can look at it.
Thanks again for all your help.
Hi,
I'm using ZC 1.5.1 with Zen Lightbox 1.6.4, and am trying to set up images on an EZ Page. Works wonderfully for the most part except adds a bogus image 1 - there's a PREV button for it, but clicking it results in the lightbox churning forever w/o displaying an image, "close" "PREV" and "NEXT" buttons also disappear, and clicking outside doesn't close the lightbox, either. Here's what I've done, perhaps I missed a step or did something wrong:
On the page, I placed 3 small images (files in "images"):
name.png - linking to images/large/name_LRG.png
name_02.png - linking to images/large/name_02_LRG.png
name_03.png - linking to images/large/name_03_LRG.png
Clicking any of them opens the lightbox with PREV/NEXT buttons working as desired, but all 3 result in a bogus image 1 of 4 (there is no 4th image with a similar file name either in "images" or "images/large"). (You can see the exact behavior at https://allstringsnylon.com/second-b...n-cordoba-15cm .)
How do I fix this, please?
Thank you,
Magz
what are your setting for the lightbox in admin
Quote:
Originally Posted by magz
Hi DarkAngel - previously "Close on Overlay Click" was set to false, now I changed it to true and at least can close the lightbox by clicking outside of it. I tried setting "Include Main Image in Gallery" to false, but instead of eliminating the bogus image on EZ Pages, it broke the display on product pages, so I set it back to true. What other change(s) would you suggest? Thank you! ~ MagzQuote:
Originally Posted by DarkAngel
Attachment 13479
Wellllllll, he settings are alright...but if telling it to not include the main image breaks it then I would "guess" that maybe something did not get uploaded correctly or got corrupted on upload when you uploaded the files...you did manually upload the LB files, right?
I would:
1. open the zip for its contents
2. go to your server files with ftp
then manually upload all the files (not images items) to the corresponding folders from zip to server.
Sometimes the net messes up the files on the upload.
When you installed the SQL did you get any errors?
For what it's worth...I have mine set in admin just like yours even if mine is 1.3.9h store.
Also I forgot this:
When you did the SQL in admin did you include this and remove the red text:
/*
zencart 1.5 mods
*/
INSERT INTO `admin_pages` (`page_key` ,`language_key` ,`main_page` ,`page_params` ,`menu_key` ,`display_on_menu` ,`sort_order`)VALUES
('configZenLightbox', 'BOX_CONFIGURATION_ZEN_LIGHTBOX', 'FILENAME_CONFIGURATION', CONCAT('gID=',@cgi), 'configuration', 'Y', @cgi);
Hi DarkAngel - I misspoke, changing "Include Main Image in Gallery" to false doesn't really *break* anything, just creates an (in my case) undesirable behavior, however it's quite in line with the command and could be quite desirable on another website. I'll reupload all of the LB files just in case that might fix the bogus image issue, although yes I did that manually the first time (in June, I think) and haven't had any other problems with LB before.Quote:
Originally Posted by DarkAngel
The sql file in my install zip contains the code you mentioned. I doubt I removed the /**/ before upload, but the corresponding record exists in my db and appears to be correct.
Can you suggest any change to one of the other files (assuming they're all installed correctly after all)? I can't write code, but I can copy & paste. ;-)
Thank you!
Magz
Hi Magz,Quote:
Originally Posted by magz
You have a hidden section on your page that includes a link to a gift certificates.
ZLB uses a wildcard selector on the page looking for links with "gif" in the url. Yours is "/gift-certificates" so it thinks that it's a link to include in the lightbox.
Thanks for the heads up, I'll make a fix for this in the next release.
There are 2 ways you can fix it yourself right now:
1. If you have no GIF images on your EZ-pages, you can change the EZ page support >file types and remove " ,gif "
2. if you are using gif images on your EZ-pages, you can fix it by opening [includes/modules/pages/page/jscript_zen_lightbox.php]
look for this line (probably around line 25):
and change it to thisCode:$("a[href*='"+item+"']").attr('rel', lightboxType);
the only change is adding that period in between the ' and ". This will tell it to look for links with .gif, thereby not finding your gift-certificates link.Code:$("a[href*='."+item+"']").attr('rel', lightboxType);
let me know if that works for you.
daniel
What other plugins do you have installed? There have been cases where another plugin interferes with ZLB causing issues possibly simliar to this. (One that comes to mind had an effect in viewing the information in the product Reviews area. When Tabbed Products Pro and ZLB were both installed it allowed an issue to be seen.) Not that ZLB didn't function, just that the code associated with both plugins allowed another issue to be discovered. (and corrected)Quote:
Originally Posted by magz
LOL, I am great at copy paste or a go find it once I am told where...and have prefiously edited something along the same lines...LOL
Reinstalling it first will let us know if it is file specific. Did you try changing to the default template to see if it still misbehaves there and another thing...
did you install/uninstall/any changes anything prior to the misbehaving LB
Thank you Daniel, this fixed it! (#1, using png sitewide...)Quote:
Originally Posted by niestudio
Magz
I had zen lightbox working then I decided to try zen_magnific_1.5. Now zen lightbox doesn't work. Are they compatible? I installed some other mods in between, so I am not sure of anything. I am using zencart 1.5.1. I have tried uninstalling both add-ons and reinstalling zen lightbox, but it still only pops up in na old-fashioned popup window.
Not sure about zen magnific. Since you installed outher things as well, I'd suggest just restoring to your backup and then install one at a time to track things down.Quote:
Originally Posted by tpeck
Both these plugins alter the modules/additional_images.php and templates/tpl_modules_main_product_image.php and should not be used together.Quote:
Originally Posted by niestudio
Zen Magnific is very light weight, 100% responsive, has some downfalls like all the admin configurations. You should choose one or the other.
Hello,
This Zen Lightbox problem was mentioned before in this thread without an actual advice on how to fix.....
"The problem is that from my cell-phone, if I try to zoom-in on the picture it moves on the screen to the right side, and if I move the page around, the image also moves (it keeps snapping to the right hand side of the cell phone screen hiding the right side of the image), so I can't "catch" the close button."
Any help would be greatly appreciated.
Thanks!!
The latest version relatively addresses this issue by not opening the picture larger than the mobile device. Otherwise, you can change the setting to make the photo diappear if clicking on the outer box. (An option I chose when the image always had to be "chased" to close.)Quote:
Originally Posted by willy12
Beyond that, at this time, there does not appear to be any other solution. Perhaps with the newer responsive templates, something like this could be addressed, but in the mean time that appears to be all.
Not mentioned anymore because as mc12345678 stated, it was resolved in the latest version of ZLB.. Are you using the latest version of ZLB?? If so are you saying that the code to address the issue ISN'T working for you?? Can you provide link to your site?Quote:
Originally Posted by willy12
which SOLVES the problem.. Not sure why there would need to be an ADDITIONAL solution..Quote:
Originally Posted by mc12345678
The latest version for ZenCart version 1.3.9h.Quote:
Originally Posted by DivaVocals
I compared the code of the ZLB for the 1.5 ZenCart versions (not many changes in it, more additions than anything it seems) and merged them and it still wouldn't work. I have been checking on iPhone and it doesn't work, don't know if it works on Android.
Site is Aquafinatic.com
Thank you for taking the time.
I believe that the problem being referred to by Willy12 is in relation to 'enlarging' the image once opened in the Lightbox.Quote:
Originally Posted by DivaVocals
Say a visitor wanted to see more detail in the image so using 'pinch' they enlarge the lightbox to see a bigger image, in doing so the lightbox does disappear to the right off the screen (on Android too) and cannot be moved around - or closed as the 'close' button is off the screen.
Quote:
Originally Posted by DivaVocals
Quote:
Originally Posted by willy12
Quote:
Originally Posted by pewe
So, I would agree that it solves the problem of initially having to chase/find the close button because the image opens to within the screen, but as pewe describes the issue still occurs that if the image is zoomed in on once the ZLBed image is displayed, then it does move around; however... By returning to the normal zoom level the image is again displayed in the correct location with the close button relatively accessible.
Looking at the site associated with the above, the images are being displayed as expected for the latest version on a mobile device.
The discussion of there being more code rather than less, why of course... That is the way of developing functionality, I don't know why anything else would be expected. Surprisingly it is the small amount of code changes that can give such a large difference.
If there is a "need" to zoom in yet further than provided by ZLB, then perhaps there is some other magnifying app that can be used off of the ZLB result to see more up close?!
This is all on point.Quote:
Originally Posted by mc12345678
The zoom is the issue after the ZLB shows the image. If there is something that can make you view it more up close or zoom in closer after ZLB displays it that would be great, as the phone displays are so small and it's really needed.
I'm sorry I forgot to mention, that it would also be great to just zoom in on the ZLB image and it would stay in the center of the screen. Probably easier too.Quote:
Originally Posted by willy12
Right.. and this was not very clear from the original post.. It was stated that this was resolved in the latest version of ZLB.Quote:
Originally Posted by pewe
Because the issue being reported wasn't clear, and I was answering in a hurry, I mistakenly agreed with this. The issue is resolved with the Colorbox module. As it turns out the issue of ZLB NOT behaving responsively on mobile devices was not fully resolved. It is resolved in a yet to be released version of Zen Colorbox (NOT the one that is currently in the downloads section)
The beta is available here: https://github.com/daniel-hopkins/zen-colorbox
I understand how developing functionality works.. However, this is actually NOT the question I asked.. Rather I inquired about why more coding was needed if the problem was in fact resolved. As I JUST indicated, the problem is NOT resolved in full with ZLB..Quote:
Originally Posted by mc12345678
Yes.. use the "pinch" feature to enlarge the view on the phone.. This is NOT something that needs to to be included in ZLB's functionality.. Smarthphones and tablets already support this.. However, ZLB does need to be modified to mimic the behavior in Zen Colorbox when using the pinch feature in a smartphone and tablet.. Since niestudio has been the active maintainer for both, he will make this change..Quote:
Originally Posted by willy12
Sorry.. I couldn't correct this typo.. so let me clarify this last part..Quote:
Originally Posted by DivaVocals
Since niestudio has been the active maintainer for both ZLB and Zen Colorbox (beta), perhaps he will make this change..
I have been reading this, but am out of town and haven't been able to look into it yet. Slimbox, which is what ZLB is based on is no longer in active development, so it's unlikely that a true responsive version will come along. I will compare it to ZCB to see if there is a simple fix I could add, but don't hold your breath :)Quote:
Originally Posted by DivaVocals
As I come from under the fog of my holiday celebrations/shenanigans:laugh:, I believe that this is why I selected Zen Colorbox (beta) over Zen Lightbox for my client's who have responsive templates..Quote:
Originally Posted by niestudio
Zen colorbox has been resubmitted a couple times, but now they don't want me to submit it as a new plugin, they wanted me to upgrade one from a few years ago. I've done that, and imagine it will be approved soon.Quote:
Originally Posted by DivaVocals
well that makes sense since your version is newer and improved.. it was going to be my suggestion to you on github..Quote:
Originally Posted by niestudio
Quote:
Originally Posted by niestudio
Besides, seems we've all learned about spawning new package paths and how development can go awry if all that is needed is to carry on down the same path.Quote:
Originally Posted by DivaVocals
Quote:
Originally Posted by DivaVocals
I guess I know better now. I was just looking at it from my point of view, that I never even downloaded that code, so it was not an upgrade of the old one, this one was from scratch. I asked the OD for his blessing to replace ALL of his code with mine, so it's still not really an "upgrade" except from the perspective of the plugins area.Quote:
Originally Posted by mc12345678
well in commercial software a complete rewrite of something with a new version number is still considered an upgrade.. but I hear you and I understand.. I think it's admirable that you were considering the other developer.. just looking forward to seeing the new color box available for the world!
Quote:
Originally Posted by niestudio
This is a brilliant pluggin!! One issue that I have is some of my products have long titles and this can affect some of the smaller images displayed and the spacing between the words and the close button. The words are squashed up against the button and because the image is relatively small, the words are crtammed up underneath each other and it looks pretty bad. I was wondering whether there was a way to adjust the layout in a way that could space the heading slightly better or remove it altogether. I have attached an image so you can see what I mean. In my case it may need the title removing. If someone can tell me where I might alter this I would be very greatful. Attachment 13628
Quote:
Originally Posted by Axeman
Maybe a link to your site would help better so they can go test and see code and all to get better fix on it...but have you tried your stylesheet for the lightbox and setting a size for the font in there? Or shrink width/height of your close button there.
not sure if you could make the entire white area a bit wider in there, I have never tried that but then my images are larger that=n that one...you could try "growing" your images if they are all that small.
I would suggest starting by making your images larger. There isn't much use for the lightbox itself it is only opening images the same size as the thumbnail. Beyond that, you could make adjustments to the css file to adjust the padding, or make a min-width for the whole box. Or even adjust the font size so that it doesn't take up so much space.Quote:
Originally Posted by Axeman
I agree with this suggestion..:yes:Quote:
Originally Posted by niestudio
I have a question I cannot find the answer to. I have a main product image, when open in lightbox it says image 1 of 2. There is not but one picture. What do I do to correct this. Thank you in advance.
Please post a link to your siteQuote:
Originally Posted by countrycharm
This is only my test site....... As you can see there is 11 imagesbut lightbox picks up 12Quote:
Originally Posted by niestudio
What other plugins are installed? There are a few that when installed alongside this one require some javascript modifications. (Posted about a few months ago, sorry haven't gone back to find the specific post(s))Quote:
Originally Posted by countrycharm
Reward PointsQuote:
Originally Posted by mc12345678
Tabbed Products Pro
Edit Orders
CSS/JS Loader
Image Handler 4
Backup Zencart
Ajax Faq
Zen Lightbox