Re: Responsive Sheffield Blue V 2.0!
Quote:
Originally Posted by
jpda
Hi Linda,
Changing 45% to 30% (lines 387 and 413) works but it will mess up the footer layout (if left column is on).
These settings in responsive_default.css overrule the computed setting $col_width in "\includes\modules\responsive_sheffield_blue\product_listing.php", resulting in 32.5% (mostly). Thus deleting them in responsive_default.css will have the same effect as changing them to 32.5% in the .css.
This template has Flexible Footer Menu v1_1 built in which tries to divide the footer according to the number of columns in the footer, which IMHO seems to cause the confict. Version 1_2 and the multi-lingual version use a different way to divide the footer in columns. I did not yet try to remove v1_1 and replace by v1_2.
@Anne: Any plans to use Flexible Footer Menu v1_2 or ML in a future release? Or is there a quick fix available?
Cheers,
jpda
Sorry, I need to correct myself: "but it will mess up the footer layout (if left column is on)" Not true! I made a stupid typo in a stylesheet file! :frusty:
@Anne: Sorry, no quick fix needed!
Cheers,
jpda
Re: Responsive Sheffield Blue V 2.0!
How can I remove Brands from the top header? I am at www.gelcandlecompany.com/demo
I tried looking at includes/templates/responsive_sheffield_blue/templates/tpl_modules_mobile_categories_tabs.php
and found this area but not sure where to disable:
<li class="brands-li"><a href="<?php echo zen_href_link(FILENAME_DEFAULT); ?>" class="drop"><?php echo HEADER_TITLE_MANUFACTURERS; ?></a><!--bof shop by brand -->
<ul >
<?php
$show_manufacturers= true;
Am I looking at the right file?
Re: Responsive Sheffield Blue V 2.0!
Have I missed something? How can I set to 3 columns? I see only 2 at my homepage.
Re: Responsive Sheffield Blue V 2.0!
Quote:
Originally Posted by
brittainmark
Hi Anne, Just started working with your excellent template. Think I have found out what is happening with the tabs. It appears that if the tab has no content then the section is not displayed which causes the Java script to fail. I simply removed the if statement and all works fine now. (just after the "<!-- bof:" and just before the "<!--eof:" statements.
Before
PHP Code:
<!-- bof: specials -->
<?php if ($zc_show_specials == true) { ?>
<section id="section-3">
<div class="centerBoxWrapper" id="specialsDefault">
<?php
/**
* require the columnar_display template to show the products
*/
require($template->get_template_dir('tpl_columnar_display.php',DIR_WS_TEMPLATE, $current_page_base,'common'). '/tpl_columnar_display.php');
?>
</div>
</section>
<?php } ?>
<!-- eof: specials -->
After
PHP Code:
<!-- bof: specials -->
<section id="section-3">
<div class="centerBoxWrapper" id="specialsDefault">
<?php
/**
* require the columnar_display template to show the products
*/
require($template->get_template_dir('tpl_columnar_display.php',DIR_WS_TEMPLATE, $current_page_base,'common'). '/tpl_columnar_display.php');
?>
</div>
</section>
<!-- eof: specials -->
if you remove these lines from the three template files tpl_modules_specials_default.php, tpl_modules_featured_products.php, tpl_modules_whats_new.php, in "includes\templates\responsive_sheffield_blue\templates\" All works fine. (not live yet. Soon hopefully)
Quote:
Originally Posted by
mc12345678
While a good catch (seeing that the javascript fails and finding that the code is trying to act on something that is not on screen) the solution is somewhat bass ackwards... The javascript displayed/sent to the browser should be modified to account for the program controlled non-display of those sections rather than forcing those sections of code to display undesirably.
Javascript is something like an addon to html... If the base page display should be as desired without javascript and then javascript actions/code to build off of it. If there is javascript referencing html that was hidden/not displayed, then that javascript shouldn't be there to reference a non-existent portion of the page.
.
Finally had a chance to revisit this...
To whom it may concern: Does/did the issue only occur if no such tabs are displayed (no featured, special nor new products), or does it occur if any one of the three tabs are not displayed when using the original code? (The sample site shows two tabs active on the main page, but does not appear to have a javascript error.)
Re: Responsive Sheffield Blue V 2.0!
Quote:
Originally Posted by
mc12345678
Finally had a chance to revisit this...
To whom it may concern: Does/did the issue only occur if no such tabs are displayed (no featured, special nor new products), or does it occur if any one of the three tabs are not displayed when using the original code? (The sample site shows two tabs active on the main page, but does not appear to have a javascript error.)
The issue occurs, for example, if in admin>index listing "Show Specials on Main Page" is set to a positive value AND no specials products exist. In tpl_modules_specials_default.php $zc_show_specials is tested, which seems to be true, even if not any special product actually exists. I guess $zc_show_specials is from specials_index.php and seems to be true if $specials_index->RecordCount() > 0, even if no record exists :unsure: .
The same for new and featured products.
The advantage of brittainmark's solution is that there is no need to change the admin settings (new, featured, specials) according to their existence. The disadvantage (a tab is present, even when empty) is acceptable.
Cheers,
jpda
Re: Responsive Sheffield Blue V 2.0!
Quote:
Originally Posted by
spawnie69
How can I remove Brands from the top header? I am at
www.gelcandlecompany.com/demo
I tried looking at includes/templates/responsive_sheffield_blue/templates/tpl_modules_mobile_categories_tabs.php
and found this area but not sure where to disable:
<li class="brands-li"><a href="<?php echo zen_href_link(FILENAME_DEFAULT); ?>" class="drop"><?php echo HEADER_TITLE_MANUFACTURERS; ?></a><!--bof shop by brand -->
<ul >
<?php
$show_manufacturers= true;
Am I looking at the right file?
No need to change tpl_modules_mobile_categories_tabs.php.
Add this line
Code:
ul.slimmenu li.brands-li{display:none;}
in stylesheet.css after line 370.
Cheers,
jpda
Re: Responsive Sheffield Blue V 2.0!
Quote:
Originally Posted by
spawnie69
Have I missed something? How can I set to 3 columns? I see only 2 at my homepage.
You did:smile:
Search this thread and you will find several discussions about this.
Cheers,
jpda
Re: Responsive Sheffield Blue V 2.0!
Quote:
Originally Posted by
jpda
The issue occurs, for example, if in admin>index listing "Show Specials on Main Page" is set to a positive value AND no specials products exist. In tpl_modules_specials_default.php $zc_show_specials is tested, which seems to be true, even if not any special product actually exists. I guess $zc_show_specials is from specials_index.php and seems to be true if $specials_index->RecordCount() > 0, even if no record exists :unsure: .
The same for new and featured products.
The advantage of brittainmark's solution is that there is no need to change the admin settings (new, featured, specials) according to their existence. The disadvantage (a tab is present, even when empty) is acceptable.
Cheers,
jpda
Up front, I'm fine with agreeing to disagree... I find as a customer to other stores that it is almost aggravating that such an option is shown but there is nothing there. In some cases makes me wonder if there is something wrong with my computer/setup because obviously why would a store show an option like that when there is nothing there and it even allows clicking/selecting the tab but nothing happens when clicked? A number of other things come to mind as well.
I guess I'm going to have to setup another template site with this installed to test it out... Seemed to me in only review of the code that it was only an issue if none of them were displayed... May require a modification to the javascript or one or more of the template files, but if nothing else, a feature was "added" to block the display of the tab, only unfortunately it is not currently compatible with another add-on to the template...
Re: Responsive Sheffield Blue V 2.0!
Quote:
Originally Posted by
jpda
No need to change tpl_modules_mobile_categories_tabs.php.
Add this line
Code:
ul.slimmenu li.brands-li{display:none;}
in stylesheet.css after line 370.
Cheers,
jpda
This worked like a charm, many thanks!
I
Re: Responsive Sheffield Blue V 2.0!
Quote:
Originally Posted by
mc12345678
Up front, I'm fine with agreeing to disagree... I find as a customer to other stores that it is almost aggravating that such an option is shown but there is nothing there. In some cases makes me wonder if there is something wrong with my computer/setup because obviously why would a store show an option like that when there is nothing there and it even allows clicking/selecting the tab but nothing happens when clicked? A number of other things come to mind as well.
I guess I'm going to have to setup another template site with this installed to test it out... Seemed to me in only review of the code that it was only an issue if none of them were displayed... May require a modification to the javascript or one or more of the template files, but if nothing else, a feature was "added" to block the display of the tab, only unfortunately it is not currently compatible with another add-on to the template...
I agree! My point was 'acceptable compared to the alternative', i.e. having the js problem whenever one of the new, specials or featured are empty (which occurs automatically w/o notice). The best solution is to change the test in the tpl_modules_*_php files and only show the meaningful tabs.
On the other hand, the links to new, featured and specials in info boxes or footer are always visible (once being activated), whether such products exist or not.
Quote:
unfortunately it is not currently compatible with another add-on
Any idea which add-on could be incompatible?
Cheers,
jpda
