Responsive Sheffield Blue v2.0

[mc12345678]

Hi Anne, Just started working with your excellent template. Think I have found out what is happening with the tabs. It appears that if the tab has no content then the section is not displayed which causes the Java script to fail. I simply removed the if statement and all works fine now. (just after the "<!-- bof:" and just before the "<!--eof:" statements.
Before

<!-- bof: specials -->
<?php if ($zc_show_specials == true) { ?>

                <section id="section-3">
<div class="centerBoxWrapper" id="specialsDefault">
<?php
/**
 * require the columnar_display template to show the products
 */
  require($template->get_template_dir('tpl_columnar_display.php',DIR_WS_TEMPLATE, $current_page_base,'common'). '/tpl_columnar_display.php');
?>
</div>
</section>

<?php } ?>
<!-- eof: specials -->

After

<!-- bof: specials -->

                <section id="section-3">
<div class="centerBoxWrapper" id="specialsDefault">
<?php
/**
 * require the columnar_display template to show the products
 */
  require($template->get_template_dir('tpl_columnar_display.php',DIR_WS_TEMPLATE, $current_page_base,'common'). '/tpl_columnar_display.php');
?>
</div>
</section>


<!-- eof: specials -->

if you remove these lines from the three template files tpl_modules_specials_default.php, tpl_modules_featured_products.php, tpl_modules_whats_new.php, in "includes\templates\responsive_sheffield_blue\templates\" All works fine. (not live yet. Soon hopefully)

While a good catch (seeing that the javascript fails and finding that the code is trying to act on something that is not on screen) the solution is somewhat bass ackwards... The javascript displayed/sent to the browser should be modified to account for the program controlled non-display of those sections rather than forcing those sections of code to display undesirably.

Javascript is something like an addon to html... If the base page display should be as desired without javascript and then javascript actions/code to build off of it. If there is javascript referencing html that was hidden/not displayed, then that javascript shouldn't be there to reference a non-existent portion of the page.
.

[picaflor-azul]

While a good catch (seeing that the javascript fails and finding that the code is trying to act on something that is not on screen) the solution is somewhat bass ackwards... The javascript displayed/sent to the browser should be modified to account for the program controlled non-display of those sections rather than forcing those sections of code to display undesirably.

Javascript is something like an addon to html... If the base page display should be as desired without javascript and then javascript actions/code to build off of it. If there is javascript referencing html that was hidden/not displayed, then that javascript shouldn't be there to reference a non-existent portion of the page.
.

If you have another suggestion, please post it

Thanks,

Anne

[mc12345678]

Hi Anne, Just started working with your excellent template. Think I have found out what is happening with the tabs. It appears that if the tab has no content then the section is not displayed which causes the Java script to fail. I simply removed the if statement and all works fine now. (just after the "<!-- bof:" and just before the "<!--eof:" statements.
Before

<!-- bof: specials -->
<?php if ($zc_show_specials == true) { ?>

                <section id="section-3">
<div class="centerBoxWrapper" id="specialsDefault">
<?php
/**
 * require the columnar_display template to show the products
 */
  require($template->get_template_dir('tpl_columnar_display.php',DIR_WS_TEMPLATE, $current_page_base,'common'). '/tpl_columnar_display.php');
?>
</div>
</section>

<?php } ?>
<!-- eof: specials -->

After

<!-- bof: specials -->

                <section id="section-3">
<div class="centerBoxWrapper" id="specialsDefault">
<?php
/**
 * require the columnar_display template to show the products
 */
  require($template->get_template_dir('tpl_columnar_display.php',DIR_WS_TEMPLATE, $current_page_base,'common'). '/tpl_columnar_display.php');
?>
</div>
</section>


<!-- eof: specials -->

if you remove these lines from the three template files tpl_modules_specials_default.php, tpl_modules_featured_products.php, tpl_modules_whats_new.php, in "includes\templates\responsive_sheffield_blue\templates\" All works fine. (not live yet. Soon hopefully)

While a good catch (seeing that the javascript fails and finding that the code is trying to act on something that is not on screen) the solution is somewhat bass ackwards... The javascript displayed/sent to the browser should be modified to account for the program controlled non-display of those sections rather than forcing those sections of code to display undesirably.

Javascript is something like an addon to html... If the base page display should be as desired without javascript and then javascript actions/code to build off of it. If there is javascript referencing html that was hidden/not displayed, then that javascript shouldn't be there to reference a non-existent portion of the page.
.

Finally had a chance to revisit this...

To whom it may concern: Does/did the issue only occur if no such tabs are displayed (no featured, special nor new products), or does it occur if any one of the three tabs are not displayed when using the original code? (The sample site shows two tabs active on the main page, but does not appear to have a javascript error.)

[jpda]

Finally had a chance to revisit this...

To whom it may concern: Does/did the issue only occur if no such tabs are displayed (no featured, special nor new products), or does it occur if any one of the three tabs are not displayed when using the original code? (The sample site shows two tabs active on the main page, but does not appear to have a javascript error.)

The issue occurs, for example, if in admin>index listing "Show Specials on Main Page" is set to a positive value AND no specials products exist. In tpl_modules_specials_default.php $zc_show_specials is tested, which seems to be true, even if not any special product actually exists. I guess $zc_show_specials is from specials_index.php and seems to be true if $specials_index->RecordCount() > 0, even if no record exists .

The same for new and featured products.

The advantage of brittainmark's solution is that there is no need to change the admin settings (new, featured, specials) according to their existence. The disadvantage (a tab is present, even when empty) is acceptable.

Cheers,

jpda

[mc12345678]

The issue occurs, for example, if in admin>index listing "Show Specials on Main Page" is set to a positive value AND no specials products exist. In tpl_modules_specials_default.php $zc_show_specials is tested, which seems to be true, even if not any special product actually exists. I guess $zc_show_specials is from specials_index.php and seems to be true if $specials_index->RecordCount() > 0, even if no record exists .

The same for new and featured products.

The advantage of brittainmark's solution is that there is no need to change the admin settings (new, featured, specials) according to their existence. The disadvantage (a tab is present, even when empty) is acceptable.

Cheers,

jpda

Up front, I'm fine with agreeing to disagree... I find as a customer to other stores that it is almost aggravating that such an option is shown but there is nothing there. In some cases makes me wonder if there is something wrong with my computer/setup because obviously why would a store show an option like that when there is nothing there and it even allows clicking/selecting the tab but nothing happens when clicked? A number of other things come to mind as well.

I guess I'm going to have to setup another template site with this installed to test it out... Seemed to me in only review of the code that it was only an issue if none of them were displayed... May require a modification to the javascript or one or more of the template files, but if nothing else, a feature was "added" to block the display of the tab, only unfortunately it is not currently compatible with another add-on to the template...

[jpda]

Up front, I'm fine with agreeing to disagree... I find as a customer to other stores that it is almost aggravating that such an option is shown but there is nothing there. In some cases makes me wonder if there is something wrong with my computer/setup because obviously why would a store show an option like that when there is nothing there and it even allows clicking/selecting the tab but nothing happens when clicked? A number of other things come to mind as well.

I guess I'm going to have to setup another template site with this installed to test it out... Seemed to me in only review of the code that it was only an issue if none of them were displayed... May require a modification to the javascript or one or more of the template files, but if nothing else, a feature was "added" to block the display of the tab, only unfortunately it is not currently compatible with another add-on to the template...

I agree! My point was 'acceptable compared to the alternative', i.e. having the js problem whenever one of the new, specials or featured are empty (which occurs automatically w/o notice). The best solution is to change the test in the tpl_modules_*_php files and only show the meaningful tabs.
On the other hand, the links to new, featured and specials in info boxes or footer are always visible (once being activated), whether such products exist or not.

unfortunately it is not currently compatible with another add-on

Any idea which add-on could be incompatible?

Cheers,

jpda

[mc12345678]

I agree! My point was 'acceptable compared to the alternative', i.e. having the js problem whenever one of the new, specials or featured are empty (which occurs automatically w/o notice). The best solution is to change the test in the tpl_modules_*_php files and only show the meaningful tabs.
On the other hand, the links to new, featured and specials in info boxes or footer are always visible (once being activated), whether such products exist or not.


Any idea which add-on could be incompatible?

Cheers,

jpda

Gotcha, agree, needs to work. The "add-on" that seems to be the issue in regards to these three tabs seems to be includes/templates/responsive_sheffield_blue/jscript/cbpFWTabs.js

Either when it is initially called in includes/templates/responsive_sheffield_blue/templates/tpl_index_default.php or in the code of the javascript. Either the javascript shouldnotbe shown/loaded at all, or if loaded should not cause issues if something else was purposefully missing. See javascript is an added feature. If the customer/guest were to access the site with javascript disabled, then one would expect that everything should work. It may not look as pretty, but it should still work... Then when the javascript is added it should not then prevent operation but instead slip intoo the mix... But sometimes little things don't quite work as expected or they are modified beyond original intent. Can't get it all every time. :)

[jpda]

Gotcha, agree, needs to work. The "add-on" that seems to be the issue in regards to these three tabs seems to be includes/templates/responsive_sheffield_blue/jscript/cbpFWTabs.js

Either when it is initially called in includes/templates/responsive_sheffield_blue/templates/tpl_index_default.php or in the code of the javascript. Either the javascript shouldnotbe shown/loaded at all, or if loaded should not cause issues if something else was purposefully missing. See javascript is an added feature. If the customer/guest were to access the site with javascript disabled, then one would expect that everything should work. It may not look as pretty, but it should still work... Then when the javascript is added it should not then prevent operation but instead slip intoo the mix... But sometimes little things don't quite work as expected or they are modified beyond original intent. Can't get it all every time. :)

Found a rather simple solution:
In includes\templates\responsive_sheffield_blue\templates\tpl_index_default.php:
I added these lines (in red):

 * Modified by Anne (Picaflor-Azul.com) Responsive Sheffield Blue v1.0 v2.0
 */
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_NEW_PRODUCTS));// added jpda
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_FEATURED_PRODUCTS_MODULE)); // added jpda
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_SPECIALS_INDEX));// added jpda

(I'm not sure if this complies with ZC's rules and regulations, there might be a better way to get $zc_show_featured, $zc_show_specials and $zc_show_new_products?)

And I added the code in red to these lines: (under //bof module navigation)

while (!$show_display_nav->EOF) {
  switch ($show_display_nav->fields['configuration_key']) {
  case 'SHOW_PRODUCT_INFO_MAIN_FEATURED_PRODUCTS':
    if ($zc_show_featured) echo '<li><a href="section-2" class="icon-shop"><span>' . BOX_HEADING_FEATURED_PRODUCTS . '</span></a></li>'. "\n";
    break;
  case 'SHOW_PRODUCT_INFO_MAIN_SPECIALS_PRODUCTS':
    if ($zc_show_specials) echo '<li><a href="section-3" class="icon-cup"><span>' . BOX_HEADING_SPECIALS . '</span></a></li>'. "\n";
    break;
  case 'SHOW_PRODUCT_INFO_MAIN_NEW_PRODUCTS':
    if ($zc_show_new_products) echo '<li><a href="section-1" class="icon-food"><span>' . BOX_HEADING_WHATS_NEW . '</span></a></li>'. "\n";
    break;
  }
  $show_display_nav->MoveNext();
}

Restored the next three files to the original template files from RSB v2.0 :
includes\templates\responsive_sheffield_blue\templates\tpl_modules_specials_defa ult.php
includes\templates\responsive_sheffield_blue\templates\tpl_modules_featured_prod ucts.php
includes\templates\responsive_sheffield_blue\templates\tpl_modules_whats_new.php
(However, I changed the section id's to be consistent with tpl_index_default.php)

Only tabs will be shown that actually contain information AND are allowed by settings in admin>index listing.

Cheers,

jpda

[2marco]

I am having some issues with position of the banner in the header slide show. It appears mostly in chrome, not in IE or firefox.
See the images below.

The images showing the demopage from this template, but I am suffering from it on my own (current local) installation as well.

But I see other online examples using the same templates who dont.
http://onlinetest.batterybg.com/fres...ain_page=index

Any Idea?

[picaflor-azul]

I am having some issues with position of the banner in the header slide show. It appears mostly in chrome, not in IE or firefox.
See the images below.

The images showing the demopage from this template, but I am suffering from it on my own (current local) installation as well.

But I see other online examples using the same templates who dont.
http://onlinetest.batterybg.com/fres...ain_page=index

Any Idea?

When I try your site I get a 403 error.

Thanks,

Anne