Responsive Sheffield Blue v2.0

[jpda]

Up front, I'm fine with agreeing to disagree... I find as a customer to other stores that it is almost aggravating that such an option is shown but there is nothing there. In some cases makes me wonder if there is something wrong with my computer/setup because obviously why would a store show an option like that when there is nothing there and it even allows clicking/selecting the tab but nothing happens when clicked? A number of other things come to mind as well.

I guess I'm going to have to setup another template site with this installed to test it out... Seemed to me in only review of the code that it was only an issue if none of them were displayed... May require a modification to the javascript or one or more of the template files, but if nothing else, a feature was "added" to block the display of the tab, only unfortunately it is not currently compatible with another add-on to the template...

I agree! My point was 'acceptable compared to the alternative', i.e. having the js problem whenever one of the new, specials or featured are empty (which occurs automatically w/o notice). The best solution is to change the test in the tpl_modules_*_php files and only show the meaningful tabs.
On the other hand, the links to new, featured and specials in info boxes or footer are always visible (once being activated), whether such products exist or not.

unfortunately it is not currently compatible with another add-on

Any idea which add-on could be incompatible?

Cheers,

jpda

[mc12345678]

I agree! My point was 'acceptable compared to the alternative', i.e. having the js problem whenever one of the new, specials or featured are empty (which occurs automatically w/o notice). The best solution is to change the test in the tpl_modules_*_php files and only show the meaningful tabs.
On the other hand, the links to new, featured and specials in info boxes or footer are always visible (once being activated), whether such products exist or not.


Any idea which add-on could be incompatible?

Cheers,

jpda

Gotcha, agree, needs to work. The "add-on" that seems to be the issue in regards to these three tabs seems to be includes/templates/responsive_sheffield_blue/jscript/cbpFWTabs.js

Either when it is initially called in includes/templates/responsive_sheffield_blue/templates/tpl_index_default.php or in the code of the javascript. Either the javascript shouldnotbe shown/loaded at all, or if loaded should not cause issues if something else was purposefully missing. See javascript is an added feature. If the customer/guest were to access the site with javascript disabled, then one would expect that everything should work. It may not look as pretty, but it should still work... Then when the javascript is added it should not then prevent operation but instead slip intoo the mix... But sometimes little things don't quite work as expected or they are modified beyond original intent. Can't get it all every time. :)

[jpda]

Gotcha, agree, needs to work. The "add-on" that seems to be the issue in regards to these three tabs seems to be includes/templates/responsive_sheffield_blue/jscript/cbpFWTabs.js

Either when it is initially called in includes/templates/responsive_sheffield_blue/templates/tpl_index_default.php or in the code of the javascript. Either the javascript shouldnotbe shown/loaded at all, or if loaded should not cause issues if something else was purposefully missing. See javascript is an added feature. If the customer/guest were to access the site with javascript disabled, then one would expect that everything should work. It may not look as pretty, but it should still work... Then when the javascript is added it should not then prevent operation but instead slip intoo the mix... But sometimes little things don't quite work as expected or they are modified beyond original intent. Can't get it all every time. :)

Found a rather simple solution:
In includes\templates\responsive_sheffield_blue\templates\tpl_index_default.php:
I added these lines (in red):

 * Modified by Anne (Picaflor-Azul.com) Responsive Sheffield Blue v1.0 v2.0
 */
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_NEW_PRODUCTS));// added jpda
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_FEATURED_PRODUCTS_MODULE)); // added jpda
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_SPECIALS_INDEX));// added jpda

(I'm not sure if this complies with ZC's rules and regulations, there might be a better way to get $zc_show_featured, $zc_show_specials and $zc_show_new_products?)

And I added the code in red to these lines: (under //bof module navigation)

while (!$show_display_nav->EOF) {
  switch ($show_display_nav->fields['configuration_key']) {
  case 'SHOW_PRODUCT_INFO_MAIN_FEATURED_PRODUCTS':
    if ($zc_show_featured) echo '<li><a href="section-2" class="icon-shop"><span>' . BOX_HEADING_FEATURED_PRODUCTS . '</span></a></li>'. "\n";
    break;
  case 'SHOW_PRODUCT_INFO_MAIN_SPECIALS_PRODUCTS':
    if ($zc_show_specials) echo '<li><a href="section-3" class="icon-cup"><span>' . BOX_HEADING_SPECIALS . '</span></a></li>'. "\n";
    break;
  case 'SHOW_PRODUCT_INFO_MAIN_NEW_PRODUCTS':
    if ($zc_show_new_products) echo '<li><a href="section-1" class="icon-food"><span>' . BOX_HEADING_WHATS_NEW . '</span></a></li>'. "\n";
    break;
  }
  $show_display_nav->MoveNext();
}

Restored the next three files to the original template files from RSB v2.0 :
includes\templates\responsive_sheffield_blue\templates\tpl_modules_specials_defa ult.php
includes\templates\responsive_sheffield_blue\templates\tpl_modules_featured_prod ucts.php
includes\templates\responsive_sheffield_blue\templates\tpl_modules_whats_new.php
(However, I changed the section id's to be consistent with tpl_index_default.php)

Only tabs will be shown that actually contain information AND are allowed by settings in admin>index listing.

Cheers,

jpda

[mc12345678]

Found a rather simple solution:
In includes\templates\responsive_sheffield_blue\templates\tpl_index_default.php:
I added these lines (in red):

 * Modified by Anne (Picaflor-Azul.com) Responsive Sheffield Blue v1.0 v2.0
 */
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_NEW_PRODUCTS));// added jpda
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_FEATURED_PRODUCTS_MODULE)); // added jpda
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_SPECIALS_INDEX));// added jpda

(I'm not sure if this complies with ZC's rules and regulations, there might be a better way to get $zc_show_featured, $zc_show_specials and $zc_show_new_products?)

And I added the code in red to these lines: (under //bof module navigation)

while (!$show_display_nav->EOF) {
  switch ($show_display_nav->fields['configuration_key']) {
  case 'SHOW_PRODUCT_INFO_MAIN_FEATURED_PRODUCTS':
    if ($zc_show_featured) echo '<li><a href="section-2" class="icon-shop"><span>' . BOX_HEADING_FEATURED_PRODUCTS . '</span></a></li>'. "\n";
    break;
  case 'SHOW_PRODUCT_INFO_MAIN_SPECIALS_PRODUCTS':
    if ($zc_show_specials) echo '<li><a href="section-3" class="icon-cup"><span>' . BOX_HEADING_SPECIALS . '</span></a></li>'. "\n";
    break;
  case 'SHOW_PRODUCT_INFO_MAIN_NEW_PRODUCTS':
    if ($zc_show_new_products) echo '<li><a href="section-1" class="icon-food"><span>' . BOX_HEADING_WHATS_NEW . '</span></a></li>'. "\n";
    break;
  }
  $show_display_nav->MoveNext();
}

Restored the next three files to the original template files from RSB v2.0 :
includes\templates\responsive_sheffield_blue\templates\tpl_modules_specials_defa ult.php
includes\templates\responsive_sheffield_blue\templates\tpl_modules_featured_prod ucts.php
includes\templates\responsive_sheffield_blue\templates\tpl_modules_whats_new.php
(However, I changed the section id's to be consistent with tpl_index_default.php)

Only tabs will be shown that actually contain information AND are allowed by settings in admin>index listing.

Cheers,

jpda

Cool: I assume something similar would need to be done to tpl_index_categories as was to tpl_index_default or did the problem not exist when navigating categories and only on the home page of the site?

[jpda]

Cool: I assume something similar would need to be done to tpl_index_categories as was to tpl_index_default or did the problem not exist when navigating categories and only on the home page of the site?

Yes, the problem exists there as well.
Thanks, good point! Didn't notice because in admin>layout settings CATEGORIES_START_MAIN was set to '' (blank).
I applied exactly the same changes to tpl_index_categories.php, problem solved.

Cheers,

jpda

[2marco]

I am having some issues with position of the banner in the header slide show. It appears mostly in chrome, not in IE or firefox.
See the images below.

The images showing the demopage from this template, but I am suffering from it on my own (current local) installation as well.

But I see other online examples using the same templates who dont.
http://onlinetest.batterybg.com/fres...ain_page=index

Any Idea?

[picaflor-azul]

I am having some issues with position of the banner in the header slide show. It appears mostly in chrome, not in IE or firefox.
See the images below.

The images showing the demopage from this template, but I am suffering from it on my own (current local) installation as well.

But I see other online examples using the same templates who dont.
http://onlinetest.batterybg.com/fres...ain_page=index

Any Idea?

When I try your site I get a 403 error.

Thanks,

Anne

[EmmaThePoly]

I am having some issues with position of the banner in the header slide show. It appears mostly in chrome, not in IE or firefox.
See the images below.

The images showing the demopage from this template, but I am suffering from it on my own (current local) installation as well.

But I see other online examples using the same templates who dont.
http://onlinetest.batterybg.com/fres...ain_page=index

Any Idea?

I am having the exact same issue on my web site! The slideshow text appears in Chrome as it does in 2Marco's screenshots. I didn't see a reply that solves Marco's problem though. Did anyone manage to solve it? I have tried playing around with the CSS but with no success. My web site is battleaxegames.com. Thanks!

[EmmaThePoly]

I am having the exact same issue on my web site! The slideshow text appears in Chrome as it does in 2Marco's screenshots. I didn't see a reply that solves Marco's problem though. Did anyone manage to solve it? I have tried playing around with the CSS but with no success. My web site is battleaxegames.com. Thanks!

After having another stab at messing around with the CSS, I -think- I've fixed it. In the stylesheet_flex.css file in the CSS folder, I removed a couple of the banner attributes, namely the margin which was set at something weird like -300 and something pixels. Still testing on different platforms to see if that created any new problems....