Printable View
I pasted both those segments over the existing stripe 1.5.7d segments. Now both PayPal and Stripe no longer show Sub Total, Tax, Total on the final checkout page
I also tried the complete file sourced from 1.5.8, expecting it to fail, the PayPal was fixed, but the Stripe had duplicated Sub Total, Tax, Total on the final checkout page
Check you template select.Quote:
Originally Posted by split63
and following codes are for ver zen cart 157c template_default
PHP Code:<?php
/**
* Page Template
*
* Loaded automatically by index.php?main_page=checkout_confirmation.<br />
* Displays final checkout details, cart, payment and shipping info details.
*
* @copyright Copyright 2003-2020 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version $Id: DrByte 2020 Oct 19 Modified in v1.5.7a $
*/
?>
<div class="centerColumn" id="checkoutConfirmDefault">
<h1 id="checkoutConfirmDefaultHeading"><?php echo HEADING_TITLE; ?></h1>
<?php if ($messageStack->size('redemptions') > 0) echo $messageStack->output('redemptions'); ?>
<?php if ($messageStack->size('checkout_confirmation') > 0) echo $messageStack->output('checkout_confirmation'); ?>
<?php if ($messageStack->size('checkout') > 0) echo $messageStack->output('checkout'); ?>
<div id="checkoutBillto" class="back">
<h2 id="checkoutConfirmDefaultBillingAddress"><?php echo HEADING_BILLING_ADDRESS; ?></h2>
<?php if (!$flagDisablePaymentAddressChange) { ?>
<div class="buttonRow forward"><?php echo '<a href="' . zen_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL') . '">' . zen_image_button(BUTTON_IMAGE_EDIT_SMALL, BUTTON_EDIT_SMALL_ALT) . '</a>'; ?></div>
<?php } ?>
<address><?php echo zen_address_format($order->billing['format_id'], $order->billing, 1, ' ', '<br />'); ?></address>
<?php
$class =& $_SESSION['payment'];
?>
<h3 id="checkoutConfirmDefaultPayment"><?php echo HEADING_PAYMENT_METHOD; ?></h3>
<h4 id="checkoutConfirmDefaultPaymentTitle"><?php echo $GLOBALS[$class]->title; ?></h4>
<?php
if (is_array($payment_modules->modules)) {
if ($confirmation = $payment_modules->confirmation()) {
?>
<div class="important"><?php echo $confirmation['title']; ?></div>
<?php
}
?>
<div class="important">
<?php
for ($i=0, $n=sizeof($confirmation['fields']); $i<$n; $i++) {
?>
<div class="back"><?php echo $confirmation['fields'][$i]['title']; ?></div>
<div ><?php echo $confirmation['fields'][$i]['field']; ?></div>
<?php
}
?>
</div>
<?php
}
?>
<br class="clearBoth" />
</div>
<?php
if ($_SESSION['sendto'] != false) {
?>
<div id="checkoutShipto" class="forward">
<h2 id="checkoutConfirmDefaultShippingAddress"><?php echo HEADING_DELIVERY_ADDRESS; ?></h2>
<div class="buttonRow forward"><?php echo '<a href="' . $editShippingButtonLink . '">' . zen_image_button(BUTTON_IMAGE_EDIT_SMALL, BUTTON_EDIT_SMALL_ALT) . '</a>'; ?></div>
<address><?php echo zen_address_format($order->delivery['format_id'], $order->delivery, 1, ' ', '<br />'); ?></address>
<?php
if ($order->info['shipping_method']) {
?>
<h3 id="checkoutConfirmDefaultShipment"><?php echo HEADING_SHIPPING_METHOD; ?></h3>
<h4 id="checkoutConfirmDefaultShipmentTitle"><?php echo $order->info['shipping_method']; ?></h4>
<?php
}
?>
</div>
<?php
}
?>
<br class="clearBoth" />
<hr />
<h2 id="checkoutConfirmDefaultHeadingComments"><?php echo HEADING_ORDER_COMMENTS; ?></h2>
<div class="buttonRow forward"><?php echo '<a href="' . zen_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL') . '">' . zen_image_button(BUTTON_IMAGE_EDIT_SMALL, BUTTON_EDIT_SMALL_ALT) . '</a>'; ?></div>
<div><?php echo (empty($order->info['comments']) ? NO_COMMENTS_TEXT : nl2br(zen_output_string_protected($order->info['comments'])) . zen_draw_hidden_field('comments', $order->info['comments'])); ?></div>
<br class="clearBoth" />
<hr />
<h2 id="checkoutConfirmDefaultHeadingCart"><?php echo HEADING_PRODUCTS; ?></h2>
<div class="buttonRow forward"><?php echo '<a href="' . zen_href_link(FILENAME_SHOPPING_CART, '', 'SSL') . '">' . zen_image_button(BUTTON_IMAGE_EDIT_SMALL, BUTTON_EDIT_SMALL_ALT) . '</a>'; ?></div>
<br class="clearBoth" />
<?php if ($flagAnyOutOfStock) { ?>
<?php if (STOCK_ALLOW_CHECKOUT == 'true') { ?>
<div class="messageStackError"><?php echo OUT_OF_STOCK_CAN_CHECKOUT; ?></div>
<?php } else { ?>
<div class="messageStackError"><?php echo OUT_OF_STOCK_CANT_CHECKOUT; ?></div>
<?php } //endif STOCK_ALLOW_CHECKOUT ?>
<?php } //endif flagAnyOutOfStock ?>
<table id="cartContentsDisplay">
<tr class="cartTableHeading">
<th scope="col" id="ccQuantityHeading"><?php echo TABLE_HEADING_QUANTITY; ?></th>
<th scope="col" id="ccProductsHeading"><?php echo TABLE_HEADING_PRODUCTS; ?></th>
<?php
// If there are tax groups, display the tax columns for price breakdown
if (sizeof($order->info['tax_groups']) > 1) {
?>
<th scope="col" id="ccTaxHeading"><?php echo HEADING_TAX; ?></th>
<?php
}
?>
<th scope="col" id="ccTotalHeading"><?php echo TABLE_HEADING_TOTAL; ?></th>
</tr>
<?php // now loop thru all products to display quantity and price ?>
<?php for ($i=0, $n=sizeof($order->products); $i<$n; $i++) { ?>
<tr class="<?php echo $order->products[$i]['rowClass']; ?>">
<td class="cartQuantity"><?php echo $order->products[$i]['qty']; ?> x</td>
<td class="cartProductDisplay"><?php echo $order->products[$i]['name']; ?>
<?php if (!empty($stock_check[$i])) echo $stock_check[$i]; ?>
<?php // if there are attributes, loop thru them and display one per line
if (isset($order->products[$i]['attributes']) && sizeof($order->products[$i]['attributes']) > 0 ) {
echo '<ul class="cartAttribsList">';
for ($j=0, $n2=sizeof($order->products[$i]['attributes']); $j<$n2; $j++) {
?>
<li>
<?php
echo $order->products[$i]['attributes'][$j]['option'] . ': ' . nl2br(zen_output_string_protected($order->products[$i]['attributes'][$j]['value']));
?>
</li>
<?php
} // end loop
echo '</ul>';
} // endif attribute-info
?>
</td>
<?php // display tax info if exists ?>
<?php if (sizeof($order->info['tax_groups']) > 1) { ?>
<td class="cartTotalDisplay">
<?php echo zen_display_tax_value($order->products[$i]['tax']); ?>%</td>
<?php } // endif tax info display ?>
<td class="cartTotalDisplay">
<?php echo $currencies->display_price($order->products[$i]['final_price'], $order->products[$i]['tax'], $order->products[$i]['qty']);
if ($order->products[$i]['onetime_charges'] != 0 ) echo '<br /> ' . $currencies->display_price($order->products[$i]['onetime_charges'], $order->products[$i]['tax'], 1);
?>
</td>
</tr>
<?php } // end for loopthru all products ?>
</table>
<hr />
<?php
if (MODULE_ORDER_TOTAL_INSTALLED) {
$order_totals = $order_total_modules->process();
?>
<div id="orderTotals"><?php $order_total_modules->output(); ?></div>
<?php
}
?>
<!--------stripe-------->
<!-- Display a payment form -->
<form id="payment-form">
<div id="payment-head" style="color: #2254dd; font-size: 24px; font-weight: bold; margin:24px 0 12px;">Stripe</div>
<div id="payment-element">
<!--Stripe.js injects the Payment Element-->
</div>
<div id="payment-message" class="hidden"></div>
<button id="submit">
<div class="spinner hidden" id="spinner"></div>
<span id="button-text"><?php echo BUTTON_CONFIRM_ORDER_ALT; ?></span>
</button>
</form>
<!--------end-stripe-------->
<?php
echo zen_draw_form('checkout_confirmation', $form_action_url, 'post', 'id="checkout_confirmation" onsubmit="submitonce();"');
if (is_array($payment_modules->modules)) {
echo $payment_modules->process_button();
}
?>
<div class="buttonRow forward"><?php echo zen_image_submit(BUTTON_IMAGE_CONFIRM_ORDER, BUTTON_CONFIRM_ORDER_ALT, 'name="btn_submit" id="btn_submit"') ;?></div>
</form>
<div class="buttonRow back"><?php echo TITLE_CONTINUE_CHECKOUT_PROCEDURE . '<br />' . TEXT_CONTINUE_CHECKOUT_PROCEDURE; ?></div>
</div>
<!--------stripe-------->
<script>
if (typeof clientS === 'undefined') {
document.getElementById('btn_submit').display ="block";
document.getElementById('checkout_confirmation').display ="block";
document.getElementById('payment-form','submit').style.display ="none";
}else{
document.getElementById('btn_submit').style.display ="none";
document.getElementById('checkout_confirmation').style.display ="none";
document.getElementById('payment-form','submit').display ="block";
}
</script>
<!--------end-stripe-------->
I just replaced the contents of tpl_checkout_confirmation_default.php with that which you posted, and the results were the same. PayPal good, Stripe Sub total, tax, total, duplicatedQuote:
Originally Posted by Gozzandes
I'm using the Responsive Classic template.
Same result as using the 1.5.8 version. What was interesting about the 1.5.8 version was it seemed to function without throwing PHP errors. Would you expect the 1.5.8 version of tpl_checkout_confirmation_default.php to operate correctly on version 1.5.7c?
I just did a file compare of the contents you just posted against the original file in Stripe_module_zc157d. They are identical
So I'm now confused.
Download from github.com.Quote:
Originally Posted by split63
The moule for zen cart 1.5.7c is included.
zencart-stripe-module_217
Be careful "mysql_upgrade_to_2.1.7" should be install before over writing the files at Admin=>Tools=>Install SQL patches.
Niho Yokane corporation
I updated the files from github. It was not until I replaced the \includes\modules\payment\stripe.php, that both PayPal and Stripe now show the final checkout page correctly.
I'll need to do more testing to be sure.
However, in stripe test mode, at the stripe dashboard, orders were coming in $5 more than they should have
Checking the "low order fee" module, the low order fee was set to false, but the fee amount was set to $5. Setting this to $0 solved the additional $5 at the stripe dashboard
Attachment 20829
Thanks!!Quote:
Originally Posted by split63
Change the following code
www\includes\modules\payment\stripe.php line 150
from
toPHP Code:if (MODULE_ORDER_TOTAL_LOWORDERFEE_STATUS == 'true' && MODULE_ORDER_TOTAL_LOWORDERFEE_ORDER_UNDER >= $order->info['total']) {
:blush:PHP Code:if (MODULE_ORDER_TOTAL_LOWORDERFEE_LOW_ORDER_FEE == 'true' && MODULE_ORDER_TOTAL_LOWORDERFEE_ORDER_UNDER >= $order->info['total']) {
I've fixed the file.
zencart-stripe-module_218
Nihon Yokane corporation
is there any way you can spend a bit of time learning github?Quote:
Originally Posted by Gozzandes
posting a zip file with all of the files within it is not the best way to make use of a collaborative tool such as github.
all of the files should be up on a repo, and then you can do releases where git will automatically create a zip file for you.
Quote:
Originally Posted by carlwhat
I apologize for not being familiar with github.
I tried to upload it to github, but it does not not accept more than 100 files, so I uploaded it as a zip file.
Now, what should we do?