Printable View
OK. It isn't a choice value by design. It needs to set and my "Zen-ability" is not quite there yet. I am using the "zen_draw_hidden_field" to set the value.
As in "'field' => zen_draw_hidden_field('opt_hazmat_handling', '1', $selected)". There is probably a better way to do this that sets the value to be fixed based on products choices on the basket.
Working on it.
TR
I need to work on my postings. I get a little rushed and it doesn't make quite as much sense I intend. I'll try again.
When I reworked the priority handling code for the hazmat and surcharge fees. I needed the charge to be a defined variable. Either yes or no. There are additional fields added to the products table, 1/0 values as to whether an item requires hazmat shipping or whether an item requires a surcharge fee.
If yes (1) is set for either of the fields it then triggers one or both of the plugins to set the charge and then add to the order total.
In the original plugin, this was a checkbox asking if the customer wanted priority handling. I made it a hidden field and assigned a value of 1.
The code looks like this "'field' => zen_draw_hidden_field('opt_hazmat_handling', '1', $selected)". It works outside of the OPC plugin fine, but now that I have added the OPC to the mix, I can see it still has problems.
1) OPC still sees it as a choice and presents it as something that can be applied (the APPLY button). I think is based on the original plugin being based on the credit component. Not sure I can change the code base without doing a complete rewrite, which is currently outside my scope.
I could rewrite the hidden field code and make it a fixed value but not sure if I am using the correct zen method to accomplish this:
maybe it should be "'field' => zen_draw_hidden_field('opt_hazmat_handling', '1')", but I am not sure if that changes anything.
It just need to be a hidden form field set to true.
After that I need to make the "APPLY" button disappear and get the fee amount back into the OPC order total.
If you have any suggestions please let me know.
Tony
Yes, any order-total that declares itself as a "credit-class" module will be displayed with an Apply button by OPC. Note that rewriting that checkbox-input to a hidden field will result in the same OPC behavior since the session-related information changes during the confirmation phase of its processing.
Let me "play back" what I "heard" you say in your previous post:
If that's the case, there's a simpler way to code those order-totals ...Quote:
For each of your "surcharge" and "hazmat" order-totals, there's an associated flag in a product's database table that indicates whether (1) or not (0) the associated fee should be applied to an order containing one-or-more of those products.
Hi lat9
First of all, thanks very much for bringing this wonderful plugin. Thanks very much.
We're testing this plugin(downloaded from https://github.com/lat9/one_page_checkout, version 1.1.1) under ZC 1.5.5c, and we got some issue with the Reward Points plugin.
We can see the Reward Points section on checkout_one page, but after we check the redeem checkbox ("Point Redeem Method" is set as auto, so by checking the checkbox, all available points will be used) and then click on the Apply button, the page will be refreshed, but the order total is not updated. We've tried set the "Point Redeem Method" as manual, and it is the same.
Parameters posted:ThanksCode:ecurityToken:e786368f3e580c522b26b589ae06190f
action:process
javascript_enabled:1
shipping_billing:1
comments:
redeem_flag:on
redeem_checkout_flag:
apply_reward_points_x:Apply
dc_redeem_code:
shipping:advshipper_3-0-0
shipping:advshipper_3-0-0
payment:paypalwpp
order_confirmed:0
current_order_total:0
Davis
Hi, y051313! First, a couple of questions:
- Which Reward Points plugin (and which version) are you using?
- Are any myDEBUG logs generated in your store's /logs directory?
- When you view your browser's console (normally by pressing F12 during a browser session, then looking for a "Console" tab), are there javascript and/or jQuery issues noted?
- Is the site publically available? If so, you can send me a link via PM and I can check a couple of things, too.
You can create me a one-page-checkout log file for this case by performing these steps:
- Log into your admin.
- Go to Configuration->One Page Checkout Settings; set the plugin's debug to "true" and make sure that the plugin itself is enabled.
- Place something "rewardable" into your cart, log in to the shop and go to checkout (so you're sitting on the OPC main page).
- Using your FTP program (or similar), go to your store's /logs directory and delete either all myDEBUG-one_page_checkout-*.log files or just the one associated with your customer id (as the last couple of characters in the file's name).
- On the storefront OPC main page, click the "Apply" button associated with the to-be-redeemed points.
- Go to the store's file-system and make a copy of the OPC log file that was generated; let me know via PM and I'll give you a direct email address to which you can send that file.
Hi lat9Quote:
Originally Posted by lat9
The Reward Points plugin we use is reward_point_full_suite 25.e (https://www.zen-cart.com/downloads.php?do=file&id=704 latest version)
Browser console doesn't show any errors, it only shows
I've sent you the site via PMCode:Setting orderConfirmed (0), submitter (null)
(index):217 jQuery version: 1.12.4
Hi lat9
We've find a solution with for the reward_point_full_suite 25.e issue (https://www.zen-cart.com/downloads.php?do=file&id=704 latest version).
It looks like the $_POST parameter was not passed into the reward module, so we have used session instead of post.
The change was made on /includes/modules/order_total/ot_reward_points.php, in function function collect_posts(), add below code
Besides, /includes/modules/page/checkout_one_confirmation/header_php.php, add below code after the "require_once (DIR_WS_CLASSES . 'http_client.php');PHP Code:if (isset($_SESSION['redeem_flag']) && $_SESSION['redeem_flag'])
$_POST['redeem_flag'] = $_SESSION['redeem_flag'];
"
PHP Code:if((isset($_POST['redeem_flag']) && $_POST['redeem_flag']))
$_SESSION['redeem_flag'] = $_POST['redeem_flag'];
else
unset($_SESSION['redeem_flag']);
Best
Davis
Btw, we also noticed 2 more issues:
1. in case user uncheck "shipping address same as billing address" checkbox, then select a shipping address with different country (e.g. billing address is US address, and shipping address is UK one), and then check "shipping address same as billing address" checkbox again, the shipping options list won't be updated (still the options available for UK address).
2. If user use a 100% coupon, which makes order total becomes zero, and then click on the confirm order button, he will be redirected back to checkout_one page, with error msg "Your order's details have changed. Please review the current values and re-submit."
Thanks for that, Davis. I will update the OPC readme with integration notes and identify those changes as required when a store also uses ot_reward_points.Quote:
Originally Posted by y051313
I have reproduced issue#2 (and created an associated GitHub issue); I'll need a bit of time to attempt to reproduce the first.Quote:
Originally Posted by y051313
Quote:
Originally Posted by frank18
@frank18 ... OK, color me confused!:huh:Quote:
Originally Posted by lat9
That "Edit" button shows in both the checkout_one_confirmation and ajax_checkout_confirmation pages and the plugin doesn't distribute the file /includes/templates/YOUR_TEMPLATE/tpl_checkout_one_confirmation_default.php.
From what I can see, reviewing the GitHub changes, that button was added back in August of 2016; perhaps you've made a template-override version that (somehow) got down-level?
Please advise.
Well... color me embarrassed :shocking: - I sure had to make changes in that template-override file to meet some requirements of this site!! Doh......Quote:
Originally Posted by lat9
My apologies for creating confusion.
Cheers
I have also reproduced issue#1; I'll post back when a solution is available.Quote:
Originally Posted by lat9
Thanks Lat9. We use a temporary solution, once user unchecks the "same address" checkbox, we will hide this checkbox.Quote:
Originally Posted by lat9
I've got the rather extensive changes complete and uploaded to the plugin's GitHub repository, if anyone wants to take a look until I get the chance to package these changes up.Quote:
Originally Posted by y051313
I've just submitted v1.2.0 to the Zen Cart plugins for review and will post back when it's available for download.
This version contains changes associated with the following GitHub issues:
#79: Correct conditionally-enabling the plugin causes checkout-loop.
#80: Add an Edit button to shopping-cart block on checkout pages.
#83: Unwanted "Your order has changed" message received after applying a credit-class order-total to the order.
#85: Correct checkout-loop after a 100%-off coupon is applied to an order.
#86: Correct "Shipping, same as Billing" processing.
... and various documentation edits.
OPC v1.2.0 is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2095Quote:
Originally Posted by lat9
Hi lat9Quote:
Originally Posted by lat9
I'v upgraded to v1.2.0. When I uncheck the "Shipping Address, Same as Billing?" checkbox, the shipping option list is not updated.
I saw there was a request to page "/ajax.php?act=ajaxOnePageCheckout&method=updateShipping", but the response is messy code like "� š[{�a{�a{�a{�a{�a{�a{'
The returning array in the debug log looks correct.
Any clues?
Thanks
Davis
Davis, does your store use a custom template? Have you customized the tpl_checkout_one_default.php template in your custom template?
If so, did you merge the template changes (highlighted in the readme) into your template-override version?
Hi lat9Quote:
Originally Posted by lat9
I've replaced all files in the new version.
Seems the issue is with the ob_flush () function on line 185 in file /includes/classes/ajax/zcAjaxOnePageCheckout.php. If I comment this line out, then the module works well.
Best
Davis
Davis, it sounds like you're missing the tpl_modules_checkout_one_shipping.php file from either your template_default/templates directory or it's been damaged in some way.
Hi lat9Quote:
Originally Posted by lat9
I've upload tpl_modules_checkout_one_shipping.php file again, but still doesn't work.
Is it necessary to add ob_flush (); line? If I remove this line, then the plugin works well.
PHP Code:require ($template->get_template_dir ('tpl_modules_checkout_one_shipping.php', DIR_WS_TEMPLATE, $current_page_base, 'templates'). '/tpl_modules_checkout_one_shipping.php');
$shipping_html = ob_get_clean ();
return $shipping_html;
ob_flush ();
Dave, your version of /includes/classes/ajax/zcAjaxOnePageCheckout.php is the one that's apparently damaged. In the as-shipped version there is no "return $shipping_html;" statement at that point of the code.
sorry, my mistake, return $shipping_html is added for debug purpose. After removing this line, I still got the messy code in the response.Quote:
Originally Posted by lat9
Although I'm not familiar with this module and only have the small piece of code posted to go by, I too, wonder about the ob_flush ();Quote:
Originally Posted by y051313
Usually, if used, it is at the beginning of the code and not the end.
lat9 can give more details on it but I would say if it corrects your problem and doesn't create any new ones, then remove it.
@Website Rob, the as-shipped code fragment reads:
@y051313, I used the credentials you sent on April 15 to login and went to checkout. It looks to me like the AJAX request/response information is correctly flowing properly on your beta .net site. I didn't click through to completion, since there was a product in the test-user's cart when I got there. Please advise.Code:ob_start ();
require ($template->get_template_dir ('tpl_modules_checkout_one_shipping.php', DIR_WS_TEMPLATE, $current_page_base, 'templates'). '/tpl_modules_checkout_one_shipping.php');
$shipping_html = ob_get_clean ();
ob_flush ();
Hi lay9Quote:
Originally Posted by lat9
I've removed the ob_flush (); line on the test site, that's why you didn't see any error.
I've added ob_flush(); back, now when you check/uncheck the "Shipping Address, Same as Billing?" checkbox, you will see error msg.
error: status=parsererror, errorThrown = SyntaxError: Unexpected end of JSON input, override: [object Object]
Best
Davis
There's a bunch of other AJAX-related handling on that site, @y051313. Have you checked that the version of /jscript/jscript_framework.php in your lite_red template's folder is the version shipped with OPC?
Yes, I'm sure. I've re-upload jscript_framework.php file in my own template and template_default folderQuote:
Originally Posted by lat9
Hi lat9Quote:
Originally Posted by y051313
It turns out the issue is caused by the gzip setting in the zen cart admin page. If this option is set to off, then the plugin works.
ob_flush and gzip can't be used together.
Best
Davis
Nice detective work, Davis! That gives me something to (hopefully) reproduce ... and correct.Quote:
Originally Posted by y051313
Beg to differ: ob_flush() and Gzip (in admin) are working fine together, no issues at all.Quote:
Originally Posted by lat9
Quote:
Originally Posted by lat9
Hmm, then something's different between the two installations. Would you both "remind" me of the Zen Cart and PHP versions and template that your stores are using?Quote:
Originally Posted by frank18
Thanks Cindy, my store runs ZC 1.5.5e with PHP 5.6.x, template is a cloned Responsive Classic (just different colors), so pretty much standard.Quote:
Originally Posted by lat9
Just swapped to PHP Version: 7.0.18 (Zend: 3.0.0), did a test order (direct bank deposit) and had no issues with Gzip switched on.Quote:
Originally Posted by frank18
I'm usingQuote:
Originally Posted by frank18
PHP Version: 5.6.9 (Zend: 2.6.0)
ZC v1.5.5e
http://stackoverflow.com/questions/1...hich-is-better
Has anyone tested OPC with the popular Ozpost shipping module (found here https://www.zen-cart.com/downloads.php?do=file&id=899 ) ??
Any feedback is much appreciated. Thanks
Can answer my own question: The Ozpost shipping module works fine with OPC. I have it working on 2 local and 1 live installation. No issues, no code modifications needed.Quote:
Originally Posted by frank18
Thanks, @frank18, for the follow-up. I'll update the OPC readme to reflect your interoperability report!Quote:
Originally Posted by frank18
This is a great add-on. The Best.
Anyway, I have been running OPC version 1.0.5, so I am trying to update to 1.2.0.
My problem comes when I try to modify the tpl_checkout_one_default.php for my template override to make it better match my template and preferred flow of checkout. If I move the shipping selection div at all it stops being able to update the total when you change the shipping method.
I'm pretty sure I'm missing something simple, so any help would be appreciated.
@LightBrown, there were a bunch of changes going from 1.0.5 to 1.2.0; make sure that you're using the 1.2.0 version as your "base" when you move those blocks around. I'll send you a PM with my direct email so you can email me your changes for review.
Is there any reason why I shouldn't trigger a "default" $checked radio button (for shipping or payment) by putting this:Quote:
Originally Posted by soxophoneplayer
...at the end of my includes/templates/YOUR_TEMPLATE/templates/tpl_checkout_one_default.php file?Code:<script>
document.getElementById('ship-storepickup-storepickup0').checked = true;
</script>
While that change might cause the radio button (as well as the currently selected one!) to display as selected, it doesn't trigger any event to cause the storepickup to be recognized as the customer's choice.Quote:
Originally Posted by wolfderby
Thanks a pretty good reason! haha Any suggestion on getting a "default" selection to load automatically?Quote:
Originally Posted by lat9
So I have Payeezy v0941b installed and One_Page_checkout 1.2.0 installed. Originally I was getting a Payeezy error that a Token was missing. I copied the jscript_payeezy.php to the /includes/modules/pages/checkout_one/ directory. I no longer get the Token error, I just get declines, but I do not believe the actual transaction is reaching out to First Data since I am not getting a decline report from them (I get email alerts on declines). If I turn One Page Checkout off the transaction completes normally. Any suggestions ?Quote:
Originally Posted by lat9
Tony
@tonyreynolds, do you have this installed on a site I could access? If you don't want to post that information, you can always send me a Private Message.
I like the one page checkout. Very lean and mean, but I am missing a possibility to have an order confirmation page. This is needed in some countries so customers can review their order before making it definitive.
That's been a "concern" of mine, too. I'm going to make the payment-method "exclusions" list a configuration setting, so that you can specify that the payment methods that your store(s) use require confirmation.Quote:
Originally Posted by Design75
:clap: thanks CindyQuote:
Originally Posted by lat9
ended up changing logic around includes/classes/shipping.php line 206 to the following so that in-store pickup shipping method could be selected by default for the shipping method by the cheapest() function when called in header_php.phpQuote:
Originally Posted by lat9
hopefully this is a little better than my javascript vanity that didn't do anything. (:Code:for ($i=0; $i<$size; $i++) {
if (is_array($cheapest)) {
if ($rates[$i]['cost'] < $cheapest['cost']) {
$cheapest = $rates[$i];
}
} else {
$cheapest = $rates[$i];
}
I'm getting "close" to a relatively major update (v1.3.0). That version:
- Implements the standardization of the checkout flow described in this posting: https://www.zen-cart.com/showthread....ity-Guidelines
- Moves the "review-required" payment-module list to a configurable item, enabling store's that require order-confirmation to meet that requirement.
- Adds a configuration setting (default enabled) to allow a store to control whether/not the "Shipping Address, same as Billing?" is displayed.
- Recognizes that some payment modules require confirmation, displaying a "Review" button instead of "Confirm" if such a payment-module is selected.
- Adds comments around significant sections in the checkout_one page's template, making it easier for store-owners to re-arrange the sections.
As of this posting, the most recent version is v1.3.0-beta2 on the plugin's GitHub repository: https://github.com/lat9/one_page_checkout/releases.
I've validated the operation under FireFox, IE-11 and Chrome with various payment methods (Payeezy, Braintree, PayPal variations) but don't have developer account access to others.
If anyone has time to grab the beta and test with your favorite payment methods, I'd appreciate it! Please report back both successes and failures.
Note: This release affects any template-override version that you might have made to the tpl_checkout_one_default.php file, so you'll need to merge any customizations that you've made.
n.b. I think that the newly-released Square payment processing will work, but I'm having difficulties establishing a developer account.
Quote:
Originally Posted by lat9
Tested 1.3.0 beta2 on a local dev site with PayPal, Direct Bank Deposit and eWay Rapid, Billing same as Shipping enabled / disabled and can happily report that all works as intended. Well done again !!!
Thanks, Frank, especially the eWay report (I'd apparently let my development site go too long without access). I've got some documentation to do, but expect to have v1.3.0 released in the next few days (unless there's a major burp).
I've just created OPC v1.3.0-beta4, available for download from the plugin's GitHub repository.
That version includes template-related changes, so if you've customized a version for your store be sure to compare against the template_default directory within the plugin's distribution. The changes from v1.3.0-beta2 can be seen here.
Since 1.3.0 is a fairly intense update, I'll hold off for a couple of days before stripping the beta off the release ... just in case someone finds another issue!
Happy 4th to all!
In admin I am getting this errorAm I missing something? if yes, then what? I cannot find what is missing even doing a compare/merge.Quote:
The One-Page Checkout plugin has been disabled. The file "/includes/templates/(my template name)/jscript/jscript_framework.php" is required for the plugin's proper operation..
@adb34, the message is telling you that a storefront file (jscript_framework.php) is missing from your template directory. The file is shipped in the OPC zip-file under the /includes/templates/YOUR_TEMPLATE/jscript directory.
Now things are getting strange. The file is in the jscript directory. After I checked this the error went.
@adb34, the error went ... where?
The error is no longer thereQuote:
Originally Posted by lat9
It could have been a "staging" issue. If you didn't upload all the plugin's files (both admin and storefront) before accessing the admin, it's likely that you would receive that message.
I have had this plug-in on my site for sometime. I do not know what is going on. I will do a bit more digging and let you know
I've just submitted v1.3.0 of One-Page Checkout to the Zen Cart Plugins for review; I'll post back here when it's available there for download.
That release contains the changes associated with the following issues; details are present in the plugin's GitHub repository:
#64: Reduce customer confusion; submit button now reads either "Review Order" or "Confirm Order"
#87: Add configuration switch to enable/disable "Shipping=Billing" feature.
#88: Add comments around "main" blocks to make it easier for stores to re-arrange.
#89: Document the "ozPost" shipping method's interoperation.
#90: Checkout-flow standardization, for payment-method interoperability.
#91: Move payment method list that requires confirmation to a configurable setting.
#92: Update core-file overwrites for Zen Cart versions prior to 1.5.5b.
#93: Always display at least one of the submit buttons (follow-on to #64).
#94: Add checkout-alternate for no-script and/or script-error conditions.
Having an odd issue on a client's site after upgrading this plugin from 1.2.0 to the latest 1.3.0.
All displays fine but the "Confirm The Order" button is not responding, it indicates the underlying link when hovering over the button but does nothing when clicked. I checked all new files for presence in the right folder(s), no problem. Could it be just a clash of jscripts?
The module is currently only enabled to work conditionally, i.e only displays when I am logged in. Can supply site URL and my login details by PM if required. Also set up customer relevant debugging so can email log file(s).
Cheers / Frank
I installed this module for my client.
When I checkout using this module, everything works fine except it creates a log file in the logs folder
Contents of the log file (just pasting only a part of it)
2017-07-17 12:27:40 checkout_one: CHECKOUT_ONE_ENTRY, version (1.2.0 (2017-04-23)), Zen Cart version (1.5.5e), template (yabba_shop)
2017-07-17 12:27:40 checkout_one: CHECKOUT_ONE_AFTER_SHIPPING_CALCULATIONS, pass (), free_shipping (), (not set)
2017-07-17 12:27:40 checkout_one: CHECKOUT_ONE_AFTER_SHIPPING_QUOTES
array (
'id' => 'perweightunit_perweightunit',
'title' => 'Per Unit (Best Way)',
'cost' => 2.45000000000000017763568394002504646778106689453125,
'module' => 'perweightunit',
)order Object
(
[info] => Array
(
[order_status] => 1
[currency] => GBP
[currency_value] => 1.00000000
[payment_method] =>
[payment_module_code] =>
[coupon_code] =>
[shipping_method] => Per Unit (Best Way)
[shipping_module_code] => perweightunit_perweightunit
[shipping_cost] => 2.45
[subtotal] => 4
[shipping_tax] => 0
[tax] => 0
[total] => 4
[tax_groups] => Array
(
[0] => 0
)
[comments] =>
[ip_address] => 81.132.142.146 - 81.132.142.146
)
[totals] => Array
Is it an error or its normal?
In Admin > Configuration > One-Page Checkout Settings, do you have "Enable One-Page Checkout Debug?" set to true? If so, just set it to "false".Quote:
Originally Posted by mani
Thank you so much!Quote:
Originally Posted by frank18
Frank, check your browser's console for javascript/jQuery errors after the OPC jQuery loads. I've got some protection in there if a jQuery error was detected prior to the OPC load, but if there's an error afterwards ... the submit/review buttons are inoperable.Quote:
Originally Posted by frank18
Those buttons now result in a form-submittal only via jQuery call, as part of the payment-module interoperation. If a jQuery error were registered prior to the OPC load, there would be a message on the screen notifying the customer with a link that will result in the "normal" 3-page checkout process to do its thing.
You can send me the link/credentials via PM or email; it might be sometime tomorrow betore I can take that peek.
Did that, console shows no error at all. That's in Firefox, same error in Opera and Chrome.Quote:
Originally Posted by lat9
Check PM
Cheers / Frank
Hmm, none of the jQuery events for OPC are "firing"; changes to the shipping-method don't result in the AJAX call to change the shipping cost and changes to the payment method don't cause the payment-type/submit-button display to be invoked.
What I see in the FireFox console:
In the Chrome console:Code:setFormSubmitButton, payment-module: null index.php:191:13
Showing "confirm" index.php:191:13
Setting orderConfirmed (0), submitter (null) index.php:191:13
jQuery version: 1.12.0 index.php:191:13
window.controllers is deprecated. Do not use it for UA detection. index.php
None of the OPC's jQuery events are firing. You should see console logs when the shipping-method and/or payment-method are changed, but I'm seeing nothing after the OPC's initial load. I'll continue investigating, but wanted to report back to let you and others know what's going on.Code:index.php:25 A Parser-blocking, cross site (i.e. different eTLD+1) script, https://code.jquery.com/jquery-1.12.0.min.js, is invoked via document.write. The network request for this script MAY be blocked by the browser in this or a future page load due to poor network connectivity. If blocked in this page load, it will be confirmed in a subsequent console message.See https://www.chromestatus.com/feature/5718547946799104 for more details.
index.php:956 A Parser-blocking, cross site (i.e. different eTLD+1) script, https://ssl.google-analytics.com/ga.js, is invoked via document.write. The network request for this script MAY be blocked by the browser in this or a future page load due to poor network connectivity. If blocked in this page load, it will be confirmed in a subsequent console message.See https://www.chromestatus.com/feature/5718547946799104 for more details.
(anonymous) @ index.php?main_page=checkout_one:956
index.php:191 setFormSubmitButton, payment-module: null
index.php:191 Showing "confirm"
index.php:191 Setting orderConfirmed (0), submitter (null)
index.php:191 jQuery version: 1.12.0
@frank18, it appears that the site's Google tracking script is not playing nice with OPC:
More investigation required ...Code:<script type="text/javascript">
var gaJsHost = (("https:" == document.location.protocol) ? "https://ssl." : "http://www.");
document.write(unescape("%3Cscript src='" + gaJsHost + "google-analytics.com/ga.js' type='text/javascript'%3E%3C/script%3E"));
</script>
<script type="text/javascript">
try {
var pageTracker = _gat._getTracker("UA-xxxxx-1");
pageTracker._trackPageview();
} catch(err) {}</script>
v1.3.0 is now available for download from the plugins.Quote:
Originally Posted by lat9
I replaced the Google tracking script to eliminate document.write but still have same issue.Quote:
Originally Posted by lat9
Interesting that document.write is still used in the latest ZC 1.5.5e in includes/templates/template_default/common/html_header.php, around lines 123-124
but a Google search for "alternative to document.write" returns umpteen documents stating that document.write is an outdated and even bad way to use it.Code:<script type="text/javascript">window.jQuery || document.write(unescape('%3Cscript type="text/javascript" src="//code.jquery.com/jquery-1.12.0.min.js"%3E%3C/script%3E'));</script>
<script type="text/javascript">window.jQuery || document.write(unescape('%3Cscript type="text/javascript" src="<?php echo $template->get_template_dir('.js',DIR_WS_TEMPLATE, $current_page_base,'jscript'); ?>/jquery.min.js"%3E%3C/script%3E'));</script>
Yes. It was still somewhat in vogue when that template was initially created. Are you suggesting it should be ripped out during a "point release" and not wait for a "major version release"?Quote:
Originally Posted by frank18
Keep in mind that the majority of people who have contributed templates or who google for help with pretty much any javascript-driven stuff are gonna find or use outdated methods ... and most won't have a clue how to use many of the so-called "better" methods.
Furthermore, you do realize that the code you're referring to is ONLY a catch-all in case the CORRECT loading of jquery hasn't already happened earlier. Those two script lines should NEVER trigger anything if the template is working as designed out of the box
Thanks Doc, we are just trying to get errors with OPC fixed as per lat9's post #470.Quote:
Originally Posted by DrByte
Eliminated one possible source, namely the Google Analytics issue but still investigating the other in that post.
Thanks for trying that, Frank. I also noticed that you're using jQuery 1.12.0 while my test site was using 2.1.4; unfortunately, downleveling the jQuery version did not lead me to replication of the site's interoperability issue.Quote:
Originally Posted by frank18
Whenever using jQuery 1.12.x or 2.2.x I always advocate to also use jQuery Migrate which helps with backwards capability; ie. JS code that needs an earlier version of jQuery to work properly. It is a shim that is most handy. Save it on your hosting account though as calling it locally is faster.
Thanks, I'll keep that in mind ... although I'm not sure it applies in the current case as I'm able to checkout with OPC using either jQuery 1.12.x or 2.1.4.Quote:
Originally Posted by Website Rob
As you are someone who checks their code beforehand I'm sure your code is not the problem. :smile:Quote:
Originally Posted by lat9
Where I found the jQuery Migrate to be very helpful is when old custom code or outdated modules are being used, which can be difficult to find / correct on errors. Not saying that is that case here either but Migrate is now a tool I use without even thinking about it.
Ok, problem solved.Quote:
Originally Posted by frank18
This morning I decided to revive the local clone of this site so I could play with various scenarios including deleting files at will without interupting a live site.
Long story short, on the local clone I had a few more files for Zen Lightbox. Found out that things started to work after deleting ../jscript/jquery-1.12.0.min.js and ../jscript/jquery.min.js. A peek at the source showed the output of ../jscript/jscript_zen_lightbox.php including a call for jquery-1.11.3.min.js - and the lightbulb went off!!! Gotcha, bugger!!
So made all look the same on the live site (deleting and modifying a few files) and bingo, OPC was up and running. As I suspected from the outset, there had to be a clash of some jscripts. This was not the case when that site had OPC 1.2.0 running....
Thanks for that, @frank18! I'll investigate further as it looks like I might be able to use the jQuery.noConflict method to provide a work-around for those multiple versions of jQuery being loaded in an OPC update.
How do you install/turn this module on, or it it already on once you upload it?
Installation details are in the docs which comes with this module. To activate / deactivate it you do that in Admin > Configuration > One-Page Checkout Settings > Enable One-Page Checkout? - set to True or False (also described in the docs).Quote:
Originally Posted by rapidfinancia1
That would be tops indeed! Many sites have different other mods installed which are using jQuery of some varying degree. Would eliminate a lot of hassles and head scratching.Quote:
Originally Posted by lat9
So that I do not get things wrong and my site crashes and I have never updated any plugin's; I am currently using v1.1.0, 2017-01-22 and For obvious reasons i want to update to v1.3.0, 2017-07-12 van I miss out v1.2.0, 2017-04-23?
Also when I look at the plugin files to upload one file set says zen155a. I have the latest copy of Zencart, v.1.5.5e running so, does this work with zen155e or is it a case of use it but it may not work, and if it does work, please let me know?
[QUOTE=adb34;1332783]Also, Reading the 'Change History' some of the files affected are in Pink. I cannot find out why the different colour, so would it be possible to explain the different colour?
From the very top of the "Change History" tab in the readme:Quote:
Originally Posted by adb34
Code:Changes to the plugin's default templates are identified in this color; remember to merge those changes with any template-override version you might have created!
The changes in the /zc155a directory are, as indicated in the readme, only for Zen Cart 1.5.5a. Those changes are already in the "core" for Zen Cart 1.5.5b and later.Quote:
Originally Posted by adb34
The plugin has been tested with Zen Cart versions up to and including Zen Cart 1.5.5e.
I am getting the same message. "Your order's details have changed. Please review the current values and re-submit" and keeps looping to the same message.Quote:
Originally Posted by lat9
Setup:
OPC 1.2
zenCart 1.54
Responsive Sheffield Blue 2.0
Braintree
I started to have this problem this weekend. Before it was working fine. I believe I had an earlier version when I mysteriously started to have this problem. I installed version 1.3 and got another message saying Can't use this method and a link to the zencart 3 page checkout. So I installed version 1.2 and now still have the original message "Your order's details have changed. Please review the current values and re-submit" and it continues to loop.
Any help will be appreciated. Need any additional information. Just let me know.
Frank
The highlighted message that you received using OPC 1.3.0 is most likely indicative of the issue you're having. Your store apparently has a jQuery conflict that is not allowing OPC to do its thing. That's why that link to the 3-page checkout is there, so that your store can continue to generate business while you're sorting out what those issues/conflicts are.Quote:
Originally Posted by fjbern1943
Hi, Since I had no idea how to fix the OPC 1.30 version and still don't, I reverted back to OPC 1.20 but get the looping with the "Your order details have changed" message. What is causing the OPC version 1.20 from working? Is the jQuery problem also effecting version 1.20?Quote:
Originally Posted by lat9
Frank
If you'll send me the link to your site via PM, perhaps I can see something.
The loop that you're in for OPC 1.2.0 is most likely due to the jQuery issue that was exposed by 1.3.0's updated messaging.
I have version 1.2 installed and just sent PM with the site url.Quote:
Originally Posted by lat9
Thanks, Frank
Sorry, I cannot read. Hidden in plain siteQuote:
Originally Posted by lat9
I'll expand that colored span to cover a couple more words, as emphasis. If you didn't "see" it, then it's likely that others won't either!Quote:
Originally Posted by adb34
Not everyone is able to see our lovely colors. And not everyone is familiar with the US's 508 accessibility standards.
These requirements only legally apply to those actually in, or working for/with, the US government. However, some of the information can be very helpful to us in making sure our customers don't miss something important.
https://standards.usa.gov/components/colors/ is a list of colors meant to make it easier for anyone to see the color AND the contrast between the color and background. Contrast is king when it comes to colors on a website.:yes:
For those that want to bypass the lesson and find a good color contrast, this tool will help you out.:smartalec:
Is version 1.3.0 compatible with ZenCart 1.5.5e?
Any special instructions for ZenCart 1.5.5e?
Yes, and maybe. You'll find a very comprehensive explanation of all those questions and more in the /docs/one_page_checkout/readme.html file included with the mod download.
The docs do not reference anything about 1.5.5e that I can find.
Okay, since you weren't specific, the answer yes was for the first question,The reference to the docs for further info was due to the fact you didn't specify what other mods you are currently using with your 1.5.5e.Quote:
Is version 1.3.0 compatible with ZenCart 1.5.5e?
If you scroll to the bottom section of the readme.html, you'll find a statementIf your shipping method, order total, or payment method is NOT listed, you'll need to experiment. This mod does not currently work with lat9's multiship mod.Quote:
The plugin has been validated on Zen Cart 1.5.4 and Zen Cart 1.5.5a through Zen Cart 1.5.5e, using the following shipping, order-total and payment methods:
We'd love to know if find anything that needs to be added to this list or something that is not working.