Re: Super Orders v4.0 Support Thread (for ZC v1.5.x)
How are you not throwing dozens of errors on the lack of quotes around all of these things like this ENTRY_AMOUNT_APPLIED_CUST v this 'ENTRY_AMOUNT_APPLIED_CUST' all throughout all these files???
Anyway looks very similar at least I know I wasn't nuts with my solutions.
Re: Super Orders v4.0 Support Thread (for ZC v1.5.x)
Quote:
Originally Posted by
lat9
There are still a slew of core-file overwrites (notably the order.php class and the admin's orders.php) that I thought could be handled now using the Zen Cart notify/observe processing. Couldn't those language-file updates be migrated to a separate extra_definitions file so that they don't require updates as well?
Yes, I suspect some of the core file overwrites could be handled using notify/observer processing; however I was on a tight timescale to get a working version into a site that a client was pushing to get put live. For sure the language edits could go into extra_definitions files too.
When I'm not so busy I'll try and find time to look at improving things further.
Re: Super Orders v4.0 Support Thread (for ZC v1.5.x)
Quote:
Originally Posted by
JimmyV
How are you not throwing dozens of errors on the lack of quotes around all of these things like this ENTRY_AMOUNT_APPLIED_CUST v this 'ENTRY_AMOUNT_APPLIED_CUST' all throughout all these files???
Anyway looks very similar at least I know I wasn't nuts with my solutions.
When it's defined you use the quotes like
Code:
define('ENTRY_AMOUNT_APPLIED_CUST', 'Amount Applied:');
but when you output the define you just do
Code:
echo ENTRY_AMOUNT_APPLIED_CUST;
If you put quotes around it like
Code:
echo 'ENTRY_AMOUNT_APPLIED_CUST';
then it will literally echo ENTRY_AMOUNT_APPLIED_CUST to the screen.
Re: Super Orders v4.0 Support Thread (for ZC v1.5.x)
Yes several things that didn't work on mine work on yours so clearly you have a better handle on it although I never use these things like the payment options etc but it is nice to have them working properly.
I also appreciate you labelled the edits which drove me nuts as some were labelled and some were labelled with a persons initials etc.
Re: Super Orders v4.0 Support Thread (for ZC v1.5.x)
Quote:
Originally Posted by
strelitzia
Yes, I suspect some of the core file overwrites could be handled using notify/observer processing; however I was on a tight timescale to get a working version into a site that a client was pushing to get put live. For sure the language edits could go into extra_definitions files too.
When I'm not so busy I'll try and find time to look at improving things further.
Thanks for that; I realize that it was a big project! One other thing to consider is that I've now got a Ty Package Tracker (https://github.com/lat9/zen_TyPackageTracker) that's a drop-in solution and integrates with both the zc157 orders.php and now-current versions of Edit Orders.
Re: Super Orders v4.0 Support Thread (for ZC v1.5.x)
Quote:
Originally Posted by
lat9
Thanks for that; I realize that it was a big project! One other thing to consider is that I've now got a Ty Package Tracker (
https://github.com/lat9/zen_TyPackageTracker) that's a drop-in solution and integrates with both the zc157 orders.php and now-current versions of Edit Orders.
...and it works beautifully!
Re: Super Orders v4.0 Support Thread (for ZC v1.5.x)
Quote:
Originally Posted by
strelitzia
yes, i suspect some of the core file overwrites could be handled using notify/observer processing; however i was on a tight timescale to get a working version into a site that a client was pushing to get put live. For sure the language edits could go into extra_definitions files too.
When i'm not so busy i'll try and find time to look at improving things further.
checking to see if or anyone else has updated this yet - i'm only looking for the batch status functionality for 1.5.7c
Re: Super Orders v4.0 Support Thread (for ZC v1.5.x)
Quote:
i'm only looking for the batch status functionality for 1.5.7c
I've done that...I'll see if I can prep it for 157 soon...
Re: Super Orders v4.0 Support Thread (for ZC v1.5.x)
Re: Super Orders v4.0 Support Thread (for ZC v1.5.x)