[Done 155b] Shipping tax not added in order confirmation - possible bug??

Note! DrByte has added the fix for v1.5.5b:

https://www.zen-cart.com/showthread....61#post1312461

-> https://github.com/zencart/zencart/pull/1034

Quote:

---

Originally Posted by DrByte

As an EXPERIMENT (no guarantees here with this idea), you could try the following...

/includes/modules/checkout_process.php
Around line 51 you'll see this section of code:

Code:

---

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

---

Try moving the shipping-module part down a few lines, like this:

Code:

---

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

$shipping_modules = new shipping($_SESSION['shipping']);


---

Note: ZC v155b includes this fix:
https://github.com/zencart/zencart/pull/1034

---

Having the same problem in 1.5.5e

I noticed the code had been moved around like this:

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

So I am just trying to move it in the same order as your post, like this to see if it fixes the issue.

So its like this:

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;
$shipping_modules = new shipping($_SESSION['shipping']);

@Nick1973; the change required that the order-class object be created prior to the shipping-class object ... so both the post that you reference and the code that's in the ZC 1.5.5e contain the same processing.

Make sure, too, that you don't have a template-override version of the checkout_process.php handling (i.e. /includes/modules/YOUR_TEMPLATE/checkout_process.php) that doesn't include the update.

Quote:

---

Originally Posted by lat9

@Nick1973; the change required that the order-class object be created prior to the shipping-class object ... so both the post that you reference and the code that's in the ZC 1.5.5e contain the same processing.

Make sure, too, that you don't have a template-override version of the checkout_process.php handling (i.e. /includes/modules/YOUR_TEMPLATE/checkout_process.php) that doesn't include the update.

---

No definitely no override file.

VAT is set up using the core Zen Cart System. There aren't any plugins calculating VAT other table rate shipping.

Shipping is set up using Table Rate Clones, similar to what people have talked about in this thread.

Please see the screenshots in the zip file in this link:

https://www.ventureonlineuk.co.uk/screenshots.zip

These will help you understand how shipping has been set up in the cart.

Quote:

---

Originally Posted by Nick1973

So I am just trying to move it in the same order as your post, like this to see if it fixes the issue.

So its like this:

PHP Code:

---

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;
$shipping_modules = new shipping($_SESSION['shipping']); 


---

---

So has this actually fixed your issue??

Quote:

---

Originally Posted by frank18

So has this actually fixed your issue??

---

Not sure yet, I am waiting for an order at the moment. I will try and test it shortly though. I realised after that my SSL was out of date on my site so you may have got a security error.

Quote:

---

Originally Posted by Nick1973

Not sure yet, I am waiting for an order at the moment. I will try and test it shortly though. I realised after that my SSL was out of date on my site so you may have got a security error.

---

SSL now fixed so you should be able to get to the attachments.

Quote:

---

Originally Posted by Nick1973

SSL now fixed so you should be able to get to the attachments.

---

Ok even after making the change as stated by Dr Byte and switching the table rate modules off then back on, VAT is still not being charged on delivery.

Quote:

---

Originally Posted by Nick1973

Ok even after making the change as stated by Dr Byte and switching the table rate modules off then back on, VAT is still not being charged on delivery.

---

In this thread that was started, the report was that VAT was not being calculated in the admin. Then here it was reported that operation of the store was the same as previously reported in this thread. So far, no data has been shown about what is actually happening.
Ie.
What does the order confirmation show?
What is the result in the various locations within the admin where the issue seems to appear?
During the checkout process where does the "calculation" appear incorrectly?
What payment module(s) are involved?
How has the store been otherwise modified or amplified (what files have been added or attempted to be renamed)?