COWOA (for ZC v1.5.x)

[Rizla]

Hi Dave
I have checked and re-checked tpl_header.php and there is really no change to the file apart from version.

Can you make a purchase using 'returning customer' ?

If so, then I may have missed a merge and will re-check

[Rizla]

Please Ignor

[Rizla]

Using Beyond Compare (now) and found some merges from original template file.... So log off is now working

[DivaVocals]

I installed github version, on a ZC 1.5.3 test site, with responsive sheffield blue and links manager installed, could not get it to reproduce the error!! I did a full checkout with out an account, stopped and added, deleted then finely deleted all items, no problems... created an account, checked out same, no problems... can not recreate the error.. login/logoff is performing as should be... COWOA is performing as expected.... if I trashed the login script on common/tpl_header.php I can get login/logoff issues, but I have to destroy all of it... Without looking at your files, I would have to say you need to go back and recopy the files over. If you have a heavy modified site, you may have to do some editing to get common/tpl_header.php coded right.
I will have to see how much space I have left then maybe do a fork for the installation issue fix...

Thanks for verifying things Dave.. Honestly, I didn't think there was an issue with the modules files.. As I USUALLY do, I spent a fair bit of time working on this version before publishing the Github repo here.. I have made quitea few changes this go around, and want to make sure it all worked before shring.. I felt that Rizla's issue was more likely an install issue due to errant merges or files not being copied over. That said it's POSSIBLE that the install SQL might require a once over.. So I APPRECIATE the assist sir!

[Rizla]

I can confirm that I have gone through every file and merged where required, and they were template files only. Hence my 'log off' now appears.

I have also removed and re-installed twice today including the SQL and can confirm that on my site at least, returning customer does not work.
I get the following error in the logs:

[19-Jul-2014 16:32:34 Europe/London] PHP Fatal error: Call to undefined function password_needs_rehash() in /home/metalpix/public_html/includes/modules/pages/login/header_php.php on line 68

IF, I enter an incorrect password in the 'existing customer' fields then it correctly displays the system error that no one exists with that user name or password, as expected.

If I fall to my backup with the original COWOA, then all works.

Hope this helps

[davewest]

Hi
Looking through the file structure.... Am I correct in assuming there is only one file (audience.php) to upload IF we are upgrading?
OR do I need to overwrite all files?

Thanks

Going back through your post to try and figure out what your doing.... not giving us much to go on. but this file audience.php is a core ZC file, not part of COWOA! not modified by COWOA...

[19-Jul-2014 16:32:34 Europe/London] PHP Fatal error: Call to undefined function password_needs_rehash() in //includes/modules/pages/login/header_php.php on line 68

COWOA does not mess with how ZC handles passwords, password_needs_rehash() is not a COWOA function, just hides things when someone checks out thinking they did not create an account.... does not change how existing accounts work!

I can not recreate the problem so guessing you did something else from your comments that's not an COWOA issue. are you doing this on a test site or live! hopfully you are working on a test site... I would re-install ZC and start over...

[Rizla]

<Sigh> Please take the time to a least read through ALL the threads.... That asked BEFORE I contemplated installation!
Dave, I asked a simple question.... Can you make purchase through 'Returning Customer' ??

'IF' you CAN.... Then I have something 'a' miss... You have not given me an answer o that question.

All files that are 'template' related I have now 're-merged' Originally using winmerge but swapped for beyond compare. All template file are merged correctly. Hence my original problem went away. (log out) as stated!

All the other files are a simple over write of the COWOA files from the old version (or am I mistaken?)

COWOA was working fine, until the upgrade and now I have the one issue.... Somewhere it 'aint reading the DB although it does as far as entering an invalid P/W... That it will pick up on.

So..." password_needs_rehash()" is NOT an error through the new COWOA then? As NOTHING has changed BUT the installation of the new COWOA.... Curious to say the least

"I can not recreate the problem so guessing you did something else from your comments that's not an COWOA issue. are you doing this on a test site or live"

LIVE

"I would re-install ZC and start over... " There is a thing called BACK-UP reinstall... lol forget it!

Now Dave... Can you use the 'returning customer' ?? ALL I ASKED

[davewest]

I installed github version, on a ZC 1.5.3 test site, with responsive sheffield blue and links manager installed, could not get it to reproduce the error!! I did a full checkout with out an account, stopped and added, deleted then finely deleted all items, no problems... created an account, checked out same, no problems... can not recreate the error.. login/logoff is performing as should be... COWOA is performing as expected....

As above... yes... I can create new, login/logout, delete, and recreate accounts and all is good... COWOA doesn't affect how ZC functions as to accounts, only hide the fact that an account was created during checkout...

"I would re-install ZC and start over... " There is a thing called BACK-UP reinstall... lol forget it!

Now Dave... Can you use the 'returning customer' ?? ALL I ASKED

If you are talking non-account returning, yes no problem... if your asking about account holders, yes, no problem... restoring form a GOOD backup yes... bad one.... not so good...
Without looking at your site we are working with only what your willing to tell us... maybe I missed this... but what is it your working with!
is this a new ZC1.5.3 or an upgrade? if so, how did you do the upgrade!
What version of PHP, MySQL is it running on

Anyway... running out of time and I don't seem to be helping you much.... off to work I go.. hope to be back in 14-28 days...

[DivaVocals]

Going back through your post to try and figure out what your doing.... not giving us much to go on. but this file audience.php is a core ZC file, not part of COWOA! not modified by COWOA...

Actually there is a "bandaid fix" to the duplicate customer records for those upgrading to the latest version of COWOA.. This change is not required for new installations of COWOA. It relates to this issue: https://github.com/DivaVocals/zen_COWOA/issues/5. A true solution to this issue would eliminate the need for this modification to the includes/functions/audience.php file for those upgrading from older versions of COWOA..

[DivaVocals]

Thanks for trying to help out Dave.. I'd like to add to what you've posted here..

Rizla, in my ORIGINAL post announcing the latest version of COWOA, I made it clear that it was a BETA release for TESTING feedback BEFORE submission to the plugins section here. If you go to the original post, I made the subject line so this was CRYSTAL clear..

http://www.zen-cart.com/showthread.p...42#post1252042

Here's the changelog:
v2.6 - 07/10/2014

Updated for Zen Cart v1.5.3
Fix bug with downloads being prevented for COWOA when 'Enable Forced Logoff' was turned on (dwest)
ref: http://www.zen-cart.com/showthread.p...75#post1246575
Additional improvements to onscreen text/labels
MANY improvements to the login page:
Eliminate the need for an unnecessary click to create an account by making the "Create Account" available on the login page.
Addition of "Shop with Confidence" and "Customer Service" content boxes (admin control to turn on/off and content managed via the banner manager)
Move guest checkout field-set to the top of the page for better user visibility

Would like folks to test and report back issues they find, and once it seems like everything is working okay, I will submit to the downloads..

Here's the link to the GitHub repo: https://github.com/DivaVocals/zen_COWOA

I also made sure the readme for the Github repo CLEARLY states that this is a BETA release

This is a development version of COWOA only

If you are looking to install the latest version from zencart please visit this page

If you need basic installation help, and the included readme does not help you, please visit the COWOA Support Thread

While this release came from changes I made for a number of my clients on their live stores, and I have tested it, I STILL would NOT suggest anyone install this BETA version on a live store UNLESS and UNTIL they too have done their own testing on a DEVELOPMENT STORE.. Which is why I posted the link to the Github repo to get TESTING feedback and make any changes required before submitting this new version of COWOA to the Zen Cart downloads. This was NEVER meant to be a "sneak preview/early release" version. If it was I would have clearly stated this.

Dave is right, at this point we cannot help you because we CANNOT recreate your test findings.. You need to roll back your live store, then create a proper dev/test clone of your store which is the ONLY PLACE you should be installing this version of COWOA to make SURE it works in your setup BEFORE moving it over to your live site. Testing should NEVER be done on a live store.. This is NO DIFFERENT than how any other Zen Cart upgrade should work whether it's the core code or a new/updated module..

You also need to provide a LOT more information than you have provided.. (Zen Cart version, what version of COWOA you are upgrading from, and any other relevant information)

As above... yes... I can create new, login/logout, delete, and recreate accounts and all is good... COWOA doesn't affect how ZC functions as to accounts, only hide the fact that an account was created during checkout...



If you are talking non-account returning, yes no problem... if your asking about account holders, yes, no problem... restoring form a GOOD backup yes... bad one.... not so good...
Without looking at your site we are working with only what your willing to tell us... maybe I missed this... but what is it your working with!
is this a new ZC1.5.3 or an upgrade? if so, how did you do the upgrade!
What version of PHP, MySQL is it running on

Anyway... running out of time and I don't seem to be helping you much.... off to work I go.. hope to be back in 14-28 days...

<Sigh> Please take the time to a least read through ALL the threads.... That asked BEFORE I contemplated installation!
Dave, I asked a simple question.... Can you make purchase through 'Returning Customer' ??

'IF' you CAN.... Then I have something 'a' miss... You have not given me an answer o that question.

All files that are 'template' related I have now 're-merged' Originally using winmerge but swapped for beyond compare. All template file are merged correctly. Hence my original problem went away. (log out) as stated!

All the other files are a simple over write of the COWOA files from the old version (or am I mistaken?)

COWOA was working fine, until the upgrade and now I have the one issue.... Somewhere it 'aint reading the DB although it does as far as entering an invalid P/W... That it will pick up on.

So..." password_needs_rehash()" is NOT an error through the new COWOA then? As NOTHING has changed BUT the installation of the new COWOA.... Curious to say the least

"I can not recreate the problem so guessing you did something else from your comments that's not an COWOA issue. are you doing this on a test site or live"

LIVE

"I would re-install ZC and start over... " There is a thing called BACK-UP reinstall... lol forget it!

Now Dave... Can you use the 'returning customer' ?? ALL I ASKED