Image Manager addon

[boudewijn]

I've been using IM for over a year and I love it, but something new has come up. I can upload a product image through the new product form and see the original just fine. The problem appears when I make medium and large versions - the generated images have the wrong permissions and don't appear.

I've tested using my FTP program. I can see them appear with permissions of 600 and manually changing them to 644 makes everything work.

ZC v.1.3.9h, IM v.1.7, hosted at GoDaddy.

Any help, TIA.

Hi,

I couldn't say how to set the default or inherited rights for newly created files , as my knowledge of Nix is very limited. A simple solution may lay in that area.
However, we can try to fix it in the program.
Follow these steps:

1. edit <admin>/includes/functions/extra_functions/function_image_manager.php
2. Go to line 968, which reads:

imagedestroy ($temp);

3. BEFORE that line, insert the following statement:

chmod($dst, 0644);

4. Save the file and upload it to your server

Please let me know if this fixes the problem.

Boudewijn

[billy565]

Please let me know if this fixes the problem.

Thanks for the speedy reply! Yes, it fixed part of the problem. Now the new med/lrg images have the right permissions.

Any idea how to fix the re-uploading permissions? I looked at <admin>/image_manager_upload.php but it uses a different process.

Thanks again.

[boudewijn]

Thanks for the speedy reply! Yes, it fixed part of the problem. Now the new med/lrg images have the right permissions.

Any idea how to fix the re-uploading permissions? I looked at <admin>/image_manager_upload.php but it uses a different process.

Thanks again.

In that file, insert after line 70, which reads:

$messageStack->add_session(IM_REPLACED . ' ' . DIR_FS_CATALOG_IMAGES . $p['dirname'] . '/' . $p['basename'], 'success');

the following line:

chmod(DIR_FS_CATALOG_IMAGES . $p['dirname'] . '/' . $p['basename'], 0644);

and add after line 91, which reads:

$messageStack->add_session(IM_ADD_SUCCESS . ' ' . DIR_FS_CATALOG_IMAGES . $p['dirname'] . '/' . $p['filename'] . '_' . $_POST['IMsuffix'] . '.' . $p['extension'], 'success');

the following line:

chmod(DIR_FS_CATALOG_IMAGES . $p['dirname'] . '/' . $p['filename'] . '_' . $_POST['IMsuffix'] . '.' . $p['extension'], 0644);

They are fixes for both re-upload and add additional images.

Please let me know the results, as I cannot test it here.

Boudewijn

[billy565]

Perfect. Thanks!

I tested the re-upload function as well as the add additional image, plus the combined copy/shrink function. No issues.

Thanks again.

[cmccreath]

Hi
Just downloaded version 1.8. First time installation on Zencart 1.38a.
I've downloaded the zip file twice from the Zencart site, but neither contain an "install.sql" or "uninstall.sql". Maybe I'm just misreading the instructions......

[boudewijn]

Hi
Just downloaded version 1.8. First time installation on Zencart 1.38a.
I've downloaded the zip file twice from the Zencart site, but neither contain an "install.sql" or "uninstall.sql". Maybe I'm just misreading the instructions......

Hi,

No, you are right. The instructions should have read "install_zc_1.3.sql" and "uninstall_zc_1.3.sql". I will correct the instructions in the next version. Thanks for mentioning this.

Boudewijn

[gothstone]

I'm working on updating to zencart 1.5 and switching to image manager from image handler at the same time. There seems be a logic flaw in listing files with errors. Heres the secario to recreate: My large image size is set to 750x550. I upload an immage thats 768x1024 (portrait instead of landscape). It creates the large image at 413x550 as it should. It then lists the image as an error, presumably because its undersized width wise.

Aditionaly, on some occasions I would upload a file smaller (both height and width) than the large image size. It will not create the large image. That makes sence, but it always shows as an error, so I can't use autofix to resize the rest.

[gothstone]

The best aproach might be to make autofix run what actions it can, but skip the actions it can't handle. It get "hung up" on images that have a height or width less than the max size.

[gothstone]

Ok, I found the heart of my issues, and some crappy workarounds. Mabey tomorrow I will be awake enough to actualy fix them. For now, heres what I have:

Function_image_manager.php
lines 337-341
This code check the size of the large image agains the max medium image size. If all my images were the same proportions this would be great. Unfortunately if my max medium is 300x240 and my origional image is 600x229 I'm SOL.
What I want is a large image of 600x229, a medium of 300x114 and a small of 145x55
To hack this for now I change the || on line 341 to &&
The real way to handel this would be to compare to the actual size of the created medium image. Of course first we would have to make sure it exists and get it size, or if it doesn't exist, make sure it could resize and calculate what size it would be. Ugg.

lines 500-507
This currently compares the small image to the max medium image width. Same problems as above. Solution is to replace line 503 with this: if ($image["small"]["width"] > IM_MAX_LARGE_WIDTH || $image["small"]["height"] > IM_MAX_LARGE_HEIGHT) {
Thats sorta works for now, but it needs a secondary check to make sure the large image will be larger than the medium image.

[boudewijn]

Ok, I found the heart of my issues, and some crappy workarounds. Mabey tomorrow I will be awake enough to actualy fix them. For now, heres what I have:

Function_image_manager.php
lines 337-341
This code check the size of the large image agains the max medium image size. If all my images were the same proportions this would be great. Unfortunately if my max medium is 300x240 and my origional image is 600x229 I'm SOL.
What I want is a large image of 600x229, a medium of 300x114 and a small of 145x55
To hack this for now I change the || on line 341 to &&
The real way to handel this would be to compare to the actual size of the created medium image. Of course first we would have to make sure it exists and get it size, or if it doesn't exist, make sure it could resize and calculate what size it would be. Ugg.

lines 500-507
This currently compares the small image to the max medium image width. Same problems as above. Solution is to replace line 503 with this: if ($image["small"]["width"] > IM_MAX_LARGE_WIDTH || $image["small"]["height"] > IM_MAX_LARGE_HEIGHT) {
Thats sorta works for now, but it needs a secondary check to make sure the large image will be larger than the medium image.

I am aware that it's by design that both dimensions must meet the defined minima. But I can also make this an option (choice OR or AND). Or, to go to the bottom, 3 choices: height, or width, or both must meet the minimum. What do you think?