Results 1 to 10 of 12

Hybrid View

  1. #1
    Join Date
    Jun 2006
    Posts
    440
    Plugin Contributions
    0

    Default Re: <meta name="description" content="MY_IMPORTANT_HOME_PAGE_DESCRIPTION" />

    HI Rod,

    thanks for your detailed reply. I considered everything after comparing the zen cart files with the original and I can see that that snippet should not be there at all. All I can suggest is that somehow it got introduced a couple of years ago when somone upgarded a zen version for me.. I think it basically stops the echo of the meta_tags.php. and it's not that the define is missing on that page.

    Having tried a delete of that snippit.. the page appears to function as it should http://www.colourshield.com/store well at least I think so....The description now appears correctly if you view source on that page.

    I truly hope I did the right thing and not broken something, though if the code is not on the original zen html_header.php I would guess I did good (or should I say hope)

    All the Best
    Renz

  2. #2
    Join Date
    Jan 2007
    Location
    Australia
    Posts
    6,167
    Plugin Contributions
    7

    Default Re: <meta name="description" content="MY_IMPORTANT_HOME_PAGE_DESCRIPTION" />

    Quote Originally Posted by Renz View Post
    Having tried a delete of that snippit.. the page appears to function as it should http://www.colourshield.com/store well at least I think so....The description now appears correctly if you view source on that page.

    I truly hope I did the right thing and not broken something,
    I think it is pretty safe to assume that you didn't break anything with the deletion. If you had, you'd certainly know about the first time you went to the page.

    Cheers
    Rod

  3. #3
    Join Date
    Jan 2004
    Posts
    66,443
    Plugin Contributions
    279

    Default Re: <meta name="description" content="MY_IMPORTANT_HOME_PAGE_DESCRIPTION" />

    The correct solution would be to leave the html_header.php file alone, and simply add the missing define to the language file, as I described initially.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  4. #4
    Join Date
    Jun 2006
    Posts
    440
    Plugin Contributions
    0

    Default Re: <meta name="description" content="MY_IMPORTANT_HOME_PAGE_DESCRIPTION" />

    Hi Dr. Byte,

    Unfortunately, I am not as knowledgeable as you in php matters, and I had to take some action, 'other than being told I deleted soemthing' as I said in this post, that the define was not missing it was there.
    I dont understand why you say I should have left it (html_header.php) alone, when it was not a page from zen cart a page that bears your signature, I am sure you have your reasons but without some explanation to a novice I am none the wiser, I do know that having made that html_header.php original to what it was when I downloaded zen cart the, problem has gone and all seems fine..

    Kind Regards
    Renz

  5. #5
    Join Date
    Jan 2004
    Posts
    66,443
    Plugin Contributions
    279

    Default Re: <meta name="description" content="MY_IMPORTANT_HOME_PAGE_DESCRIPTION" />

    Quote Originally Posted by Renz View Post
    I do know that having made that html_header.php original to what it was when I downloaded zen cart the, problem has gone and all seems fine..
    Perhaps I missed something in the dialog that's happened over several days.
    Using the original code that came with the original Zen Cart files is usually the safest and most correct "fix".
    That's what I was referring to when I said that it's best not to touch the html_header.php file. I thought that you'd followed a suggestion posted by someone else who was guiding you to changing that file by removing original PHP content and replacing it with specific text so that it's no longer dynamically generated when needed.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  6. #6
    Join Date
    Jan 2007
    Location
    Australia
    Posts
    6,167
    Plugin Contributions
    7

    Default Re: <meta name="description" content="MY_IMPORTANT_HOME_PAGE_DESCRIPTION" />

    Quote Originally Posted by DrByte View Post
    I thought that you'd followed a suggestion posted by someone else who was guiding you to changing that file by removing original PHP content and replacing it with specific text so that it's no longer dynamically generated when needed.
    Ouch!

    'Tis a useful method of having the desired effect (for the client) until more facts were known. We had no idea where
    MY_IMPORTANT_HOME_PAGE_DESCRIPTION
    was originally defined, or even what defined it, not to mention if something else that may be dependent on it.

    There was also no assurance that the module that used the define would be reading the zencart language and/or meta files either, so the suggestion to add it to the file that contained the other define should ensure it'll be available when needed.

    Of course, going back to the original zen cart install files was always an option but that would break whatever cool feature it was that the home page description deemed to be MY_IMPORTANT'

    So There

    Cheers
    Rod

 

 

Similar Threads

  1. Remove Store Name from <meta name="description" content=
    By Podgeminster in forum General Questions
    Replies: 9
    Last Post: 14 Jul 2016, 06:16 PM
  2. Replies: 0
    Last Post: 3 May 2014, 07:47 AM
  3. Replies: 1
    Last Post: 21 Jul 2010, 07:36 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg