Edit Orders v3.0 for ZC 1.3.9 [Support Thread]

[DivaVocals]

require(DIR_WS_LANGUAGES . $_SESSION['language'] . '/' . 'order_status_email.php');

line 10 in admin/includes/languages/english/orders.php

Delete the line.. (BTW, the forum code tags work better when quoting code)

[vandydavid]

GREAT ADD-ON. I have a client who wants to know when they edit an order - it puts a Modified Order * next to the information...is this at all possible? Am I missing something?

[DivaVocals]

GREAT ADD-ON. I have a client who wants to know when they edit an order - it puts a Modified Order * next to the information...is this at all possible? Am I missing something?

It's software.. Nearly anything you need it to do is possible.. However, this requires some modifications to Edit Orders to achieve.. I don't know what specifically is required to add this specific functionality, but perhaps another community member has some ideas they wish to share.. Your other option is to hire a developer to make these changes for you..

[lhungil]

Just installed edit orders 4.02 into my test environment. The installation went very smooth!

I would recommend removing the "Thumbs.db" files from image locations in your zip file (maybe a little picky)

I have found a few minor issues related to adding products to an existing order. I've attached a patch file of changes I needed to make to admin/edit_orders.php. If I find any other bugs during my testing and integration (with some custom pricing modules), I'll pass any fixes I make your way.

Attachment 11036

[DivaVocals]

Just installed edit orders 4.02 into my test environment. The installation went very smooth!

I would recommend removing the "Thumbs.db" files from image locations in your zip file (maybe a little picky)

I have found a few minor issues related to adding products to an existing order. I've attached a patch file of changes I needed to make to admin/edit_orders.php. If I find any other bugs during my testing and integration (with some custom pricing modules), I'll pass any fixes I make your way.

Attachment 11036

Not a "official" package yet so not a big deal that the "Thumbs.db" files are there.. They would of course be removed from the final package (when I finally find time to make that happen)

Your patch would be even more helpful if you could explain the issues you found and at a high level at least walk through how you resolved them.. This way I can do my own testing to see if I too can replicate the problem before applying any fixes to my package..

[bislewl]

I figured out a solution, maybe not the best one.
In the file:
/mallet_2012/includes/init_includes/init_admin_auth.php

Look for the lines that are around line 50

if (!in_array($page, array(FILENAME_DEFAULT,FILENAME_ADMIN_ACCOUNT,FILENAME_LOGOFF,FILENAME_ALERT_PAG E,FILENAME_PASSWORD_FORGOTTEN,FILENAME_DENIED,FILENAME_ALT_NAV)) &&
!zen_is_superuser())
{
if (check_page($page, $_GET) == FALSE)
{
zen_redirect(zen_href_link(FILENAME_DENIED, '', 'SSL'));
}
}

Add-
Before section: if (basename($_SERVER['SCRIPT_FILENAME']) != 'FILENAME_ORDER_EDIT') {
after section:}

Keep in mind that someone whom may not be authorized, may be able to access the Edit Order modules. If i come up with a more secure version I will post it here.


Larry

[DivaVocals]

I figured out a solution, maybe not the best one.
In the file:
/mallet_2012/includes/init_includes/init_admin_auth.php

Look for the lines that are around line 50

if (!in_array($page, array(FILENAME_DEFAULT,FILENAME_ADMIN_ACCOUNT,FILENAME_LOGOFF,FILENAME_ALERT_PAG E,FILENAME_PASSWORD_FORGOTTEN,FILENAME_DENIED,FILENAME_ALT_NAV)) &&
!zen_is_superuser())
{
if (check_page($page, $_GET) == FALSE)
{
zen_redirect(zen_href_link(FILENAME_DENIED, '', 'SSL'));
}
}

Add-
Before section: if (basename($_SERVER['SCRIPT_FILENAME']) != 'FILENAME_ORDER_EDIT') {
after section:}

Keep in mind that someone whom may not be authorized, may be able to access the Edit Order modules. If i come up with a more secure version I will post it here.


Larry

and this reason is why this should not be implemented..

When I get some time I'll look at this.. May be a while for me to look at this as I am MAD busy..

So if anyone has right solution which maintains the admin profile securities, please post..

[lhungil]

Your patch would be even more helpful if you could explain the issues you found and at a high level at least walk through how you resolved them.. This way I can do my own testing to see if I too can replicate the problem before applying any fixes to my package..

Very basic, thus the patch file. Two lines were changed.
a) Fixed the name of a variable to be compatible with *nix hosts. Basically a case-sensitivity change. Fixes a error with a SQL check prior to updating order totals (tax or no tax).
b) Added a check to make sure the selected category (when selecting a product to add) has products. If it does not, the page stays at step 1 of adding a product. Removes extraneous warning and errors in log files. Can probably be improved upon by using the message stack or some such to provide active feedback.

[DivaVocals]

Very basic, thus the patch file. Two lines were changed.
a) Fixed the name of a variable to be compatible with *nix hosts. Basically a case-sensitivity change. Fixes a error with a SQL check prior to updating order totals (tax or no tax).
b) Added a check to make sure the selected category (when selecting a product to add) has products. If it does not, the page stays at step 1 of adding a product. Removes extraneous warning and errors in log files. Can probably be improved upon by using the message stack or some such to provide active feedback.

Good stuff!!! Thanks for the patch.. I'll have a looksee this weekend if I can squeeze a little time out and update the files on my site..

[lhungil]

I've taken a look at this issue and believe I have a fix. The configuration page was registered as an admin page, but the actual edit_orders page was not. On the profile permissions page it will add a new admin page under "modules" to control access to the file "edit_orders".

Patch Details:
a) Added a new definition. Required to support an additional "admin page".

b) I've added a snippet to the init file. First it checks for the presence of a specific function added in Zen Cart 1.5. If present, it checks to see if the admin page has already been registered. If not already registered, it finds an appropriate page sort order and registers the new "admin page".

I've taken the liberty of moving the edit orders configuration admin page code into the block created in b). More of a personal preference, I prefer doing a check to undoing the registration. Feel free to move the code back outside if desired.

Attachment 11044