Event Calendar v3

[LaCamus]

My version looks nothing like this, it stretches across the page. The colorful rainbow is the div's for reporting success/warning/info. In firefox when text is empty they are hidden, easy fix.

What I think's going on is you have some default widths for tables or td's that I don't have. Could be coming any of the css's in your package. I will give the tables and their child elements a class and that "should" fix the issue.

[DivaVocals]

My version looks nothing like this, it stretches across the page. The colorful rainbow is the div's for reporting success/warning/info. In firefox when text is empty they are hidden, easy fix.

What I think's going on is you have some default widths for tables or td's that I don't have. Could be coming any of the css's in your package. I will give the tables and their child elements a class and that "should" fix the issue.

The only thing in my admin stylesheet that is different is this:

/* BOF Added so that the configuration settings displayed will wrap correctly */
   table {border-collapse:collapse; table-layout:fixed;}
   table td {word-wrap:break-word;vertical-align:top;}
/* EOF Added so that the configuration settings displayed will wrap correctly */

This was added for a custom template that I am using.. The template has some configuration settings in Configuration > Layout Settings that were not wrapping correctly so they mucked up the settings display.. so I added this to fix the issue..

[LaCamus]

The only thing in my admin stylesheet that is different is this:

/* BOF Added so that the configuration settings displayed will wrap correctly */
   table {border-collapse:collapse; table-layout:fixed;}
   table td {word-wrap:break-word;vertical-align:top;}
/* EOF Added so that the configuration settings displayed will wrap correctly */

This was added for a custom template that I am using.. The template has some configuration settings in Configuration > Layout Settings that were not wrapping correctly so they mucked up the settings display.. so I added this to fix the issue..

It may be the collapse setting, you could try removing both lines temporarily just to test it. Those settings, the way they are written will apply to all tables and td's that don't have those attributes set.

Now if you remove them and it works I then know and can go in and create those attributes in a class for the tables/td's in the events manager which then will override yours.

fyi: i started taking css out of events manager and putting it in a separate file, same for javascript...this should make the code a little easier to read through. Being able to flip back and forth between the 3 languages using multiple editor windows really helps speed up the coding process.

[DivaVocals]

It may be the collapse setting, you could try removing both lines temporarily just to test it. Those settings, the way they are written will apply to all tables and td's that don't have those attributes set.

Now if you remove them and it works I then know and can go in and create those attributes in a class for the tables/td's in the events manager which then will override yours.

fyi: i started taking css out of events manager and putting it in a separate file, same for javascript...this should make the code a little easier to read through. Being able to flip back and forth between the 3 languages using multiple editor windows really helps speed up the coding process.

THAT was going to be my next suggestion.. What's that they say about great minds..

[dw08gm]

Rus

Re Version 2, I encountered a few problems, all but one relatively minor.

1. Upon resizing a gif or png containing transparent sections, usually outside the margins of non-rectangular shapes, the transparent sections are turned black. For me this is no big deal, as I would normally resize these images prior to uploading, and having onscreen controls to adjust width/height makes this optimisation easy. However, for stores with colorful backgrounds, the blackening affect could look unsavoury.


2. However, the removal of <img class="c1" in tpl_events_calendar_default.php breaks my fluid and flexible design approach, as images are no longer reduced further to fit their enclosing divs. I cannot accept this change as is.


3. In admin\includes\languages\english\events_manager.php, I applied the following changes. :

define('TEXT_EVENT_IMAGE', 'Event Image Info:'); // Event Info File:
define('TEXT_EVENT_NO_IMAGE', 'Unselect Image:'); // remove info file:

The checkbox for TEXT_EVENT_NO_IMAGE does not physically move or delete an image, but only deletes the link in the database. FWIW I like the fact that I can tick this checkbox to unselect an existing image and at the same time upload a replacement image.


4. In tpl_events_calendar_default.php, I added the following snippets in case storeowners wish to prepend the event start and end dates with the weekday ie Thursday April 11, 2013 as opposed to April 11, 2013. This is useful when viewing events beyond the current month, as the sidebox only shows the current calendar month in event view, and could force a customer the look elsewhere for the weekday of the event. To activate, simply rem the upper line and unrem the lower line of each snippet respectively.

          $date_start = date($dateDisplayFormat, mktime(0,0,0,$month,$day,$year));
//          $date_start = zen_date_long($events->fields['start_date']);

            $date_end = date($dateDisplayFormat, mktime(0,0,0,$month_end,$day_end,$year_end));
//            $date_end = zen_date_long($events->fields['end_date']);

Cheers

[DivaVocals]

4. In tpl_events_calendar_default.php, I added the following snippets in case storeowners wish to prepend the event start and end dates with the weekday ie Thursday April 11, 2013 as opposed to April 11, 2013. This is useful when viewing events beyond the current month, as the sidebox only shows the current calendar month in event view, and could force a customer the look elsewhere for the weekday of the event. To activate, simply rem the upper line and unrem the lower line of each snippet respectively.

          $date_start = date($dateDisplayFormat, mktime(0,0,0,$month,$day,$year));
//          $date_start = zen_date_long($events->fields['start_date']);

            $date_end = date($dateDisplayFormat, mktime(0,0,0,$month_end,$day_end,$year_end));
//            $date_end = zen_date_long($events->fields['end_date']);

Cheers

My suggestion is to turn this into an admin configuration item.. It keeps novice shopowners "out of the code", and ensures that install errors from an errant edit won't happen.. The easiest way to do that is to wrap this code in a conditional statement..

[LaCamus]

Rus

Re Version 2, I encountered a few problems, all but one relatively minor.

1. Upon resizing a gif or png containing transparent sections, usually outside the margins of non-rectangular shapes, the transparent sections are turned black. For me this is no big deal, as I would normally resize these images prior to uploading, and having onscreen controls to adjust width/height makes this optimisation easy. However, for stores with colorful backgrounds, the blackening affect could look unsavoury.

Just researched...others have had issues with this, looks like there is a way to do it from what I am reading. Give me a few days. This is happening to GIF's? or just to PNG's?

2. However, the removal of <img class="c1" in tpl_events_calendar_default.php breaks my fluid and flexible design approach, as images are no longer reduced further to fit their enclosing divs. I cannot accept this change as is.

I meant to talk with you about this...the code as written was:

<!-- Note: closing ' />' for <img> is located in function zen_image -->
      <img class="c1" <?php echo zen_image(DIR_WS_IMAGES .'events_images/' . $event_array['image'], '', '', 'hspace="0" vspace="0"');?>

What that did was create a reference with 2 open brackets ( <img class="c1" <img ). The zen_image function actually has support for additional parameters. It (probably) should have been written like this:

      <?php echo zen_image(DIR_WS_IMAGES .'events_images/' . $event_array['image'], '', '', 'class="c1" hspace="0" vspace="0"');?>

My new function also supports extra parameters...the existing code as is can be changed to:

echo event_flink_small($event_array['image'], $event_array['title'], 'class="c1" hspace="0" vspace="0"');

3. In admin\includes\languages\english\events_manager.php, I applied the following changes. :

define('TEXT_EVENT_IMAGE', 'Event Image Info:'); // Event Info File:
define('TEXT_EVENT_NO_IMAGE', 'Unselect Image:'); // remove info file:

The checkbox for TEXT_EVENT_NO_IMAGE does not physically move or delete an image, but only deletes the link in the database. FWIW I like the fact that I can tick this checkbox to unselect an existing image and at the same time upload a replacement image.

Yeah, it is really up to the individual, that's why it is in with the language defines. I had "Event Info File" because those terms applied to both docs and images. For the 2nd one, yeah, you are right the way the program works it deselects the file by just deleting the reference in the db. I don't think the program ever did delete the files. We could add another option to "delete physical file", it would only work if the deselect was checked...your call.

4. In tpl_events_calendar_default.php, I added the following snippets in case storeowners wish to prepend the event start and end dates with the weekday ie Thursday April 11, 2013 as opposed to April 11, 2013. This is useful when viewing events beyond the current month, as the sidebox only shows the current calendar month in event view, and could force a customer the look elsewhere for the weekday of the event. To activate, simply rem the upper line and unrem the lower line of each snippet respectively.

          $date_start = date($dateDisplayFormat, mktime(0,0,0,$month,$day,$year));
//          $date_start = zen_date_long($events->fields['start_date']);

            $date_end = date($dateDisplayFormat, mktime(0,0,0,$month_end,$day_end,$year_end));
//            $date_end = zen_date_long($events->fields['end_date']);

Cheers

I like that one, good idea: On my end I made it a dynamic option via the defines file...

in /includes/languages/english/extra_definitions/your_template/events_calendar_include_defines.php
added:
// use long dates (includes day of week) when displaying events
define(EVENTS_LONG_DATES, true);

on the two lines above I changed them to:
          $date_start = ( EVENTS_LONG_DATES ? zen_date_long($events->fields['start_date']) 
                                            : date($dateDisplayFormat, mktime(0,0,0,$month,$day,$year)) );

            $date_end = ( EVENTS_LONG_DATES ? zen_date_long($events->fields['end_date'])
                                            : date($dateDisplayFormat, mktime(0,0,0,$month_end,$day_end,$year_end)) );

Rus

[LaCamus]

My suggestion is to turn this into an admin configuration item.. It keeps novice shopowners "out of the code", and ensures that install errors from an errant edit won't happen.. The easiest way to do that is to wrap this code in a conditional statement..

Dude! You jumped in front of me...again, you're reading my mind.

[DivaVocals]

Dude! You jumped in front of me...again, you're reading my mind.

**LOL**

Okay I need to go to bed.. will post my findings from today's adventure with this tomorrow..

[dw08gm]

Just researched...others have had issues with this, looks like there is a way to do it from what I am reading. Give me a few days. This is happening to GIF's? or just to PNG's?

Both gif's and png's. Had no trouble with other types, although did not test for docx as I had none at hand.

My new function also supports extra parameters...the existing code as is can be changed to:

echo event_flink_small($event_array['image'], $event_array['title'], 'class="c1" hspace="0" vspace="0"');

Hopefully this will work.

We could add another option to "delete physical file", it would only work if the deselect was checked...your call.

Happy to leave out "delete physical file", as I prefer to do such tasks manually and always after creating a backup.

I like that one, good idea: On my end I made it a dynamic option via the defines file...

in /includes/languages/english/extra_definitions/your_template/events_calendar_include_defines.php
added:
// use long dates (includes day of week) when displaying events
define(EVENTS_LONG_DATES, true);

on the two lines above I changed them to:
          $date_start = ( EVENTS_LONG_DATES ? zen_date_long($events->fields['start_date']) 
                                            : date($dateDisplayFormat, mktime(0,0,0,$month,$day,$year)) );

            $date_end = ( EVENTS_LONG_DATES ? zen_date_long($events->fields['end_date'])
                                            : date($dateDisplayFormat, mktime(0,0,0,$month_end,$day_end,$year_end)) );

Rus

Excellent - will try.

Re: stripping css and js from events manager.
I largely agree, although I am not adverse to inline css. I can handle the css but am a bit green with js. Should js be shoved into a function file?

Re: developer attributions
Since you have done so much work upon certain files, I believe it more than fair to give yourself credit as in events_manager_drop_dns.php

Generally, I am standing in awe at your rapid responses and prompt solutions, and feel I should almost check myself for experiencing so much pleasure in our dealings. I have been at this for years and have never gained so much in so short a time.

Cheers