
Originally Posted by
DivaVocals
That said it appears that your code strips "target=_blank" for all links and this just creates another issue in that external links will open in the parent window which is NOT what should be happening.. internal links should NOT include "target=_blank". It makes the site look like children who don't know better built it.. EXTERNAL links should absolutely open in a new window/tab for the reasons you stated.. "as a shop owner you don't want to lose focus on your store front." How do we get there??
That code only strips target=_blank from the links that are built from existing manufacturers/categories/products...in no case that I can think of (again, I am new to Zen Carts) is that url not going to link internally, so with that in mind it should always be stripped on the store front. There are a # of places it displays on the admin side (3 I can think of) so that meant more code changes, this one line provides simplicity and maintains backward compatibility. Even with making the changes on the admin side you still are going to need this line of code to strip all those events added with past versions of the events calendar. When you stripped those targets from the admin side did you try clicking on one of the links? ...they now will pull you out of edit mode meaning you could inadvertently lose some of your changes.
and yes I suppose it COULD be an admin configurable item with 1 option for external links and another configurable option for internal links (for those who LIKE the old way silly as I think it is.. to each his own right?? let everybody be happy as my BFF would say

)..
I forget to put this in the other post...I found a bug around line 175, the line should read:
Code:
<tr> <!-- event ZC_Link row -->
<td class="event_heading" nowrap="nowrap">
<strong><?php echo TEXT_EVENT_ZC_LINK;?></strong></td>
<td class="event_description"><?php echo $event_array['ZC_link'];?></td>
for some reason there were 2 php echos for the built url with only one closing tag, not sure why.
Another thing, those links in the admin are being built with https:// (instead of http://) if your site supports ssl. I don't think it should have been programmed that way. It should use whatever the default prefix is for the front side, instead it is using the back (admin) prefix. There should probably be some code in there to check the main url and pull the prefix from it to build the store link url.