Event Calendar v3

[dw08gm]

In either case it doesn't matter what my height and width settings are (I left the default settings). It also doesn't matter whether I choose to resize images or not. Since re-sizing happens on upload I also expected this. In either case the Images configuration settings has no effect on the image display within an event (which is what I expected). The ONLY setting that affects the image display is the "Include the IMG tag height and width" setting..

If resizing only happens upon upload, then this needs to be written into the Readme. I am sure, however, that earlier I was able to resize images, both up and down, that were already in the events_images folder, which may or may not have been done when delinking one image for another.

[DivaVocals]

If resizing only happens upon upload, then this needs to be written into the Readme. I am sure, however, that earlier I was able to resize images, both up and down, that were already in the events_images folder, which may or may not have been done when delinking one image for another.

You CAN re-size images if you edit the event and then choose the re-sizing radio button. Otherwise the size of the image is unaffected by merely changing the settings.. I will adjust the readme and the admin setting explanation to make this clearer.. I still want to make an attempt at adding an auto-installer to eliminate the need for an external SQL file..

[DivaVocals]

Actually I was seeking the dropdowns to display thus
Sidebox = APR, since it is standalone
Page = Apr, since the appended event title text is predominately in lowercase.

However, allowing for all variants is the way to go.

cheers

Right and that works for YOUR situation.. but other shopowners may not want this exact same layout, and in fact may be okay with the way the current settings work. So some flexibility has to be included so everyone can modify this as they wish. Plus, since both dropdowns share the same set of defines, this would require that the page and sidebox would each need a different set of defines so they could be setup differently. barring I can't find a CSS solution.. (not sure that this can be done using ONLY CSS)

[DivaVocals]

I am really struggling to explain with this phenomena....

The original code, before the introduction of the image manipulation code and before I inadvertantly did the double <img> thing, returned the actual image width and height in px (as listed in view source and as stored in the events_images folder) and, even though the image as displayed on the event page may have been smaller than the actual image size, the proportions were maintained.

This should still be the case after image manipulation, but somehow some function (zen_image, zen_image_OLD or whatever) is distorting this process. My limited understanding of coding prevents from seeing how the image width and height values as collected should not be maintained in whatever code does the proportioning for the display.

Does/can event_flink_small do any proportioning, or is the proportioning entirely dependent upon zen_image/zen_image_OLD?

Using the IMG height and width tells the BROWSER what size to display the image. If you use that with the CSS settings that are meant to re-size the image to the container, and the image is larger or smaller than those settings, the images will distort.

If you want the CSS to control the image display size
and
you are NOT going to use the resizing features (the full sized image will be uploaded and left as is)
and
the image is larger (or smaller) than the dimensions of the page container

then you need to remove the height and width from the IMG tag so that the image will not distort, and so the CSS will properly display the image in the correct proportions.

You indicated that you wanted to maintain the ability to upload the full image size and let the CSS do the proportioning and resizing the image display versus explicitly resizing the image upon upload and then telling the browser what those image dimensions are. Rus provided the code to achieve this, and also provided the code for those who were okay with using the resizing features.. If you go back to the posts where Rus introduced this code you will see that this is what he said, and you confirmed that this code worked.. All I did was add a conditional statement so that BOTH options could be used.

[dw08gm]

Using the IMG height and width tells the BROWSER what size to display the image. If you use that with the CSS settings that are meant to re-size the image to the container, and the image is larger or smaller than those settings, the images will distort.

If you want the CSS to control the image display size
and
you are NOT going to use the resizing features (the full sized image will be uploaded and left as is)
and
the image is larger (or smaller) than the dimensions of the page container

then you need to remove the height and width from the IMG tag so that the image will not distort, and so the CSS will properly display the image in the correct proportions.

You indicated that you wanted to maintain the ability to upload the full image size and let the CSS do the proportioning and resizing the image display versus explicitly resizing the image upon upload and then telling the browser what those image dimensions are. Rus provided the code to achieve this, and also provided the code for those who were okay with using the resizing features.. If you go back to the posts where Rus introduced this code you will see that this is what he said, and you confirmed that this code worked.. All I did was add a conditional statement so that BOTH options could be used.

Yes I understood as much, but this is not what I am getting at.

The html image tag <img> puts the actual width and height values on the page, presumably in that order. My code does not change those values, but preserves the actual values on screen, even though the image is resized by css, while proportion is maintained.

Both zen_image and zen_image_OLD utilise <img> and both also use CONFIG_CALCULATE_IMAGE_SIZE to determine image size. But zen_image says if PROPORTIONAL_IMAGES_STATUS = 0, then use zen_image_OLD, otherwise stay with zen_image. But my site needs PROPORTIONAL_IMAGES_STATUS = 1 to correctly proportion product images, so theoretically we should be using zen_image. However, using zen_image and PROPORTIONAL_IMAGES_STATUS = 1 causes the event images to distort, while forcing zen_image_OLD and setting PROPORTIONAL_IMAGES_STATUS = 1, the event images are displayed in proportion. That is, until the call to display width and height values is made, whereupon the event image is once again distorted. But using zen_image with PROPORTIONAL_IMAGES_STATUS = 1 and displaying width and height values distorts the events images

Enough to drive one mad. This is why I suspect something in this arrangement is a-about.

Maybe the answer is to do away with zen_image and zen_image_OLD altogether in events calendar and just use the <img> tag, which could also dispense with the need for an admin switch to display the width and height.

Does this makes sense.

[DivaVocals]

Yes I understood as much, but this is not what I am getting at.

The html image tag <img> puts the actual width and height values on the page, presumably in that order. My code does not change those values, but preserves the actual values on screen, even though the image is resized by css, while proportion is maintained.

Both zen_image and zen_image_OLD utilise <img> and both also use CONFIG_CALCULATE_IMAGE_SIZE to determine image size. But zen_image says if PROPORTIONAL_IMAGES_STATUS = 0, then use zen_image_OLD, otherwise stay with zen_image. But my site needs PROPORTIONAL_IMAGES_STATUS = 1 to correctly proportion product images, so theoretically we should be using zen_image. However, using zen_image and PROPORTIONAL_IMAGES_STATUS = 1 causes the event images to distort, while forcing zen_image_OLD and setting PROPORTIONAL_IMAGES_STATUS = 1, the event images are displayed in proportion. That is, until the call to display width and height values is made, whereupon the event image is once again distorted. But using zen_image with PROPORTIONAL_IMAGES_STATUS = 1 and displaying width and height values distorts the events images

Enough to drive one mad. This is why I suspect something in this arrangement is a-about.

Maybe the answer is to do away with zen_image and zen_image_OLD altogether in events calendar and just use the <img> tag, which could also dispense with the need for an admin switch to display the width and height.

Does this makes sense.

Sorry no..

If I upload animage and choose NOT to resize it

AND

I leave the PROPORTIONAL_IMAGES_STATUS = 1

AND

I simply turn on the call for the IMG height/width

then the images distort..

If I turn off the call for the IMG height/width then the images DO NOT distort and disply correctly..

Honestly speaking, I'm not clear what it is you think is wrong as it seems to do what you have been suggesing (upload the full sized image and NOT use the resizing, and then let the CSS drive the image proportions) Perhaps if we understood this we can get towards a solution.. I do not think that we should do away with zen_image.. I think we need to figure out what it is you are trying to achieve here.. The current settings appear to do that, but clearly you don't think so.. Getting down to WHY you think this is will help get towards a solution that is flexible for ALL..

[DivaVocals]

One other thing I noticed.. the includes/templates/custom_template/css/stylesheet_events_calendar.css loads on EVERY page. This should probably be a page specific CSS file so that it ONLY loads on the events calendar pages.. So I suggest that this file be renamed includes/templates/custom_template/css/events_calendar.css so it only loads on the events calendar pages.

[dw08gm]

Sorry no..

If I upload animage and choose NOT to resize it

AND

I leave the PROPORTIONAL_IMAGES_STATUS = 1

AND

I simply turn on the call for the IMG height/width

then the images distort..

If I turn off the call for the IMG height/width then the images DO NOT distort and disply correctly..

Honestly speaking, I'm not clear what it is you think is wrong as it seems to do what you have been suggesing (upload the full sized image and NOT use the resizing, and then let the CSS drive the image proportions) Perhaps if we understood this we can get towards a solution.. I do not think that we should do away with zen_image.. I think we need to figure out what it is you are trying to achieve here.. The current settings appear to do that, but clearly you don't think so.. Getting down to WHY you think this is will help get towards a solution that is flexible for ALL..

Resizing is an admin event_manager function and is completely separate to the display of event images in event calendar.

[dw08gm]

One other thing I noticed.. the includes/templates/custom_template/css/stylesheet_events_calendar.css loads on EVERY page. This should probably be a page specific CSS file so that it ONLY loads on the events calendar pages.. So I suggest that this file be renamed includes/templates/custom_template/css/events_calendar.css so it only loads on the events calendar pages.

Interesting thought, will try.

stylesheet_events_calendar.css was inherited from the very first version 1.01, presumedly so-named because it also contains sidebox setting that load on every page.

[DivaVocals]

Interesting thought, will try.

stylesheet_events_calendar.css was inherited from the very first version 1.01, presumedly so-named because it also contains sidebox setting that load on every page.

Ahhhhhh okay.. forgot about the sidebox.. So we COULD consider seperating the sidebox stylesheet from the page stylesheet..