Edit Orders v4.0 Support Thread

[lhungil]

...
Also in edit_orders_functions.php around line 747 in eo_update_order_subtotal()

I have wrapped the $shown_price calculation in a check for whether prices are displayed with tax, and removed the tax calculation accordingly ...

Found some other potential issues related to the tax calculations. As a temporary work around (until I can dig into the needed changes more extensively) you will also want to make sure DISPLAY_PRICE_WITH_TAX and DISPLAY_PRICE_WITH_TAX_ADMIN are both set to the same value ('True' or 'False').

[DivaVocals]

Found some other potential issues related to the tax calculations. As a temporary work around (until I can dig into the needed changes more extensively) you will also want to make sure DISPLAY_PRICE_WITH_TAX and DISPLAY_PRICE_WITH_TAX_ADMIN are both set to the same value ('True' or 'False').

Should I hold off on QA testing and wait for an update?? Also it would help if you could give me (at high level) the test case/scenario I should be running in order to confirm the fast and furious changes coming..

Also I am going to test a bug Ajeh reported to me a while back that I could NOT address because.. well because I am not a PHP developer that's why..

If I discover that this old bug is still an issue, is NOW the time to raise/report this??

[lhungil]

Also I am going to test a bug Ajeh reported to me a while back ...
If I discover that this old bug is still an issue, is NOW the time to raise/report this??

Would be a good time. I'd like input on any "known bugs" so even if they are not fixed we can at least add them to the readme :)

[Gadgit]

Found some other potential issues related to the tax calculations. As a temporary work around (until I can dig into the needed changes more extensively) you will also want to make sure DISPLAY_PRICE_WITH_TAX and DISPLAY_PRICE_WITH_TAX_ADMIN are both set to the same value ('True' or 'False').

Ah yes - I did notice that it uses the define for the front end, I wasn't sure whether that was by design or not. I have got the ADMIN set to true, and the front end one set to False, since that's the way I need it set up. It doesn't seem to cause any major issues though..

[lhungil]

Ah yes - I did notice that it uses the define for the front end, I wasn't sure whether that was by design or not. I have got the ADMIN set to true, and the front end one set to False, since that's the way I need it set up. It doesn't seem to cause any major issues though..

This is the reason your calculations was off for VAT and taxes. Certain functions in the admin are hard coded to use DISPLAY_PRICE_WITH_TAX_ADMIN and the order total code and modules (we call these to calculate totals) are hard coded to use DISPLAY_PRICE_WITH_TAX. So if both values are not the same, the calculations get off

I do not want to modify the Zen Cart functions directly as it will impact many other pages... So we will probably need to duplicate some of the code from the catalog side functions... And when the values are not the same on both sides add a warning to the top of the page in the admin to let users know calculations shown in Edit Orders are based upon the catalog side settings.

The "quick" fix for most people running EO 4.1 to address the calculations being off is make sure both these settings are the same.

[twi]

ZC1.5.1
TY PACKAGE 3.1.3
EDIT ORDERS 4.4.1-B1
SUPER ORDERS 4.XXX (latest VERSION)
RECOVER CART SALES 1.5
UPS SHIPPING MOD

There are 3 problems with my super order batch form printing functions:
1. traditional menu printing invoices yield a http 500 Internal server error
2 traditional menu printing packing slips yield a http 500 Internal server error
3. PDF Packing slip printing works but display a browser tab heading of "503 Service Temporary Un.....

Looking in my logs I find:

[22-May-2013 10:17:43] PHP Fatal error: Cannot redeclare class base in /htdocs/myzencart/includes/classes/class.base.php on line 17


[21-May-2013 16:07:50] PHP Warning: Invalid argument supplied for foreach() in /htdocs/myzencart/admin/super_batch_pages.php on line 37


What does this mean? Can anyone help?

[lhungil]

...
There are 3 problems with my super order batch form printing functions:
1. traditional menu printing invoices yield a http 500 Internal server error
2 traditional menu printing packing slips yield a http 500 Internal server error
3. PDF Packing slip printing works but display a browser tab heading of "503 Service Temporary Un.....

Looking in my logs I find:

[22-May-2013 10:17:43] PHP Fatal error: Cannot redeclare class base in /htdocs/myzencart/includes/classes/class.base.php on line 17


[21-May-2013 16:07:50] PHP Warning: Invalid argument supplied for foreach() in /htdocs/myzencart/admin/super_batch_pages.php on line 37

The 500's may be coming from the FATAL error... You can double check your webserver / php_error logs if your hosting provider has them enabled to double check.

I'd guess the first one is coming from code somewhere using include(class.base.php) or require(class.base.php) when the file already has been included (or required). Edit Orders does not manually call any includes for these... So you might check the Super Orders code...

The second is most likely caused by the variable being passed to the foreach on line 37 not being initialized or not being an iterable object.

[twi]

@lhungil


there are no log in the hosting server logs. guess the host didn't enable them.

As far as coding goes, I am illiterate. Hope someone here can help.

thanks

[twi]

Also posted the info at Super orders for help.

[DivaVocals]

@lhungil


there are no log in the hosting server logs. guess the host didn't enable them.

As far as coding goes, I am illiterate. Hope someone here can help.

thanks

Double posting the SAME problem on two threads is generally frowned upon in this forum.. Not to mention your issue (as you reported it) is not with Edit Orders, but with SUPER ORDERS.. the fact that integration between these modules is possible doesn't mean that issues with one relate tothe other.. Super Orders, Ty Package Tracking and Edit Orders are still three distinct modules with different purposes/functions (Order Management, Shipping, and order Editing). So unless an issue is SPECIFIC to the integration of these modules, you should be reporting functional issues in the specific support thread for the module where the problem exists.. (in this case Super Orders batch printing is NOT in any way affected by Edit Orders)