Reward Points Module for ZC v13x

[BlessIsaacola]

You have extra single quotes (shown in red) which are causing problems in at least 2 places

Thank you so much. I look inside the file that contains the information but I am not sure if you see what's wrong below. I have pasted the three areas that could potentially have issues.

if(zen_get_products_price_is_free($products_id)==false || REWARD_POINTS_ALLOW_ON_FREE=='1') // Allow RP on free items (Admin settable)
    {
        $sql = "SELECT prp.point_ratio*p.products_price AS reward_points, prp.point_ratio, p.products_price, p.products_priced_by_attribute 
                FROM ".TABLE_REWARD_MASTER." prp, ".TABLE_PRODUCTS." p, ".TABLE_PRODUCTS_TO_CATEGORIES." p2c 
                WHERE p.products_id='" . $products_id . "'
                AND p2c.products_id='" . $products_id . "'
                AND ((prp.scope_id=p.products_id AND prp.scope='".SCOPE_PRODUCT."') 
                OR (p.products_id=p2c.products_id AND prp.scope_id=p2c.categories_id AND prp.scope='".SCOPE_CATEGORY."')
                OR (prp.scope='".SCOPE_GLOBAL."'))
                ORDER BY prp.scope DESC LIMIT 1;";
    
        $result=$db->Execute($sql); 

$sql = "SELECT prp.point_ratio 
            FROM ".TABLE_REWARD_MASTER." prp, ".TABLE_PRODUCTS." p, ".TABLE_PRODUCTS_TO_CATEGORIES." p2c 
            WHERE p.products_id='" . $products_id . "'
            AND p2c.products_id='" . $products_id . "'
            AND ((prp.scope_id=p.products_id AND prp.scope='".SCOPE_PRODUCT."') 
            OR (p.products_id=p2c.products_id AND prp.scope_id=p2c.categories_id AND prp.scope='".SCOPE_CATEGORY."')
            OR (prp.scope='".SCOPE_GLOBAL."'))
            ORDER BY prp.scope DESC LIMIT 1;";
    
    $result=$db->Execute($sql); 

$sql = "SELECT redeem_ratio 
            FROM ".TABLE_REWARD_MASTER." prp, ".TABLE_CUSTOMERS." as c
            LEFT JOIN(".TABLE_GROUP_PRICING." as gp) ON (gp.group_id=c.customers_group_pricing)
            WHERE c.customers_id='".(int)$customers_id."'
            AND ((prp.scope_id='".$customers_id."' AND prp.scope='".SCOPE_CUSTOMER."')
            OR (gp.group_id=c.customers_group_pricing AND prp.scope_id=gp.group_id AND scope='".SCOPE_GROUP."')
            OR (prp.scope='".SCOPE_GLOBAL."'))
            ORDER BY prp.scope DESC LIMIT 1;"; 

    $result=$db->Execute($sql); 

I hope you or someone else sees what's wrong in the above and can guide me.

Thanks!

[gilby]

It appears that its the first of those sql queries.
However the code appears fine.
The only way that I can see it producing the code thats in the error is if $products_id is corrupt
ie: $products_id = 11178' <- note the trailing apostrophre

[BlessIsaacola]

It appears that its the first of those sql queries.
However the code appears fine.
The only way that I can see it producing the code thats in the error is if $products_id is corrupt
ie: $products_id = 11178' <- note the trailing apostrophre

We may have to do away with the Rewards points module because I can't figure out what's going on. I do not see any problem with that product id in the DB and it happens with other products as well so it definitely cannot be an issue with the id.

Thanks for helping to troubleshoot though. I am surprised that I am the only one seeing this problem in the log.

[gilby]

We may have to do away with the Rewards points module because I can't figure out what's going on. I do not see any problem with that product id in the DB and it happens with other products as well so it definitely cannot be an issue with the id.

Thanks for helping to troubleshoot though. I am surprised that I am the only one seeing this problem in the log.

Be aware that $products_id is NOT in the database.
It is a php variable that has been assigned somewhere.

p.products_id and p2c.products_id ARE in the database

Have you tried uploading the files again. It could be a corrupt upload.

[BlessIsaacola]

Be aware that $products_id is NOT in the database.
It is a php variable that has been assigned somewhere.

p.products_id and p2c.products_id ARE in the database

Have you tried uploading the files again. It could be a corrupt upload.

Thanks so much for the pointer about $products_id. I searched Zen Cart and all the files that uses this seems to have

(int)$products_id

instead of

$products_id

Perhaps that's my problem. I will play with it and see if that helps.

This is driving me crazy :)

[joyjoy]

Hi everyone. I have Super Orders and Edit Orders installed(current) on v1.51, it seems to work well. Until I try to edit an order.

I am able to make edits to an order. But when I try to update and order, I get a blank screen. This is the the error log:
[11-Aug-2013 05:40:33] PHP Fatal error: Call to undefined function getrewardpoints() in /hsphere/local/home/c376292/luxuriouspurse.com/shop/includes/modules/order_total/ot_reward_points_display.php on line 40

However the edits made to the order are actually saved. Any idea how to fix this? Thank you!

[TheGoofyOne]

Has anyone gotten pagination to work in admin. With over 250 customers that start with A, it's taking the database ages to pull the report on 250 customers. Ihave even more in S. If I set it to 50 the database pulls the data in a number of seconds, but I can't get to the rest of my customers.

[nikerymis]

Hi everyone. I have Super Orders and Edit Orders installed(current) on v1.51, it seems to work well. Until I try to edit an order.

I am able to make edits to an order. But when I try to update and order, I get a blank screen. This is the the error log:
[11-Aug-2013 05:40:33] PHP Fatal error: Call to undefined function getrewardpoints() in /hsphere/local/home/c376292/luxuriouspurse.com/shop/includes/modules/order_total/ot_reward_points_display.php on line 40

However the edits made to the order are actually saved. Any idea how to fix this? Thank you!

I am also having this issue (and am a complete PHP n00b) on my test site (where I'm trying out Edit Orders for the first time). I have no issues on my main site (where I only have Reward Points and no order plugins). Any thoughts on how to fix? My test site, where I'm encountering this error is running Zen Cart v1.5.1 and Edit Orders 4.1.2, but no Super Orders. I'm using PHP version 5.3.x. Let me know if you need more details.

[bi11i]

Sorry if this has been answered before - been looking around and can't find much. This add-on is excellent, however I'm looking for some docs or instructions that explain the workings of this to my customer. Has anyone written a good doc that I could pillage for my site that explains how everything works to my customer base?

Thanks in advance and again apologies if this has been answered elsewhere....

[Athens Collectibles]

It has indeed been answered before but I can not blame you for not finding it within the 2300 posts of this thread

I have created a Q+A page about the workings of the Reward Program on my site and you may find it useful as the basis of your own documentation.

You may also download all my policies in PDF format and find the Reward Program in pages 11-12 of the document.

I hope this helps.