Edit Orders v4.0 Support Thread

[Bruce_m]

Hopefully this will help

[mydanilo]

PRODUCTS_OPTIONS_TYPE_READONLY_IGNORED
Result looks exactly like in your picture

and I want to add that on the front end all options are working correctly for all products

and I am totally lost by the info in the link you provided, sorry! SQL stuff is not my strength. Can you point out what I should run and look for? I have cpanel access.

[DivaVocals]

Hopefully this will help

bigger pictures and still NO IDEA WHAT THE ISSUE IS..Pardon my bluntness here, but believe it or not the images don't tell us jack anyway.. So instead of posting MORE pictures.. PLEASE PLEASE PLEASE...

Why don't you simply STATE (in WORDS) what the issue is.. it will be SOOOOOOO much easier...

from what you've posted thus far, the issue is with the Big Royal Mail' shipping module. You are either SEEING or NOT SEEING something when you click the shipping dropdown.. What is it you are SEEING or NOT SEEING, and what is it you expect to see or not see instead?? It looks like there is something in the Royal Mail dropdowns that shouldn't be there???

Help the community to help you by providing some DETAILS as to the issue you are having so we don't have to GUESS at the problem..

[Bruce_m]

What I am seeing is in the Shipping Drop Down I have the available shipping options all with their HTML for colour font etc:

e.g. Royal Mail Airmail <span style= “font weight; normal - and so on

I had expected and would prefer to see simply - ‘Royal Mail Airmail’ without the HTML

How can I get this please?

[lhungil]

What I am seeing is in the Shipping Drop Down I have the available shipping options all with their HTML for colour font etc ...

Shipping Module Background
First let me give you some background on shipping modules (quick not exhaustive). Typically you only have a single shipping module per shipping carrier (UPS, USPS, FexEx, etc). When a customer requests a "quote" this single shipping module communicates with the shipping carrier and retrieves either a single quote or a list of quotes with shipping options.

This makes sense for customers as they would see: "This store offers Royal Mail shipping"!. Inside the "Royal Mail" shipping section the customer would then see different (and selectable) shipping methods for "Royal Mail". This avoids confusion if more than one shipping carrier is available (such as flat rate, table rate, free shipping, UPS, etc).

To make this work, each shipping module defines a unique "name" for the module. This is saved in the shipping module to "$this->title". This "name" is then used as the display text for the shipping module section (not for the shipping options such as "airmail", "2nd day", "priority", etc). The actual shipping options are returned separately and only when a quote has been requested by the customer and are typically returned as an array. As such the "name" returned by the module does not usually include HTML code.

Royal Mail add-on
First let me say I do not use the "Royal Mail" add-on and have not looked at the source code. It probably returns valid and working quotes and as such is functional. However the add-on does not appear to follow the usual Zen Cart shipping module convention. Instead of a single shipping module returning multiple shipping options for one carrier, this module appears to add a separate shipping module for each shipping method... Which means a customer see's a shipping carrier box for each method! No disrespect intended to the author of the "Royal Mail" add-on, but it would be cleaner if the convention was followed.

The second critique I have is "presentational" HTML data has been added to what really should just be data. Not sure if this is part of the "Royal Mail" add-on or something someone added by editing part of the add-on (such as a language file or the core module itself). One should always avoid combining the two when possible (encapsulating the data is acceptable, but no "style" attributes should be used). Using a "style" attribute overrides any CSS (which is where your presentational logic SHOULD be whenever possible). Otherwise guess what happens if one changes the website look and feel (using CSS)? Text may disappear, images may not load, sizes may be off, and layouts may become broken (until one manually edits the module producing data).

How the shipping module dropdown shown in "Edit Orders" works

1. Loads the Order Total shipping module (ot_shipping).
2. Asks the Order Total shipping module for a list of installed and enabled shipping modules from the database.
3. Query each enabled shipping module and ask "what is your internal name (title)"?
4. Generate a dropdown containing the "name" returned by the enabled shipping modules.
5. Show admin users the list and let them select the appropriate shipping module (for the customer to see).

Edit Orders at this time does NOT allow admin users to get a "quote" or a "list of quotes" for a shipping module. Further changing the selected shipping module does NOT recalculate the shipping total (only shipping tax which is handled by ot_shipping).

... I had expected and would prefer to see simply - ‘Royal Mail Airmail’ without the HTML ... How can I get this please?

I would as well, even as a customer!

The first thing I would change (if in your shoes), would be to remove the "style" attributes from the names of your shipping modules.

The second change (needed only if you really MUST use HTML containers in the name of the shipping module) would be to use strip_tags to remove the HTML. The problem with using strip_tags is if the HTML is malformed it may remove more than expected (or even everything). If you are okay with that caveat, go ahead and open up "/admin/includes/functions/extra_funcions/edit_orders_functions.php". Search for the function "eo_get_available_shipping_modules()". Inside this function find the line where the "title" is assigned to the "text". Change the code to read:

$retval[] = array(
  'id' => $GLOBALS[$class]->code,
  'text' => strip_tags($GLOBALS[$class]->title)
);

[Bruce_m]

Thank you for your very full and helpful reply - probably best not to risk messing up what the customer see on the front end for the few occasions when an order needs to be changed. Again thanks!

[lhungil]

Thank you for your very full and helpful reply.

No problem. Thank You for pointing out what you were seeing (and expected to see)!

Hopefully did not overwhelm anyone with the long post... I've spent a fair amount of time working with shipping modules (still learning a few things) in the course of another project... So just wanted to give some insight into why the "Edit Orders" code in regards to the shipping modules is the way it is today.

Making the change to "/admin/includes/functions/extra_funcions/edit_orders_functions.php" will only affect what is shown in the admin dropdown (not for the customers), so should be fairly safe (and in the image the HTML used by your shipping modules appears correctly formed).

I'm hesitant to enable this globally in future versions by default (I can see the "my shipping module is blank / does not show up" questions already)... But I might add an "option" in the configuration of "Edit Orders" in the future (to selectively enable / disable stripping HTML from the name for the shipping dropdown). Seems like an okay idea at the moment. Anyone else have thoughts on this?

[DivaVocals]

I might add an "option" in the configuration of "Edit Orders" in the future (to selectively enable / disable stripping HTML from the name for the shipping dropdown). Seems like an okay idea at the moment. Anyone else have thoughts on this?

I like this idea.. It's safe, and it might even fix Bruce's issue.. Perhaps Bruce could beta test it???

[gsmsalers]

"Edit orders" not re-calculating tax for after I change product quantity for customers. TAX calculation works fine if customer checkout from front end.
What can be done?

[lhungil]

"Edit orders" not re-calculating tax for after I change product quantity for customers. TAX calculation works fine if customer checkout from front end.
What can be done?

Start by providing more information. Zen Cart version (exact)? Edit Orders version (exact)? Store upgraded from previous version? Other installed modifications (especially any which may impact taxes)? Additional Order Total modules (not part of stock Zen Cart)? Steps to replicate (and what was expected)? What if any debugging has been attempted? Any error logs? Any other information about how your store differs from a stock Zen Cart 1.5 installation?