Problem with taxes and Store Pickup shipping module

[sple]

As I said, it's a design inefficiency. You might prefer to call it a bug.

The Store Pickup module doesn't require an address, so there's no address to calculate taxes against. It doesn't matter whether you set your store to tax based on "Store" or "Shipping" or "Payment".

You'll do best to set your store to tax based on "Shipping", since that will properly assess taxes on all purchases which you ship to in-state addresses. The others you'll have to handle differently in the meantime.

Could you please clarify this?
I have a v1.5 store, set to store based taxing.
I would expect the tax to be calculated on the location of the store for every order, irrespective of the customers billing or shipping address. Isn't that the point of the option?
If I wanted to base tax on the customers shipping or billing address, I would have selected that option in the first place.
....unless I have mis-understood something?

Anybody else come across/solve this?

I have made a tweak to the order class roughly based on DrByte's suggestion to get round this, but it feels very wrong to have to tweak anything.

[jodyroth]

For version 1.5.1 I edited the /includes/classes/order.php file and included the following code (highlighted in green) to somewhere around line 325. Now all taxable goods are treated to sales tax from the store location, regardless of customer shipping/billing address. I can't believe how hard it was to finally find an answer. This solution came from posts by Ajeh, numinix, and DrByte. The earlier post by DrByte was missing the ['id'] that I needed to make this work.

Store pickup should already be set up to charge sales tax based on store location, hope they fix this in formal releases as it was a pain to figure out.

      } else {
        $tax_address_query = "select ab.entry_country_id, ab.entry_zone_id
                                from " . TABLE_ADDRESS_BOOK . " ab
                                left join " . TABLE_ZONES . " z on (ab.entry_zone_id = z.zone_id)
                                where ab.customers_id = '" . (int)$_SESSION['customer_id'] . "'
                                and ab.address_book_id = '" . (int)($this->content_type == 'virtual' ? $_SESSION['billto'] : $_SESSION['sendto']) . "'";
      }
    }



    //Bogue Rat Creations edit to enable tax on all store pickups that are of taxable class.
    if (strstr($_SESSION['shipping']['id'],'storepickup') == TRUE) {
        $taxCountryId = STORE_COUNTRY;
        $taxZoneId = STORE_ZONE;
        $tax_address_query = '';
    }
    // End BRC Edit
    
    
      
    if ($tax_address_query != '') {
      $tax_address = $db->Execute($tax_address_query);
      if ($tax_address->recordCount() > 0) {
        $taxCountryId = $tax_address->fields['entry_country_id'];
        $taxZoneId = $tax_address->fields['entry_zone_id'];
      }
    }

[delia]

I know that the store pickup mod was changed in 1.5.4 and I assume in order to take care of this very thing. But I have run across two scenarios where the store pickup mod in conjunction with another mod that affects taxes and the store pickup mod does not charge taxes any longer. One mod is the local sales tax mod and the other is the product by postcode. The product by post code has been updated for 1.5.4 where the local sales tax mod hasn't. Since it's happening in both I thought it was worth looking at it from this view as appropriate.

[delia]

Using that code in this situation, displays the tax on the orders but does not add the money to the order. Doesn't look like this can be done in 1.5.4