Problem with taxes and Store Pickup shipping module

To the group,

I am trying out Zen Cart (and installed v1.5) and installed just the base install with no add-ons so far. My question is I can't seem to get tax to apply to my products.

I have searched all of the forums and tried all of the solutions, but none seem to work.

My goal is to at first make product a "Store Pickup" we ship nothing.

In my Store I set the tax based on the store location which is Rhode Island.

The issue I think is under my Store Pickup shipping method, it only gives me two options Shipping and Billing Address (see attachment), does NOT give me the option for Store??? Is this a bug or am I missing something.

When I look at the product, it show the correct tax.

thanks for any help.

Steve

You can configure taxes for PRODUCTS, and you can also configure taxes on SHIPPING.

Since you're not shipping anything, you won't be setting any taxes on your shipping module.

Instead, you will edit your product and set a tax class on that product. Then the tax associated with that tax class will be applied to that product during checkout.

Still no luck on getting this to work. I have attached all of the relevant screens, can you see if everything is setup properly?

If you need additional information, please let me know...When I get to the check-out, it shows $0.00 for Rhode Island Tax Rate...

thanks

Steve

Why did you set the Basis of Product Tax to store?
If everything is store-pickup, then your customers are all going to have RI addresses, right? So, it would be better to set the Basis of Product Tax to Billing, since it's the customer's billing address you need to use for taxation in that case.

Customers come from many surrounding states, and the store is located in RI, so the store location would be the tax applied.

Very quick guess about a possible code change you could try:
/includes/classes/order.php
at line 320 you'll see this:} } if ($tax_address_query != '') { $tax_address = $db->Execute($tax_address_query);Try adding some additional lines, as shown here:```
}
}
[B]if (strstr($_SESSION['shipping'],'storepickup')) {
$taxCountryId = STORE_COUNTRY;
$taxZoneId = STORE_ZONE;
$tax_address_query = '';
}
[/B] if ($tax_address_query != '') {
$tax_address = $db->Execute($tax_address_query);

Thank you for the code, but this did not fix the problem. I would think this would just work out of the box. Is anyone using 1.5 and able to get taxes working? If so, can they post the screen shots on how they set this up, and I will try to replicate it...

thanks

Steve

Taxes in Zen Cart 1.5, and earlier for that matter, work just fine. There are FAQ articles on setting up taxes to work correctly.

But there's obviously a feature limitation SPECIFICALLY ONLY when using the Store Pickup module and charging taxes for everyone on those kinds of transactions.

Moving this thread to the Bug Reports section for consideration in a future version.

To the group,

What this looks like to me is that it is basing the taxes on my Shipping Address. If I set myself an account and my state (MA) is not equal to the state the store (RI) is in, then it calculates $0.00 for taxes. I changed my shipping address to the same state (RI) as the store (RI), and taxes appeared. I looked my my Store Configuration and it says to calculate taxes based on store location, do I need to change this anywhere else, or is this a bug?

thanks

Steve

As I said, it's a design inefficiency. You might prefer to call it a bug.

The Store Pickup module doesn't require an address, so there's no address to calculate taxes against. It doesn't matter whether you set your store to tax based on "Store" or "Shipping" or "Payment".

You'll do best to set your store to tax based on "Shipping", since that will properly assess taxes on all purchases which you ship to in-state addresses. The others you'll have to handle differently in the meantime.

DrByte:

As I said, it's a design inefficiency. You might prefer to call it a bug.

The Store Pickup module doesn't require an address, so there's no address to calculate taxes against. It doesn't matter whether you set your store to tax based on "Store" or "Shipping" or "Payment".

You'll do best to set your store to tax based on "Shipping", since that will properly assess taxes on all purchases which you ship to in-state addresses. The others you'll have to handle differently in the meantime.

Could you please clarify this?
I have a v1.5 store, set to store based taxing.
I would expect the tax to be calculated on the location of the store for every order, irrespective of the customers billing or shipping address. Isn't that the point of the option?
If I wanted to base tax on the customers shipping or billing address, I would have selected that option in the first place.
....unless I have mis-understood something?

Anybody else come across/solve this?

I have made a tweak to the order class roughly based on DrByte's suggestion to get round this, but it feels very wrong to have to tweak anything.

For version 1.5.1 I edited the /includes/classes/order.php file and included the following code (highlighted in green) to somewhere around line 325. Now all taxable goods are treated to sales tax from the store location, regardless of customer shipping/billing address. I can't believe how hard it was to finally find an answer. This solution came from posts by Ajeh, numinix, and DrByte. The earlier post by DrByte was missing the ['id'] that I needed to make this work.

Store pickup should already be set up to charge sales tax based on store location, hope they fix this in formal releases as it was a pain to figure out.

      } else {
        $tax_address_query = "select ab.entry_country_id, ab.entry_zone_id
                                from " . TABLE_ADDRESS_BOOK . " ab
                                left join " . TABLE_ZONES . " z on (ab.entry_zone_id = z.zone_id)
                                where ab.customers_id = '" . (int)$_SESSION['customer_id'] . "'
                                and ab.address_book_id = '" . (int)($this->content_type == 'virtual' ? $_SESSION['billto'] : $_SESSION['sendto']) . "'";
      }
    }



    //Bogue Rat Creations edit to enable tax on all store pickups that are of taxable class.
    if (strstr($_SESSION['shipping']['id'],'storepickup') == TRUE) {
        $taxCountryId = STORE_COUNTRY;
        $taxZoneId = STORE_ZONE;
        $tax_address_query = '';
    }
    // End BRC Edit
    
    
      
    if ($tax_address_query != '') {
      $tax_address = $db->Execute($tax_address_query);
      if ($tax_address->recordCount() > 0) {
        $taxCountryId = $tax_address->fields['entry_country_id'];
        $taxZoneId = $tax_address->fields['entry_zone_id'];
      }
    }

I know that the store pickup mod was changed in 1.5.4 and I assume in order to take care of this very thing. But I have run across two scenarios where the store pickup mod in conjunction with another mod that affects taxes and the store pickup mod does not charge taxes any longer. One mod is the local sales tax mod and the other is the product by postcode. The product by post code has been updated for 1.5.4 where the local sales tax mod hasn't. Since it's happening in both I thought it was worth looking at it from this view as appropriate.

Using that code in this situation, displays the tax on the orders but does not add the money to the order. Doesn't look like this can be done in 1.5.4