Product Name Not Appearing in Detail Line Items

[HeyIts007]

re; 1.53 paypalwpp.php

"All the items in your shopping basket (see details in the store and on your store receipt)."

Wondering if it's some kind of array element mismatch, as in my debug testing using if (strval($optionsST['ITEMAMT']) < 0) instead of the <= 0 actually outputs the product line detail to PayPal, however it also includes the product code in square brackets [ ] in the product detail which seems odd. Almost seems like some kind of mismatch somewhere, be it an array element or how its accessed or something else etc...

E.G. With the debug test mode of < 0 it's outputting "TEST Product [123]" with 123 being the product code, instead of just "Test Product" as it used to. This brings me back to my previous question regarding statement if (strval($optionsST['ITEMAMT']) <= 0) and what a zero value as opposed to a greater than zero represents in the shopping basket transaction?

Definitely seems this relates to the crux of the issue though and working backwards from here should reveal more about the cause.

[HeyIts007]

re; v1.53 paypalwpp.php

What's the name of the product detail array ? i.e. that forms the product line detail e.g. "TEST Product [123]" etc...

[HeyIts007]

re; v1.53 paypalwpp.php

Why is the code appending the product ID to the product name ? Is that the new format ? or is that leftover debug code not removed?

$optionsLI["L_NAME$k"] = $order->products[$i]['name'] . ' [' . (int)$order->products[$i]['id'] . ']';

[DrByte]

There's no leftover debug code there.

[HeyIts007]

re; v1.53 paypalwpp.php
It's evident that;
re;
if (strval($optionsST['ITEMAMT']) <= 0) {

If I just make it <0 as follows;
if (strval($optionsST['ITEMAMT']) < 0) {

The product line detail then gets displayed in my order at least.

However then looking at the below code.

$optionsLI["L_NAME$k"] = $order->products[$i]['name'] . ' [' . (int)$order->products[$i]['id'] . ']'; is producing "TEST Product [123]" in the line item output. So why is that ? Normally the line item output is just "TEST Product"

Appending . ' [' . (int)$order->products[$i]['id'] . '] is resulting in the [123] in the product line item output which is then showing in the PayPal order detail.

[HeyIts007]

re; v1.53 paypalwpp.php
"All the items in your shopping basket (see details in the store and on your store receipt)."

What are the implications of applying these two code adjustments to correct the PayPal missing product line output issue in my v1.53 that seems to have resulted from data migration from 1.39 ?

1.
if (strval($optionsST['ITEMAMT']) <= 0) {

Becomes: if (strval($optionsST['ITEMAMT']) < 0) {

2.
$optionsLI["L_NAME$k"] = $order->products[$i]['name'] . ' [' . (int)$order->products[$i]['id'] . ']';

Becomes: $optionsLI["L_NAME$k"] = $order->products[$i]['name'] ;

These two adjustments correct the PayPal product line output problem in my case, however will applying them cause other problems?

[mc12345678]

So, this question/request was made a while back to try to answer the question of why the database of your existing store upgraded/brought into your rebuilt store is causing the issues that you have observed and the request remains unanswered. Now the solution being proposed is to 1, change the way the code is written (which is not unheard of) but based on some previous experience (huh, when I last drove my car 50 mph down this road, with my eyes shut nothing happened. Where did that car come from?). If you take the time to identify why this issue is happening on your site (or provide the information to help others do the same) then the "problem" whether on your site or in the core code can be resolved.

Although I only briefly looked throught that portion of the paypal code, it seemed to me that that section was about verifying that things were set up correctly to move forward with the sale/purchase. I'm only calling from my memory of yesterday as I hadn't taken the time today to look through the code to try to determine what it is you are not providing...

When you goto modules->Order Total in the admin panel, what modules are listed that do not have a red circle? What are their sort orders and are they green or some other color?

[HeyIts007]

re; v1.53 paypalwpp.php
"All the items in your shopping basket (see details in the store and on your store receipt)."

Thanks for looking at this. Yes I've spent a week on this issue and not identified a forum solution for my case. Shipping and Total are green, everything else is red. The only 1.53 code change made was the commenting out of the SSL3 reference in paypal_curl.php to address PayPal Poodle BUG. From there it was working perfectly until the 1.39 data migration. Seems like perhaps there's some kind of data mismatch in the array processing.

Does the data migration also update PHP coding? I will presume not at this stage. I'm not a PHP expert and don't know how all this ZenCart code works, but failing a provided solution, I'm having to try to come up with my own. That is why I have sought to clarify if these two proposed code adjustments which correct the PayPal product line output problem in my case, will cause other problems if implemented on my live site? I'm asking if there's a car coming I guess. I expect someone familiar with this code would know the answer to that.

[HeyIts007]

To further clarify re; your question about the modules settings. The following two are green. The rest are red.

Shipping ot_shipping 200
Total ot_total 999

[mc12345678]

To further clarify re; your question about the modules settings. The following two are green. The rest are red.

Shipping ot_shipping 200
Total ot_total 999

In each of those, what are the settings? (We are talking about the settings of either the imported old data or the old store, they ought to be the same.)