Direct Bank Deposit

[jolliejollie]

Just upgraded a site to 1.5.4 running on PHP 5.4.39 and had this error whilst testing:



To fix this open your /includes/modules/payment/dirbankaus.php

Change

// class methods 
    function update_status() { 
      global $order, $db; 
 
      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0) ) { 
        $check_flag = false; 

to this

// class methods 
    function update_status() { 
      global $order, $db; 
       
      if ($this->enabled && (int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0 && isset($order->billing['country']['id'])) { 
        $check_flag = false; 

Note that I am in Australia, if you are using the USA equivalent replace DIRBANKAUS with DIRBANKUSA and similar for other countries.

Just noticed "zone" and "billing country" from the codes above. Does it check the customers' addresses before allowing customers to check out using this payment option? Or does it check where I am located? I'm in Hong Kong and my customers are also in Hong Kong. I think there isn't a Hong Kong version of Direct Bank Deposit, is there? I originally planned to use the New Zealand version since the info displayed is the same as that is required for Hong Kong bank account transfers and I would just change the name of the payment method displayed in:

1. order confirmation page by changing:
includes\languages\english\modules\payment\dirbanknz.php:
define('MODULE_PAYMENT_DIRBANKNZ_TEXT_TITLE', 'Direct Bank Deposit - NZ');
change to:
define('MODULE_PAYMENT_DIRBANKNZ_TEXT_TITLE', 'Direct Bank Deposit - HK');

2. order confirmation email (changing 'Direct Bank Deposit - NZ' to 'Direct Bank Deposit - HK' but haven't found out how to do that yet. some advice would be appreciated.)

I thought I would be able to use the NZ version of this payment module though my customers and I are actually in Hong Kong after making the above changes. Does it work like that? Does it help if I set my Store Zone as “None” and leave my Store Address blank in my Admin Settings?

Thanks.

[gilby]

Just noticed "zone" and "billing country" from the codes above. Does it check the customers' addresses before allowing customers to check out using this payment option? Or does it check where I am located? I'm in Hong Kong and my customers are also in Hong Kong. I think there isn't a Hong Kong version of Direct Bank Deposit, is there? I originally planned to use the New Zealand version since the info displayed is the same as that is required for Hong Kong bank account transfers and I would just change the name of the payment method displayed in:

1. order confirmation page by changing:
includes\languages\english\modules\payment\dirbanknz.php:
define('MODULE_PAYMENT_DIRBANKNZ_TEXT_TITLE', 'Direct Bank Deposit - NZ');
change to:
define('MODULE_PAYMENT_DIRBANKNZ_TEXT_TITLE', 'Direct Bank Deposit - HK');

2. order confirmation email (changing 'Direct Bank Deposit - NZ' to 'Direct Bank Deposit - HK' but haven't found out how to do that yet. some advice would be appreciated.)

I thought I would be able to use the NZ version of this payment module though my customers and I are actually in Hong Kong after making the above changes. Does it work like that? Does it help if I set my Store Zone as “None” and leave my Store Address blank in my Admin Settings?

Thanks.

In its simplest form this mod doesn't check anything at all.
It provides a way to present the website bank details to the customer as a form of payment.
It also doesn't check if the payment was made or anything else.

So, Yes the NZ version should work just fine.

If you do want to restrict it to certain customers or certain countries?
Then that will require more coding

[frank18]

....
If you do want to restrict it to certain customers or certain countries?
Then that will require more coding

Restriction to certain countries is done in the admin, you simply set Payment Zone to Australia, Hong Kong or whatever. Does not require extra coding.

Restricting to specific customers - yes, that does require a hack.

[gilby]

Restriction to certain countries is done in the admin, you simply set Payment Zone to Australia, Hong Kong or whatever. Does not require extra coding.

Restricting to specific customers - yes, that does require a hack.

Indeed, the country can be set in the admin. (I have been using it for years and haven't needed to change that)

[frank18]

For anyone interested in this payment module, it can be downloaded here

[blueskyhigh]

I have installed Direct Bank Deposit 1.5.3 for AUS. Installed and works fine. However in the email order confirmation the font for the bank details etc is like a Times New Roman font rather than Arial like the rest of the email content.

How do you change the font for the DBD text in the order confirmation email?

[frank18]

I have installed Direct Bank Deposit 1.5.3 for AUS. Installed and works fine. However in the email order confirmation the font for the bank details etc is like a Times New Roman font rather than Arial like the rest of the email content.

How do you change the font for the DBD text in the order confirmation email?

Did you install/upload all files in that package?

If so, can you give us a link or screenshot?

[dw08gm]

For anyone interested in this payment module, it can be downloaded here

Mod needs to be upgraded for 154 as per #67.

Since this is a payment module, I am interested to know for the update_status function of includes\modules\payment\dirbankaus.php whether:
1) "delivery" should be changed to "billing"
2) and the code that checks for "virtual products" should be removed

such that replace

    function update_status() {
      global $order, $db;

      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0) ) {
        $check_flag = false;
        $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKAUS_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");
        while (!$check->EOF) {
          if ($check->fields['zone_id'] < 1) {
            $check_flag = true;
            break;
          } elseif ($check->fields['zone_id'] == $order->delivery['zone_id']) {
            $check_flag = true;
            break;
          }
          $check->MoveNext();
        }

        if ($check_flag == false) {
          $this->enabled = false;
        }
      }
// disable the module if the order only contains virtual products
      if ($this->enabled == true) {
        if ($order->content_type == 'virtual') {
          $this->enabled = false;
        }
      }
    }

with

    function update_status() {
      global $order, $db;
      if ($this->enabled && (int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0 && isset($order->billing['country']['id'])) {
        $check_flag = false;
        $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKAUS_ZONE . "' and zone_country_id = '" . $order->billing['country']['id'] . "' order by zone_id");
        while (!$check->EOF) {
          if ($check->fields['zone_id'] < 1) {
            $check_flag = true;
            break;
          } elseif ($check->fields['zone_id'] == $order->billing['zone_id']) {
            $check_flag = true;
            break;
          }
          $check->MoveNext();
        }

        if ($check_flag == false) {
          $this->enabled = false;
        }
      }
// disable the module if the order only contains virtual products
//      if ($this->enabled == true) {
//        if ($order->content_type == 'virtual') {
//          $this->enabled = false;
//        }
//      }
    }

[dw08gm]

link to this or a new support thread needs to be added to downloads page for this plugin

[allmart]

Has anyone used this for Canada?