Stock by Attribute v4.0 addon for v1.3.5-1.3.9

[mc12345678]

yep, correct, thanks for pointing that out - somehow i had missed uploading that file 'YOUR_ADMIN/includes/classes/observers/class.products_with_attributes_stock.php'

i can access admin now

however, when i add a product to cart the content area of the page goes blank https://www.jarbon.com/dev/index.php?main_page=product_info&cPath=62_73&products_id=9

problem is i am not receiving any errors for this in logs

i have double, triple checked that all files are up

I have looked at Stock By Attribute (SBA) installation script and it is showing no errors, all seems to be in order

any ideas?

In the "check" of the files, what has been the method of checking? It may be that files didn't get transferred satisfactorily even if when looking at the directory structure they appear to be there.

Also, how were the files transferred, and suggest addressing the questions posed in the posting tips found just above the message box when generating a message (and not using the mobile template to access this site.)

[mattys]

In the "check" of the files, what has been the method of checking? It may be that files didn't get transferred satisfactorily even if when looking at the directory structure they appear to be there.

Also, how were the files transferred, and suggest addressing the questions posed in the posting tips found just above the message box when generating a message (and not using the mobile template to access this site.)

I've been through the files several times now, all seems to be in order.

i use winmerge to merge the files and just upload one by one referring to files list (with notes)

i am using zen cart 1.5.3 and stock_by_attribute_1.5.4-mc12345678_ZC154, sorry, most posts i have included this info, the last one i didnt though

i have just PM'd you though, see if you available to do some paid work on this, i have spent days on it, and it's just about come to a head...

[mc12345678]

I've been through the files several times now, all seems to be in order.

i use winmerge to merge the files and just upload one by one referring to files list (with notes)

i am using zen cart 1.5.3 and stock_by_attribute_1.5.4-mc12345678_ZC154, sorry, most posts i have included this info, the last one i didnt though

i have just PM'd you though, see if you available to do some paid work on this, i have spent days on it, and it's just about come to a head...

I seem to recall the details provided above, but more importantly are things like: other plugins, the source of the ZC store files, was this an upgraded store, if so how, etc...

I'll get back to you shortly, but wanted to assist as able from this perspective.

[mattys]

here is a list of plug ins used

ceon url mapping
google merchant senter feeder (need to uninstall)
products with attributes stock
Ceon Sage Pay Form v2.0.3
Product Listing - Layout Style column plugin (product_listing.php)
database backup mysql
export email addresses
gift wrap

out of these it is only gift wrap that has code in similar files, but i have been very careful to merge properly keeping all code intact

i'm not sure excatly what you mean by the source of the zc store files, but i recently upgraded zen cart to 1.5.3, the files from standard zen cart download

im not sure what you mean by how i upgraded, i just upgraded like you normally do,except it ook me several tries and to this point a few days trying to make sure all files are merged/uploaded correctly

[mc12345678]

Thanks to some testing performed by mattys, it was identified that there was an error in the zen_get_products_stock function for when a product had multiple attributes that were grouped together as mixed attributes, and that a specific variant of the group was set to a quantity of zero, then the variant did not show out-of-stock even though there was no product.

After some testing, specifically identified, the following situation:

When a product had two attributes,
- one with 3 values the other with 2
- the attributes are added as a combination (a, 1; a, 2; b, 1: b, 2; c, 1; c, 2)
- If the combination of a, 2 is set to zero, then when displaying the product on the store side, the total quantity of a is displayed instead of the expected value of zero.

While a minor fix for that one thing, the branch(es) I started of SBA 1.5.4 have been updated to contain all of the latest fixes and streamline the various corrections into the master branch. The readme.MD file now indicates that it is compatible with both ZC 1.5.3 and ZC 1.5.4. The place to go to see these is: https://github.com/potteryhouse/stoc...ttribute_1.5.4.

Working on bringing all of the fixes and capability of SBA 1.5.4 to SBA 1.5.3 so that those still using ZC 1.5.1 can also have the same benefits. The files have been locally setup and appear functional, now trying to compare the files to a fresh install so that the number of changes necessary in a merge are minimized. Identified a few minor improvements to apply to SBA 1.5.4 that will also minimize some of the core file changes as nice as it would be to make this more of a core program. :)

For what its worth, it is now possible (in SBA 1.5.4, soon to come to SBA 1.5.3) to populate multiple attribute product either by combined attributes or as multiple single attribute variants, but not yet a combination of both. Some thinking needs to be applied before using the multiple single attribute approach as it may not make sense to populate in that fashion and may cause inventory tracking issues. It may also make a lot of sense for some. One use might be something like: flowers are being sold, with or without vases. At the moment a quantity of vases as well as a quantity without vases would need to be populated (Hadn't programmed yet the possibility of one attribute option being used for inventory while the other not). But basically, vases would be populated for the product as a total number of vases (for that product), and the number of flowers of that flower type would be populated. But the inventory would not need to be set such that there were x flowers with vase and y flowers without vase, but there would need to be x flowers, y vases, and z non-vases (which would be suggested to be the same value as x flowers or larger). The code will determine the maximum number of product combination based on the minimum quantity available of each of the attributes, hence the need to ensure that the quantity of non-vase options equals or exceeds the number of flower options. This is just a single scenario and there are many others to consider. Additional coding will continue to address this and several other options and features.

[mc12345678]

FYI, uploaded to the master branch (meaning no special tricks needed) an updated version 1.5.3 of SBA that incorporates the functionality available in SBA 1.5.4 but is ZC 1.5.1 centric. Available from: https://github.com/potteryhouse/stoc...ttribute_1.5.3

So those issues identified over the last several pages that were identified as being addressed in SBA 1.5.4 are now incorporated. It is still suggested to upgrade to the latest version of ZC; however, if one must continue to use an older version of ZC, at least SBA should still be able to function on it.

[Malaperth]

Thanks to some testing performed by mattys, it was identified that there was an error in the zen_get_products_stock function for when a product had multiple attributes that were grouped together as mixed attributes, and that a specific variant of the group was set to a quantity of zero, then the variant did not show out-of-stock even though there was no product.

After some testing, specifically identified, the following situation:

When a product had two attributes,
- one with 3 values the other with 2
- the attributes are added as a combination (a, 1; a, 2; b, 1: b, 2; c, 1; c, 2)
- If the combination of a, 2 is set to zero, then when displaying the product on the store side, the total quantity of a is displayed instead of the expected value of zero.

While a minor fix for that one thing, the branch(es) I started of SBA 1.5.4 have been updated to contain all of the latest fixes and streamline the various corrections into the master branch. The readme.MD file now indicates that it is compatible with both ZC 1.5.3 and ZC 1.5.4. The place to go to see these is: https://github.com/potteryhouse/stoc...ttribute_1.5.4.

Working on bringing all of the fixes and capability of SBA 1.5.4 to SBA 1.5.3 so that those still using ZC 1.5.1 can also have the same benefits. The files have been locally setup and appear functional, now trying to compare the files to a fresh install so that the number of changes necessary in a merge are minimized. Identified a few minor improvements to apply to SBA 1.5.4 that will also minimize some of the core file changes as nice as it would be to make this more of a core program. :)

For what its worth, it is now possible (in SBA 1.5.4, soon to come to SBA 1.5.3) to populate multiple attribute product either by combined attributes or as multiple single attribute variants, but not yet a combination of both. Some thinking needs to be applied before using the multiple single attribute approach as it may not make sense to populate in that fashion and may cause inventory tracking issues. It may also make a lot of sense for some. One use might be something like: flowers are being sold, with or without vases. At the moment a quantity of vases as well as a quantity without vases would need to be populated (Hadn't programmed yet the possibility of one attribute option being used for inventory while the other not). But basically, vases would be populated for the product as a total number of vases (for that product), and the number of flowers of that flower type would be populated. But the inventory would not need to be set such that there were x flowers with vase and y flowers without vase, but there would need to be x flowers, y vases, and z non-vases (which would be suggested to be the same value as x flowers or larger). The code will determine the maximum number of product combination based on the minimum quantity available of each of the attributes, hence the need to ensure that the quantity of non-vase options equals or exceeds the number of flower options. This is just a single scenario and there are many others to consider. Additional coding will continue to address this and several other options and features.

You da MAN!!! As much as I am attempting to upgrade all of one of my customers sites to 1.54, the customer is overloading me with tiny changes and and (although I cannot no matter how hard I try) I cannot convince her to just chill out for a while so I can get her the "latest and greatest", but as lame as it may be, I do have a life and work to do on my property so a newer version of SBA that worked with ZC 1.5.1 would be fantastic!!! Thank you for putting in all the effort that you do, mc12345678 and whatever other coders and testers are involved! This SBA plugin is the most important thing I ever installed other than ZC itself!!!

Mal

[mc12345678]

You da MAN!!! As much as I am attempting to upgrade all of one of my customers sites to 1.54, the customer is overloading me with tiny changes and and (although I cannot no matter how hard I try) I cannot convince her to just chill out for a while so I can get her the "latest and greatest", but as lame as it may be, I do have a life and work to do on my property so a newer version of SBA that worked with ZC 1.5.1 would be fantastic!!! Thank you for putting in all the effort that you do, mc12345678 and whatever other coders and testers are involved! This SBA plugin is the most important thing I ever installed other than ZC itself!!!

Mal

Yes there are many programmers that over the years have worked on this plugin in one way or another. Hopefully though you have seen the post indicating that SBA for ZC 1.5.1 got updated: https://www.zen-cart.com/showthread....43#post1283243

Actually have a minor update to the SBA 1.5.4 version that is expected to prevent any issues with the store if the files are loaded but the install script hasn't been run yet. This has already been addressed in the SBA 1.5.3 version.