SEND_EXTRA_NEW_ORDERS_EMAILS_TO_SUBJECT and starnge charecter

[Congerman]

And to clarify (for fear of the above seeming rude) 1. We haven't talked about which version of ZC is involved,
2) The results of searching on FILENAME_EMAIL_EXTRAS hasn't been provided,
3) Haven't discussed how if at all includes/languages/english.php has been modified.

These three things in and of themselves can vary the default behaviour which should load the default version of the email_extras.php file if one does not exist in the template override directory at least in the latest ZC version (which this obviously is not based on the difference in line numbers for the same code provided above...)

So... That led both lat9 and I to ask about the same file in attempting a solution.

Hi, Have found that the bana template english.php, when deleted or renamed, solves the problem. What I cannot understand is why? It looks like the php is not closed but closed or open it still causes the problem php below

<?php
/**
 * @package languageDefines
 * @copyright Copyright 2003-2011 Zen Cart Development Team
 * @copyright Portions Copyright 2003 osCommerce
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: english.php 19690 2011-10-04 16:41:45Z drbyte $
 */

define('BANA_LABEL_LANGUAGE', 'Languages');
define('BANA_LABEL_CURRENCY', 'Currencies');
define('BANA_EMPTY_CART', 'Your cart is empty.');
define('BANA_PRODUCT_LIST', 'Listing');
define('BANA_PRODUCT_NEXT', 'Next »');
define('BANA_PRODUCT_PREVIOUS', '« Previous');
define('BANA_NO_PRODUCT_FOUND', 'No Product Found');
define('BANA_GENDER', 'Gender');
define('BANA_SUBSCRIBE', 'Subscribe');
define('BANA_EMAIL', 'Email Address');
define('BANA_REVIEWS', 'Reviews');
define('BANA_NUM_REVIEWS', 'review(s)');
define('BANA_BASED_ON', 'stars based on');

[Congerman]

OK Think I have the solution. It appears to be a problem with the Bana responsive template english.php

I have deleted the override bana/english.php but added its define contents to the bottom of my standard english.php and replaced the << and >> symbols with their html equivalents.

So to summarize, if you are using bana template and have these problems then remove the bana, english.php but add these lines at end of standard english.php

define('BANA_LABEL_LANGUAGE', 'Languages');
define('BANA_LABEL_CURRENCY', 'Currencies');
define('BANA_EMPTY_CART', 'Your cart is empty.');
define('BANA_PRODUCT_LIST', 'Listing');
define('BANA_PRODUCT_NEXT', 'Next &gt;&gt;');
define('BANA_PRODUCT_PREVIOUS', '&lt;&lt; Previous');
define('BANA_NO_PRODUCT_FOUND', 'No Product Found');
define('BANA_GENDER', 'Gender');
define('BANA_SUBSCRIBE', 'Subscribe');
define('BANA_EMAIL', 'Email Address');
define('BANA_REVIEWS', 'Reviews');
define('BANA_NUM_REVIEWS', 'review(s)');
define('BANA_BASED_ON', 'stars based on');

I would really appreciate someone to tell me why moving the defines from the override english to the standard english.php worked?

would like to understand the error

[mc12345678]

The "closure" of the php (tag at end of file ?> is actually unnecessarily included in files across ZC; however, is not being removed unless the file is otherwise modified.

That is interesting though, as at least more recent versions of ZC will load both the template override and the standard language file to catch any "default" defines not covered by the template override... Now for some reason, I thought I remembered that one of the older versions didn't do this, but that doesn't exactly make sense based oon the explained behavior otherwise...

So, the real question here is how is your store different than a vanilla install of your version of ZC, what plugins are installed, how are your override files (template related or other overrides) different from the same/equivalent default files causing them not to operate as expected (again basing on more recent versions of ZC as I haven't gone to try to figure out in what version(s) did the above line numbers line up... And honestly, it's a questionmuch easier answered by those who have access to the site...) and causing this issue to appear...

There are a few files that do the language loading which would be my first consideration working backwards, but again the odd thing is that if that language override only had those few lines, and otherwise the store works, I'm a bit baffled if the code hasn't otherwise been modified AND we're talking about a relatively more recent version...

[Congerman]

Thanks, Unsure why this one was different.

Fresh install v1.5.1 ( used that version to ensure compatability inporting products from another store ) installed bana template, recover cart sales, easy populate csv, uk shipping by postcode and nochex payment module. adjusted date and time format to British.

Thanks for your input

[mc12345678]

Thanks, Unsure why this one was different.

Fresh install v1.5.1 ( used that version to ensure compatability inporting products from another store ) installed bana template, recover cart sales, easy populate csv, uk shipping by postcode and nochex payment module. adjusted date and time format to British.

Thanks for your input

Okay so I hate to jump gears (on other people) but has the extra character in front of the British pound issue also been resolved by this language file "change"?

[Congerman]

Okay so I hate to jump gears (on other people) but has the extra character in front of the British pound issue also been resolved by this language file "change"?

Yes, and all I ended up doing was putting the bana defines in zens default english php and removed the bana one completely. very strange as I see no code in the bana one that would affect a site in this way.

[mc12345678]

So finally got a chance to 1) pull up ZC 1.5.1 code and 2) retrace my steps to the earlier discovery of how the language files basically get loaded.

The issue we were all referencing is covered in includes/init_includes/init_templates.php

It is here that the template language file is loaded before loading the base language. Further the base language loads the email_extras file so that should have taken care of all the essentials for the template to work. It is possible though that the file is overridden in the includes/init_includes/overrides folder, but still, the other aspects of the includes/languages/english.php file appeared to be loaded and the applicable line in the file existed and seemed to work..

[Congerman]

Wow, very in depth and a bit beyond me. At least it all seems to work now. Many thanks for your assistance with this