[Closed] FEEDBACK ON BETA of v1.5.5

[lat9]

Just noticed this: In admin - tools - developer tools.

I did a search and the results returned look a little wonky. See image attached.

Attachment 15887

Yes, that's another side-effect of the change to use either <pre> or <code> to format the results, as I'd mentioned here.

[charmedbytina2]

Yes, that's another side-effect of the change to use either <pre> or <code> to format the results, as I'd mentioned here.

Derh! Maybe it's too early for "eggnog"? I guess I should have looked at this thread a little closer - apologies!

[lat9]

Derh! Maybe it's too early for "eggnog"? I guess I should have looked at this thread a little closer - apologies!

It's never too early for eggnog! Your posting included the jagged output display (which I was too lazy to include), so it's all good.

[lat9]

The file /admin/customers.php has been changed from the ZC1.5.4 base, but the header comments still reflect last-changed in v1.5.4.

[lat9]

Admin, Tools->Developers Tool Kit. It looks like either the CSS or layout was changed so that a mono-type font is now used for the display:
Attachment 15872
It's quite ugly (IMO) now and very difficult to read. Can this be changed back?

P.S. I do like the new highlighting of the searched-for term!

Just noticed this: In admin - tools - developer tools.

I did a search and the results returned look a little wonky. See image attached.

Attachment 15887

FWIW, I changed the file /admin/includes/developers_tool_kit.css, removing the lines highlighted to restore the display to a non-monospaced font:

/*
 * @package Admin 
 * @copyright Copyright 2003-2015 Zen Cart Development Team
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: Author: DrByte  Modified in v1.6.0 $
 */

.dtk-highlite {font-weight: bold; color: rgb(255, 10, 5);}
.dtk-foundline, .dtk-foundline-multi {font-family: courier;}
.dtk-foundline-multi {background-color: rgba(4, 211, 216, 0.12);}
.dtk-contextline {font-family: courier;}
.dtk-linenum {font-family: courier;}

[Ajeh]

/*
 * @package Admin 
 * @copyright Copyright 2003-2015 Zen Cart Development Team
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: Author: DrByte  Modified in v1.6.0 $
 */

.dtk-highlite {font-weight: bold; color: rgb(255, 10, 5);}
.dtk-foundline, .dtk-foundline-multi {font-family: courier;}
.dtk-foundline-multi {background-color: rgba(4, 211, 216, 0.12);}
.dtk-contextline {font-family: courier;}
.dtk-linenum {font-family: courier;}

You could just change those to Verdanda, sans-serif to cover 90% of the issue ...

[lat9]

That's, in essence, what the font falls back to with those lines removed!

[ibuttons]

is there any additional documentation on how to install and/or setup the responsive design stuff?

[lat9]

What are you trying to setup?

[mc12345678]

Changes made to sql statements in includes/functions/functions_lookups did not use $db->bindVars(

function zen_has_product_attributes_downloads_status($products_id) {
  if (!defined('DOWNLOAD_ENABLED') || DOWNLOAD_ENABLED != 'true') {
    return false;
  }

  $query = "select pad.products_attributes_id
              from " . TABLE_PRODUCTS_ATTRIBUTES . " pa
              inner join " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " pad
              on pad.products_attributes_id = pa.products_attributes_id
              where pa.products_id = " . (int) $products_id;

  global $db;
  return ($db->Execute($query)->RecordCount() > 0);
}

Could/should be:

function zen_has_product_attributes_downloads_status($products_id) {
  if (!defined('DOWNLOAD_ENABLED') || DOWNLOAD_ENABLED != 'true') {
    return false;
  }

  $query = "select pad.products_attributes_id
              from " . TABLE_PRODUCTS_ATTRIBUTES . " pa
              inner join " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " pad
              on pad.products_attributes_id = pa.products_attributes_id
              where pa.products_id = :products_id:";

  global $db;
  $query = $db->bindvars($query, ':products_id:', $products_id, 'integer');
  return ($db->Execute($query)->RecordCount() > 0);
}