Banner set to No new window not working

[carlwhat]

the OP confirmed that the banners are turned off in the banner manager. perhaps EC's banners function has changed; perhaps it never worked in V1.5.1. i do not know.

the code the OP listed on line 42 suggests that the template may honor the flag associated with the banners opening in a new window; however if the banner link construction is being done on line 142, my guess is that the 100 lines of code is far too many for them to be related.

EC, i would compare your code to the following code around your line 142:

if ($banner->fields['banners_open_new_windows'] == '1') {
    $banner_string = '<a href="' . zen_href_link(FILENAME_REDIRECT, 'action=banner&goto=' . $banner->fields['banners_id']) . '" target="_blank">' . zen_image(DIR_WS_IMAGES . $banner->fields['banners_image'], $banner->fields['banners_title']) . '</a>';
} else {
    $banner_string = '<a href="' . zen_href_link(FILENAME_REDIRECT, 'action=banner&goto=' . $banner->fields['banners_id']) . '">' . zen_image(DIR_WS_IMAGES . $banner->fields['banners_image'], $banner->fields['banners_title']) . '</a>';
} 

this is how it looks under v1.5.4 and it would seem to honor the flags mentioned above. if your code does not look like this, you should copy this code to replace your line 142 and see if that works.

line 42 should be left alone.... although i'm not really sure what it is doing up there.

on your single line, you code just change the following, but then your flags would not work (which is what is currently happening anyway):

//original line
$banner_string = '<a href="' . zen_href_link(FILENAME_REDIRECT, 'action=banner&goto=' . $banner->fields['banners_id']) . '" target="_blank">' . zen_image(DIR_WS_IMAGES . $banner->fields['banners_image'], $banner->fields['banners_title']) . '</a>';

//new line
$banner_string = '<a href="' . zen_href_link(FILENAME_REDIRECT, 'action=banner&goto=' . $banner->fields['banners_id']) . '" >' . zen_image(DIR_WS_IMAGES . $banner->fields['banners_image'], $banner->fields['banners_title']) . '</a>'; 

good luck!