[Closed] FEEDBACK ON BETA of v1.5.5

[Ajeh]

Has the problem with text attributes not showing up as "required" even if the box has been clicked in Attributes Controller been addressed in 1.5.5 code?
See Scott's post below:
https://www.thatsoftwareguy.com/blog...t-not-working/

Keep in mind this is triggered by Add-Ons that are not written correctly and delete those needed settings in Zen Cart which breaks the TEXT required

[mc12345678]

Has the problem with text attributes not showing up as "required" even if the box has been clicked in Attributes Controller been addressed in 1.5.5 code?

It wasn't in the version I am testing, but can't remember what day I downloaded the code from github for sure, so thought I would ask.

See Scott's post below:

https://www.thatsoftwareguy.com/blog...t-not-working/

I am not seeing that in v1.5.5 ... I was testing with the demo products for:
Per letter - required

and it appears to work fine ...

Keep in mind this is triggered by Add-Ons that are not written correctly and delete those needed settings in Zen Cart which breaks the TEXT required

In a way it was corrected a version or two ago (confirmed to be corrected in ZC 1.5.3 and 1.5.4, I don't/never have installed ZC 1.5.2 and ZC 1.5.1 still had "that" issue)... The "pertinent" data is now stored in a different configuration location. Those values are no longer kept in gID=0 and are no longer "lost" because of incorrectly formatted SQL (BTW, was guilty at least once of providing something that caused this... Lesson learned... :) )

As far as "addressed", I have a feeling that if in an upgrade, the values were previously deleted (non-existent) that they are not recreated, but I'm starting a rumor by saying that as I haven't looked through the install/upgrade code to validate that the value is created/recreated in the appropriate location if missing upon upgrade. Wouldn't surprise me though if it were "restored" if absent in an upgrade from 1.5.1 or below to at least 1.5.3.

[Ajeh]

NOTE: the configuration_group_id was changed from 0 to 6 ... and, providing they exist, they will be updated ...

[stellarweb]

I simply added a option name with TEXT, then in attributes controller clicked the box on the bottom right that says Attribute required for text "yes" and it did not work (would allow checkout without the text field having anything in it) until I ran the SQL script in Scott's post.

Guess there is more than one way to skin a cat! But still wonder if maybe I am not "getting" what Attribute required for text box is all about...

I am not seeing that in v1.5.5 ... I was testing with the demo products for:
Per letter - required

and it appears to work fine ...

[Ajeh]

In phpMyAdmin, search the configuration table for the configuration_keys:
PRODUCTS_OPTIONS_TYPE_SELECT
UPLOAD_PREFIX
TEXT_PREFIX

Do all 3 of these come up?

The TEXT required means if a Product with a TEXT attribute is attempted to be added *without* the Text actually filled in, it will not be added to the shopping cart and you will get a warning saying fill it in ...

If the TEXT attribute is marked as required and this warning does not come up when trying to add the Product to the cart without filling in the Text, then there is a problem to be addressed ...

[stellarweb]

Yes on all three showing up in phpMyAdmin

The 1.5.5 is pretty much a vanilla cart - and the text attribute was marked required, but was still able to add the product to the cart without the text field filled in. Once I installed Scott's sql - it worked properly

Same thing happened with my 1.5.4 installation - but that one does have a few mods installed.

I will go do a BRAND SPANKING NEW install with today's code and see if it does the same thing and report back. This 1.5.5 install was from 1/14/16 - so is a week old.

In phpMyAdmin, search the configuration table for the configuration_keys:
PRODUCTS_OPTIONS_TYPE_SELECT
UPLOAD_PREFIX
TEXT_PREFIX

Do all 3 of these come up?

The TEXT required means if a Product with a TEXT attribute is attempted to be added *without* the Text actually filled in, it will not be added to the shopping cart and you will get a warning saying fill it in ...

If the TEXT attribute is marked as required and this warning does not come up when trying to add the Product to the cart without filling in the Text, then there is a problem to be addressed ...

[Ajeh]

That doesn't really make sense on the v1.5.5 ...

A plain vanilla v1.5.5 works fine ...

Are you really saying a Zen Cart v1.5.5 with a database from an older version of Zen Cart that you ran the Upgrader on?

When in phpMyAdmin, and you searched for the configuration table for the configuration_keys:
PRODUCTS_OPTIONS_TYPE_SELECT
UPLOAD_PREFIX
TEXT_PREFIX

Did you find 1 of each or many of each?

[stellarweb]

There was only one of each and yes, it was an upgrade in the sense that I brought over only the product tables from an older version then ran ZC_install again once they were brought over. That must have been what caused the problem.

I just did a fresh install and it worked properly ..... except that it would not let me do anything in the attributes controller if I had only added a text attribute under option name and there were no other option names listed. It gave me the following error: Warning: No Option Values have been defined

Once I added a "fictitious" option name and added an option value, then I was able to apply the text attribute to the product and marking it required worked.

Just to test... I then went back and deleted the "extra" option name / value so that I was left again with only a text option I had set up, and again got the same error - it would not let me add the text attribute without first setting up a fictitious option name/value that was not TEXT

That doesn't really make sense on the v1.5.5 ...

A plain vanilla v1.5.5 works fine ...

Are you really saying a Zen Cart v1.5.5 with a database from an older version of Zen Cart that you ran the Upgrader on?

When in phpMyAdmin, and you searched for the configuration table for the configuration_keys:
PRODUCTS_OPTIONS_TYPE_SELECT
UPLOAD_PREFIX
TEXT_PREFIX

Did you find 1 of each or many of each?

[Ajeh]

Had those been there, there would have been a slightly different setting as the upgrader fo v155 would have run:

UPDATE configuration set configuration_group_id = 6 where configuration_key in ('PRODUCTS_OPTIONS_TYPE_SELECT', 'UPLOAD_PREFIX', 'TEXT_PREFIX');

You should run that in the Tools ... Install SQL patches .. to bring them up to date on the configuration_group_id to switch from 0 to 6 ...

[rbarbour]

I know this is pretty petty but one thing I have always struggled with is styling the "display price".

Maybe it would be possible to add a span in functions_prices.php, I alter this file for this reason on every template or client site I have ever designed or re-designed.

line 255:

        if ($product_check->fields['product_is_free'] == '1') {
          $show_normal_price = '<s>' . $currencies->display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</s>';
        } else {
          $show_normal_price = $currencies->display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id']));
        } 

perhaps something like:

        if ($product_check->fields['product_is_free'] == '1') {
          $show_normal_price = '<span class="productFreePrice"><s>' . $currencies->display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</s></span>';
        } else {
          $show_normal_price = '<span class="productBasePrice">' . $currencies->display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</span>';
        }