Edit Orders v4.0 Support Thread

[lat9]

It turns out that using the setting Configuration->My Store->Show Split Tax Lines (when set to 'true') is the basis for the issue that Colleen is experiencing. When that setting is active, there are multiple instances of the ot_tax order-total where EO 4.1.4 is expecting that each order-total occurs once per order.

[jackie.taferner]

Found a bug in the latest Github version (https://github.com/lat9/edit_orders).

PHP Fatal error: Call to undefined function zen_product_in_category() in /admin/includes/functions/extra_functions/edit_orders_functions.php on line 326

Category-restricted coupons were not adding into the total after editing the order. In addition to the bugfix found in post #495, I needed to do the following as well.

In this file:
admin/includes/functions/extra_functions/edit_orders_functions.php

Change this:

			if (($coupons->fields['category_id'] !=0) && (zen_product_in_category($product_id, $coupons->fields['category_id'])) && ($coupons->fields['coupon_restrict']=='Y')) return false;
			// if category is not restricted(allow) and product not in category deny
			if (($coupons->fields['category_id'] !=0) && (!zen_product_in_category($product_id, $coupons->fields['category_id'])) && ($coupons->fields['coupon_restrict']=='N')) return false;
			return true;

To this:

			if (($coupons->fields['category_id'] !=0) && (validate_for_category($product_id, $coupons->fields['category_id'])) && ($coupons->fields['coupon_restrict']=='Y')) return false;
			// if category is not restricted(allow) and product not in category deny
			if (($coupons->fields['category_id'] !=0) && (!validate_for_category($product_id, $coupons->fields['category_id'])) && ($coupons->fields['coupon_restrict']=='N')) return false;
			return true;

[lat9]

Jackie, thanks for that! I'll get that updated.

[lat9]

Jackie, I've looked and your proposal is not good since it's modifying the functionality that's being ported from that function in the functions_general.php file in the storefront.

There's something funky going on with the function insertions that I need to investigate.

[lat9]

When did you download the EO fileset from GitHub? I'd made a change on 4/1 that added those "missing" functions. Please re-download the plugin's files as I think it's all better now.

[swguy]

@lat9, should the issues noted in Github which are flagged "fix provided" not just be closed?

I noticed the product select did not account for products_status, so I added that and submitted a PR. I will keep testing. Thanks for fixing my carriage control issue reported here:
https://www.zen-cart.com/showthread....85#post1307485

but I believe there is still an issue (reported on https://www.zen-cart.com/showthread....n-Orders/page2)

[lat9]

@swguy, I'm keeping the "fix provided" status until there's a release candidate (and associated GitHub release) so that I can verify that I've got the readme and install/uninstall handling updated.

I'll need to consider the change you submitted via PR, as it's not clear whether the behavior you're looking to change is a bug or a feature! There might, for example, be shop-owners that use that behavior to add otherwise-disabled products to a customer's order as part of a rewards program.

Regarding the multi-line break characters, I'm not seeing that using Zen Cart 1.5.5 (2016-03-29) plus the 2016-04-12 versions of AdminRequestSanitizer.php and init_sanitize.php and the current code-set from the EO GitHub repository. What admin-level plugins do you have installed in addition to Edit Orders?

[swguy]

Re: Line breaks - This is 1.5.4, with the prior version of EO and just that patch installed. I will test on 1.5.5 with the full candidate release of EO. Thanks for the clarifications.

Re: Status checks - that's a really good point. Would you take my PR if I added a flag to the database and allowed the behavior to be configured?

[lat9]

Re: Line breaks - This is 1.5.4, with the prior version of EO and just that patch installed. I will test on 1.5.5 with the full candidate release of EO. Thanks for the clarifications.

Re: Status checks - that's a really good point. Would you take my PR if I added a flag to the database and allowed the behavior to be configured?

I've been speaking with @lhungil about the line breaks; it appears that the Zen Cart base handling might have changed when the change was made from mysql_* to mysqli_* function usage. I'll follow up on this and report back.

For the status checks, I'd prefer not to burden the plugin with yet-another configuration value; my preference (as indicated via this GitHub issue) is to simply identify those products in the drop-down list that are disabled, possibly via an asterisk (*).

[swguy]

For the status checks, I'd prefer not to burden the plugin with yet-another configuration value; my preference (as indicated via this GitHub issue) is to simply identify those products in the drop-down list that are disabled, possibly via an asterisk (*).

OK. Will do tonight or this weekend.