Yes just a suffix on the second price that reminds the visitor that the price given is "ex VAT"
Yes just a suffix on the second price that reminds the visitor that the price given is "ex VAT"
I'll give my recommended code to add the suffix into the class file in a moment, but it appears that the inc_ex_functions file in includes/functions/extra_functions is missing a span tag in one place as seen by your website and then review of that code as downloaded a while back from zc. There is a line in that function file starting with
The right side of that "equation" should be encompassed by a span of class normalPrice or similar it looks like.Code:$show_normal_price=display_price(
ZC Installation/Maintenance Support <- Site
Contribution for contributions welcome...
On line 110? I have corrected that
If I am correct, line 10 didn't have a class assigned and just had a strike through <s>. Generally speaking, that is as expected because there would/should be some other class that follows and would be replaced with an applicable price to update. It would be two lines down where there is no "html" surrounding the price value(s). It appears to be causing on your product info page for the "base price" to not be uniquely surrounded by a span that can be "tagged" and therefore the entire content is being replaced not just the applicable price(s).
BTW, feedback on the above modification would be greatly appreciated as I have it staged (locally) to be posted to github and to ZC for incorporation. Would like to get it as close to fully operational as possible.
ZC Installation/Maintenance Support <- Site
Contribution for contributions welcome...
Hi
Ok will do.
So here are the changes I recommend to support the inc/excl VAT module.
First, update the includes/functions/extra_functions/inc_ex_functions.php file to change this:
Around line 112 to this (in red):Code:if ($product_check->fields['product_is_free']=='1') $show_normal_price='<s>'.display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s>'; else $show_normal_price=display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id']));
Then in includes/modules/pages/product_info/jscript_dynamic_price_updater.php:Code:if ($product_check->fields['product_is_free']=='1') $show_normal_price='<s>'.display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s>'; else $show_normal_price='<span class="normalprice">'.display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</span>';
At and around line 222:
Add: a check for the className normalprice and a check for the "alternate tax" display possibilities:Code:for (var a=0,b=test.length; a<b; a++) { if (test[a].className == "productSpecialPrice" || test[a].className == "productSalePrice" || test[a].className == "productSpecialPriceSale") { psp = test[a]; } }
Then below that beginning at line 243:Code:var pspInclEx = false; var pspEx = false; var pspIncl = false; for (var a=0,b=test.length; a<b; a++) { if (test[a].className == "normalprice" || test[a].className == "productSpecialPrice" || test[a].className == "productSalePrice" || test[a].className == "productSpecialPriceSale") { psp = test[a]; } } if (test[a].className == "productIncExTaxPrice") { pspInclEx = test[a]; } if (test[a].className == "productTaxExPrice") { pspEx = test[a]; } if (test[a].className == "productTaxPrice") { pspIncl = test[a]; }
Insert additional cases of "priceTotalInclTax", "priceTotalExcTax", and "priceTotalIncExcTax" to support the various classes that the plugin uses.Code:switch (type) {<?php // the 'type' attribute defines what type of information is being provided ?> case "priceTotal": if (psp) { psp.innerHTML = temp[i].childNodes[0].nodeValue; } else { thePrice.innerHTML = temp[i].childNodes[0].nodeValue; } if (_secondPrice !== false) { this.updSP(); } break; case "quantity": with (temp[i].childNodes[0]) { if (nodeValue != "") { if (psp) { psp.innerHTML += nodeValue; } else { thePrice.innerHTML += nodeValue; } this.updSP(); } } break;
Then in includes/classes/dynamic_price_updater.php within the prepareOutput function modifying (for now) the area in blue below (a similar modification will be incorporated for when not showing the currency symbols, but first am trying to get through with when they are displayed):Code:switch (type) {<?php // the 'type' attribute defines what type of information is being provided ?> case "priceTotal": if (psp) { psp.innerHTML = temp[i].childNodes[0].nodeValue; } else { thePrice.innerHTML = temp[i].childNodes[0].nodeValue; } if (_secondPrice !== false) { this.updSP(); } break; case "priceTotalInclTax": if (pspIncl) { pspIncl.innerHTML = temp[i].childNodes[0].nodeValue; } break; case "priceTotalExcTax": if (pspEx) { pspEx.innerHTML = temp[i].childNodes[0].nodeValue; } break; case "priceTotalInclExcTax": if (pspInclEx) { pspInclEx.innerHTML = temp[i].childNodes[0].nodeValue; } break; case "quantity": with (temp[i].childNodes[0]) { if (nodeValue != "") { if (psp) { psp.innerHTML += nodeValue; } else { thePrice.innerHTML += nodeValue; } this.updSP(); } } break;
Incorporate the following (in red, the "blue" line remains unchanged):Code:if (DPU_SHOW_CURRENCY_SYMBOLS == 'false') { $decimal_places = $currencies->get_decimal_places($_SESSION['currency']); $this->responseText['priceTotal'] .= number_format($this->shoppingCart->total, $decimal_places); } else { $this->responseText['priceTotal'] .= $currencies->display_price($this->shoppingCart->total, zen_get_tax_rate($product_check->fields['products_tax_class_id'])/* 0 */ /* DISPLAY_PRICE_WITH_TAX */); }
I may add a "switch" to the jscript file to detect if the incl/exc VAT plugin is installed/enabled/active, but need to identify what would trigger that "knowledge". Otherwise, for non-users of that code, additional javascript is sent to a browser and possibly a little processing speed/time by calculating the opposite price of what the store is showing on page load/attribute change with no other ill effect(s) by this change.Code:if (DPU_SHOW_CURRENCY_SYMBOLS == 'false') { $decimal_places = $currencies->get_decimal_places($_SESSION['currency']); $this->responseText['priceTotal'] .= number_format($this->shoppingCart->total, $decimal_places); } else { $product_tax_class_id = zen_products_lookup((int)$_POST['products_id'], 'products_tax_class_id'); $tax_rate = zen_get_tax_rate($product_tax_class_id); // Rate comes back as a "whole number" such as 20% returns 20 and NOT 0.20 if (DISPLAY_PRICE_WITH_TAX != 'false') { $price_without_tax = 100.0 * $this->shoppingCart->total / ($tax_rate + 100.0); // Price of product without tax $this->responseText['priceTotalInclExcTax'] = $this->responseText['priceTotal'] . $currencies->display_price($price_without_tax, 0); $this->responseText['priceTotalExcTax'] = $currencies->display_price($price_without_tax, 0); } else { $this->responseText['priceTotalInclExcTax'] = $this->responseText['priceTotal'] . $currencies->display_price($this->shoppingCart->total + zen_calculate_tax($this->shoppingCart->total, $tax_rate), 0); $this->responseText['priceTotalInclTax'] = $currencies->display_price($this->shoppingCart->total + zen_calculate_tax($this->shoppingCart->total , $tax_rate), 0); } $this->responseText['priceTotal'] .= $currencies->display_price($this->shoppingCart->total, 0)/* 0 */ /* DISPLAY_PRICE_WITH_TAX */; }
ZC Installation/Maintenance Support <- Site
Contribution for contributions welcome...
I did this and as a result the including VAT price now has a strikethroughAround line 112 to this (in red):
Code:if ($product_check->fields['product_is_free']=='1') $show_normal_price='<s>'.display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s>'; else $show_normal_price='<span class="normalprice">'.display_price($display_normal_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</span>';
This stopped the Price Updater working
Then in includes/modules/pages/product_info/jscript_dynamic_price_updater.php:
At and around line 222:
Code:for (var a=0,b=test.length; a<b; a++) { if (test[a].className == "productSpecialPrice" || test[a].className == "productSalePrice" || test[a].className == "productSpecialPriceSale") { psp = test[a]; } }
Add: a check for the className normalprice and a check for the "alternate tax" display possibilities:
Then below that beginning at line 243:Code:var pspInclEx = false; var pspEx = false; var pspIncl = false; for (var a=0,b=test.length; a<b; a++) { if (test[a].className == "normalprice" || test[a].className == "productSpecialPrice" || test[a].className == "productSalePrice" || test[a].className == "productSpecialPriceSale") { psp = test[a]; } } if (test[a].className == "productIncExTaxPrice") { pspInclEx = test[a]; } if (test[a].className == "productTaxExPrice") { pspEx = test[a]; } if (test[a].className == "productTaxPrice") { pspIncl = test[a]; }
Insert additional cases of "priceTotalInclTax", "priceTotalExcTax", and "priceTotalIncExcTax" to support the various classes that the plugin uses.Code:switch (type) {<?php // the 'type' attribute defines what type of information is being provided ?> case "priceTotal": if (psp) { psp.innerHTML = temp[i].childNodes[0].nodeValue; } else { thePrice.innerHTML = temp[i].childNodes[0].nodeValue; } if (_secondPrice !== false) { this.updSP(); } break; case "quantity": with (temp[i].childNodes[0]) { if (nodeValue != "") { if (psp) { psp.innerHTML += nodeValue; } else { thePrice.innerHTML += nodeValue; } this.updSP(); } } break;
Code:switch (type) {<?php // the 'type' attribute defines what type of information is being provided ?> case "priceTotal": if (psp) { psp.innerHTML = temp[i].childNodes[0].nodeValue; } else { thePrice.innerHTML = temp[i].childNodes[0].nodeValue; } if (_secondPrice !== false) { this.updSP(); } break; case "priceTotalInclTax": if (pspIncl) { pspIncl.innerHTML = temp[i].childNodes[0].nodeValue; } break; case "priceTotalExcTax": if (pspEx) { pspEx.innerHTML = temp[i].childNodes[0].nodeValue; } break; case "priceTotalInclExcTax": if (pspInclEx) { pspInclEx.innerHTML = temp[i].childNodes[0].nodeValue; } break; case "quantity": with (temp[i].childNodes[0]) { if (nodeValue != "") { if (psp) { psp.innerHTML += nodeValue; } else { thePrice.innerHTML += nodeValue; } this.updSP(); } } break;
The DPU doesn't work at the moment. I have followed your instructions clearly twice now with the same result.Then in includes/classes/dynamic_price_updater.php within the prepareOutput function modifying (for now) the area in blue below (a similar modification will be incorporated for when not showing the currency symbols, but first am trying to get through with when they are displayed):
Incorporate the following (in red, the "blue" line remains unchanged):Code:if (DPU_SHOW_CURRENCY_SYMBOLS == 'false') { $decimal_places = $currencies->get_decimal_places($_SESSION['currency']); $this->responseText['priceTotal'] .= number_format($this->shoppingCart->total, $decimal_places); } else { $this->responseText['priceTotal'] .= $currencies->display_price($this->shoppingCart->total, zen_get_tax_rate($product_check->fields['products_tax_class_id'])/* 0 */ /* DISPLAY_PRICE_WITH_TAX */); }
I may add a "switch" to the jscript file to detect if the incl/exc VAT plugin is installed/enabled/active, but need to identify what would trigger that "knowledge". Otherwise, for non-users of that code, additional javascript is sent to a browser and possibly a little processing speed/time by calculating the opposite price of what the store is showing on page load/attribute change with no other ill effect(s) by this change.Code:if (DPU_SHOW_CURRENCY_SYMBOLS == 'false') { $decimal_places = $currencies->get_decimal_places($_SESSION['currency']); $this->responseText['priceTotal'] .= number_format($this->shoppingCart->total, $decimal_places); } else { $product_tax_class_id = zen_products_lookup((int)$_POST['products_id'], 'products_tax_class_id'); $tax_rate = zen_get_tax_rate($product_tax_class_id); // Rate comes back as a "whole number" such as 20% returns 20 and NOT 0.20 if (DISPLAY_PRICE_WITH_TAX != 'false') { $price_without_tax = 100.0 * $this->shoppingCart->total / ($tax_rate + 100.0); // Price of product without tax $this->responseText['priceTotalInclExcTax'] = $this->responseText['priceTotal'] . $currencies->display_price($price_without_tax, 0); $this->responseText['priceTotalExcTax'] = $currencies->display_price($price_without_tax, 0); } else { $this->responseText['priceTotalInclExcTax'] = $this->responseText['priceTotal'] . $currencies->display_price($this->shoppingCart->total + zen_calculate_tax($this->shoppingCart->total, $tax_rate), 0); $this->responseText['priceTotalInclTax'] = $currencies->display_price($this->shoppingCart->total + zen_calculate_tax($this->shoppingCart->total , $tax_rate), 0); } $this->responseText['priceTotal'] .= $currencies->display_price($this->shoppingCart->total, 0)/* 0 */ /* DISPLAY_PRICE_WITH_TAX */; }
It seems that there are other changes that have been made unrelated to the above suggestions to support continued display of both included and excluded taxes. Possibly something modified in the includes/classes/dynamic_price_updater.php file? Or more likely based on system response, the includes/configure.php file has been modified for this sub-directory store, because from the above link, clicking on anything there takes one to the "live" store instead of remaining in the temporary store.
I've "externally" checked what is presented at the provided link and while initially the page loads just fine, all of the links point to the main directory not to the "temporary" directory that appears to have been created. This then causes thing like the ajax to fail because it look like there is a cross browser type situation occurring. When the default sub-directory is removed, then the site loads, and as of just now, DPU is working as it originally was recently provided, but without edits suggested above being visible. So, it seems that the primary issue over the last few days related to the provided link is that it did not direct/redirect to a properly formed/generated site, therefore any other issues at that point were unrelated to DPU.
As to the line through with the normalprice class, yeah I can see how the use of that class is already designated to format with a line-through (the normalprice class is used when the normal price is displayed and some other price is present such as a special or a sale). Not using a class of some type in that area causes the overall price swap to fail/cause what is being seen of the entire "block" being replaced. Perhaps use of normalInclExcPrice as the class to be used to support swapping could work. That way at least the price is editable without a lot of text manipulation or substitution. It somewhat depends on what is desired/necessary. I have installed a version of the includes/excludes VAT price module and have been working on a solution that does not require an additional incl/exc VAT function with the current result being that on change of the attribute, both the included and excluded VAT price are shown, but the sale, special, etc.. price has been replaced as well thus far in testing. It would be nice to just replace the necessary values, which in part I have been able to do, but further ideally would be for this plugin to be provided to operate as normal without any subsequent changes and to also operate "as normal" with the incl/exc VAT plugin such that again no code changes to DPU would be necessary. It does look like though that the incl/exc VAT plugin could use a few tweaks to support being installed, to have the necessary switch adjustments to affect display, but to also be "disabled" without having to be removed. I believe countrycharm had at one point posted a slightly updated version, but even that could use a few modifications to accomplish the installed but not adding to the returned text.
ZC Installation/Maintenance Support <- Site
Contribution for contributions welcome...
@dharrison - is just me or does the zenID also appear for you on every link?
To prevent that:
Admin -> Configuration -> Sessions
Cookie Domain
Force Cookie Use
- make sure they both say True
Also, you have some links in the HTML HEADER using "http://" links instead of "https://" which is causing my Browser to give Warning msgs.
I have noticed that the config setting DPU_SHOW_LOADING_IMAGE (true to show a small loading graphic so the user knows something is happening) is misleading as if you set it to false the whole functionality is not loading anymore. There is no image loading but no price change as well :-) If the graphic is needed it would be better to remove this setting. If the graphic is not needed something must be wrong in thesections.Code:<?php if (DPU_SHOW_LOADING_IMAGE == 'true') { ?>