City value of States

[lat9]

When you look at a customer's record in the admin, does it show the "City" as empty?

Perhaps you need a small change to the "create_account" page's processing, where you use the zone_id value to look up the associated "City" and just copy that value into the customer's "City" field.

[gunni]

When you look at a customer's record in the admin, does it show the "City" as empty?

Perhaps you need a small change to the "create_account" page's processing, where you use the zone_id value to look up the associated "City" and just copy that value into the customer's "City" field.

Yes. The city is empty in the customer's record.

Tried some changes in the "create account" without success. The city field in the customer's record still empty.
Even tried city=state but I'm not a PHP expert...
That's why I put in the beginning of this thread the "create_account" relevant code of the city and the state so you could advice
what value should I put where...

[lat9]

You should keep the changes you made to the tpl_modules_create_account.php (especially the renaming of the "State" field to "City").

If you don't have a file named /includes/modules/responsive_sheffield_blue/create_account.php, create a template override by copying the like-named file from the /includes/modules directory into the responsive_sheffield_blue subdirectory.

You'll need to edit that template-override file, looking for the following block (for zc1.5.5a, around line 200) that deals with the country/state values:

  if (strlen($city) < ENTRY_CITY_MIN_LENGTH) {
    $error = true;
    $messageStack->add('create_account', ENTRY_CITY_ERROR);
  }

  if (ACCOUNT_STATE == 'true') {
    $check_query = "SELECT count(*) AS total
                    FROM " . TABLE_ZONES . "
                    WHERE zone_country_id = :zoneCountryID";
    $check_query = $db->bindVars($check_query, ':zoneCountryID', $country, 'integer');
    $check = $db->Execute($check_query);
    $entry_state_has_zones = ($check->fields['total'] > 0);
    if ($entry_state_has_zones == true) {
      $zone_query = "SELECT distinct zone_id, zone_name, zone_code
                     FROM " . TABLE_ZONES . "
                     WHERE zone_country_id = :zoneCountryID
                     AND " .
                     ((trim($state) != '' && $zone_id == 0) ? "(upper(zone_name) like ':zoneState%' OR upper(zone_code) like '%:zoneState%') OR " : "") .
                    "zone_id = :zoneID
                     ORDER BY zone_code ASC, zone_name";

      $zone_query = $db->bindVars($zone_query, ':zoneCountryID', $country, 'integer');
      $zone_query = $db->bindVars($zone_query, ':zoneState', strtoupper($state), 'noquotestring');
      $zone_query = $db->bindVars($zone_query, ':zoneID', $zone_id, 'integer');
      $zone = $db->Execute($zone_query);

      //look for an exact match on zone ISO code
      $found_exact_iso_match = ($zone->RecordCount() == 1);
      if ($zone->RecordCount() > 1) {
        while (!$zone->EOF && !$found_exact_iso_match) {
          if (strtoupper($zone->fields['zone_code']) == strtoupper($state) ) {
            $found_exact_iso_match = true;
            continue;
          }
          $zone->MoveNext();
        }
      }

      if ($found_exact_iso_match) {
        $zone_id = $zone->fields['zone_id'];
        $zone_name = $zone->fields['zone_name'];
      } else {
        $error = true;
        $error_state_input = true;
        $messageStack->add('create_account', ENTRY_STATE_ERROR_SELECT);
      }
    } else {
      if (strlen($state) < ENTRY_STATE_MIN_LENGTH) {
        $error = true;
        $error_state_input = true;
        $messageStack->add('create_account', ENTRY_STATE_ERROR);
      }
    }
  }

... and make the highlighted changes, copying the matching zone's name into the city value.

/*-bof --- City will be copied from the matching state ---
  if (strlen($city) < ENTRY_CITY_MIN_LENGTH) {
    $error = true;
    $messageStack->add('create_account', ENTRY_CITY_ERROR);
  }
-eof --- City will be copied from the matching state --- */

  if (ACCOUNT_STATE == 'true') {
    $check_query = "SELECT count(*) AS total
                    FROM " . TABLE_ZONES . "
                    WHERE zone_country_id = :zoneCountryID";
    $check_query = $db->bindVars($check_query, ':zoneCountryID', $country, 'integer');
    $check = $db->Execute($check_query);
    $entry_state_has_zones = ($check->fields['total'] > 0);
    if ($entry_state_has_zones == true) {
      $zone_query = "SELECT distinct zone_id, zone_name, zone_code
                     FROM " . TABLE_ZONES . "
                     WHERE zone_country_id = :zoneCountryID
                     AND " .
                     ((trim($state) != '' && $zone_id == 0) ? "(upper(zone_name) like ':zoneState%' OR upper(zone_code) like '%:zoneState%') OR " : "") .
                    "zone_id = :zoneID
                     ORDER BY zone_code ASC, zone_name";

      $zone_query = $db->bindVars($zone_query, ':zoneCountryID', $country, 'integer');
      $zone_query = $db->bindVars($zone_query, ':zoneState', strtoupper($state), 'noquotestring');
      $zone_query = $db->bindVars($zone_query, ':zoneID', $zone_id, 'integer');
      $zone = $db->Execute($zone_query);

      //look for an exact match on zone ISO code
      $found_exact_iso_match = ($zone->RecordCount() == 1);
      if ($zone->RecordCount() > 1) {
        while (!$zone->EOF && !$found_exact_iso_match) {
          if (strtoupper($zone->fields['zone_code']) == strtoupper($state) ) {
            $found_exact_iso_match = true;
            continue;
          }
          $zone->MoveNext();
        }
      }

      if ($found_exact_iso_match) {
        $zone_id = $zone->fields['zone_id'];
        $zone_name = $zone->fields['zone_name'];
        $city = $zone_name;  // Copy the city from the selected zone's name
      } else {
        $error = true;
        $error_state_input = true;
        $messageStack->add('create_account', ENTRY_STATE_ERROR_SELECT);
      }
    } else {
      if (strlen($state) < ENTRY_STATE_MIN_LENGTH) {
        $error = true;
        $error_state_input = true;
        $messageStack->add('create_account', ENTRY_STATE_ERROR);
      }
    }
  }

That should do it for the coding part (please note that I haven't tested this, so be sure to attempt the changes on a test site!). You'll also need to change the wording of the two (currently state-related) messages that I highlighted above.

You'll also want to apply these changes to the address-gathering forms and processing for the checkout_payment_address, checkout_shipping_address and address_book_process page.

[gunni]

Thank you lat9 !
First process for the account create looks good.
I put the code $city = $zone_name and after a new customer create, I look in the admin and the customer record
city apears good !
Now, need to work on the other 3 address-payment related files.
Hope no problems there....

[gunni]

You'll also want to apply these changes to the address-gathering forms and processing for the checkout_payment_address, checkout_shipping_address and address_book_process page.

@lat9
regarding those 3 files that you mentioned, I thought that I need to put in them the code "$city = $zone_name"
but they have mainly 'defines' in them.
Did you mean to change the defines?

On the other hand, there is checkout_new_address.php file and there I add the "$city = $zone_name".

So...just want to be sure that "$city = $zone_name" was needed to be put in 2 files only.

[lat9]

@gunni, for the checkout_payment_address and checkout_shipping_address pages' update you'll need to start with a template-override version of /includes/modules/checkout_new_address.php and apply the same changes as you did with the template-override of /includes/modules/create_account.php.

That will provide the "city" recording for both pages and you'll need also to update your template-override version of tpl_checkout_payment_address_default.php and tpl_checkout_shipping_address_default.php like you did to tpl_modules_create_account.php.

Then, for the address_book_process page you'll edit the core-file /includes/modules/pages/address_book_process/header_php.php like you did for /includes/modules/create_account.php and update your template-override version of tpl_address_book_process_default.php to make the template change.

I think that should "do it"!

[gunni]

@lat9 Big thanks again but not all clear....

@gunni, for the checkout_payment_address and checkout_shipping_address pages' update you'll need to start with a template-override version of /includes/modules/checkout_new_address.php and apply the same changes as you did with the template-override of /includes/modules/create_account.php.

That will provide the "city" recording for both pages

This is clear (after 6 times or reading...:).

and you'll need also to update your template-override version of tpl_checkout_payment_address_default.php and tpl_checkout_shipping_address_default.php like you did to tpl_modules_create_account.php.

I opened thoese two files and they do not have "city" nor "state" like I changed the tpl_modules_create_account.php file
so what do I need to change in these files ? Not clear.

Then, for the address_book_process page you'll edit the core-file /includes/modules/pages/address_book_process/header_php.php like you did for /includes/modules/create_account.php

Did it :)

and update your template-override version of tpl_address_book_process_default.php to make the template change.

What to update ? Opened this file and do not understand what to update...where ? Or should I put this file in my template dir ?

Thanks again...

[lat9]

I opened thoese two files and they do not have "city" nor "state" like I changed the tpl_modules_create_account.php file
so what do I need to change in these files ? Not clear.

My bad; those two files (tpl_checkout_payment_address_default.php and tpl_checkout_shipping_address_default.php) both include /tpl_modules_checkout_new_address.php; it's that common file that you might need to update to change the "State" to "City" ... although, I'm thinking now that those values are in your primary language file (hebrew.php?).

What to update ? Opened this file and do not understand what to update...where ? Or should I put this file in my template dir ?

Thanks again...

Dang it! That one, too. The form is displayed via tpl_modules_address_book_details.php

For both the tpl_modules_address_book_details.php and tpl_modules_checkout_new_address.php, you'll need to copy the files from the /includes/templates/template_default/templates directory to /includes/templates/responsive_sheffield_blue/templates ... unless the file is already in that directory.

In either case, you'll apply any edits like you previously made to tpl_modules_create_account.php.