Multiple Ship-To Addresses [Support Thread]

[lat9]

Understood; I'll get three GitHub issues noted:

1. The coding error that resulted in the database barf when the order includes a product with attributes.
2. The coding error that resulted in the "new error" you reported.
3. A change to the language text, providing "better" guidance.

Just so I'm clear, did the change I made to your test site (issue #1) correct that debug-log generation?

[dbltoe]

Yes ma'am!

[lat9]

OK, made (yet another) change, this time to /YOUR_ADMIN/includes/classes/observers/class.admin_multiship_observer.php. Find:

    public function update(&$class, $eventID, $p1a) 
    {
        global $db;
        $this->eventID = $eventID;

and add the highlighted additional parameters:

    public function update(&$class, $eventID, $p1a, &$p2, &$p3) 
    {
        global $db;
        $this->eventID = $eventID;

@dbltoe, I've applied this correction to your test site.

[dbltoe]

That got it!

Take the rest of the day off. You deserve it.

[lat9]

That got it!

Take the rest of the day off. You deserve it.

Yeah! Thanks for providing the test-area. I'll get those language changes packaged up in preparation for this plugin's update.

[dbltoe]

Newest little twist in the packing slip department.

I have modified the standard packing slip on all our sites to reflect an image of the product being shipped. In a standard packing slip, the change starts around line 142 and looks like the following (additions in red)

    <td><table border="0" width="100%" cellspacing="0" cellpadding="2">              <!--   dbltoe -- Add Product Image      -->
      <tr class="dataTableHeadingRow">
        <td class="dataTableHeadingContent">Image</td>
        <td class="dataTableHeadingContent"><?php echo TABLE_HEADING_PRODUCTS; ?></td> <!-- Dropped colspan="2" -->
        <td class="dataTableHeadingContent"><?php echo TABLE_HEADING_PRODUCTS_MODEL; ?></td>
      </tr>
<?php
    for ($i=0, $n=sizeof($order->products); $i<$n; $i++) {
      echo '      <tr class="dataTableRow">' . "\n" .
           '        <td class="dataTableContent" valign="top" align="right"><img src="' . DIR_WS_CATALOG . DIR_WS_IMAGES . zen_get_products_image($order->products[$i]['id']) .'" align="left" width="' . IMAGE_ON_INVOICE_IMAGE_WIDTH . '" height="' . IMAGE_ON_INVOICE_IMAGE_HEIGHT . '" />' . $order->products[$i]['qty'] . '&nbsp;x</td>' . "\n" .
           //dbltoe - Add Product Image
          '        <td class="dataTableContent" valign="top">' . $order->products[$i]['name'];

This is the code in the packingslip_multiship that I need to adjust

      <tr class="dataTableHeadingRow">        <td class="dataTableHeadingContent" colspan="2"><?php echo TABLE_HEADING_PRODUCTS; ?></td>
        <td class="dataTableHeadingContent"><?php echo TABLE_HEADING_PRODUCTS_MODEL; ?></td>
      </tr>
<?php
    foreach ($order->products as $currentProduct) {
        if ($currentProduct['orders_multiship_id'] != $multiship_id) {
        continue;
        }
?>
      <tr class="dataTableRow">
        <td class="dataTableContent" valign="top" align="right"><?php echo $currentProduct['qty']; ?>&nbsp;x</td>
        <td class="dataTableContent" valign="top"><?php echo $currentProduct['name']; ?>

I've tried several options with no joy.

Any assistance greatly appreciated.

[lat9]

@dbltoe, while not exactly what you had originally, I believe that the following will get you close ... and without a lot of "carving up":

    <td><table border="0" width="100%" cellspacing="0" cellpadding="2">
      <tr class="dataTableHeadingRow">
<?php
//-bof-20180125-lat94dbltoe-Add 'images' column
?>
        <td class="dataTableHeadingContent">Image</td>
<?php
//-eof-20180125-lat94dbltoe-Add 'images' column
?>
        <td class="dataTableHeadingContent" colspan="2"><?php echo TABLE_HEADING_PRODUCTS; ?></td>
        <td class="dataTableHeadingContent"><?php echo TABLE_HEADING_PRODUCTS_MODEL; ?></td>
      </tr>
<?php
    foreach ($order->products as $currentProduct) {
        if ($currentProduct['orders_multiship_id'] != $multiship_id) {
        continue;
        }
?>
      <tr class="dataTableRow">
<?php
//-bof-20180125-lat94dbltoe-Add image to column
?>
        <td class="dataTableContent" valign="top" align="left"><?php echo zen_image(DIR_WS_CATALOG . DIR_WS_IMAGES . zen_get_products_image($order->products[$i]['id']), '', IMAGE_ON_INVOICE_IMAGE_WIDTH, IMAGE_ON_INVOICE_IMAGE_HEIGHT); ?></td>
<?php
//-eof-20180125-lat94dbltoe-Add image to column
?>
        <td class="dataTableContent" valign="top" align="right"><?php echo $currentProduct['qty']; ?>&nbsp;x</td>
        <td class="dataTableContent" valign="top"><?php echo $currentProduct['name']; ?>
<?php

[dbltoe]

Sorry for the delay in getting back to you. I had accidentally added two mods that crashed multiship.

I slightly changed the code to

      <tr class="dataTableRow">        <!-- BOF Add Image 2 of 2 - dbltoe -->
        <td class="dataTableContent" valign="top" align="left"><?php echo zen_image(DIR_WS_CATALOG . DIR_WS_IMAGES . zen_get_products_image($order->products[$i]['id']), '', IMAGE_ON_INVOICE_IMAGE_WIDTH, IMAGE_ON_INVOICE_IMAGE_HEIGHT); ?></td>
        <!-- EOF Add Image 2 of 2 - dbltoe -->
        <td class="dataTableContent" valign="top" align="center"><?php echo $currentProduct['qty']; ?></td>
        <td class="dataTableContent" valign="top"><?php echo $currentProduct['name']; ?>
<?php


        if (isset($currentProduct['attributes']) && (sizeof($currentProduct['attributes']) > 0)) {
            foreach ($currentProduct['attributes'] as $currentAttribute) {
?>
          <br /><span class="nobreak"><small>&nbsp;<i> - <?php echo $currentAttribute['option'] . ': ' . nl2br(zen_output_string_protected($currentAttribute['value'])); ?></i></small></span>
<?php
            }
?>
        </td>
        <td class="dataTableContent" valign="top"><?php echo $currentProduct['model']; ?></td>
<?php
        }
?>
      </tr>

page source reveals that all I'm getting from the line in red is this

<td class="dataTableContent" valign="top" align="left"><img src="/155f/images/" border="0" alt="" width="IMAGE_ON_INVOICE_IMAGE_WIDTH" height="IMAGE_ON_INVOICE_IMAGE_HEIGHT"></td>

[lat9]

Since I'd mimicked your original code, I assumed that the IMAGE_ON_INVOICE_IMAGE_WIDTH/HEIGHT definitions were available; your page-source shows differently.

[dbltoe]

Sorry was rushing out the door to PT.
the problem is the undefined constraints but, it's not pulling the image correctly before that. Only gets directory and folder